| commit | d46d861de207b407b7275da7a094faebb4d751c7 | [log] [tgz] |
|---|---|---|
| author | Xuewei Zhang <xueweiz@google.com> | Wed Apr 24 16:49:19 2019 -0700 |
| committer | Xuewei Zhang <xueweiz@google.com> | Wed Aug 21 15:44:31 2019 -0700 |
| tree | b9caf0aea6d4d386727079fb497a1af605dfc189 | |
| parent | 49c36f4573d690f4fc821c5436da9fbcef756a09 [diff] |
lakitu: disable userland crash reporting. Reason for disabling userland crash reporting is at b/131256513#comment1 This filter file is used to do PID-based userland crash filtering, see: https://chromium.googlesource.com/chromiumos/platform2/+/c02622c124533dd6140aeaf036b2ae0cf25a7b1a/crash-reporter/user_collector.cc#253 It does not affect kernel crash reporting. BUG=b:131256513 TEST=crash-reporter validation test RELEASE_NOTE=None Change-Id: I57a01c94650ed227efef26ffd5a9c4a4b3176a8c Reviewed-on: https://chromium-review.googlesource.com/1582616 Commit-Ready: Xuewei Zhang <xueweiz@google.com> Tested-by: Xuewei Zhang <xueweiz@google.com> Reviewed-by: Robert Kolchmeyer <rkolchmeyer@google.com> (cherry picked from commit 53cf1c7484ae0c7753d9a2b6f72d243a88f32766)
diff --git a/overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/chromeos-bsp-lakitu-0.0.1-r31.ebuild b/overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/chromeos-bsp-lakitu-0.0.1-r31.ebuild deleted file mode 120000 index ac428ab..0000000 --- a/overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/chromeos-bsp-lakitu-0.0.1-r31.ebuild +++ /dev/null
@@ -1 +0,0 @@ -chromeos-bsp-lakitu-0.0.1.ebuild \ No newline at end of file
diff --git a/overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/chromeos-bsp-lakitu-0.0.1-r28.ebuild b/overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/chromeos-bsp-lakitu-0.0.1-r32.ebuild similarity index 100% rename from overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/chromeos-bsp-lakitu-0.0.1-r28.ebuild rename to overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/chromeos-bsp-lakitu-0.0.1-r32.ebuild
diff --git a/overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/files/crash-filter b/overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/files/crash-filter index 4cedad3..5ea593b 100644 --- a/overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/files/crash-filter +++ b/overlay-lakitu/chromeos-base/chromeos-bsp-lakitu/files/crash-filter
@@ -3,11 +3,8 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -pid=$1 -exec_device=$(stat -L -c %D /proc/$pid/exe) -root_device=$(stat -c %D /) - -if [ "${exec_device}" != "${root_device}" ]; then - logger --tag crash_reporter "Not collecting crash from pid=${pid}" - exit 1 -fi +# Do no collect any userland crash. +# Userland crash are reported in minidump format, which contains stack memory. +# Since COS do not depend on userland crashes for debugging (yet), we should +# remove it to simplify the privacy question. +exit 1