)]}' { "log": [ { "commit": "b668591003841f571c730d236d6b34063a617d83", "tree": "e8a58213d905d342b375f18f8b00c23b8639145e", "parents": [ "a97abb3f98916d0350038f9682775ca0f5cd570a" ], "author": { "name": "Ronja Meyer", "email": "rnj@google.com", "time": "Wed May 20 16:02:45 2026 +0000" }, "committer": { "name": "Ronja Meyer", "email": "rnj@google.com", "time": "Fri May 22 10:29:51 2026 -0700" }, "message": "sign_official_cos_build: Support signature-based IMA\n\nPreviously, the script only supported hash-based IMA. This commit\nreplaces the \"ima\" option with \"ima_hash\" and \"ima_sign\" options. To\nmaintain backwards compatibility, \"ima\" is an aliase for \"ima_hash\".\nThe \"ima_sign\" option requires an ima_key.pem in the key dir.\n\nBUG\u003db/465211305\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nChange-Id: I61440922cd1689534fc01c46145e2d080a64c1db\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/153404\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\n" }, { "commit": "a97abb3f98916d0350038f9682775ca0f5cd570a", "tree": "9cf642f77caf271634c00e09b1b540c2e47b6163", "parents": [ "1c20df9e1341a7000b9953c80a30c967da97807e" ], "author": { "name": "Ronja Meyer", "email": "rnj@google.com", "time": "Wed May 20 16:05:11 2026 +0000" }, "committer": { "name": "Ronja Meyer", "email": "rnj@google.com", "time": "Fri May 22 10:29:51 2026 -0700" }, "message": "sign_official_cos_build: Don\u0027t feed folders to evmctl\n\nThe find command feeding files to evmctl was returning directories in\naddition to regular files. Add `-type f` to ensure only regular files\nare handed to evmctl.\n\nAt least for me, running `evmctl ima_hash \u003csome_folder\u003e` yields an\n`Unsupported file type (0x4000)`.\n\nBUG\u003db/465211305\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nChange-Id: I4b6d1473eae831a7ba697fb69b4c0cffffdb971c\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/153403\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\n" }, { "commit": "1c20df9e1341a7000b9953c80a30c967da97807e", "tree": "cc4c96b6ff791f221f06833cc2806d89e46d1b17", "parents": [ "a324d656524da288dbe37b53cf0082797669e441" ], "author": { "name": "Ronja Meyer", "email": "rnj@google.com", "time": "Wed May 20 16:05:04 2026 +0000" }, "committer": { "name": "Ronja Meyer", "email": "rnj@google.com", "time": "Fri May 22 10:29:51 2026 -0700" }, "message": "Makefile: Fix UEFI devkey discovery\n\nInclude UEFI key directories (db/, kek/, pk/) in devkeys_install\ntarget. Without this change, scripts/image_signing/sign_uefi.sh\naborted, complaining about missing UEFI keys.\n\nBUG\u003db/465211305\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nChange-Id: I4b6d1473eae831a7ba697fb69b4c0cffffdb971b\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/152103\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\n" }, { "commit": "a324d656524da288dbe37b53cf0082797669e441", "tree": "957eebd75955d5f0633ba15507d1e25ce877d4ec", "parents": [ "e9225ca414833733b5d5e89a6dafb2eade5e7d92" ], "author": { "name": "Ronja Meyer", "email": "rnj@google.com", "time": "Wed May 13 21:38:34 2026 +0000" }, "committer": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Thu May 14 08:03:03 2026 -0700" }, "message": "sign_official_cos_build: implement safe_umount to avoid umount race\n\nIn a previous cusky run I got:\nsign_official_cos_build.sh: INFO : Updating rootfs hash and updating config for Kernel partitions\nmount: /tmp/tmp.RDGvtloIoZ: /dev/loop4p3 already mounted or mount point busy.\n\nHeavy asynchronous metadata writes, such as generating thousands of\nsecurity.ima xattrs during IMA signing, can cause the kernel to keep\nloopback devices busy, leading to umount failures.\n\nI speculate that the intermittent failures seen in update_rootfs_hash,\nwhere mount complains about /dev/loop4p3 being already mounted or busy,\nare a direct downstream consequence of the umount in sign_ima failing,\nleaving the partition actively mounted read-write when the next step\nattempts to mount it read-only.\n\nBUG\u003dNone\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nChange-Id: I15b1a18ded6fc6e93022176254c43174d158f798\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/151905\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\n" }, { "commit": "e9225ca414833733b5d5e89a6dafb2eade5e7d92", "tree": "e1e3b076399a2d646c86006c3f838c62d71eeb1c", "parents": [ "b18ce78c2d1f7c3ddb84b458c86e8b4110adeb95" ], "author": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Tue Apr 21 17:11:07 2026 -0700" }, "committer": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Wed Apr 22 08:59:17 2026 -0700" }, "message": "sign_official_cos_build: make IMA signing more robust\n\nDo not override existing ima attrs. Doing so breaks nvidia firmware\nloading.\n\nBUG\u003dNone\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nChange-Id: If2a2a804866e6a7f6b5dd373ebbdbeb12d9caef7\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/145183\nReviewed-by: He Gao \u003chegao@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\n" }, { "commit": "b18ce78c2d1f7c3ddb84b458c86e8b4110adeb95", "tree": "81595d63eccae38e5679f825efa4ac799935cffd", "parents": [ "698b982dbdeb8769eae7d819eb758a5f87cb460f" ], "author": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Tue Apr 14 10:44:14 2026 -0700" }, "committer": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Wed Apr 15 10:03:28 2026 -0700" }, "message": "sign_official_cos_build.sh: add ima signing capability\n\nOnly runs when \"ima\" is passed as an argument, and only does\ndigest-based labeling on the root file system. This should be the last\nthing that runs before re-sealing the root file system.\n\nThis just does labeling, and does not set an IMA policy.\n\nBUG\u003db/465211305\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nChange-Id: I327d504b3ed8f84cc9bb92581bd413482225c4d3\nSigned-off-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/144203\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nReviewed-by: He Gao \u003chegao@google.com\u003e\n" }, { "commit": "698b982dbdeb8769eae7d819eb758a5f87cb460f", "tree": "533da84b9987c5d5c0cd415969ee9b8c3c26874b", "parents": [ "260b2b587fb3d13960bafc477b91ff96e479111f" ], "author": { "name": "Miri Amarilio", "email": "mirilio@google.com", "time": "Thu Mar 12 22:44:28 2026 +0000" }, "committer": { "name": "Miri Amarilio", "email": "mirilio@google.com", "time": "Mon Apr 13 11:47:49 2026 -0700" }, "message": "Update measure.sh to account for secure-boot changes\n\nBUG\u003db/413014554\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\ncos-patch: bug\nChange-Id: Iffa6674fddce6cf490b924e27dea7c5b7ce77603\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/142445\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\n" }, { "commit": "260b2b587fb3d13960bafc477b91ff96e479111f", "tree": "ebce2f7833115d08d67d1b6b51ff7b7b8cab5f44", "parents": [ "8c1fd31bf425585eb87f903b53e196686a83052e" ], "author": { "name": "Miri Amarilio", "email": "mirilio@google.com", "time": "Thu Jun 05 19:45:43 2025 +0000" }, "committer": { "name": "Miri Amarilio", "email": "mirilio@google.com", "time": "Fri Jun 06 11:19:23 2025 -0700" }, "message": "fix measure.sh to fit arm64 filepaths\n\nBUG\u003db/410625960\nChange-Id: I507eb62843a514b1c542c22d49d217a4e9e7f56f\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/104382\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nReviewed-by: Kevin Berry \u003ckpberry@google.com\u003e\n" }, { "commit": "8c1fd31bf425585eb87f903b53e196686a83052e", "tree": "39f8cfa17b8461814212e32c7aca4551466e8c57", "parents": [ "868aaba1ee205304deab81d53bbd0962b54355e5" ], "author": { "name": "Miri Amarilio", "email": "mirilio@google.com", "time": "Mon Jun 02 04:00:28 2025 +0000" }, "committer": { "name": "Miri Amarilio", "email": "mirilio@google.com", "time": "Wed Jun 04 11:22:12 2025 -0700" }, "message": "Add script to generate measured boot hashes json file\n\nChange-Id: Ifc0bc1df17be8c86c41ce88fc5dc41febc4ea7d4\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/103565\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\n" }, { "commit": "868aaba1ee205304deab81d53bbd0962b54355e5", "tree": "2adba53e18c935b083fbec792169f81edfc50f6a", "parents": [ "ae240a42e4d5a19e492e12dcecb3b5ec7307cc2c" ], "author": { "name": "Miri Amarilio", "email": "mirilio@google.com", "time": "Thu Mar 21 17:10:16 2024 +0000" }, "committer": { "name": "Miri Amarilio", "email": "mirilio@google.com", "time": "Wed Apr 03 20:40:48 2024 +0000" }, "message": "Update the signing scripts to allow KMS signing in RBE.\n\nWe will pass on a flag from the builder script all the way to the signing scripts.\nIn the scripts - accept the new flags and pass them on to the KMS signer app.\n\nThis change must go in the same time as the BE change to add that new flag:\nhttps://cos-internal-review.git.corp.google.com/c/cos/infra/build-executor/+/39983\n\nBUG\u003db/332363254\nTEST\u003dpresubmit passes on rbe (verifies impersonation) and on kokoro (verifies existing behavior when flag is not provided)\n\nChange-Id: I544e77cdceed3c507e96699d6183118e757a9aae\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/67690\nTested-by: RBE Service account \u003cservice-384042960741@remotebuildexecution.iam.gserviceaccount.com\u003e\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\n" }, { "commit": "ae240a42e4d5a19e492e12dcecb3b5ec7307cc2c", "tree": "8f6fd16c67948baf994a089cc1b5c127908ee5a0", "parents": [ "4a9f73567b0d83aa7170b5dce20ae60b52e2a2c1", "0b9cd28a6bc5f5366ca34b7f889ee87c55547a12" ], "author": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Fri Dec 16 13:59:52 2022 -0800" }, "committer": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Fri Dec 16 13:59:52 2022 -0800" }, "message": "Merge cos-sdk into ToT\n\nIncludes changes for the most recent ChromeOS merge.\n\nBUG\u003db/257271340\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nChange-Id: I9910568160c45bbbf5cc1a7267cf74dcba9d8aa3\n" }, { "commit": "4a9f73567b0d83aa7170b5dce20ae60b52e2a2c1", "tree": "9a136c61fb7c18f0e2fc4301141c88ee461f209c", "parents": [ "079e24aa2d7976e46f8a37090fa96b325299e385" ], "author": { "name": "Nobel Barakat", "email": "nobelbarakat@google.com", "time": "Tue Nov 22 00:40:20 2022 +0000" }, "committer": { "name": "Nobel Barakat", "email": "nobelbarakat@google.com", "time": "Fri Dec 16 18:37:49 2022 +0000" }, "message": "flashrom: ensure flashrom symbols are not loaded if !USE_FLASHROM\n\nThe linking process during the installation phase of this package\nbreaks if you compile with make USE_FLASHROM\u003d0. A new conditional has\nbeen added to the make file that prevents utility/crossystem from\ncompiling if USE_FLASHROM is either not set or set to the number 0.\n\nBUG\u003db/256682063\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dnone\nBRANCH\u003dnone\n\nChange-Id: Id1b851bc78d8db1878596b7f47fe80ef0719ae26\nSigned-off-by: Nobel Barakat nobelbarakat@google.com\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/40328\nReviewed-by: Oleksandr Tymoshenko \u003covt@google.com\u003e\nTested-by: Nobel Barakat \u003cnobelbarakat@google.com\u003e\n" }, { "commit": "0b9cd28a6bc5f5366ca34b7f889ee87c55547a12", "tree": "65010a5c45c6595e79498025da2876be4bd24032", "parents": [ "079e24aa2d7976e46f8a37090fa96b325299e385", "67f613b922e4ccff6019de318c154a377afbe822" ], "author": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Tue Dec 13 13:16:48 2022 -0800" }, "committer": { "name": "Robert Kolchmeyer", "email": "rkolchmeyer@google.com", "time": "Tue Dec 13 13:16:48 2022 -0800" }, "message": "Update to ChromeOS 15047.0.0\n\nMerge commit \u002767f613b922e4ccff6019de318c154a377afbe822\u0027 into sdk-update-pre\n\nBUG\u003db/257271340\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nChange-Id: I49762318407ffc1651cae5233d3ebb03f4cae277\n" }, { "commit": "079e24aa2d7976e46f8a37090fa96b325299e385", "tree": "0d2946ac2bf4fd2a83d954d3ef2ab6ef32be4678", "parents": [ "b92daa74321bd812fab2a810984cb997eca1d70a" ], "author": { "name": "Meena Shanmugam", "email": "meenashanmugam@google.com", "time": "Thu Oct 27 05:20:01 2022 +0000" }, "committer": { "name": "Meena Shanmugam", "email": "meenashanmugam@google.com", "time": "Mon Oct 31 19:05:58 2022 +0000" }, "message": "LAKITU:Signing_script: Fix the bug in getting the hashstart value.\n\necho statement in hashstart case is missing in get_verity_arg which is\ncausing the verity tool to return wrong payload blocks and number of\nsectors. When these numbers are used to recalculate the hash when\nauto-update happens, it fails with hash mismatch.\n\nBUG\u003db/240174341\nTEST\u003dpresubmit,validation,auto-update test.\nRELEASE_NOTE\u003dNone\nBRANCH\u003dNone\n\nSigned-off-by: Meena Shanmugam \u003cmeenashanmugam@google.com\u003e\n\nChange-Id: Ia05821f8c982b3d9ebcffd691f61095fcbd0a13c\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/37987\nReviewed-by: Arnav Kansal \u003crnv@google.com\u003e\nReviewed-by: Vaibhav Rustagi \u003cvaibhavrustagi@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\n" }, { "commit": "b92daa74321bd812fab2a810984cb997eca1d70a", "tree": "ddbc1dfc68ed823eb937061f7f3796a3693cdabe", "parents": [ "fee44f7f9b78be3307d284c07b81ea755de3ea93" ], "author": { "name": "Meena Shanmugam", "email": "meenashanmugam@google.com", "time": "Thu Oct 13 19:12:08 2022 +0000" }, "committer": { "name": "Meena Shanmugam", "email": "meenashanmugam@google.com", "time": "Mon Oct 17 22:17:20 2022 +0000" }, "message": "signing-script: Modify kernel_config variable name to kernel_cmd_line.\n\nThroughout the signing script, kernel command line is referenced as\nkernel_config which is misleading. Hence modify the variable name to\nkernel_cmd_line.\n\nBUG\u003db/240174341\nBRANCH\u003dNone\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nSigned-off-by: Meena Shanmugam \u003cmeenashanmugam@google.com\u003e\nChange-Id: If804d81c242cb4695cfe2265f6d953a18e3e0719\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/37596\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\n" }, { "commit": "fee44f7f9b78be3307d284c07b81ea755de3ea93", "tree": "12d24646e9d7c42791766de275f1c784b471e091", "parents": [ "25876f2be637a3a923b2c516846adb94b6dba515" ], "author": { "name": "Meena Shanmugam", "email": "meenashanmugam@google.com", "time": "Wed Sep 07 03:43:42 2022 +0000" }, "committer": { "name": "Meena Shanmugam", "email": "meenashanmugam@google.com", "time": "Mon Oct 17 22:16:19 2022 +0000" }, "message": "signing-script: Update COS signing script to support the new dm format.\n\nUpdated the cos signing script to support both old and new version.\n\nBUG\u003db/240174341\nBRANCH\u003dNone\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nSigned-off-by: Meena Shanmugam \u003cmeenashanmugam@google.com\u003e\nChange-Id: I8a8747e23ed0dd9cac33824dbd48ab0295864937\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/36692\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\n" }, { "commit": "67f613b922e4ccff6019de318c154a377afbe822", "tree": "13350f1d92d867a643e89ff2eac4e50ed31c18ab", "parents": [ "7d3dd82630e7505fe2804551c61e12e08c9fae4e" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Mon Aug 01 11:46:34 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun Aug 07 07:14:44 2022 +0000" }, "message": "futility: updater: Stop looking for zephyr.bin\n\nIn CL:3788136 the zephyr EC image is renamed from zephyr.bin to ec.bin.\nTherefore we don\u0027t need to check the existence of zephyr.bin anymore.\n\nBUG\u003db:239887568\nTEST\u003dmake runtests -j\nBRANCH\u003dnone\n\nCq-Depend: chromium:3788136\nChange-Id: Icd82baff93d2019cfd90b982e9c25b45cbf611c3\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3795458\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-by: Yidi Lin \u003cyidilin@chromium.org\u003e\n" }, { "commit": "7d3dd82630e7505fe2804551c61e12e08c9fae4e", "tree": "9ce50c6df4c65a40784a447b5d57c0afc74c2c77", "parents": [ "91ae3a544c237655379173a8e818c1057576166b" ], "author": { "name": "Jakub Czapiga", "email": "jacz@semihalf.com", "time": "Tue Aug 02 14:06:48 2022 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Aug 05 13:26:13 2022 +0000" }, "message": "host/lib/cbfstool: Fail on subprocess error\n\nMake cbfstool_truncate() fail critically on subprocess execution error.\ncbfstool is mandatory, so it should always be available.\nIf subprocess_run(), then either cbfstool is not available, or code is\nincorrect, so it should not return.\n\nBUG\u003dnone\nTEST\u003dmake runfutiltests\nBRANCH\u003dnone\n\nSigned-off-by: Jakub Czapiga \u003cjacz@semihalf.com\u003e\nChange-Id: I17089d0cc2512a25f25cafe616caa79845a7e078\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3804563\nCommit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "91ae3a544c237655379173a8e818c1057576166b", "tree": "023cb42d208d449bb3e18e48ecc0136f7e210b49", "parents": [ "b671c3553d0e2a596db2dddbf8042441c11cc6ab" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Fri Jul 29 16:09:49 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 04 01:57:56 2022 +0000" }, "message": "futility: gscvd: Allow verification ranges in SI_ALL section\n\nRecent discussions have brought us to the conclusion that we probably\nwant to include the SI_DESC section on Intel mainboards in the GSCVD\nverified areas, since it contains soft straps that may affect\npre-coreboot behavior. The problem is that while this section itself\ngenerally doesn\u0027t change, it is part of the larger Intel-specific SI_ALL\nsection that also contains the ME code and data -- which _can_ be\noverwritten, so we usually place it in the RW part of the flash. The\nsection is instead protected from unauthorized software access by\nplatform-specific mechanisms.\n\nThis patch modifies `futility gscvd` so that it will also accept\nverification ranges in an SI_ALL region (if it exists), not just in\nWP_RO.\n\nBRANCH\u003dnone\nBUG\u003dnone\nTEST\u003dModified coreboot to add SI_DESC range, verified ranges on Joxer.\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: Iacff931f7cb34a41d3d878eee395b97ba2452c2d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3794950\nReviewed-by: Tim Wawrzynczak \u003ctwawrzynczak@chromium.org\u003e\n" }, { "commit": "b671c3553d0e2a596db2dddbf8042441c11cc6ab", "tree": "c22927a5f2e08d1712c666206e1a4ac2d3ef673d", "parents": [ "18cb85b52d689b4cfbd49c6384ae2088b78af1e0" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Thu Jul 14 17:22:21 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 03 08:25:01 2022 +0000" }, "message": "vboot_api.h: Remove VbExDiskGetInfo and VbExDiskFreeInfo\n\nVbExDiskGetInfo and VbDiskFreeInfo are removed. Also, remove\nVB2_DISK_FLAG_REMOVABLE and VB2_DISK_FLAG_FIXED since depthcharge\ndoesn\u0027t need them anymore.\n\nBUG\u003db:172339016\nBRANCH\u003dnone\nTEST\u003dmake runtests\nTEST\u003dmake test-screenshot\nTEST\u003dFW_NAME\u003dtomato emerge-cherry depthcharge\n\nCq-Depend: chromium:3760812\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: I30d142508992b8c634ab4f919cc1b1b1edb23f14\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3762078\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "18cb85b52d689b4cfbd49c6384ae2088b78af1e0", "tree": "2c7e7aca1e50a81e05aa7c302db29554f0a82c70", "parents": [ "81b8d3faabad2f16bfd08efa6920bdaaeb637ce8" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Tue Jul 12 10:52:13 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jul 29 09:47:12 2022 +0000" }, "message": "2load_kernel.c: Expose load kernel as vb2_api\n\nMove VbTryLoadKernel() and VbTryLoadMiniOsKernel() to depthcharge.\nIn addition, expose LoadKernel() and LoadMiniOsKernel() as\nvb2api_load_kernel() and vb2api_load_minos_kernel(), respectively.\nSince we remove VbTryLoadKernel() in vb2api_normal_boot(), rename\nvb2api_normal_boot() to check_kernel_version() and call it in\nvb2api_kernel_finalize().\n\nAlso, rename VbSelectAndLoadKernelParams, VbDiskInfo, and\nVbExDiskHandle_t as vb2_kernel_params, vb2_disk_info, and\nvb2ex_disk_handle_t, respectively.\n\nBUG\u003db:172339016\nBRANCH\u003dnone\nTEST\u003dmake runtests\nTEST\u003dFW_NAME\u003dtomato emerge-cherry depthcharge\n\nCq-Depend: chromium:3758201\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: Iaf182ca81797fee24c6104dac9d4770ff75c7fb2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3755923\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "81b8d3faabad2f16bfd08efa6920bdaaeb637ce8", "tree": "a8842889f148b4b56d93892e40a179c3dc0c3543", "parents": [ "aa4671712ddb54216febc103cc9ff530b586b54a" ], "author": { "name": "Subrata Banik", "email": "subratabanik@google.com", "time": "Wed Jul 13 23:48:23 2022 +0530" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jul 29 09:37:19 2022 +0000" }, "message": "firmware/2lib: Introduce `vb2api_get_fw_boot_info` API\n\nThis patch introduces a new API named `vb2api_get_fw_boot_info` to get\nthe FW slot information like tries, current boot slot, previous boot\nslot, previous boot status and boot mode.\n\nAdditionally, moved the required data structures from 2api.h to newly\ncreated 2info.h file to keep vboot information and inline functions\nfor coreboot/eventlog usage.\n\nBUG\u003db:215615970\nTEST\u003dAble to compile the Google/Kano board using the emerge command.\n\nSigned-off-by: Subrata Banik \u003csubratabanik@google.com\u003e\nChange-Id: Ib3f197c851dc4b445dbf64868c3f9157a4f6c9fe\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3737570\nAuto-Submit: Subrata Banik \u003csubratabanik@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nTested-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "aa4671712ddb54216febc103cc9ff530b586b54a", "tree": "c44324f586a475603da55456f539c47c1ffd36e5", "parents": [ "64dd01225f64d6745a008d91fba3fcac2f1920bd" ], "author": { "name": "Josh Horwich", "email": "jhorwich@google.com", "time": "Thu Jul 28 13:24:14 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jul 29 04:18:48 2022 +0000" }, "message": "signer: continue to use --sb_extract for shellballs\n\ncrrev.com/c/3665477 started using `--unpack` rather than\n`--sb_extract` for self-extracting firmware update bundles.\nUnfortunately, existing prebuilt artifacts used by signer tests are\nold and only support `--sb_extract`, and hence fail with recent\nvboot_reference that includes this change.\n\nThis change simply reverts the option back to `--sb_extract` for\nunpacking self-extracting bundles.\n\nBRANCH\u003dNone\nBUG\u003db:179170462\nBUG\u003db:202397678\nTEST\u003dunittests\n\nChange-Id: I528346a5d593caba7ca822820b9a38e994f0ea94\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3792485\nCommit-Queue: Josh Horwich \u003cjhorwich@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Prameet Shah \u003cphshah@chromium.org\u003e\nTested-by: Josh Horwich \u003cjhorwich@chromium.org\u003e\nAuto-Submit: Josh Horwich \u003cjhorwich@chromium.org\u003e\n" }, { "commit": "64dd01225f64d6745a008d91fba3fcac2f1920bd", "tree": "6d1bb9a194c763284a8d2655853b212ade295cd7", "parents": [ "499b1814a76303b332c49dd5efb2c84e30b973ba" ], "author": { "name": "Jakub Czapiga", "email": "jacz@semihalf.com", "time": "Mon Jul 04 12:34:28 2022 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jul 22 07:46:32 2022 +0000" }, "message": "futility: Add --keyset option to sign command for BIOS and kernel\n\nThis patch adds --keyset option for sign command for BIOS_IMAGE,\nRAW_FIRMWARE, RAW_KERNEL and KERN_PREAMBLE file types. The default value\nof this option is \u0027/usr/share/vboot/devkeys\u0027. It allows futility to load\npublic and private keys, and keyblocks from under this path, when they\nwere not provided manually using their respective options.\n\nFiles loaded by default for BIOS_IMAGE and RAW_FIRMWARE:\n- ${keysetdir}/firmware_data_key.vbprivk\n- ${keysetdir}/firmware.keyblock\n- ${keysetdir}/kernel_subkey.vbpubk\n\nFiles loaded by default for RAW_KERNEL:\n- ${keysetdir}/kernel_data_key.vbprivk\n- ${keysetdir}/kernel.keyblock\n\nFile loaded by default for KERN_PREAMBLE:\n- ${keysetdir}/kernel_data_key.vbprivk\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dmake runfutiltests\n\nSigned-off-by: Jakub Czapiga \u003cjacz@semihalf.com\u003e\nChange-Id: Ic4026d501d88e0de7d2c6f52c7494c639d08bd15\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3740601\nAuto-Submit: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nTested-by: Jakub Czapiga \u003cczapiga@google.com\u003e\n" }, { "commit": "499b1814a76303b332c49dd5efb2c84e30b973ba", "tree": "b0ed5d48887ad88b5fcd3b9488901c9f65d4d31f", "parents": [ "a975eed306e16947c30b48ccd25ab67a37295742" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Wed Jul 20 10:13:49 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jul 21 05:07:34 2022 +0000" }, "message": "futility: updater: allow --fast to skip scanning archive in do_manifest\n\nThe `--manifest` (do_manifest) command needs to scan most firmware\nimages in the archive to build up the right information. That can be ~2s\nfor a 200MB archive even though we just need the version string. 2s is\nusually fast enough for developers when they want to check the archive\ncontents, but that is too slow if the boot time scripts (for example,\nCSME updater) need to collect the information.\n\nAs a result, we want to allow overriding how the updater gets the\nmanifest. For most systems that the firmware archive is created by the\nbuildbot or the signerbot, the scripts can use \"--manifest --fast\" to\nretrieve the cached JSON manifest file.\n\nBUG\u003db:238908603\nTEST\u003dmake; run test\nBRANCH\u003dNone\n\nChange-Id: I5d7dead4d0a43129fd31dd035aac63deaee42a08\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3775703\nReviewed-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "a975eed306e16947c30b48ccd25ab67a37295742", "tree": "47c71250e1c5d9d1b841fade2ad8e69632f9cef9", "parents": [ "b68529526ab82d1da99b58155620beaa8aa3f487" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Fri Jul 08 16:55:54 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jul 15 07:11:44 2022 +0000" }, "message": "2kernel.c: check display request in vb2api_kernel_phase2\n\nIn preparation for moving VbTryLoadKernel to depthcharge, move the\nVB2_NV_DISPLAY_REQUEST check from vb2api_normal_boot to\nvb2api_kernel_phase2.\n\nBUG\u003db:172339016\nBRANCH\u003dnone\nTEST\u003dmake runtests\n\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: I3629d8dbbcaba23220152543ba77558c8bbcdc7b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3752431\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "b68529526ab82d1da99b58155620beaa8aa3f487", "tree": "a20deea997321779f8b8030bb84ace82fa0250a5", "parents": [ "1d25a753a35245af0f98897c4e999ec428b97134" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Thu Jul 07 16:46:06 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jul 15 07:11:42 2022 +0000" }, "message": "tests/common/boot_mode.c: Introduce SET_BOOT_MODE\n\nIntroduce set_boot_mode to set up the corresponding ctx flags and call\nvb2_set_boot_mode to set ctx-\u003eboot_mode to be consistent with those\nflags.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dmake runtests\n\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: I7020639521af30bcdb6edcfac4c1a5b21ca8815e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3750959\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "1d25a753a35245af0f98897c4e999ec428b97134", "tree": "6fa36a8961003de706565936d6c06da99fee23d0", "parents": [ "9b04e0e9a0bdada307097e89610b4ce1ab9351f8" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Mon Jul 11 15:55:11 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jul 15 07:11:40 2022 +0000" }, "message": "tests/common/tests.h: rename test_common.h to common/tests.h\n\nCreate tests/common/ to put some common files.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dmake runtests\n\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: I8918b7a1e62d47fca6074ef123e2de6f46f1aa00\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3754814\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "9b04e0e9a0bdada307097e89610b4ce1ab9351f8", "tree": "7bf07358c9d67e4b807bbbccd87c14772eec2000", "parents": [ "800f5de9662b2a7345e0f56dd070a11b9d4526bc" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Wed Jul 06 10:47:17 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 13 16:55:17 2022 +0000" }, "message": "Makefile: Hide coverage helper targets if COV is not set\n\nWe only check COV\u003d1 in `make coverage` before. This will result in\ndeleting all files in the current working directory if we accidentally\ntried `make coverage_init`.\n\nHide coverage_init and coverage_html if COV is not set.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dmake coverage_init and see the error message\nTEST\u003dmake clean \u0026\u0026 COV\u003d1 make coverage -j\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I2d22b211b3d9e59d12faa0ab3d1c2ca8433598f7\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3747419\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "800f5de9662b2a7345e0f56dd070a11b9d4526bc", "tree": "dc089e0b5695b4e9c096c60dd8cc83efdda80597", "parents": [ "6d74ce8a95a3a0ed8adb41bde3172f5d7db96f64" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Tue Jul 12 15:39:23 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 13 16:55:15 2022 +0000" }, "message": "Makefile: coverage: Fix build failure\n\nCurrently, make coverage is broken due to two issues:\n\n1. The optimization option -O0 ignores the inline specifier in\n firmware/2lib/2sha256_x86.c:46 and 52. This will violate the\n compile-time constraint \"i\" and cause a build failure.\n\nFix this issue by using -Og instead of -O0.\n\n2. The coverage_html requires ${COV_INFO}.* files which are generated in\n coverage_init and runtests. We need to add prerequisites to prevent\n potential errors while running with \"-j\".\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dmake clean \u0026\u0026 COV\u003d1 make coverage -j\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: If1f9de1dbc56f36afead9045c1f95349a5fa156c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3755927\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "6d74ce8a95a3a0ed8adb41bde3172f5d7db96f64", "tree": "3fd6a8f2149b06f3512e31d75d34dbba3c5868fc", "parents": [ "4756206b07f2250155c9c4c1d75577281ea111f5" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Mon Jul 04 14:45:13 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 13 09:07:43 2022 +0000" }, "message": "2lib/2auxfw_sync: Request recovery for missing auxfw\n\nWhen the hash file of auxfw is not found in the CBFS, VB2_ERROR_UNKNOWN\nwill be returned from vb2ex_auxfw_check(), causing the device to enter\nreboot loop. Similar to how we handle missing ecrw.hash, vb2api_fail()\nshould be called, so that the device will try to boot from the other\nslot, and if the hash is still missing, recovery will be triggered.\n\nCall vb2api_fail() from vb2api_auxfw_sync() using the 3-argument form of\nVB2_TRY(). Add a unit test to prevent regression.\n\nBUG\u003db:237745301\nTEST\u003dmake run2tests\nTEST\u003demerge-corsola libpayload\nBRANCH\u003dnone\n\nChange-Id: I789c63b10201bd1852bc087199ec7b226ec85ba8\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3742863\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "4756206b07f2250155c9c4c1d75577281ea111f5", "tree": "90a27dd88ac49fefe6ed2571b8eb0690ad6c12ef", "parents": [ "35f4cb027230e03af30a6206cbea8e638d9dd0d0" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Tue Jun 28 16:38:26 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 13 05:01:22 2022 +0000" }, "message": "vboot_api_kernel.c: Remove kparams_ptr\n\nPass VbSelectAndLoadKernelParams kparams as a function argument instead\nof using global variable kparams_ptr. Remove VbSelectAndLoadKernel and\nreplace its tests with the unit tests for vb2_set_boot_mode,\nvb2api_kernel_phase2, vb2api_kernel_finalize, and vb2api_normal_boot.\n\nBUG\u003db:172339016\nBRANCH\u003dnone\nTEST\u003dmake runtests\n\nCq-Depend: chromium:3731710\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: I26895ced5e310b2894b9d42d0ad5514d3b0b930a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3731412\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "35f4cb027230e03af30a6206cbea8e638d9dd0d0", "tree": "5279c68276a0260f21d5609904896d68171626fb", "parents": [ "61f16fca1def81c486c1283f8c0b1325fbdad7bc" ], "author": { "name": "Josh Horwich", "email": "jhorwich@google.com", "time": "Thu Jun 23 16:40:09 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jul 12 20:56:19 2022 +0000" }, "message": "signer: Preserve capabilities on Android system image\n\nSince crrev.com/c/2511121 we no longer use xattrs when using\nunsquashfs on the Android system image. A side-effect of this change\nis the loss of capabilities for a handful of Android binaries such as\n/system/bin/run-as.\n\nThis change records the capabilities on the system image and applies\nthem manually to the output system image.\n\nBUG\u003db:179170462\nBRANCH\u003dNone\nTEST\u003dunittests\nTEST\u003dLocally sign hatch (ARC R) and kevin (ARC P) base images and\n verify signed base image\u0027s system.raw.img contents\n\nSigned-off-by: Josh Horwich \u003cjhorwich@chromium.org\u003e\n\nChange-Id: Ied824d5ebf7a5139e71341abca810b14e67623e0\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3723017\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\nTested-by: Josh Horwich \u003cjhorwich@chromium.org\u003e\nReviewed-by: Prameet Shah \u003cphshah@chromium.org\u003e\nCommit-Queue: Josh Horwich \u003cjhorwich@chromium.org\u003e\nReviewed-by: Yury Khmel \u003ckhmel@google.com\u003e\nReviewed-by: Yury Khmel \u003ckhmel@chromium.org\u003e\n" }, { "commit": "61f16fca1def81c486c1283f8c0b1325fbdad7bc", "tree": "8ddc1a00fb3bc627fa2fbe3f703fefbab1323fff", "parents": [ "78a0e6cfc75cb117008d568aa0981bfc9ecce126" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Thu Jun 30 17:23:23 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jul 11 18:24:55 2022 +0000" }, "message": "2kernel.c: Clear VB2_NV_DIAG_REQUEST unconditionally\n\nBUG\u003dnone\nTEST\u003dmake runtests\nBRANCH\u003dnone\n\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: I406bcf806a6bbe21faa5f069381b73d43a7550b2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3737566\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nTested-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "78a0e6cfc75cb117008d568aa0981bfc9ecce126", "tree": "98eaa69293c6e8ccc8895b4b32555e83e9e1ae5c", "parents": [ "448322b612d57980c35ce3be06bf2cea28676914" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Thu Jul 07 16:20:48 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Jul 09 11:58:37 2022 +0000" }, "message": "vb2_context: Use fixed-width type for boot_mode\n\nUsing enum types in serialized data structures is dangerous, because\ntheir width may depend on compiler settings. This patch changes the data\ntype for (vb2_context).boot_mode to uint8_t to make sure the struct\nlayout will be the same in all environments. Since we only defined boot\nmodes up to 5 for now (and our systems are always little endian), the\nstructure remains binary compatible with serializations of the previous\nversion (so no struct version change should be necessary).\n\nBRANCH\u003dnone\nBUG\u003dnone\nTEST\u003dmake runtests\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: I82bc8e665ea51adaaf1f5d94986c22bd62e58bba\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3751833\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\n" }, { "commit": "448322b612d57980c35ce3be06bf2cea28676914", "tree": "87bf4b17fa2a7dd5c21ab5a6871d2edbbb9d1e2f", "parents": [ "48e92c2fa97015e98c329acc413aad184de2f183" ], "author": { "name": "Subrata Banik", "email": "subratabanik@google.com", "time": "Thu Jun 30 18:53:35 2022 +0530" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jul 08 22:48:36 2022 +0000" }, "message": "vboot: Move `vb2_fw_result` definition from 2nvstorage.h to 2api.h\n\nThis patch moves the `vb2_fw_result` enum definition from 2nvstorage.h\nto 2api.h as 2api.h is the only header file which is getting included\nby the vb2_api.h.\n\nThe direction is to keep all required data structure needed by coreboot\ninside 2api.h only.\n\nThe follow-up patch would like to implement a new API which would allow\nto get the slot information and vboot logic as part of coreboot will\ncall into this API to retrieve this info prior storing into the elog\nwhile booting.\n\nBUG\u003db:215615970\nTEST\u003dAble to compile the Google/Kano board using the emerge command.\n\nSigned-off-by: Subrata Banik \u003csubratabanik@google.com\u003e\nChange-Id: I35a4d34d1032dbf354b161feb6fcd68221a039a8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3737569\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nAuto-Submit: Subrata Banik \u003csubratabanik@chromium.org\u003e\nCommit-Queue: Subrata Banik \u003csubratabanik@chromium.org\u003e\nTested-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\n" }, { "commit": "48e92c2fa97015e98c329acc413aad184de2f183", "tree": "b2fae9df467cddace4c23c759c35d6d29e26dd4f", "parents": [ "0c357126066949f2b5a66641536547fb372fc3a0" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Mon Jul 04 17:25:10 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 06 22:42:16 2022 +0000" }, "message": "OWNERS: Add roccochen@chromium.org\n\nBUG\u003dnone\nTEST\u003dnone\nBRANCH\u003dnone\n\nChange-Id: Iedbad16be5f9541cb74cc092821b828bd25b12da\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3742864\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "0c357126066949f2b5a66641536547fb372fc3a0", "tree": "6b484e51c3508e8fa901c0478d83863cccd83a22", "parents": [ "9ae9d2c03f42b25238f803a26ebae4902541317e" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Thu Jun 30 16:38:40 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun Jul 03 00:38:13 2022 +0000" }, "message": "2api.c: Initialize display using boot_mode\n\nIn vb2api_fw_phase1, use the boot_mode set by vb2_set_boot_mode to\ndetermine whether to initialize display. This fixes the edge case where\nVB2_NV_DIAG_REQUEST is set, but vb2api_diagnostic_ui_enabled() is 0.\n\nBUG\u003dnone\nTEST\u003dmake runtests\nBRANCH\u003dnone\n\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: Iecb9f52b056906bcd1d7da324390672adc5112c7\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3737563\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "9ae9d2c03f42b25238f803a26ebae4902541317e", "tree": "4fb994c865757570ca5a40a5b376e7779dc9a584", "parents": [ "57eb6ea8e8ebf6ecb859815ef15b962a38803bd2" ], "author": { "name": "Jakub Czapiga", "email": "jacz@semihalf.com", "time": "Thu Apr 07 14:44:44 2022 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 30 14:55:17 2022 +0000" }, "message": "futility/file_type_bios: Rework image signing\n\nThis patch reworks whole BIOS image signing to support images with CBFS,\nand with ponly RW/A slot. CBFS images will now be truncated to eliminate\nunnecessary empty space, and will sign only the part of firmware area\nwhich contains the data, and not empty space.\nThis patch also adds more checks for potential errors, and does not\nallow for signing incorrect nor uses data from structures, which might\nnot be valid.\nfutility sign command tests are also greatly extended to cover a wide\nvariety of possible errors, which have to be handled correctly.\n\nBUG\u003db:197114807\nTEST\u003dsudo emerge vboot_reference\nTEST\u003dbuild whole chromeos-bootimage after making it and coreboot use\n `futility sign --type bios ...`\nTEST\u003dmake runtests\nBRANCH\u003dnone\n\nSigned-off-by: Jakub Czapiga \u003cjacz@semihalf.com\u003e\nCq-Depend: chromium:3707104\nChange-Id: I7c84aa38776e8890a87f0e9b7ec7f32d86f82c13\nDisallow-Recycled-Builds: test-failures\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3575325\nTested-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nAuto-Submit: Jakub Czapiga \u003cczapiga@google.com\u003e\nCommit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\n" }, { "commit": "57eb6ea8e8ebf6ecb859815ef15b962a38803bd2", "tree": "c243a33c6955e83081a3b858e6cdd92d37a1e149", "parents": [ "9867ce3ed708b3b89f4f547e263a87c8b34cc945" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Thu Jun 23 18:37:45 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jun 28 12:59:30 2022 +0000" }, "message": "2kernel: Add vb2api_kernel_phase2 and vb2api_normal_boot\n\nExtract the middle part of VbSelectAndLoadKernel as vb2api_kernel_phase2\nand call it from VbSelectAndLoadKernel. Also, remove vb2_nv_init in\nVbSelectAndLoadKernel. Furthermore, publicize vb2_normal_boot as\nvb2api_normal_boot in preparation for moving the content of\nVbSelectAndLoadKernel to depthcharge. Besides, when NO_BOOT is set,\nmanual recovery should be disallowed (unless\nVB2_GBB_FLAG_FORCE_MANUAL_RECOVERY is set). Therefore, print the NO_BOOT\ndebug log only for the broken screen case.\n\nBUG\u003db:172339016\nBRANCH\u003dnone\nTEST\u003dmake runtests\n\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: I4dc5ee4fb80ecc8c24a992a489c3bf6fe267046d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3720975\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "9867ce3ed708b3b89f4f547e263a87c8b34cc945", "tree": "bb9328546f8aa8ea4e9bbbe03dec141ee880e81b", "parents": [ "5d3a51a6e44a0035d6b9021051591e0a02cad5d8" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Thu Jun 23 14:45:43 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jun 27 02:57:33 2022 +0000" }, "message": ".gitignore: ignore swap files of vim\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dnone\n\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: Ia29490c6fb8bf02a98ef09b1d284369802a2b750\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3719468\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "5d3a51a6e44a0035d6b9021051591e0a02cad5d8", "tree": "a60bcf53eb125d079438b1569af66dd0d94f55f6", "parents": [ "3bd83883a08fb16069e89c5f6c1b6353e313184a" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Jun 24 10:40:38 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun Jun 26 17:28:28 2022 +0000" }, "message": "futility: updater: disable broken \u0027--repack\u0027 argument\n\nThe `--repack` is actually broken if invoked from futility updater\nbecause libzip does not support SFX, and can\u0027t open an empty file.\nThe right way to repack is to use the --repack from the wrapper script\n(e.g., chromeos-firmwareupdate) that it will call zip directly.\n\nBUG\u003db:236399204\nTEST\u003dmake; test\nBRANCH\u003dnone\n\nChange-Id: I0a88bb9d9f16acb49029626da76e92e78fcd331d\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3721657\nReviewed-by: YH Lin \u003cyueherngl@chromium.org\u003e\n" }, { "commit": "3bd83883a08fb16069e89c5f6c1b6353e313184a", "tree": "7e98c2c499c5059572974c147586a5029525ba5a", "parents": [ "a729c3f95d6c6d98c4e4d3500cc7535bf2ceee8a" ], "author": { "name": "Hsin-Te Yuan", "email": "yuanhsinte@google.com", "time": "Wed Jun 22 18:25:48 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 24 16:02:49 2022 +0000" }, "message": "2kernel: add vb2api_kernel_finalize\n\nMove the final part of VbSelectAndLoadKernel into vb2api_kernel_finalize\nand call vb2api_kernel_finalize at the end of VbSelectAndLoadKernel.\n\nBUG\u003db:172339016\nBRANCH\u003dnone\nTEST\u003dmake runtests\n\nSigned-off-by: Hsin-Te Yuan \u003cyuanhsinte@google.com\u003e\nChange-Id: Ieef929f679e4703e6771313cdf34a9959cc1335f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3715882\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "a729c3f95d6c6d98c4e4d3500cc7535bf2ceee8a", "tree": "71162c877dbd7c6aeb7246f3d0426fa91bc4c7a5", "parents": [ "6bcf9f7b7913604368cde04f681ece204779c240" ], "author": { "name": "Jakub Czapiga", "email": "jacz@semihalf.com", "time": "Wed Jun 08 13:35:46 2022 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 23 19:26:12 2022 +0000" }, "message": "tests: Fix most of errors reported by shellcheck\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dmake runtests\n\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nChange-Id: I364ac6ace35705f1cfdaec71297523d4c2132b75\nDisallow-Recycled-Builds: test-failures\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3695417\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "6bcf9f7b7913604368cde04f681ece204779c240", "tree": "55f77d20a9ab3f2e22d0878eb1e4d81de94a483f", "parents": [ "61971455ccb99fc6da03c493dfcda102e71aee2f" ], "author": { "name": "Robert Zieba", "email": "robertzieba@google.com", "time": "Tue May 24 13:50:17 2022 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 23 16:53:58 2022 +0000" }, "message": "scripts/image_signing: Add ensure_amd_psp_flags script\n\nCurrently there is no script to ensure that AMD PSP flags are set\ncorrectly in a firmware image. This commit adds ensure_amd_psps_flags.sh\nto handle that functionality. The script can check that certain flags\nare set as well as checking that certain flags are not set.\n\nBRANCH\u003dnone\nBUG\u003db:202397678\nTEST\u003dRan script with grunt, zork, MI and skyrim images, verified that\nit responds correctly to PSP flag values\n\nSigned-off-by: Robert Zieba \u003crobertzieba@google.com\u003e\nChange-Id: Ie0864544b9b97704ee901d893b4d833c1ab068b9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3526100\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "61971455ccb99fc6da03c493dfcda102e71aee2f", "tree": "630284c4574524d3e8472ff04fb1af844d33f799", "parents": [ "dff7e6124b6a9fafe98dd0812f9f454ef979ac5f" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Thu Jun 09 13:09:39 2022 +1000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 16 00:45:02 2022 +0000" }, "message": "vboot_ref/Makefile: Expose symbols irregardless of USE_FLASHROM\n\nsubproccess helpers are only used by flashrom.c at the moment. However we\ntemporarily need the symbols to bridge the gap with cbfstools/elogtool in\nupstream coreboot. Furthmore, there are new additional use-cases for\nsubproccess in other parts of vboot_reference unrelated to flashrom\ndirectly.\n\nBUG\u003db:231152447\nBRANCH\u003dnone\nTEST\u003dbuilds\n\nChange-Id: Id8008eefd46efa329adf76323800bb7646bf922c\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3697856\nTested-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nAuto-Submit: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "dff7e6124b6a9fafe98dd0812f9f454ef979ac5f", "tree": "92afc64efeb34f3da50664c014e02a8fc8af88b6", "parents": [ "847ee5a830e4dc1d00fab2eb70465e3cddd1fb27" ], "author": { "name": "Robert Zieba", "email": "robertzieba@google.com", "time": "Tue May 24 13:49:14 2022 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jun 15 23:05:18 2022 +0000" }, "message": "scripts/image_signing: Move `extract_firmware_bundle` to common.sh\n\nThis commit moves `extract_firmware_bundle` into common.sh as this\nfunction is useful for other scripts as well. This commit also updates\nthis function to use the `--unpack` option as `--sb_extract` is now\ndeprecated.\n\nBRANCH\u003dnone\nBUG\u003db:202397678\nTEST\u003dVerified that scripts continue to work as expected\n\nSigned-off-by: Robert Zieba \u003crobertzieba@google.com\u003e\nChange-Id: Ib5596968f31a4b3b21fb81877d84b28660824818\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3665477\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "847ee5a830e4dc1d00fab2eb70465e3cddd1fb27", "tree": "8df7c2f3091c54e2141feb7b8531b2a97011e7cc", "parents": [ "bc952540dfeb2f2441e24a33965f62cc12681f96" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Thu Mar 17 18:07:53 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jun 07 10:23:08 2022 +0000" }, "message": "2api: Remove UI callback functions\n\nWith a series of UI callback functions removed from depthcharge (see the\nlong CL list in Cq-Depend below), now we can remove them from vboot2\nAPI.\n\nBUG\u003db:172339016\nTEST\u003dmake runtests -j\nTEST\u003demerge-corsola libpayload depthcharge\nBRANCH\u003dnone\n\nCq-Depend: chromium:3581323, chromium:3581320, chromium:3587669\nCq-Depend: chromium:3611670, chromium:3631467, chromium:3631405\nCq-Depend: chromium:3677727, chromium:3681952\nChange-Id: Icccaf81b8a6f16780bf68a6f1f3aa01689fc9ed8\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3682754\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "bc952540dfeb2f2441e24a33965f62cc12681f96", "tree": "e1adb1e07dc6dc1b7125e072542880d99d44c4d9", "parents": [ "3000736e2da72115f1350b6d9c0c66d208ddd1be" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Thu Jun 02 12:49:36 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 03 22:37:18 2022 +0000" }, "message": "OWNERS: Remove `*` approval\n\nAdding `*` to OWNERS makes Rubber Stamper not work for cherry-picks, so\nwe transition to something else. While coreboot and depthcharge\nresponsibilities are so distributed that it probably still makes sense\nto allow the whole firmware team to approve (see CL:3687245 and\nCL:3687246), vboot is not as platform-specific and it seems that we\nmostly have a tighter group of contributors. Looking at the recent\ncommits, it seems that pretty much every patch was approved by one of\nthe existing explicitly-mentioned owners anyway, so I think it makes\nsense to reduce ownership to that set. (Note that the scripts/\nsubdirectory already has its own additional OWNERS file managed by the\ninfra team, so we don\u0027t necessarily need to cover that.)\n\nBRANCH\u003dnone\nBUG\u003dnone\nTEST\u003dnone\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: Ib902f4dcf654f00703da8fff831c6a2b9f7e9e0e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3687195\nReviewed-by: Tim Wawrzynczak \u003ctwawrzynczak@chromium.org\u003e\n" }, { "commit": "3000736e2da72115f1350b6d9c0c66d208ddd1be", "tree": "cdffce0a346021eba308728628831e51561a4ec3", "parents": [ "fb0ddbbdf6018d9305248eb3138cb3cfcd532b31" ], "author": { "name": "Jakub Czapiga", "email": "jacz@semihalf.com", "time": "Tue Apr 12 14:49:22 2022 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon May 30 14:12:59 2022 +0000" }, "message": "futility: Remove --devsign and --devkeyblock\n\nThis feature has not been needed since pre-2012 devices which have long\nsince reached their end of life. We can safely remove it to simplify the\ncode.\nAlso remove ZGB image, as it is no longer needed.\n\nBUG\u003db:197114807\nTEST\u003dsudo FEATURES\u003dtest emerge vboot_reference\nBRANCH\u003dnone\n\nSigned-off-by: Jakub Czapiga \u003cjacz@semihalf.com\u003e\nCq-Depend: chromium:3650757\nChange-Id: I889dc6300c5cb72bdfcb9c2b66d63e97d3f8c862\nDisallow-Recycled-Builds: test-failures\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3578968\nCommit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\nAuto-Submit: Jakub Czapiga \u003cczapiga@google.com\u003e\nTested-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "fb0ddbbdf6018d9305248eb3138cb3cfcd532b31", "tree": "a44cc7d6bb73c75ec14e43c9ec01924f8dd9eb1a", "parents": [ "6dba972b6ab1246864d3af0eaa3effcda29407d1" ], "author": { "name": "Daichi Hirono", "email": "hirono@google.com", "time": "Fri May 20 11:13:37 2022 +0900" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri May 27 17:17:21 2022 +0000" }, "message": "signer: Reland \"Check the list of android image files\"\n\nPrevious change I5e8b4d848f30f53fae58c721c9b7ddcfbfea9852\nwas reverted because the check did not pass if the\nsigning process adds new files to the image.\n\nThe new check alerts only when we miss files in the original image.\n\nBUG\u003db:230434967\nBRANCH\u003dNone\nTEST\u003dRun ./sign_official_build.sh locally\n\nSigned-off-by: Daichi Hirono \u003chirono@chromium.org\u003e\n\nChange-Id: If8e9eeb9568fefcde92d737b356fa84b865b05c9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3653721\nCommit-Queue: Shao-Chuan Lee \u003cshaochuan@chromium.org\u003e\nTested-by: Daichi Hirono \u003chirono@chromium.org\u003e\nCommit-Queue: Daichi Hirono \u003chirono@chromium.org\u003e\nAuto-Submit: Daichi Hirono \u003chirono@chromium.org\u003e\nReviewed-by: Shao-Chuan Lee \u003cshaochuan@chromium.org\u003e\n" }, { "commit": "6dba972b6ab1246864d3af0eaa3effcda29407d1", "tree": "9e189ab7e3ff1d922dcdf22ad92178ab5fd16133", "parents": [ "ff1f3b91c31706d1e73a82ec928fd9bdd080f96f" ], "author": { "name": "Jae Hoon Kim", "email": "kimjae@chromium.org", "time": "Mon May 23 16:21:33 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 26 15:48:16 2022 +0000" }, "message": "futility: [deferredupdates] Defer setting firmware cookies\n\nThis is the firmware part of go/deferredupdates.\n\nDuring autoupdates, it\u0027s required to defer firmware cookies (a.k.a. slot\nswitching) to not try the updated RW firmware. Instead it is deferred\nfor the values to be updated at a later time, when the actual update\nshould be applied.\n\nSince there is not a clear communication method between\nfutility and postinstall+autoupdater, it\u0027ll be the case that STATUS will\nbe used as the IPC for postinstall+autoupdater to determine when to\nupdate firmware cookies w/ a UUID.\n\n```\n// autoupdate\nlocalhost ~ # chromeos-firmwareupdate --mode\u003dautoupdate --wp\u003d1\n\n Machine Model: gimble\n Write Protect: HW\u003d0 SW\u003d0\n Last Boot Version: RO\u003dGoogle_Gimble.14498.0.0 ACT/B\u003dGoogle_Gimble.14498.0.0\n Firmware Updater: RO\u003dGoogle_Gimble.14505.93.0 RW\u003dGoogle_Gimble.14505.93.0\n\n\u003e\u003e Starting firmware updater.\n\u003e\u003e Target image: images/bios-gimble.ro-14505-93-0.rw-14505-93-0.bin (RO:Google_Gimble.14505.93.0, RW/A:Google_Gimble.14505.93.0, RW/B:Google_Gimble.14505.93.0).\n\u003e\u003e Current system: \u003csys-flash\u003e (RO:Google_Gimble.14498.0.0, RW/A:Google_Gimble.14505.93.0, RW/B:Google_Gimble.14498.0.0).\n\u003e\u003e Write protection: 1 (enabled; HW\u003d1, SW\u003d1).\n\u003e\u003e TRY-RW UPDATE: Updating RW_SECTION_A to try on reboot.\n\u003e\u003e DONE: Firmware updater exits successfully.\n\nfw_prev_result \u003d trying # [RO/str] Firmware result of previous boot\nfw_prev_tried \u003d B # [RO/str] Firmware tried on previous boot (A or B)\nfw_result \u003d success # [RW/str] Firmware result this boot\nfw_tried \u003d B # [RO/str] Firmware tried this boot (A or B)\nfw_try_count \u003d 10 # [RW/int] Number of times to try fw_try_next\nfw_try_next \u003d A # [RW/str] Firmware to try next (A or B)\nfw_vboot2 \u003d 1 # [RO/int] 1 if firmware was selected by vboot2 or 0 otherwise\nfwb_tries \u003d 10 # [RW/int] Try firmware B count\nfwid \u003d Google_Gimble.14498.0.0 # [RO/str] Active firmware ID\nfwupdate_tries \u003d 0 # [RW/int] Times to try OS firmware update (inside kern_nv)\nmainfw_act \u003d B # [RO/str] Active main firmware\n\n// deferupdate HOLD\nlocalhost ~ # chromeos-firmwareupdate --mode\u003ddeferupdate_hold --wp\u003d1\n\n Machine Model: gimble\n Write Protect: HW\u003d0 SW\u003d0\n Last Boot Version: RO\u003dGoogle_Gimble.14498.0.0 ACT/B\u003dGoogle_Gimble.14498.0.0\n Firmware Updater: RO\u003dGoogle_Gimble.14505.93.0 RW\u003dGoogle_Gimble.14505.93.0\n\n\u003e\u003e Starting firmware updater.\n\u003e\u003e Target image: images/bios-gimble.ro-14505-93-0.rw-14505-93-0.bin (RO:Google_Gimble.14505.93.0, RW/A:Google_Gimble.14505.93.0, RW/B:Google_Gimble.14505.93.0).\n\u003e\u003e Current system: \u003csys-flash\u003e (RO:Google_Gimble.14498.0.0, RW/A:Google_Gimble.14505.93.0, RW/B:Google_Gimble.14498.0.0).\n\u003e\u003e Write protection: 1 (enabled; HW\u003d1, SW\u003d1).\n\u003e\u003e TRY-RW UPDATE: Updating RW_SECTION_A to try on reboot.\n\u003e\u003e DEFER UPDATE: Defer setting cookies for RW_SECTION_A.\n\u003e\u003e DONE: Firmware updater exits successfully.\n\nfw_prev_result \u003d trying # [RO/str] Firmware result of previous boot\nfw_prev_tried \u003d B # [RO/str] Firmware tried on previous boot (A or B)\nfw_result \u003d success # [RW/str] Firmware result this boot\nfw_tried \u003d B # [RO/str] Firmware tried this boot (A or B)\nfw_try_count \u003d 0 # [RW/int] Number of times to try fw_try_next\nfw_try_next \u003d B # [RW/str] Firmware to try next (A or B)\nfw_vboot2 \u003d 1 # [RO/int] 1 if firmware was selected by vboot2 or 0 otherwise\nfwb_tries \u003d 0 # [RW/int] Try firmware B count\nfwid \u003d Google_Gimble.14498.0.0 # [RO/str] Active firmware ID\nfwupdate_tries \u003d 0 # [RW/int] Times to try OS firmware update (inside kern_nv)\nmainfw_act \u003d B # [RO/str] Active main firmware\n\n// deferupdate APPLY\nlocalhost ~ # chromeos-firmwareupdate --mode\u003ddeferupdate_apply --wp\u003d1\n\n Machine Model: gimble\n Write Protect: HW\u003d0 SW\u003d1\n Last Boot Version: RO\u003dGoogle_Gimble.14498.0.0 ACT/B\u003dGoogle_Gimble.14498.0.0\n Firmware Updater: RO\u003dGoogle_Gimble.14505.106.0 RW\u003dGoogle_Gimble.14505.106.0\n\n\u003e\u003e Starting firmware updater.\nINFO: update_firmware: Apply defer updates, only setting cookies for the next boot slot.\n\u003e\u003e DONE: Firmware updater exits successfully.\n\nfw_prev_result \u003d trying # [RO/str] Firmware result of previous boot\nfw_prev_tried \u003d B # [RO/str] Firmware tried on previous boot (A or B)\nfw_result \u003d success # [RW/str] Firmware result this boot\nfw_tried \u003d B # [RO/str] Firmware tried this boot (A or B)\nfw_try_count \u003d 10 # [RW/int] Number of times to try fw_try_next\nfw_try_next \u003d A # [RW/str] Firmware to try next (A or B)\nfw_vboot2 \u003d 1 # [RO/int] 1 if firmware was selected by vboot2 or 0 otherwise\nfwb_tries \u003d 10 # [RW/int] Try firmware B count\nfwid \u003d Google_Gimble.14498.0.0 # [RO/str] Active firmware ID\nfwupdate_tries \u003d 0 # [RW/int] Times to try OS firmware update (inside kern_nv)\nmainfw_act \u003d B # [RO/str] Active main firmware\n```\n\nBUG\u003db:232304971\nTEST\u003dchromeos-firmwareupdate w/ comment above\nBRANCH\u003dNone\n\nSigned-off-by: Jae Hoon Kim \u003ckimjae@chromium.org\u003e\nChange-Id: Idcfc5864a2cfc2b46a8b936bbab61e3da7c62596\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3661357\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "ff1f3b91c31706d1e73a82ec928fd9bdd080f96f", "tree": "17b01cf60b5ec4ce100b329f748bcc266528510c", "parents": [ "d14e1c4b4ec45c8d23adf88aaff460d758275d66" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Thu May 19 14:06:25 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 25 20:29:32 2022 +0000" }, "message": "futility: gscvd: Allow passing board ID in ASCII\n\nIn many places (e.g. go/cros-dlm), we treat GSC board IDs as a 4-letter\nASCII string rather than a hexadecimal number. To relieve people of the\nneed to manually convert between formats when copy\u0026pasting IDs, this\npatch makes the `gscvd` command accept both versions.\n\nBRANCH\u003dnone\nBUG\u003db:229015103\nTEST\u003dfutility gscvd -b GVLR\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: I50fa73f5a14d2747c3e1b15e5dc3fbfcb2391f47\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3656349\nReviewed-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n" }, { "commit": "d14e1c4b4ec45c8d23adf88aaff460d758275d66", "tree": "4afd36f50427bc92af643473d3417de63cfd31cb", "parents": [ "fa4c817abb6eb9421bb4296cd137947519c37651" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Wed May 18 13:55:37 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat May 21 06:34:38 2022 +0000" }, "message": "vboot: Move TPM disabling call to depthcharge\n\nIntroduce a new vboot context flag VB2_CONTEXT_DISABLE_TPM to indicate\nwhether TPM should be disabled before jumping to kernel. This allows us\nto move the vb2ex_tpm_set_mode(VB2_TPM_MODE_DISABLED) call from vboot to\ndepthcharge. See CL:3653659 for details.\n\nBUG\u003db:223662000, b:232743820\nTEST\u003dmake runtests\nTEST\u003demerge-cherry depthcharge\nBRANCH\u003dcherry\n\nCq-Depend: chromium:3653659\nChange-Id: Ie7bcc3c7bf01346a3bc1f9e14b30017a4c3148ac\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3653207\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "fa4c817abb6eb9421bb4296cd137947519c37651", "tree": "83b0de6486328109901e5416d631f92c96f15e82", "parents": [ "523e7f1dde9193a68714ca5d8a70511f56577fae" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Tue May 17 17:23:51 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 18 21:48:56 2022 +0000" }, "message": "futility: gscvd: Add -G flag for GBB ranges\n\nThis patch adds a new `--add_gbb`/`-G` flag to the `gscvd` command that\ncan be used as a shorthand option to add the `GBB` FMAP section to the\ncovered ranges. When adding the GBB, it is important that we exclude the\nHWID and HWID digest from the covered ranges, because they can vary\nbetween units and it would be too cumbersome to sign every possible HWID\nseparately. Figuring out the right ranges to pass that exclude these\nindividual fields of the structure manually from the build scripts would\nbe very awkward, so let\u0027s add this option here where we can write the\nlogic cleanly with C code and have all the vboot data structure\ndefinitions readily available.\n\nAlso do some minor option parsing cleanups.\n\nBRANCH\u003dnone\nBUG\u003db:229015103\nTEST\u003dCreated GSCVDs with this flag, manually confirmed with a hex editor\nthat the correct ranges were created.\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: I3bef5355506d831353afe6f534ae9303334d014c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3653203\nReviewed-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n" }, { "commit": "523e7f1dde9193a68714ca5d8a70511f56577fae", "tree": "e6a7d10466d3c9455990f9573cb11feac274bc4e", "parents": [ "1928a657d475c1ab243185627a28cdf4dd36823e" ], "author": { "name": "Daichi Hirono", "email": "hirono@chromium.org", "time": "Wed May 18 05:58:29 2022 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed May 18 13:22:16 2022 +0000" }, "message": "Revert \"signer: Check the list of android image files\"\n\nThis reverts commit 48532e571bf79f32af972f6096681c11674c3825.\n\nReason for revert: Stable roll blocked due to unit test failures in platform/signing.\nhttps://ci.chromium.org/ui/p/chromeos/builders/cq/fullcheckout-presubmit/b8813887760837459473/overview\n\nOriginal change\u0027s description:\n\u003e signer: Check the list of android image files\n\u003e\n\u003e BUG\u003db:230434967\n\u003e BRANCH\u003dNone\n\u003e TEST\u003dRun ./sign_official_build.sh locally\n\u003e\n\u003e Signed-off-by: Daichi Hirono \u003chirono@chromium.org\u003e\n\u003e\n\u003e Change-Id: I5e8b4d848f30f53fae58c721c9b7ddcfbfea9852\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3607891\n\u003e Tested-by: Daichi Hirono \u003chirono@chromium.org\u003e\n\u003e Commit-Queue: Daichi Hirono \u003chirono@chromium.org\u003e\n\u003e Reviewed-by: Shao-Chuan Lee \u003cshaochuan@chromium.org\u003e\n\nBug: b:230434967\nChange-Id: I185562d6dcbac4fd30b6dc4c331bd0b1508d58e8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3644484\nCommit-Queue: Daichi Hirono \u003chirono@chromium.org\u003e\nTested-by: Daichi Hirono \u003chirono@chromium.org\u003e\nReviewed-by: Shao-Chuan Lee \u003cshaochuan@chromium.org\u003e\nAuto-Submit: Daichi Hirono \u003chirono@chromium.org\u003e\n" }, { "commit": "1928a657d475c1ab243185627a28cdf4dd36823e", "tree": "e904ff8265a1109ed31c6ffd7522a3a120abe620", "parents": [ "d2072ef664acf5486a664a8652e6d6f3dd9bf6fe" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri May 13 14:30:21 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon May 16 02:06:30 2022 +0000" }, "message": "futility: updater: split manifest implementation from updater_archive\n\nThe updater_archive has two functions: the implementation of archives,\nand the creation of manifest. Since we are having more support of\narchives in different format and the logic of manifests is getting more\ncomplicated, so it is better to move the manifest to its own file.\n\nNo functional changes, only internal refactoring.\n\nBUG\u003dNone\nTEST\u003dmake; run test\nBRANCH\u003dNone\n\nChange-Id: I01ff9561583357eac4c6add8a09384f1c4c9d671\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3647407\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "d2072ef664acf5486a664a8652e6d6f3dd9bf6fe", "tree": "2fb22ee4edbd457e9792f53944854ae1488db9e9", "parents": [ "e399c71caa6f2b1fccc6dd6ee6e1f07dc7fc7aab" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri May 13 11:18:24 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun May 15 13:02:15 2022 +0000" }, "message": "futility: updater: support reading the archives using libarchive\n\nThe firmware archive files from buildbot are usually released in\ntar+bzip2 format. Although the standard format of the archive\n(chromeos-firmwareupdate) is ZIP, it is very helpful if the developers\ncan quickly run the update using the standard tar.bz2 archive files.\n\nBUG\u003db:230679721\nTEST\u003dfutility update --manifest -a \\\n ~/Downloads/ChromeOS-firmware-R91-13885.3.0-asurada.tar.bz2\n QEMU_LD_PREFIX\u003d/build/cherry qemu-arm /build/cherry/usr/bin/futility \\\n update --manifest -a \\\n ~/Downloads/ChromeOS-firmware-R91-13885.3.0-asurada.tar.bz2\nBRANCH\u003dNone\n\nChange-Id: Ibbab2e8226a00e8b5b292293af570eda37b31a8a\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3644540\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "e399c71caa6f2b1fccc6dd6ee6e1f07dc7fc7aab", "tree": "9117ec2787d270ffbdd19a7468d9b4ee6a3a0d59", "parents": [ "8f851be54880fd941f2b49f5fa0419071eb89d81" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Thu May 12 14:16:31 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun May 15 13:02:14 2022 +0000" }, "message": "futility: updater: refactor \u0027archive\u0027 structure name\n\nRename \u0027struct archive\u0027 to \u0027struct u_archive\u0027 as \u0027updater archive\u0027\nso in future we can support libarchive (which needs \u0027struct archive\u0027).\n\nBUG\u003dNone\nTEST\u003dmake; run test\nBRANCH\u003dNone\n\nChange-Id: Id4e5b425044b6f1e64f504373c264dba05da62f4\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3644539\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "8f851be54880fd941f2b49f5fa0419071eb89d81", "tree": "29f05605ab97c6fdf291217c769231421d8de983", "parents": [ "e49bfbca21a3aeec31472aac7774c8dec94a4f17" ], "author": { "name": "Jakub Czapiga", "email": "jacz@semihalf.com", "time": "Thu Mar 31 11:42:49 2022 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat May 14 08:50:21 2022 +0000" }, "message": "futility: Rework file opening and mapping\n\nAdding calls to cbfstool truncate command requires file to be closed and\nnot mapped to work correctly. This patch reworks file opening and\nmapping to make it simpler. It also moves responsibility from main\ncommand runner to command functions to correctly operate on their\ninput/output files.\n\nBUG\u003db:197114807\nTEST\u003dsudo FEATURES\u003dtest emerge vboot_reference\nTEST\u003dbuild and boot while chromeos-bootimage and boot on volteer/voxel\n platform\nBRANCH\u003dnone\n\nSigned-off-by: Jakub Czapiga \u003cjacz@semihalf.com\u003e\nChange-Id: Iee24fdc43f2a57f54c65f6e55cdd26adf44a0b29\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3575324\nTested-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nAuto-Submit: Jakub Czapiga \u003cczapiga@google.com\u003e\n" }, { "commit": "e49bfbca21a3aeec31472aac7774c8dec94a4f17", "tree": "5a1bc36128b60bf4c85f4555cc2bb64950f11eb9", "parents": [ "23a1f64d4704cd1d69365eaf33cbc55af48ca34b" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@google.com", "time": "Thu May 05 16:18:38 2022 -0700" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri May 06 18:03:20 2022 +0000" }, "message": "create_new_gsc_key.sh: generate key file with the requested base name\n\nLet\u0027s require the user of this script to explicitly provide the base\nfile name of the generated key.\n\nBRANCH\u003dnone\nBUG\u003db:221423468\nTEST\u003dverified generating the new key in various directories (local and\n non local).\n\n Verified that the script fails if the user does not supply the\n required key file base name.\n\nChange-Id: Iaf85e5822d06c65ca4b7d51f17579269576e4707\nSigned-off-by: Vadim Bendebury \u003cvbendeb@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3630287\nTested-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n" }, { "commit": "23a1f64d4704cd1d69365eaf33cbc55af48ca34b", "tree": "3b008e64ec09314352bfbfeb867107d77012df7c", "parents": [ "dd04ea86966be157e1962475c42c23a44081038d" ], "author": { "name": "Nikolai Artemiev", "email": "nartemiev@google.com", "time": "Tue Mar 22 18:46:28 2022 +1100" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri May 06 03:56:52 2022 +0000" }, "message": "updater_utils: fix implicit conversion to enum wp_state\n\nThe getter for HWWP implicitly converted the integer returned by\ncrossystem to an `enum wp_state`. This only worked because of the\nparticular values assigned to the enum values, so explicitly convert\ninstead.\n\nBUG\u003db:223291615\nBRANCH\u003dnone\nTEST\u003dbuilds\n\nChange-Id: Ib572733f8b05a5a992f09ba98050a7eab5e3bcce\nSigned-off-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3540784\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nTested-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "dd04ea86966be157e1962475c42c23a44081038d", "tree": "9a82e3130110b144f93842e038a1055ae0d6059b", "parents": [ "2f21f0f1928aa9e92fc9e69900eafaa9933f836c" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Sat Apr 30 01:57:26 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 05 09:03:26 2022 +0000" }, "message": "futility: updater: refactor creating manifest from a simple folder\n\nMove the creation of simple folder manifest to a new function.\nNo changes in functionality.\n\nBUG\u003dNone\nTEST\u003dmake; run test\nBRANCH\u003dNone\n\nChange-Id: I302752183fc4f385f9b915023d26723a5cbd0c1c\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3615697\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "2f21f0f1928aa9e92fc9e69900eafaa9933f836c", "tree": "70547010f493a53a3c119c90187141a27e58184a", "parents": [ "c059f03ac296d9d439a87887e4dbd1e3494840d1" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Thu Apr 28 17:29:22 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 05 09:03:25 2022 +0000" }, "message": "futility: updater: create a manifest from the signer config\n\nThe signer_config.csv contains almost everything we need for mapping\nfrom models to image files so that can be an alternative when\nmodels/*/setvars.sh files are not available. This can be shared by\n/firmware in future.\n\nVerified by comparing the manifest.json from existing firmware updaters\non the following boards: volteer (share target), sarien (no ec), octopus\n(custom-label), and hatch (share target).\n\n for BOARD in volteer sarien octopus hatch; do\n /build/$BOARD/usr/sbin/chromeos-firmwareupdate --unpack test/$BOARD\n jq -S . \u003ctest/$BOARD/manifest.json \u003eold\n rm -rf test/$BOARD/models\n futility update --manifest -a test/$BOARD | jq -S . \u003enew\n diff new old \u003ediff.$BOARD\n done\n\n # all diff.$BOARD are empty, e.g., no difference.\n\nBUG\u003db:230679721\nTEST\u003dmake; run test\nBRANCH\u003dNone\n\nChange-Id: I17393c941d2577a2b1c5f00f60b25e98fa3f3a6f\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3612646\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "c059f03ac296d9d439a87887e4dbd1e3494840d1", "tree": "ddf296ce963c49a268ebcf88054f6f92930d649f", "parents": [ "53491084865df3620193304d896d048c1acf5882" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Sat Apr 30 01:40:07 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu May 05 09:03:23 2022 +0000" }, "message": "futility: updater: fix a typo in the SETVARS variable name\n\nThe PATH_ENDSWITH_SERVARS should be PATH_ENDSWITH_SETVARS.\n\nBUG\u003dNone\nTEST\u003dmake; run test\nBRANCH\u003dNone\n\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nChange-Id: I2fd8ab9fe9accf185bc85b2a195e90a9863669bf\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3615696\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "53491084865df3620193304d896d048c1acf5882", "tree": "bad918b7741329f89b60c80d75047fa7d8521e0f", "parents": [ "567d37e7a4d3fc88587b873cc0ef40d8812366d6" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Thu Apr 28 17:26:32 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 03 08:57:18 2022 +0000" }, "message": "futility: updater: always add a \\0 when reading files from archives\n\nTo simplify parsing text files in future we want the archive_read_file\nto always return a NULL terminated string on success.\n\nBUG\u003dNone\nTEST\u003dmake; run test\nBRANCH\u003dNone\n\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nChange-Id: I0dd0105971a80d857a1b05d9680b34b42dbff7e6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3612645\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "567d37e7a4d3fc88587b873cc0ef40d8812366d6", "tree": "7f4c6058345ba5db15a7958c6fbb52ca4dd33a3c", "parents": [ "5c19df0e6ea9ba079280ff06e9d4016b14c081ee" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@chromium.org", "time": "Thu Apr 21 20:38:47 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Apr 30 23:37:57 2022 +0000" }, "message": "keygeneration: add ability to generate accessory GSC RW signing key pair\n\nGSC RW signing requires a 3070 bit RSA key. The codesigner tool when\ninvoked expects the public key in .pem format, the same format is used\nby the RO codebase when incorporating the public key in the RO image.\n\nThis patch introduces a new accessory key generating script, which\ninvokes the appropriate opensssl command to generated the required key\npair.\n\nBUG\u003db:221423468\nBRANCH\u003dnone\nTEST\u003dran scripts/keygeneration/accessory/create_new_gsc_key.sh and\n observed two gsc keys generated:\n\n ls -l *gsc*\n -rw------- 1 vbendeb vbendeb 2451 Apr 21 20:42 gsc_3070.pem\n -rw-r--r-- 1 vbendeb vbendeb 625 Apr 21 20:42 gsc_3070.pem.pub\n\n in the FPGA setup confirmed that Ti50 RW can be signed and\n verified using the generated key pair.\n\nSigned-off-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nChange-Id: I429c250f60aa1da28aa99f39dff40c3bcda71df6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3600151\nReviewed-by: Andrey Pronin \u003capronin@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "5c19df0e6ea9ba079280ff06e9d4016b14c081ee", "tree": "34c8f9329d31d2437ac84f69c495e2381d423481", "parents": [ "cba197e626d47fc9f31babffdee614cddd4eebb3" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Wed Apr 27 23:02:55 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Apr 29 05:20:35 2022 +0000" }, "message": "futility: updater: support /firmware as a raw archive\n\nFor early bring up and the lab deployment, the developers need a simple\nway to update the firmware directly from the build artifacts (either\nfrom CPFE firmware archives or /build/$BOARD/firmware) before the\nfirmware is pinned and available via chromeos-firmwareupdate.\n\nTo simplify the process, we want the updater to understand the layout of\nfiles in /firmware. This change supports that as \"raw archive\" so\ndevelopers can update by:\n\n # Verify what\u0027s available.\n futility update -a /build/$BOARD/firmware --manifest\n\n # Update the firmware for a specific model.\n futility update -a /build/$BOARD/firmware --model $MODEL\n\n # On DUT, detect the model and update the firmware.\n mkdir /tmp/firmware\n tar -xvf firmware.tbz -C /tmp/firmware\n futility update -a /tmp/firmware\n\nBUG\u003db:230679721\nTEST\u003dmake; run tests\nBRANCH\u003dNone\n\nChange-Id: I8a262f1d2ec916da62e49a53fd45bdec9fa0ad9b\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3611322\nReviewed-by: Sergey Frolov \u003csfrolov@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "cba197e626d47fc9f31babffdee614cddd4eebb3", "tree": "88a3e7b56a52f821f08e7e23feb43f99c8bc2104", "parents": [ "48532e571bf79f32af972f6096681c11674c3825" ], "author": { "name": "Manoj Gupta", "email": "manojgupta@google.com", "time": "Wed Apr 27 12:07:27 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Apr 28 03:14:07 2022 +0000" }, "message": "futility: Fix -Wstrict-prototypes warning\n\nToT clang is complaining about missing \u0027void\u0027 in\nfunction prototype.\nfutility/updater.c:1235:42:\nerror: a function declaration without a prototype is\ndeprecated in all versions of C [-Werror,-Wstrict-prototypes]\nstruct updater_config *updater_new_config()\n ^\n void\nBUG\u003db:230345382\nTEST\u003dCQ, llvm tot test\nBRANCH\u003dnone\n\nSigned-off-by: Manoj Gupta \u003cmanojgupta@google.com\u003e\nChange-Id: Ic68b71a7413e9396904dd319e0febce2eecb0df3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3610725\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nTested-by: Manoj Gupta \u003cmanojgupta@chromium.org\u003e\nCommit-Queue: Manoj Gupta \u003cmanojgupta@chromium.org\u003e\nAuto-Submit: Manoj Gupta \u003cmanojgupta@chromium.org\u003e\n" }, { "commit": "48532e571bf79f32af972f6096681c11674c3825", "tree": "c5f2820cac3fa1585a3465c6b78826052c8b8c6b", "parents": [ "adadf8e219f4d1cbe6b940100ae0be843f438cef" ], "author": { "name": "Daichi Hirono", "email": "hirono@google.com", "time": "Tue Apr 26 17:52:42 2022 +0900" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 27 23:00:54 2022 +0000" }, "message": "signer: Check the list of android image files\n\nBUG\u003db:230434967\nBRANCH\u003dNone\nTEST\u003dRun ./sign_official_build.sh locally\n\nSigned-off-by: Daichi Hirono \u003chirono@chromium.org\u003e\n\nChange-Id: I5e8b4d848f30f53fae58c721c9b7ddcfbfea9852\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3607891\nTested-by: Daichi Hirono \u003chirono@chromium.org\u003e\nCommit-Queue: Daichi Hirono \u003chirono@chromium.org\u003e\nReviewed-by: Shao-Chuan Lee \u003cshaochuan@chromium.org\u003e\n" }, { "commit": "adadf8e219f4d1cbe6b940100ae0be843f438cef", "tree": "9cdad1ad2cff5c5eecba373c461e04ab597047fd", "parents": [ "58bfa1d53c4a1be40680775bd004ddb5b80ad8cb" ], "author": { "name": "Jakub Czapiga", "email": "jacz@semihalf.com", "time": "Wed Apr 06 13:25:04 2022 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 27 15:41:17 2022 +0000" }, "message": "futility/file_type_bios: Remove old FlashMap area names\n\nOld names are not in use for very long time, so remove them.\n\nBUG\u003db:197114807\nTEST\u003dcros-workon-volteer start vboot_reference \u0026\u0026 \\\n FW_NAME\u003dvoxel emerge-volteer vboot_reference coreboot\n chromeos-bootimage\nTEST\u003dsudo FEATURES\u003dtest emerge vboot_reference\nBRANCH\u003dnone\n\nSigned-off-by: Jakub Czapiga \u003cjacz@semihalf.com\u003e\nChange-Id: I07916b82a721481c982b291e228df0772e0fc2a2\nDisallow-Recycled-Builds: test-failures\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3575323\nAuto-Submit: Jakub Czapiga \u003cczapiga@google.com\u003e\nCommit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nTested-by: Jakub Czapiga \u003cczapiga@google.com\u003e\n" }, { "commit": "58bfa1d53c4a1be40680775bd004ddb5b80ad8cb", "tree": "72728f7716e4cc965a898b9dad46a22dea5a8e8d", "parents": [ "2981c0bacbaa0446562aaa04f23e3e9f07c86069" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@chromium.org", "time": "Thu Apr 21 20:25:48 2022 -0700" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Apr 23 04:09:58 2022 +0000" }, "message": "Revert \"keygeneration: add ability to generate GSC RW signing key pairs\"\n\nThis reverts commit 2981c0bacbaa0446562aaa04f23e3e9f07c86069, as that\npatch is not the proper way to generate accessory keys.\n\nBUG\u003db:221423468\nBRANCH\u003dnone\nTEST\u003dnone\n\nChange-Id: I5500424b01ef45cc353468173f60f9b202b92b54\nSigned-off-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3600150\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "2981c0bacbaa0446562aaa04f23e3e9f07c86069", "tree": "0809685defe30eaefaff7c5ad1540983bb598793", "parents": [ "3308065075cd5d55ee61f0b2fd456866c8286400" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@chromium.org", "time": "Mon Apr 18 17:32:24 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 20 12:10:45 2022 +0000" }, "message": "keygeneration: add ability to generate GSC RW signing key pairs\n\nGSC RW signing requires an 3070 bit RSA key. The codesigner tool when\ninvoked expects the public key in .pem format, the same format is used\nby the RO codebase when incorporating the public key in the RO image.\n\nThis patch introduces a new key option, RSA3070_NOSIG_ALGOID. The keys\nof this kind are not going to be processed by futility, hence no need\nto specify the signing algorithm.\n\nBUG\u003db:221423468\nBRANCH\u003dnone\nTEST\u003dran ./create_new_keys.sh and observed two gsc keys generated:\n $ ls *gsc*\n gsc_rw_3070.pem gsc_rw_3070.pem.pub\n\n in the FPGA setup confirmed that Ti50 RW can be signed and\n verified using the generated key pair.\n\nSigned-off-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nChange-Id: Ie676ba8043c34900388372270329a4903656d499\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3591642\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "3308065075cd5d55ee61f0b2fd456866c8286400", "tree": "72728f7716e4cc965a898b9dad46a22dea5a8e8d", "parents": [ "c38fe37ca1da6c8b682ddb74f79b139cda99fa7f" ], "author": { "name": "Alyssa Haroldsen", "email": "kupiakos@google.com", "time": "Tue Apr 12 14:34:05 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Apr 14 05:34:46 2022 +0000" }, "message": "Add a pre-built keyblock for arv_platform\n\nThis adds a keyblock holding the arv_platform public key that is signed\nwith the arv_root private key. The SHA-256 of the root key is\n3d74429f35be8d34bcb425d4397e2218e6961afed456a78ce30047f5b54ed158.\n\nCommand to build:\n\n./build/futility/futility vbutil_keyblock \\\n --pack tests/devkeys/arv_platform.keyblock \\\n --datapubkey tests/devkeys/arv_platform.vbpubk \\\n --signprivate tests/devkeys/arv_root.vbprivk\n\nBUG\u003db:161483233\nTEST\u003dabove command\nBRANCH\u003dNone\nSigned-off-by: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\n\nChange-Id: I7989c081e4a3ad79f957e3e6d8a3b2314e06152f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3584691\nReviewed-by: Jett Rink \u003cjettrink@chromium.org\u003e\nCommit-Queue: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\nTested-by: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\n" }, { "commit": "c38fe37ca1da6c8b682ddb74f79b139cda99fa7f", "tree": "428f6b6ed1d8fd9f04f329d7d195fc9df9c7f1dd", "parents": [ "33ff54fd5272ba4807c704aee8a46ee5d7d29215" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Wed Mar 09 12:00:39 2022 +1100" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 13 15:19:37 2022 +0000" }, "message": "host/lib/flashrom_drv.c: Ensure buffer is large enough in write op\n\nBUG\u003db:207808292\nBRANCH\u003dnone\nTEST\u003demerge-octopus and cros deploy\u0027ed\n\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nChange-Id: I8a8f941f224416d872592d6cc2de4caf058cb5bc\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3512274\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nTested-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nAuto-Submit: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nCommit-Queue: Nikolai Artemiev \u003cnartemiev@google.com\u003e\n" }, { "commit": "33ff54fd5272ba4807c704aee8a46ee5d7d29215", "tree": "1a2d749c922830acffe60c384d4a45b0bf5cf569", "parents": [ "e61f21346777c792868c96aad295aa704a41eae3" ], "author": { "name": "Alyssa Haroldsen", "email": "kupiakos@google.com", "time": "Tue Apr 12 14:21:46 2022 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 13 10:35:51 2022 +0000" }, "message": "[futility] Open gscvd in R/O mode when verifying\n\nOtherwise, it will mutate the file under your feet!\nThis also adds some clarifying messages, including a message if\nverification failed due to incorrect signing instead of silent output.\n\nBUG\u003dNone\nTEST\u003d`futility gscvd \u003cfile\u003e` does not change sha256sum of file\nBRANCH\u003dNone\nSigned-off-by: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\n\nChange-Id: Ic793ad47c0160e3cedb7e2b7cc842a3f4380749d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3584690\nReviewed-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nCommit-Queue: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\nTested-by: Alyssa Haroldsen \u003ckupiakos@google.com\u003e\n" }, { "commit": "e61f21346777c792868c96aad295aa704a41eae3", "tree": "a21778cf9c527e16ac028464b85183e9f1b75801", "parents": [ "a580477b7e0af844688f7f94c32b3436374b37ac" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Sat Apr 09 12:13:34 2022 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 13 08:10:38 2022 +0000" }, "message": "futility: updater: Support new servo control \u0027ccd_cpu_fw_spi\u0027\n\nSome newer devices need extra preparation steps even when using CCD via\nservo, so a new \u0027ccd_cpu_fw_spi\u0027 is added to hdctools. The firmware\nupdater should use it in servo+ccd modes.\n\nAlso, the custom_rst is now moved to detect_servo so the --servo_noreset\noption is removed.\n\nBUG\u003db:216832684\nTEST\u003dmake; run test\nBRANCH\u003dNone\n\nChange-Id: I6af0f03d5b0b1bb473ecb29680b253a5b71c7465\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3577658\nReviewed-by: Wai-Hong Tam \u003cwaihong@google.com\u003e\nTested-by: Wai-Hong Tam \u003cwaihong@google.com\u003e\n" }, { "commit": "25876f2be637a3a923b2c516846adb94b6dba515", "tree": "0abadfc7c7d2fe19da05647b46db00611d3b03e0", "parents": [ "1d1640f5cf8896fd284dd0435430bcb04e8ce321" ], "author": { "name": "Rayan Dasoriya", "email": "dasoriya@google.com", "time": "Mon Apr 04 18:44:13 2022 +0000" }, "committer": { "name": "Rayan Dasoriya", "email": "dasoriya@google.com", "time": "Thu Apr 07 00:16:28 2022 +0000" }, "message": "Revert \"image_signing: skip signing of boot*.efi on reven board\".\n\nThis reverts commit 4200cb21c7f6c79dacee511400c88994bca5cf7f. The reason\nfor revert is because this commit fails to load the secure boot.\n\nBUG\u003db/226099733\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\nChange-Id: Id25bd22945a177bc3298162160ef610df5f6a478\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/vboot_reference/+/31420\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\n" }, { "commit": "a580477b7e0af844688f7f94c32b3436374b37ac", "tree": "4f2b8240123c2945d47b0262a5af9f787861a15d", "parents": [ "4abb7e065dcdc9fa15b34da2ac53d9ab1e6a9db8" ], "author": { "name": "Sam McNally", "email": "sammc@chromium.org", "time": "Thu Feb 17 17:47:03 2022 +1100" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Apr 02 05:51:27 2022 +0000" }, "message": "vboot: Support servo micro and C2D2 for {get,set}_gbb_flags.sh --servo.\n\nDetect servo micro and C2D2 servo types and toggle cpu_fw_spi before and\nafter flash access is required.\n\nBUG\u003db:220992685\nTEST\u003d{get,set}_gbb_flags.sh --servo with C2D2 and servo micro\nBRANCH\u003dNone\n\nCq-Depend: chromium:3470605\nChange-Id: I9f8a9bcabe731001ed18150ca1db9820db20e0d3\nSigned-off-by: Sam McNally \u003csammc@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3469747\nReviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "4abb7e065dcdc9fa15b34da2ac53d9ab1e6a9db8", "tree": "85cad49200eaa7779b2a7536df2a458ba5444ed2", "parents": [ "26187f1d4e2534fe9d2fe90e7ce82af23ada1866" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@chromium.org", "time": "Fri Mar 25 10:46:34 2022 -0700" }, "committer": { "name": "Vadim Bendebury", "email": "vbendeb@chromium.org", "time": "Wed Mar 30 17:06:35 2022 +0000" }, "message": "sign_gsc_firmware: drop version number check for node locked images\n\nWith introduction of Ti50 images the version of the eraseflashinfo\ncapable images must change, which will prevent signing scripts from\naccepting Ti50 images from node locked signing.\n\nEnforcing the version number is proving to be a larger pain that in is\nworth: we do need to modify the version once in a while, and it takes\na lot of effort and time to propagate the version adjustment through\nsigning stages.\n\nWe already have a quorum requirement for eraseflashinfo capable node\nlocked images, this provides enough guarantee from accidental signing\nor malicious signing of such an image, version number enforcement does\nnot add security.\n\nBRANCH\u003dnone\nBUG\u003db:219774807\nTEST\u003dnone\n\nChange-Id: Ifd5ac17540595d71210445e6ad573c81fc25a47a\nSigned-off-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3553419\nReviewed-by: Mary Ruthven \u003cmruthven@chromium.org\u003e\nReviewed-by: Andrey Pronin \u003capronin@chromium.org\u003e\n" }, { "commit": "26187f1d4e2534fe9d2fe90e7ce82af23ada1866", "tree": "8a9327ae1d77f03c9532a89185b4e338c4e40907", "parents": [ "67d21be99c7ce35bc0580c4fd4e062da90bd1cbb" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Mar 18 14:19:16 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 18 20:43:53 2022 +0000" }, "message": "futility: updater: add new quirk \u0027external_flashrom\u0027\n\nThe new quirk will allow the updater to easily switch the underlying\nflash driver between the libflashrom and the external flashrom.\n\nBUG\u003dNone\nTEST\u003dbuild and run test\nBRANCH\u003dNone\n\nChange-Id: I5b9da373b1e22a948e04d844973a5683adffe63c\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3534489\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "67d21be99c7ce35bc0580c4fd4e062da90bd1cbb", "tree": "f6414ee80a59d7502a58db69d1b248d037041807", "parents": [ "4cba64cfb67c0215eec140caedac3450ee837de9" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Tue Mar 08 20:35:38 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 18 20:43:52 2022 +0000" }, "message": "futility: updater: support external flashrom\n\nThe libflashrom is still different from the real flashrom program.\nTo easily debug and compare the execution results (especially for\ndevices under development), we want to allow the updater to\nswitch between the libflashrom and the external flashrom.\nThe real switch (either a quirk or a command line argument) will\nbe added in a follow up change.\n\nBUG\u003dNone\nTEST\u003dbuild and run test\nBRANCH\u003dNone\n\nChange-Id: I3f3226fd555dc9e7c40838cd1474e0d018b27ccc\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3500339\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "4cba64cfb67c0215eec140caedac3450ee837de9", "tree": "682edf8c4fb01657d2ea8ef26fa87e6083e5542e", "parents": [ "8f30263bde6636a58e1d33d7fdd007c3abb4f7ce" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Wed Mar 09 20:58:05 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 18 20:43:50 2022 +0000" }, "message": "futility: updater: refactor {write,load}_system_firmware\n\nThe \u0027write_system_firmware\u0027 and \u0027load_system_firmware\u0027 have too many\nparameters that are already contained in the updater_config.\nTo simplify the interfaces, we should just pass the updater_config to\n{write,load}_system_firmware, and merge the write_firmware_sections\n(only handling emulation and deciding the diff image) to the\nwrite_system_firmware.\n\nAlso moved the utility functions only used by *_system_firmware (for\nexample is_the_same_programmer and emulate_write_firmware) to the\nupdater_utils.c.\n\nThe emulate_write_firmware is also revised to handle a list of sections\ndirectly (so we don\u0027t need to handle that in write_system_firmware).\n\nBUG\u003dNone\nTEST\u003dmake; build and run test.\nBRANCH\u003dNone\n\nChange-Id: I4d123d12e8057da82d6c301899472e3773f3266e\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3508121\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "8f30263bde6636a58e1d33d7fdd007c3abb4f7ce", "tree": "dcd1bf81eb6028377334e59628979f17a1ec9bb2", "parents": [ "613f22e8de3f8ef3d87bf8e5de6f277e92e3a631" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Mar 18 14:38:19 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 18 16:05:02 2022 +0000" }, "message": "futility: updater: rename \u0027customlabel_tag\u0027 to \u0027custom_label_tag\u0027\n\nPer discussion, the \u0027custom_label_tag\u0027 is easier to read than\n\u0027customlabel_tag\u0027. We should rename it before any real devices\nhave started using the different names.\n\nBUG\u003db:169766857\nTEST\u003dmake; build and run test\nBRANCH\u003dNone\n\nChange-Id: I3672e7b20bc85f79796470ba1a58c2896d26ff88\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3534491\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "613f22e8de3f8ef3d87bf8e5de6f277e92e3a631", "tree": "bccbf1742901c1d74d05c6ff461022dc3eebd4f9", "parents": [ "ecf7b40b087a3c604c849bbf3a599c8daeff2268" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Thu Mar 17 19:09:57 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 18 10:02:24 2022 +0000" }, "message": "2api: Correct the comment of vb2api_disable_developer_mode()\n\nIt should be VB2_NV_DISABLE_DEV_REQUEST, not VB2_NV_DIAG_REQUEST.\n\nBUG\u003db:172339016\nTEST\u003dnone\nBRANCH\u003dnone\n\nChange-Id: Id35ea2680dd55d830991cf118f4e9c97f52eb0cb\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3532539\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "ecf7b40b087a3c604c849bbf3a599c8daeff2268", "tree": "c32b1117aee1b6edc2a011abf748c941d29e393a", "parents": [ "e064462e6be553bf9601a1d2d0b79f2eded47381" ], "author": { "name": "Peter Marheine", "email": "pmarheine@chromium.org", "time": "Tue Mar 15 15:49:47 2022 +1100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Mar 16 00:00:10 2022 +0000" }, "message": "futility: correct typo of \"flashrom\"\n\nBUG\u003dnone\nTEST\u003dstill builds\nBRANCH\u003dnone\n\nChange-Id: I3b244461b86c8aeec4f33ad7205157c709e0d695\nSigned-off-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3524288\nReviewed-by: Reka Norman \u003crekanorman@chromium.org\u003e\n" }, { "commit": "1d1640f5cf8896fd284dd0435430bcb04e8ce321", "tree": "97ede3996e9762f262f2d44eddff177c49c4d7bf", "parents": [ "79af323d0f49fc28a8a4f674ccdcf6d1f7e18daf", "c31013768eb4ed052c54df50c398f70f2d7ef36d" ], "author": { "name": "Rayan Dasoriya", "email": "dasoriya@google.com", "time": "Thu Mar 03 00:05:33 2022 +0000" }, "committer": { "name": "Rayan Dasoriya", "email": "dasoriya@google.com", "time": "Tue Mar 15 23:36:02 2022 +0000" }, "message": "Merge commit \u0027c31013768eb4ed052c54df50c398f70f2d7ef36d\u0027 into 14542.0.0\n\nBUG\u003db/222349736\nTEST\u003dlocal BE run\nRELEASE_NOTE\u003dNone\n\nSigned-off-by: Rayan Dasoriya \u003cdasoriya@google.com\u003e\nChange-Id: Ie0b27e4c165dec7db1bcca809d14e859894babe1\n" }, { "commit": "e064462e6be553bf9601a1d2d0b79f2eded47381", "tree": "d996853c87cdeca84bda6a88020d864b1b803ead", "parents": [ "660c41fbf07015af212aadba8395439f137789e8" ], "author": { "name": "Subrata Banik", "email": "subratabanik@google.com", "time": "Mon Mar 14 01:43:32 2022 +0530" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 15 12:51:19 2022 +0000" }, "message": "crossystem: Add support for MTL gpiochip\n\nOn Meteor Lake platform, the pinctrl (gpiochip) driver label is\n\"INTC1083:00\", hence declare it properly.\n\nBUG\u003db:224325352\nTEST\u003dTest pending\n\nSigned-off-by: Subrata Banik \u003csubratabanik@google.com\u003e\nChange-Id: I9c1583972e71ae472c8b3f360eda34611c8c8f0c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3520099\nReviewed-by: Tim Wawrzynczak \u003ctwawrzynczak@chromium.org\u003e\nTested-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\nCommit-Queue: Subrata Banik \u003csubratabanik@chromium.org\u003e\nAuto-Submit: Subrata Banik \u003csubratabanik@chromium.org\u003e\n" }, { "commit": "660c41fbf07015af212aadba8395439f137789e8", "tree": "7daae2c4da7164d4176d0169ebfce47a9b044630", "parents": [ "1662f3f83a494a64c7e7d85428a00d4e942d6b8c" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Tue Mar 01 18:09:51 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 11 07:59:15 2022 +0000" }, "message": "futility: updater: revise building RW-recovery sections\n\nWhen checking the sections to update in the RW-recovery flow, we should\nalways check the availability before adding them to the list for\nupdating.\n\nBUG\u003dNone\nTEST\u003dbuild and run test\nBRANCH\u003dNone\n\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nChange-Id: Id714b1db736cbf4eef879566431e5a496f319cd4\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3494671\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "1662f3f83a494a64c7e7d85428a00d4e942d6b8c", "tree": "5d17645da05f98867ec6839a16a5c41034325772", "parents": [ "41cc9ec586acf454808efab37626cde7d1f68c46" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Mon Mar 07 16:45:25 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 08 01:35:17 2022 +0000" }, "message": "futility: updater: always do partial verify (-N/--noverify-all)\n\nThe updater should always only update the whole image when write\nprotection is disabled, or partial (RW) when write protection is\nenabled. As a result, it should be better to always turn on -N\n(--noverify-all) for two reasons: (1) faster partial write, and\n(2) prevent failure due to other processors accessing the flash\nin parallel.\n\n- Faster partial write:\n On recent x86 Chromebooks the flash size is getting bigger and bigger\n (for example 32M on Brya) and the RW section size is much smaller\n (8M on Brya). So we wasted a lot of time reading and verifying\n sections that we don\u0027t care (64M versus 16M) if we don\u0027t turn on -N.\n\n- Concurrent access:\n On recent x86 devices the system flash is shared by two processors -\n the CPU and the CSME. Before the ME is locked, CPU can see and access\n all regions - including those managed by ME/CSME. As a result, when\n the updater is changing the RW_SECTION, the CSME may be updating\n CSE_RO or CSE_RW on its own. So if we don\u0027t turn on -N, the\n verification will fail in CSE regions.\n\nAlso revised to only set FLASHROM_FLAG_VERIFY_AFTER_WRITE one time.\n\nBUG\u003dNone\nTEST\u003dmake; build and run tests.\nBRANCH\u003dNone\n\nChange-Id: I1ebff2d7f00b85037464eff4fa5d4573f867ce44\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3505290\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "41cc9ec586acf454808efab37626cde7d1f68c46", "tree": "a815e9e67be8e801ce7cbb0ad2e7e34014ffb387", "parents": [ "065008678e3cd2567c3dc44ecaddf0bcad226c81" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Mon Mar 07 09:39:37 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 07 18:12:24 2022 +0000" }, "message": "futility: updater: Change \u0027whitelabel_tag\u0027 to \u0027customlabel_tag\u0027\n\nSupport new VPD name \u0027customlabel_tag\u0027 for the custom label program.\nFor shipped devices (firmware is already locked and write protected) we\nstill support the legacy name.\n\nThe quirk \u0027allow_empty_wl_tag\u0027 also renamed to\n\u0027allow_empty_customlabel_tag\u0027.\nThis is usually not recommended, but given no devices have used this\nquirk in the CBFS quirks, it should be fine to change the quirk name.\n\nBUG\u003db:169766857\nTEST\u003dmake; build and run test\nBRANCH\u003dNone\n\nChange-Id: Ia29051a4e829d853cc60488f286d575c20f52f20\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3503199\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "065008678e3cd2567c3dc44ecaddf0bcad226c81", "tree": "548ec51a60a381101966b870bc676fa3d68cf4b7", "parents": [ "d0e5d8bc0ba6a5ac0ddff70f38adf31bfc082e49" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Thu Feb 17 11:26:43 2022 +1100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 03 12:33:53 2022 +0000" }, "message": "vboot_ref/cgpt: Move mkdir out of flashrom worker func\n\nSmall refactor to make it easier to more towards\nlibflashrom. This makes the call site responsible for\nsetting up the path for ReadNorFlash().\n\nBUG\u003db:207808292,b:220079643\nBRANCH\u003dnone\nTEST\u003d`make cgpt`\n\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nChange-Id: I15fc57e5afca6206b60df92616fd4cdce63b03e3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3469738\nTested-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nAuto-Submit: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-by: Sam McNally \u003csammc@chromium.org\u003e\nCommit-Queue: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "d0e5d8bc0ba6a5ac0ddff70f38adf31bfc082e49", "tree": "e36d65e7505765edae6b6dedf225ac66e190426e", "parents": [ "160904567282fb18b9c42e5bff65e65a45d408e1" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Thu Feb 17 11:16:25 2022 +1100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 03 12:33:52 2022 +0000" }, "message": "vboot_ref/cgpt: Consolidate flashrom write cmd paths\n\nSmall refactor to make it easier to more towards libflashrom.\n\nBUG\u003db:207808292,b:220079643\nBRANCH\u003dnone\nTEST\u003d`make cgpt`\n\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nChange-Id: Ie0c7f4faee3052300b10ba2d1adce7876d7b821c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3469737\nTested-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nAuto-Submit: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-by: Sam McNally \u003csammc@chromium.org\u003e\nCommit-Queue: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "160904567282fb18b9c42e5bff65e65a45d408e1", "tree": "74f4190b69351d9d51621403da7ff111bc550f01", "parents": [ "a824e1e710b9038cf99fa3f08f47dbc1faa83d99" ], "author": { "name": "Sam McNally", "email": "sammc@chromium.org", "time": "Wed Feb 16 19:49:41 2022 +1100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 03 11:29:20 2022 +0000" }, "message": "futility: Support C2D2 with futility update --servo.\n\nC2D2 is used similarly to servo micro. Mirror the servo micro logic\naccordingly.\n\nBUG\u003db:220992685\nTEST\u003dfutility update --servo over C2D2 with and with servo v4\nBRANCH\u003dNone\n\nCq-Depend: chromium:3470605\nChange-Id: I298fe5847abba0957fa5c2da4e1981a7da9e0428\nSigned-off-by: Sam McNally \u003csammc@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3469746\nReviewed-by: Reka Norman \u003crekanorman@chromium.org\u003e\n" }, { "commit": "a824e1e710b9038cf99fa3f08f47dbc1faa83d99", "tree": "edc1eb6fd39d671bbe33387597f31336347153fe", "parents": [ "c31013768eb4ed052c54df50c398f70f2d7ef36d" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Wed Mar 02 20:17:23 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Mar 02 21:33:45 2022 +0000" }, "message": "futility: updater: increase verbosity on retries\n\nTo get more message for debugging, we want to increase the verbosity on\neach retry.\n\nBUG\u003dNone\nTEST\u003dbuild and run tests\nBRANCH\u003dNone\n\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nChange-Id: I85e0fc518113a18bb1aaa39db3f58329d94b5ecb\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3500326\nReviewed-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\n" }, { "commit": "c31013768eb4ed052c54df50c398f70f2d7ef36d", "tree": "2ef2be6db7746b10beaf42e9a60b3706d653f9b6", "parents": [ "37055cfb165e233a83820fd561b476edf966d2b0" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Thu Feb 10 15:02:19 2022 +1100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 01 09:42:32 2022 +0000" }, "message": "vboot_ref/cgpt: Use defines for region consts\n\nBUG\u003db:207808292,b:220079643\nBRANCH\u003dnone\nTEST\u003d`make cgpt`\n\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nChange-Id: I367e44eed18c79a807bd428e50a3faf926833719\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3461097\nAuto-Submit: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nTested-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nCommit-Queue: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "37055cfb165e233a83820fd561b476edf966d2b0", "tree": "22dd0942e2590c2ea8b09bd8606689b6e5dc495c", "parents": [ "ed3ae2dc822fc6607c0a669ab259424659c826f4" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Feb 25 12:48:34 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 01 02:41:44 2022 +0000" }, "message": "futility: updater: write multiple sections in recovery RW update\n\nThe write_firmware_sections now supports writing multiple sections in\none invocation so we can pass all RW sections to it for the recovery\nupdate.\n\nOn Brya, the total execution time may be reduced from 4 mins to\n1.5 mins.\n\nBUG\u003db:221137867\nTEST\u003dbuild and run test\nBRANCH\u003dNone\n\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nChange-Id: Ifbc67327a02096e027c1e2025485ebb17645a71d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3490387\nReviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "ed3ae2dc822fc6607c0a669ab259424659c826f4", "tree": "18ffc295c81a145a2f8eec7f00f9dd8f56c2b8c2", "parents": [ "cc3f48ba5dc64e91404fccdec100f6c67887b01a" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Feb 25 12:38:57 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 01 02:41:43 2022 +0000" }, "message": "futility: updater: allow writing multiple sections in one flash command\n\nAdd new function \u0027write_firmware_sections\u0027 so we can write update\nsections in one write_system_firmware (e.g., flashrom) command.\n\nBUG\u003db:221137867\nTEST\u003dbuild; and run test\nBRANCH\u003dNone\n\nChange-Id: Ia33ec5ac82e1c661457180ec45df6c02beae4ec3\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3490389\nReviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "cc3f48ba5dc64e91404fccdec100f6c67887b01a", "tree": "355d61887d2935459ee87cb64a06329f189c53dd", "parents": [ "07a7bc69641129e937ab702b95e893d4a5ba45fd" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Feb 25 11:27:54 2022 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 01 02:41:41 2022 +0000" }, "message": "futility: flashrom_drv: support partial write for multiple regions\n\nWhen we have multiple regions to update, invoking flashrom_write_image\nmultiple times will take much longer because for each write it has to\nread the whole flash, write and then verify whole flash (also timer\ncalibration and programmer init/shutdown every time).\n\nAs a result, we want to support writing multiple regions - just like\nthat flashrom can take arbitrary numbers of \"-i REGION\".\n\nThis change only extended flashrom_write_image, and the firmware updater\nis calling flashrom_drv multiple times. That will be addressed in the\nfollow up changes.\n\nBUG\u003db:221137867\nTEST\u003dbuild; and run test\nBRANCH\u003dNone\n\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nChange-Id: Id335cc9f816f1384f1886422efa97fe2c7b81aec\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3490388\nReviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "07a7bc69641129e937ab702b95e893d4a5ba45fd", "tree": "0f26b5205e1f190a27a316b7b8d6622512369e1b", "parents": [ "14b8a681131e81523f6dd9ffd5125026c737daed" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Mon Feb 28 13:08:15 2022 +1100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Feb 28 23:30:28 2022 +0000" }, "message": "vboot_reference/Makefile: Fix building with USE_FLASHROM:\u003d0\n\nUnfortunately the USE_FLASHROM build flag broke during a refactor\nin commit f0af257a9b333b. This flag is needed for coreboot builds.\nResolve by putting relevant files under guards.\n\nBUG\u003db:221234560,b:220833585\nBRANCH\u003dnone\nTEST\u003d`USE_FLASHROM\u003d{0,1} make`\n\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nChange-Id: Ic10a3909bf070897cef7f1556deef57eba6c57f3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3493527\nTested-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nAuto-Submit: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-by: Martin Roth \u003cmartinroth@google.com\u003e\nCommit-Queue: Martin Roth \u003cmartinroth@google.com\u003e\n" } ], "next": "14b8a681131e81523f6dd9ffd5125026c737daed" }