)]}'
{
  "commit": "abd6cb388bed9d21a1c3b17d23897db09acaec80",
  "tree": "baacd978146d94244b8b44ce2c7b92e5817f8a6e",
  "parents": [
    "658dd24c41d2d017834fcada7437e1eb4c7f695f"
  ],
  "author": {
    "name": "Yu-Ping Wu",
    "email": "yupingso@google.com",
    "time": "Mon Sep 07 11:33:00 2026 +0800"
  },
  "committer": {
    "name": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Sep 09 04:10:16 2026 -0700"
  },
  "message": "sign_official_build: Remove \"|| ret\u003d$?\" in resign_firmware_payload\n\nIn resign_firmware_payload(), resign_firmware_shellball() is invoked\nwith `|| ret\u003d$?` to record the exit status and attempt to run\n`sudo umount \"${rootfs_dir}\"` afterwards.\n\nHowever, invoking a function in an `||` list suppresses `set -e`\nthroughout the function\u0027s execution tree. If a command inside fails\nwithout explicitly calling `die`, the error is silently ignored and the\nfunction may still return 0, masking failures. Furthermore, if a command\ndoes call `die`, `exit 1` terminates the script immediately, so\n`|| ret\u003d$?` and subsequent cleanup lines are never reached anyway.\n\nSince make_temp_dir() already registers temporary mount directories in\nTEMP_DIR_LIST, any script exit or fatal error triggers the global EXIT\ntrap (cleanup_temps_and_mounts()), ensuring proper unmounting.\n\nRemove `|| ret\u003d$?` so that errors inside resign_firmware_shellball()\npropagate naturally under `set -e`.\n\nBUG\u003db:557267321\nTEST\u003dmake runtests\nBRANCH\u003dnone\nTAG\u003dagy\nCONV\u003d705e5b3f-acf0-4ebd-91be-9a3d57b9198a\n\nSigned-off-by: Yu-Ping Wu \u003cyupingso@google.com\u003e\nChange-Id: I949588845d06c49202be22d844df0a156a6a6964\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/8364946\nTested-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "245ef7356ffbd5729976ddff3f86709ba3a9f0ce",
      "old_mode": 33261,
      "old_path": "scripts/image_signing/sign_official_build.sh",
      "new_id": "f2a36cace058934b796db1c3ed71df1287dfedbd",
      "new_mode": 33261,
      "new_path": "scripts/image_signing/sign_official_build.sh"
    }
  ]
}