)]}'
{
  "commit": "92e9d72aa09f222c592a34cf1724d9aeabfbd2e3",
  "tree": "69b54e24a643e090e3de131893ee33e920850573",
  "parents": [
    "a87b5efa123a3fa2351e0c2eb359dc05b5c526a5"
  ],
  "author": {
    "name": "Shrihari Murali",
    "email": "shriharim@google.com",
    "time": "Fri May 01 02:40:41 2026 +0000"
  },
  "committer": {
    "name": "SHRIHARI MURALI",
    "email": "shriharim@google.com",
    "time": "Wed May 06 16:31:11 2026 -0700"
  },
  "message": "Bypass pickargs usage for cvm boards to fix GRUB boot hang\n\nAn [upstream COS\nchange](https://cos-review.git.corp.google.com/c/third_party/platform/crosutils/+/142463)\nintroduced the `pickargs` command into the legacy GRUB configuration\ntemplates to dynamically parse extra command line arguments from\n\u0027cmdline_extra.bin\u0027.\n\nHowever, the minimal GRUB binary used for Confidential VM (cvm) boards\ndoes not include or support the custom \u0027pickargs\u0027 module. As a result,\nwhen the image boots on target hardware, GRUB encounters an \u0027unknown\ncommand pickargs\u0027 error and freezes entirely before the kernel can\nstart, resulting in a blank serial console.\n\nThis fix introduces a conditional check using wildcard matching\n(`*cvm-amd64-gdc*`) in `create_legacy_bootloader_templates.sh`. If a cvm variant\nboard is detected, the script bypasses the pickargs layout and instead\nemits the exact, character-for-character legacy GRUB text configuration\nthat was working previously.\n\nReview Notes:\n- The master behavior using `pickargs` remains 100% identical and unchanged\n  for all other boards.\n- This fix successfully restores the serial console stream and lets the\n  verified boot flow complete cleanly on cvm targets.\n\nBUG\u003db/504738188 TEST\u003dhttps://paste.googleplex.com/6162200533270528\n\nChange-Id: I58280281d58b4f2a81eda9eff765defaf90e8678\nReviewed-on: https://cos-review.googlesource.com/c/third_party/platform/crosutils/+/148203\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nReviewed-by: Robert Kolchmeyer \u003crkolchmeyer@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ab22b5c5426f3ef25284203582fe06877469600b",
      "old_mode": 33261,
      "old_path": "build_library/create_legacy_bootloader_templates.sh",
      "new_id": "48a741c7a8545672d4ba6a7b61719809d50ac069",
      "new_mode": 33261,
      "new_path": "build_library/create_legacy_bootloader_templates.sh"
    }
  ]
}