| commit | 5bf47309705c0a484c97b9e5148369d182da6970 | [log] [tgz] |
|---|---|---|
| author | Brian Norris <briannorris@chromium.org> | Fri Nov 13 16:14:10 2020 -0800 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Nov 18 22:11:14 2020 +0000 |
| tree | 6c17378b40a270ec269140e91dd68fa79919400f | |
| parent | 4aa33ca249b6cf58dc934047328973c4b02284c8 [diff] |
build_kernel_image: drop nmi_watchdog= The ",lapic" part was superfluous for a very long time. See https://crrev.com/c/2530315, which was reverted at https://crrev.com/c/2538055 for procedural reasons (the signer didn't like the new command line). The signer has since been fixed. The remaining piece (nmi_watchdog=panic) (a) was never required for non-x86 systems, as they specified the "panic" behavior in their kernel configuration instead; and (b) is no longer required for x86 systems (as of https://chromium-review.googlesource.com/q/Idd46b11e21ade10bf7f399055a7d462076137335) for the same reason. All architectures are consistent now (where hardlockup detectors are supported), and we can drop the command line entirely. BUG=b:172222678 TEST=platform_KernelErrorPaths.HARDLOCKUP Change-Id: I51c2b2c0fce25c52635d74ff9cc0894c070dd764 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosutils/+/2538358 Commit-Queue: Brian Norris <briannorris@chromium.org> Tested-by: Brian Norris <briannorris@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>