tree c420f3fc32ee49974e75ca9369c234849d66934c
parent 12928b849a0de249aa1bec78926b7a120a5ac387
author Guenter Roeck <groeck@chromium.org> 1576271857 -0800
committer Commit Bot <commit-bot@chromium.org> 1578405966 +0000

build_kernel_image: Configure tpm_tis command line override per platform

A boot warning similar to the following is seen on many platforms.

tpm tpm0: tpm_try_transmit: tpm_send: error -5
tpm tpm0: tpm_relinquish_locality: : error -1
tpm_tis: probe of tpm_tis failed with error -5

The error is more severe on some other platforms. On lars, we see
the following warning and traceback:

------------[ cut here ]------------
WARNING: CPU: 1 PID: 1 at ../../../../../tmp/portage/sys-kernel/chromeos-kernel-3_18-3.18-r2419/work/chromeos-kernel-3_18-3.18/lib/iomap.c:43 bad_io_access+0x36/0x38()
Bad IO access at port 0x84 (return inl(port))
Modules linked in:
CPU: 1 PID: 1 Comm: swapper/0 Not tainted 3.18.0-19943-g523bb9d34d2f #1
Hardware name: Acer Lars/Lars, BIOS Google_Lars.7820.376.0 05/18/2018
0000000000000000 00000000185291bb ffff88017a1bfb38 ffffffff923aedfb
0000000000000000 ffff88017a1bfb90 ffff88017a1bfb78 ffffffff91dc5747
00000000000fed44 ffff880179aa6ee8 ffff8801791f1800 ffff8801799abc00
Call Trace:
[<ffffffff923aedfb>] dump_stack+0x4e/0x71
[<ffffffff91dc5747>] warn_slowpath_common+0x84/0x9f
[<ffffffff91dc585b>] warn_slowpath_fmt+0x55/0x6b
[<ffffffff91fa721c>] bad_io_access+0x36/0x38
[<ffffffff91fa7421>] ioread32+0x2a/0x2f
[<ffffffff92045c1f>] tpm_tis_init+0xb3/0x131
[<ffffffff92045dad>] tpm_tis_pnp_init+0x110/0x11f
...

This is due to the "tpm_tis.force=1 tpm_tis.interrupts=0" command line
flags, which are currently provided for all platforms in the generic
build_kernel_image.sh. Unfortunately, some older platforms do need those
flags, so they can not be removed entirely. Move the flags to per-platform
build scripts where needed to solve the problem.

BUG=b:113527055, chromium:
TEST=Ensure that login on all boards still works

Cq-Depend: chromium:1967937
Change-Id: I8cffd1a7116b353ca57f2edcb6e68250fd65b917
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosutils/+/1967867
Commit-Queue: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>