| From 807a938a576ec52bc8c971100b2da26b059d9347 Mon Sep 17 00:00:00 2001 |
| From: Tobias Jungel <tobias.jungel@gmail.com> |
| Date: Wed, 22 Aug 2018 21:14:46 +0200 |
| Subject: [PATCH 1/2] mitigate gcc8 -Werror=ignored-qualifiers |
| |
| --- |
| src/core/ext/transport/chttp2/transport/flow_control.cc | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/src/core/ext/transport/chttp2/transport/flow_control.cc b/src/core/ext/transport/chttp2/transport/flow_control.cc |
| index 53932bcb7f5..4b1862735d6 100644 |
| --- a/src/core/ext/transport/chttp2/transport/flow_control.cc |
| +++ b/src/core/ext/transport/chttp2/transport/flow_control.cc |
| @@ -190,7 +190,7 @@ TransportFlowControl::TransportFlowControl(const grpc_chttp2_transport* t, |
| uint32_t TransportFlowControl::MaybeSendUpdate(bool writing_anyway) { |
| FlowControlTrace trace("t updt sent", this, nullptr); |
| const uint32_t target_announced_window = |
| - static_cast<const uint32_t>(target_window()); |
| + static_cast<uint32_t>(target_window()); |
| if ((writing_anyway || announced_window_ <= target_announced_window / 2) && |
| announced_window_ != target_announced_window) { |
| const uint32_t announce = static_cast<uint32_t> GPR_CLAMP( |
| |
| From 5a03e7f10145c6591f313055907a9cf26ccb9234 Mon Sep 17 00:00:00 2001 |
| From: Tobias Jungel <tobias.jungel@gmail.com> |
| Date: Wed, 22 Aug 2018 21:17:01 +0200 |
| Subject: [PATCH 2/2] mitigate gcc8 -Werror=stringop-truncation |
| |
| --- |
| .../client_channel/lb_policy/grpclb/load_balancer_api.cc | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc b/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc |
| index f24281a5bfb..8c064214729 100644 |
| --- a/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc |
| +++ b/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc |
| @@ -68,7 +68,8 @@ grpc_grpclb_request* grpc_grpclb_request_create(const char* lb_service_name) { |
| req->has_initial_request = true; |
| req->initial_request.has_name = true; |
| strncpy(req->initial_request.name, lb_service_name, |
| - GRPC_GRPCLB_SERVICE_NAME_MAX_LENGTH); |
| + GRPC_GRPCLB_SERVICE_NAME_MAX_LENGTH - 1); |
| + req->initial_request.name[GRPC_GRPCLB_SERVICE_NAME_MAX_LENGTH - 1] = '\0'; |
| return req; |
| } |
| |