commit | b7d9b2ec6d95b82b6da47bbcb61c64a6923f20d2 | [log] [tgz] |
---|---|---|
author | Jiri Slaby <jslaby@suse.cz> | Thu Oct 31 10:59:46 2019 +0100 |
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | Thu Oct 01 13:12:52 2020 +0200 |
tree | c524d3fdd8f6bbbc68e63d2197288c0ab41b7ac4 | |
parent | 306a1c5b5683c1d37565e575386139a64bdbec6f [diff] |
ata: sata_mv, avoid trigerrable BUG_ON commit e9f691d899188679746eeb96e6cb520459eda9b4 upstream. There are several reports that the BUG_ON on unsupported command in mv_qc_prep can be triggered under some circumstances: https://bugzilla.suse.com/show_bug.cgi?id=1110252 https://serverfault.com/questions/888897/raid-problems-after-power-outage https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1652185 https://bugs.centos.org/view.php?id=14998 Let sata_mv handle the failure gracefully: warn about that incl. the failed command number and return an AC_ERR_INVALID error. We can do that now thanks to the previous patch. Remove also the long-standing FIXME. [v2] use %.2x as commands are defined as hexa. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Jens Axboe <axboe@kernel.dk> Cc: linux-ide@vger.kernel.org Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>