tree 6dbe22310a867c59f2d4c854d9cdb9906cba0968
parent e3a5df144bd6678df0da60b1c97765fd02aa06c0
author Trond Myklebust <trond.myklebust@hammerspace.com> 1731086011 -0500
committer Shuo Yang <gshuoy@google.com> 1737093860 -0800

NFSv4.0: Fix a use-after-free problem in the asynchronous open()

[ Upstream commit 2fdb05dc0931250574f0cb0ebeb5ed8e20f4a889 ]

Yang Erkun reports that when two threads are opening files at the same
time, and are forced to abort before a reply is seen, then the call to
nfs_release_seqid() in nfs4_opendata_free() can result in a
use-after-free of the pointer to the defunct rpc task of the other
thread.
The fix is to ensure that if the RPC call is aborted before the call to
nfs_wait_on_sequence() is complete, then we must call nfs_release_seqid()
in nfs4_open_release() before the rpc_task is freed.

BUG=b/390131656
TEST=presubmit
RELEASE_NOTE=Fixed CVE-2024-53173 in the Linux kernel.

cos-patch: security-high
Reported-by: Yang Erkun <yangerkun@huawei.com>
Fixes: 24ac23ab88df ("NFSv4: Convert open() into an asynchronous RPC call")
Reviewed-by: Yang Erkun <yangerkun@huawei.com>
Change-Id: I585896b8e2c1694f8e516ab3172a078c706fec6f
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kernel CVE Triage Automation <cloud-image-kernel-cve-triage-automation@prod.google.com>
Reviewed-on: https://cos-review.googlesource.com/c/third_party/kernel/+/90682
Reviewed-by: Shuo Yang <gshuoy@google.com>
Reviewed-by: Kevin Berry <kpberry@google.com>
Tested-by: Cusky Presubmit Bot <presubmit@cos-infra-prod.iam.gserviceaccount.com>