)]}'
{
  "commit": "cee13e1beaab03f37e1257bc2dc4c7846d59797c",
  "tree": "baeaa139e3c251acc4fca13f484be1a5c5209a35",
  "parents": [
    "b6d75be076b3213d67ed1f698659072a83858ba4"
  ],
  "author": {
    "name": "Jozsef Kadlecsik",
    "email": "kadlec@netfilter.org",
    "time": "Tue Jun 04 15:58:03 2024 +0200"
  },
  "committer": {
    "name": "COS Cherry Picker",
    "email": "cloud-image-release@prod.google.com",
    "time": "Sat Jun 22 06:58:06 2024 -0700"
  },
  "message": "netfilter: ipset: Fix race between namespace cleanup and gc in the list:set type\n\n[ Upstream commit 4e7aaa6b82d63e8ddcbfb56b4fd3d014ca586f10 ]\n\nLion Ackermann reported that there is a race condition between namespace cleanup\nin ipset and the garbage collection of the list:set type. The namespace\ncleanup can destroy the list:set type of sets while the gc of the set type is\nwaiting to run in rcu cleanup. The latter uses data from the destroyed set which\nthus leads use after free. The patch contains the following parts:\n\n- When destroying all sets, first remove the garbage collectors, then wait\n  if needed and then destroy the sets.\n- Fix the badly ordered \"wait then remove gc\" for the destroy a single set\n  case.\n- Fix the missing rcu locking in the list:set type in the userspace test\n  case.\n- Use proper RCU list handlings in the list:set type.\n\nThe patch depends on c1193d9bbbd3 (netfilter: ipset: Add list flush to cancel_gc).\n\nBUG\u003db/347649132\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dNone\n\ncos-patch: bug\nFixes: 97f7cf1cd80e (netfilter: ipset: fix performance regression in swap operation)\nReported-by: Lion Ackermann \u003cnnamrec@gmail.com\u003e\nTested-by: Lion Ackermann \u003cnnamrec@gmail.com\u003e\nChange-Id: I723bca899c73e5b097f1a776f74fe9cb03d0fd9a\nSigned-off-by: Jozsef Kadlecsik \u003ckadlec@netfilter.org\u003e\nSigned-off-by: Pablo Neira Ayuso \u003cpablo@netfilter.org\u003e\nReviewed-on: https://cos-review.googlesource.com/c/third_party/kernel/+/74675\nMain-Branch-Verified: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nReviewed-by: Arnav Kansal \u003crnv@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f645da82d826e2d2113c527a6fc52deb8aa427ee",
      "old_mode": 33188,
      "old_path": "net/netfilter/ipset/ip_set_core.c",
      "new_id": "649b8a5901e338b26c487b0010421281f03dd929",
      "new_mode": 33188,
      "new_path": "net/netfilter/ipset/ip_set_core.c"
    },
    {
      "type": "modify",
      "old_id": "8e433a355b782cca4d4cea9f84d64c585b12e823",
      "old_mode": 33188,
      "old_path": "net/netfilter/ipset/ip_set_list_set.c",
      "new_id": "902ff2f3bc72b539a9e1791281d0ca53eff608ff",
      "new_mode": 33188,
      "new_path": "net/netfilter/ipset/ip_set_list_set.c"
    }
  ]
}