security: allow using Clang's zero initialization for stack variables
Upstream commit f0fe00d4972a8cd4b98cc2c29758615e4d51cdfe.
In addition to -ftrivial-auto-var-init=pattern (used by
CONFIG_INIT_STACK_ALL now) Clang also supports zero initialization for
locals enabled by -ftrivial-auto-var-init=zero. The future of this flag
is still being debated (see https://bugs.llvm.org/show_bug.cgi?id=45497).
Right now it is guarded by another flag,
which means it may not be supported by future Clang releases. Another
possible resolution is that -ftrivial-auto-var-init=zero will persist
(as certain users have already started depending on it), but the name
of the guard flag will change.
In the meantime, zero initialization has proven itself as a good
production mitigation measure against uninitialized locals. Unlike pattern
initialization, which has a higher chance of triggering existing bugs,
zero initialization provides safe defaults for strings, pointers, indexes,
and sizes. On the other hand, pattern initialization remains safer for
return values. Chrome OS and Android are moving to using zero
initialization for production builds.
Performance-wise, the difference between pattern and zero initialization
is usually negligible, although the generated code for zero
initialization is more compact.
This patch renames CONFIG_INIT_STACK_ALL to CONFIG_INIT_STACK_ALL_PATTERN
and introduces another config option, CONFIG_INIT_STACK_ALL_ZERO, that
enables zero initialization for locals if the corresponding flags are
supported by Clang.
Cc: Kees Cook <email@example.com>
Cc: Nick Desaulniers <firstname.lastname@example.org>
Cc: Greg Kroah-Hartman <email@example.com>
Signed-off-by: Alexander Potapenko <firstname.lastname@example.org>
Reviewed-by: Maciej Żenczykowski <email@example.com>
Signed-off-by: Kees Cook <firstname.lastname@example.org>
Tested-by: Cusky Presubmit Bot <email@example.com>
Reviewed-by: Vaibhav Rustagi <firstname.lastname@example.org>
(cherry picked from commit 007971ab7111f9397d3dfacb56a4af0924e65bcd)
3 files changed