tree 781e1eb5390a53a7a78a10ba442a5a3e6990c5c2
parent a04bcff2e6ef67126fc133bea632ea8014f82e68
author Florian Westphal <fw@strlen.de> 1691838316 +0200
committer Oleksandr Tymoshenko <ovt@google.com> 1695333614 +0000

netfilter: nf_tables: deactivate catchall elements in next generation

[ Upstream commit 90e5b3462efa37b8bba82d7c4e63683856e188af ]

When flushing, individual set elements are disabled in the next
generation via the ->flush callback.

Catchall elements are not disabled.  This is incorrect and may lead to
double-deactivations of catchall elements which then results in memory
leaks:

WARNING: CPU: 1 PID: 3300 at include/net/netfilter/nf_tables.h:1172 nft_map_deactivate+0x549/0x730
CPU: 1 PID: 3300 Comm: nft Not tainted 6.5.0-rc5+ #60
RIP: 0010:nft_map_deactivate+0x549/0x730
 [..]
 ? nft_map_deactivate+0x549/0x730
 nf_tables_delset+0xb66/0xeb0

(the warn is due to nft_use_dec() detecting underflow).

BUG=b/298762627
TEST=presubmit
RELEASE_NOTE=Fixed CVE-2023-4569 in the Linux kernel

cos-patch: security-high
Fixes: aaa31047a6d2 ("netfilter: nftables: add catch-all set element support")
Reported-by: lonial con <kongln9170@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Change-Id: I42280be241f8e7c03db40ba22dddd920d25f2204
Reviewed-on: https://cos-review.googlesource.com/c/third_party/kernel/+/57430
Reviewed-by: Arnav Kansal <rnv@google.com>
Tested-by: Cusky Presubmit Bot <presubmit@cos-infra-prod.iam.gserviceaccount.com>