)]}'
{
  "commit": "761669d1f2f82a64e8c2ed8d9b10036da5dd4b7a",
  "tree": "ad1aaa6e1740a1e0716fb8dfa144fdb4c3886a44",
  "parents": [
    "62f66f7d03783505ef1b0dc091d1f4bd63d7bd17"
  ],
  "author": {
    "name": "Jamie Bainbridge",
    "email": "jamie.bainbridge@gmail.com",
    "time": "Fri Aug 23 16:26:58 2024 +1000"
  },
  "committer": {
    "name": "Anil Altinay",
    "email": "aaltinay@google.com",
    "time": "Wed Sep 25 22:06:24 2024 +0000"
  },
  "message": "ethtool: check device is present when getting link settings\n\n[ Upstream commit a699781c79ecf6cfe67fb00a0331b4088c7c8466 ]\n\nA sysfs reader can race with a device reset or removal, attempting to\nread device state when the device is not actually present. eg:\n\n     [exception RIP: qed_get_current_link+17]\n  #8 [ffffb9e4f2907c48] qede_get_link_ksettings at ffffffffc07a994a [qede]\n  #9 [ffffb9e4f2907cd8] __rh_call_get_link_ksettings at ffffffff992b01a3\n #10 [ffffb9e4f2907d38] __ethtool_get_link_ksettings at ffffffff992b04e4\n #11 [ffffb9e4f2907d90] duplex_show at ffffffff99260300\n #12 [ffffb9e4f2907e38] dev_attr_show at ffffffff9905a01c\n #13 [ffffb9e4f2907e50] sysfs_kf_seq_show at ffffffff98e0145b\n #14 [ffffb9e4f2907e68] seq_read at ffffffff98d902e3\n #15 [ffffb9e4f2907ec8] vfs_read at ffffffff98d657d1\n #16 [ffffb9e4f2907f00] ksys_read at ffffffff98d65c3f\n #17 [ffffb9e4f2907f38] do_syscall_64 at ffffffff98a052fb\n\n crash\u003e struct net_device.state ffff9a9d21336000\n    state \u003d 5,\n\nstate 5 is __LINK_STATE_START (0b1) and __LINK_STATE_NOCARRIER (0b100).\nThe device is not present, note lack of __LINK_STATE_PRESENT (0b10).\n\nThis is the same sort of panic as observed in commit 4224cfd7fb65\n(\"net-sysfs: add check for netdevice being present to speed_show\").\n\nThere are many other callers of __ethtool_get_link_ksettings() which\ndon\u0027t have a device presence check.\n\nMove this check into ethtool to protect all callers.\n\nBUG\u003db/369325316\nTEST\u003dpresubmit\nRELEASE_NOTE\u003dFixed CVE-2024-46679 in the Linux kernel.\n\ncos-patch: security-moderate\nFixes: d519e17e2d01 (\"net: export device speed and duplex via sysfs\")\nFixes: 4224cfd7fb65 (\"net-sysfs: add check for netdevice being present to speed_show\")\nChange-Id: If16ee3e9c18c92c854a1f7f19445b804b1b386d7\nSigned-off-by: Jamie Bainbridge \u003cjamie.bainbridge@gmail.com\u003e\nLink: https://patch.msgid.link/8bae218864beaa44ed01628140475b9bf641c5b0.1724393671.git.jamie.bainbridge@gmail.com\nSigned-off-by: Jakub Kicinski \u003ckuba@kernel.org\u003e\nSigned-off-by: Sasha Levin \u003csashal@kernel.org\u003e\nSigned-off-by: Kernel CVE Triage Automation \u003ccloud-image-kernel-cve-triage-automation@prod.google.com\u003e\nReviewed-on: https://cos-review.googlesource.com/c/third_party/kernel/+/82059\nTested-by: Cusky Presubmit Bot \u003cpresubmit@cos-infra-prod.iam.gserviceaccount.com\u003e\nReviewed-by: Kevin Berry \u003ckpberry@google.com\u003e\nReviewed-by: Anil Altinay \u003caaltinay@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e9ea0695efb420a7115ce6b3527c7fb6b49d5336",
      "old_mode": 33188,
      "old_path": "net/core/net-sysfs.c",
      "new_id": "173ea92124f8c8a9ada82e487dab6e9e488c5b59",
      "new_mode": 33188,
      "new_path": "net/core/net-sysfs.c"
    },
    {
      "type": "modify",
      "old_id": "53e2ef6ada8f32b185cbc527ceaf04b5c06f0aff",
      "old_mode": 33188,
      "old_path": "net/ethtool/ioctl.c",
      "new_id": "1e9e70a633d1ca432d1f37a1ff12bfd60b6dd008",
      "new_mode": 33188,
      "new_path": "net/ethtool/ioctl.c"
    }
  ]
}