tree 80d54ef2d0c20c07555c55328006be649645b7b9
parent 5e59b13b9b3298d0c4a60590bdcd0e1645bbdb1b
author Jakub Kicinski <kuba@kernel.org> 1758068893 -0700
committer Cloud Image Release <cloud-image-release@prod.google.com> 1758926026 -0700

tls: make sure to abort the stream if headers are bogus

Normally we wait for the socket to buffer up the whole record
before we service it. If the socket has a tiny buffer, however,
we read out the data sooner, to prevent connection stalls.
Make sure that we abort the connection when we find out late
that the record is actually invalid. Retrying the parsing is
fine in itself but since we copy some more data each time
before we parse we can overflow the allocated skb space.

Constructing a scenario in which we're under pressure without
enough data in the socket to parse the length upfront is quite
hard. syzbot figured out a way to do this by serving us the header
in small OOB sends, and then filling in the recvbuf with a large
normal send.

Make sure that tls_rx_msg_size() aborts strp, if we reach
an invalid record there's really no way to recover.

Reported-by: Lee Jones <lee@kernel.org>
Fixes: 84c61fe1a75b ("tls: rx: do not use the standard strparser")
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20250917002814.1743558-1-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

BUG=b/446655675
TEST=presubmit
RELEASE_NOTE=Fixed KCTF-0aeb54a in the Linux Kernel.

cos-patch: security-high
Change-Id: Ifac6bfd9c784829643c2ffa674aa07c09c73e53e
Reviewed-on: https://cos-review.googlesource.com/c/third_party/kernel/+/111943
Reviewed-by: Kevin Berry <kpberry@google.com>
Main-Branch-Verified: Cusky Presubmit Bot <presubmit@cos-infra-prod.iam.gserviceaccount.com>
Tested-by: Cusky Presubmit Bot <presubmit@cos-infra-prod.iam.gserviceaccount.com>
Reviewed-on: https://cos-review.googlesource.com/c/third_party/kernel/+/112362