tree 3d4d587eea4609557be87629542efd4e65aa2d4b
parent 8d1df121e4c58a67f3e3f76b62250995162eb822
author Hangyu Hua <hbh25y@gmail.com> 1677551624 +0800
committer COS Cherry Picker <cloud-image-release@prod.google.com> 1679714948 -0700

net: tls: fix possible race condition between do_tls_getsockopt_conf() and do_tls_setsockopt_conf()

commit 49c47cc21b5b7a3d8deb18fc57b0aa2ab1286962 upstream.

ctx->crypto_send.info is not protected by lock_sock in
do_tls_getsockopt_conf(). A race condition between do_tls_getsockopt_conf()
and error paths of do_tls_setsockopt_conf() may lead to a use-after-free
or null-deref.

More discussion:  https://lore.kernel.org/all/Y/ht6gQL+u6fj3dG@hog/

BUG=b/274745771
TEST=presubmit,validation
RELEASE_NOTE=Fixes CVE-2023-28466 in the Linux kernel.

Fixes: 3c4d7559159b ("tls: kernel TLS support")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20230228023344.9623-1-hbh25y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Meena Shanmugam <meenashanmugam@google.com>

cos-patch: security-high
Change-Id: I70e2f7e38583ec2508493584516dfd793080bab6
Reviewed-on: https://cos-review.googlesource.com/c/third_party/kernel/+/45374
Reviewed-by: Oleksandr Tymoshenko <ovt@google.com>
Main-Branch-Verified: Cusky Presubmit Bot <presubmit@cos-infra-prod.iam.gserviceaccount.com>
Tested-by: Cusky Presubmit Bot <presubmit@cos-infra-prod.iam.gserviceaccount.com>