UPSTREAM: drm/i915/skl: Fix has_ipc on skl and document WaDisableIPC.
According to Spec for SKL+: "Isochronous Priority Control.
If enabled, Display sends demoted requests once the transition
watermark is reached. If transition watermark is not enabled,
Display sends demoted requests when the display buffer is full."
The commit 'e57f1c02155f ("drm/i915/gen9+: Add has_ipc flag in
device info structure")' introduced that as gen9+ but missing many
I believe the reason for that is Spec also mentions workarounds for
SKL-ALL: "IPC (Isoch Priority Control) may cause underflows
WA: Do not enable IPC in register ARB_CTL2"
It seems lame to add the feature and forever disable it,
but it will avoid a mistake of enabling it when we are reorganizing
the feature definitions on i915_pci.c later.
It will also allow us to probably extend that workaround for
TEST=boot casta, run google play
Cc: Mahesh Kumar <email@example.com>
Cc: Maarten Lankhorst <firstname.lastname@example.org>
Cc: Chris Wilson <email@example.com>
Signed-off-by: Rodrigo Vivi <firstname.lastname@example.org>
Reviewed-by: Mahesh Kumar <email@example.com>
(cherry picked from commit 4d6ef0da415124ebce578b1326f4e511e35d95f2)
Signed-off-by: Chiou, Cooper <firstname.lastname@example.org>
Tested-by: Cooper Chiou <email@example.com>
Tested-by: Cooper Chiou <firstname.lastname@example.org>
Commit-Ready: Cooper Chiou <email@example.com>
Legacy-Commit-Queue: Commit Bot <firstname.lastname@example.org>
Reviewed-by: Stéphane Marchesin <email@example.com>
Reviewed-by: Sean Paul <firstname.lastname@example.org>
(cherry picked from commit bb613a7875c1f440a65cbc73fc6effa78e9c5357)
Reviewed-by: Young H Kim <email@example.com>
Reviewed-by: Justin TerAvest <firstname.lastname@example.org>
Tested-by: Young H Kim <email@example.com>
Tested-by: Justin TerAvest <firstname.lastname@example.org>
Commit-Queue: Justin TerAvest <email@example.com>
2 files changed