|author||Tomasz Tylenda <firstname.lastname@example.org>||Thu Sep 22 20:34:15 2022 +0900|
|committer||Chromeos LUCI <email@example.com>||Mon Oct 03 08:42:43 2022 +0000|
cros-ide: spell check commit messages The objective of this is change is to add ability to call Tricium API for the commit message. The following needs some work before the feature is usable: * Invoking the spellchecker on the right events. * Retrieving the commit message needs some clean-up and better integration with git_documents.ts. BUG=b:217287367 TEST=https://screenshot.googleplex.com/98KNpzjWZXCUyPS.png Change-Id: I31f4144e5207221d74b0720c78eebfc3015b3ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3912123 Commit-Queue: Tomasz Tylenda <firstname.lastname@example.org> Tested-by: Tomasz Tylenda <email@example.com> Reviewed-by: Keigo Oka <firstname.lastname@example.org>
This doc tries to give an overview and head start to anyone just starting out on Chromite development.
Before you get started on Chromite, we recommend that you go through ChromeOS developer guides at external (first) and then goto/chromeos-building for internal. The Gerrit starter guide may also be helpful. You should flash a built image on a test device (Ask around for one!).
Chromite was intended to be the unified codebase for anything related to building ChromeOS/ChromiumOS. Currently, it is the codebase responsible for several things including: building the OS from the requisite packages for the necessary board (
parallel_emerge), driving the infrastructure build workflow (CBuildBot), hosting a Google App Engine App, and providing utility functions for various scripts scattered around ChromeOS repositories. It is written for the most part in Python with some Bash sprinkled in.
Non-public code has a separate internal Code Search site. It's organized into different “repositories”, and we have two: “Chrome OS - Internal” (only internal repositories) & “Chrome OS - Public” (only public repositories). You can add a search query for a single combined view (public & private) in the Saved Queries settings page. Use the query
package:^chromeos_(internal|public)$. NB: The “Chrome OS - Public” repository is exactly the same as the public source.chromium.org site.
The Chromite API for the CI system. The API exposes a subset of the chromite functionality that needs to be strictly maintained as much as possible.
CBuildBot is the collection of entire code that runs on both the parent and the child build machines. It kicks off the individual stages in a particular build. It is a configurable bot that builds ChromeOS. More details on CBuildBot can be found in this tech talk (slides).
This folder contains configurations of the different builders in use. Each has its own set of stages to run usually called under RunStages function. Most builders used regularly are derived from SimpleBuilder class.
Each file here has implementations of stages in the build process grouped by similarity. Each stage usually has PerformStage as its primary function.
Code here is expected to be imported whenever necessary throughout Chromite.
Unlike lib, code in scripts will not and should not be imported anywhere. Instead they are executed as required in the build process. Each executable is linked to either
virtualenv_wrapper.py. Some of these links are in
chromite/bin. The wrapper figures out the directory of the executable script and the
$PYTHONPATH. Finally, it invokes the correct Python installation by moving up the directory structure to find which git repo is making the call.
These files act as the centralized business logic for processes, utilizing lib for the implementation details. Any process that's implemented in chromite should generally have an entry point somewhere in a service such that it can be called from a script, the API, or anywhere else in lib where the process may be useful.
This folder contains all the third_party python libraries required by Chromite. You need a very strong reason to add any library to the current list. Please confirm with the owners beforehand.
This folder contains smaller, generic utility functionality that is not tied to any specific entities in the codebase that would make them more at home in a lib module.
This folder contains the chromite-specific infra repos.
This folder contains test-only utilities and helper functions used to make writing tests in other modules easier.
There are smaller folders with miscellaneous functions like config, licencing, cidb, etc.
Before any testing, you should check your code for lint errors with:
$ cros lint <filename>
Chromite now uses pytest for running and writing unit tests. All new code & tests should be written with the expectation to be run under pytest.
Pytest is responsible for running unit tests under Python 3, with the legacy unit test runner
scripts/run_tests responsible for running unit tests under Python 2.
Chromite provides a single
run_tests wrapper in the top dir that runs all the unittests for you. It's the same as
scripts/run_tests, but in an easier-to-find location.
Every Python file in Chromite is accompanied by a corresponding
*_unittest.py file. Running a particular file's unit tests is best done via
chromite $ ./run_tests example_file_unittest.py
This script initializes a Python 3 virtualenv with necessary test dependencies and runs
pytest inside that virtualenv over all tests in Chromite, with the configuration specified in pytest.ini. The default configuration runs tests in parallel and skips some tests known to be flaky or take a very long time.
Tests will not run in a standalone git checkout of chromite. Use the repo-based flow described above to obtain a functional-testing environment.
By default, any test that reaches out to the network (those wrapped in a
@cros_test_lib.pytestmark_network_test decorator) will not be run. To include these tests, add the
~/trunk/chromite $ ./run_tests --network -- ...
Chromite‘s unit tests make use of pytest fixtures. Fixtures that are defined in a
conftest.py file are visible to tests in the same directory and all child directories. If it’s unclear where a test function is getting an argument from, try searching for a fixture with that argument's name in a
Be sure to consult pytest's excellent documentation for guidance on how to take advantage of the features pytest offers when writing unit tests.
Unit tests must clean up after themselves and in particular must not leak child processes after running. There is no guaranteed order in which tests are run or that tests are even run in the same process.
Once you mark your CL as Commit-Queue +1 on the Chromium Gerrit, the PreCQ will pick up your change and fire few preset config runs as a precursor to CQ.
This is the final step in getting your change pushed. CQ is the most comprehensive of all tests. Once a CL is verified by CQ, it is merged into the codebase.
Refer to these talk slides on ChromeOS Build Overview.