Google Git
Sign in
cos / mirrors / cros / chromiumos / third_party / toolchain-utils / ad5bd3e097f1d6ef592bdbc5ee041ad896b6b9aa
commitad5bd3e097f1d6ef592bdbc5ee041ad896b6b9aa[log] [tgz]
authorPirama Arumuga Nainar <pirama@google.com>Mon Jun 01 15:09:18 2020 -0700
committerCommit Bot <commit-bot@chromium.org>Thu Jun 11 02:02:40 2020 +0000
treea9ee8642e087719d18dde9a9babce165a6c1169d
parentdeff1db299a82e7f1dd480ccf5844d4afa485916 [diff]
[compiler-wrapper] Handle double build for clang-tidy

For clang-tidy, the equivalent of -Werror is --warnings-as-errors (or
-warnings-as-errors).  The error message will also have
"warnings-as-errors".  So,
1. Trigger double-build if "warnings-as-errors" is in *stdout*.
Clang-tidy will also fail if clang issues a Werror diagnostic.  In this
case, we'd get "clang-diagnostic" in stdout.  Do a re-build in both
these cases.
2. Remove flags containing "-warnings-as-errors" in the rerun.  Unlike
-Werror/Wno-error, clang-tidy doesn't have a -no-warnings-as-errors to
override a prior -warnings-as-errors.  Existing double-build processing
will disable -Werror flags to Clang.

Originally reviewed at
https://android-review.googlesource.com/c/platform/external/toolchain-utils/+/1322200.

BUG=None
TEST=go test

Change-Id: I18de245972da81e0ac3600f9098b71cec82e9e96
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2239370
Commit-Queue: Pirama Arumuga Nainar <pirama@google.com>
Tested-by: Pirama Arumuga Nainar <pirama@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
3 files changed
tree: a9ee8642e087719d18dde9a9babce165a6c1169d
  1. afdo_metadata/
  2. afdo_redaction/
  3. afdo_tools/
  4. android_bench_suite/
  5. bestflags/
  6. binary_search_tool/
  7. compiler_wrapper/
  8. cros_utils/
  9. crosperf/
  10. cwp/
  11. debug_info_test/
  12. go/
  13. heatmaps/
  14. llvm_extra/
  15. llvm_tools/
  16. orderfile/
  17. pgo_tools/
  18. toolchain_utils_githooks/
  19. .gitignore
  20. .style.yapf
  21. android_merge_from_upstream.sh
  22. auto_delete_nightly_test_data.py
  23. build_chromeos.py
  24. build_tc.py
  25. buildbot_test_llvm.py
  26. buildbot_test_toolchains.py
  27. chromiumos_image_diff.py
  28. compiler-test.sh
  29. file_lock_machine.py
  30. file_lock_machine_test.py
  31. image_chromeos.py
  32. LICENSE
  33. lock_machine.py
  34. OWNERS
  35. OWNERS.toolchain
  36. PRESUBMIT.cfg
  37. pyrun
  38. README.chromium
  39. README.md
  40. remote_test.py
  41. run_tests_for.py
  42. setup_chromeos.py
  43. tc_enter_chroot.py
  44. update_telemetry_defaults.py
README.md

toolchain-utils

Various utilities used by the Chrome OS toolchain team.

Note

To run Python scripts in this directory, first run:

export PYTHONPATH=$(readlink -f .):$PYTHONPATH

from this directory.

Then you can run any script.

To get help on any script, type in python <script> --help, or refer to the header of the script for more information.