| commit | dccf55ec9fc43c66af23097a9fc410ffe99d020a | [log] [tgz] |
|---|---|---|
| author | Mike Frysinger <vapier@chromium.org> | Tue Mar 03 17:17:22 2020 -0500 |
| committer | Mike Frysinger <vapier@chromium.org> | Sat Mar 14 14:52:08 2020 +0000 |
| tree | f07edd6032601972eae01e55926cf34e97a18929 | |
| parent | f25e2dc53eb55e74293c9b7ce982844511531d0e [diff] |
ebuild: check for QA issues in preinst logs too The pkg_preinst phase is still safe to die in, so run QA checks after that too to catch common errors like "command not found". BUG=chromium:821145 TEST=CQ passes Change-Id: I6db81fbcfba7b3f6d7d96b5a3febbdc6b21c2c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/portage_tool/+/2085971 Reviewed-by: Chris McDonald <cjmcdonald@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
diff --git a/lib/_emerge/EbuildPhase.py b/lib/_emerge/EbuildPhase.py index bb2088b..5d7fa50 100644 --- a/lib/_emerge/EbuildPhase.py +++ b/lib/_emerge/EbuildPhase.py
@@ -239,7 +239,7 @@ logfile = self._get_log_path() - if self.phase == "install": + if self.phase in {'install', 'preinst'}: out = io.StringIO() ret = _check_build_log(self.settings, out=out) if ret is False: