)]}' { "log": [ { "commit": "d56ae073fa2ffe2ae367903fec92a0e795592f1d", "tree": "6948abf0a1669d0d7e3ffc9b90007848c90f232f", "parents": [ "55b92cd5a0f3ed56b3be2e2b972faef8b8b3b4be" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Mon Sep 30 22:56:42 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 30 16:37:14 2024 +0000" }, "message": "OWNERS: remove quasisec\n\nBUG\u003dnone\nTEST\u003dnone\n\nChange-Id: Ic07dc8d1240db334599e1eb2cc174320719ce6af\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/5898515\nAuto-Submit: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nCommit-Queue: Dossym Nurmukhanov \u003cdossym@chromium.org\u003e\nReviewed-by: Dossym Nurmukhanov \u003cdossym@chromium.org\u003e\nReviewed-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\nTested-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "55b92cd5a0f3ed56b3be2e2b972faef8b8b3b4be", "tree": "8bd525576d5195810fd124e35fbc1b5e2047b89d", "parents": [ "b3790e2ad154131bcf333e86d8ec6ac593b95553" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Mon Sep 30 21:35:00 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 30 16:37:11 2024 +0000" }, "message": "OWNERS: add roccochen and subratabanik\n\nBUG\u003dnone\nTEST\u003dnone\n\nChange-Id: I8ebc04ee6c963b1b899678f77e1dc65669d0b9ec\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/5899352\nCommit-Queue: Dossym Nurmukhanov \u003cdossym@chromium.org\u003e\nReviewed-by: Dossym Nurmukhanov \u003cdossym@chromium.org\u003e\nReviewed-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\nTested-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nAuto-Submit: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "b3790e2ad154131bcf333e86d8ec6ac593b95553", "tree": "dbb3f75446f8bcb2fd4db1f371646f9af3b7b224", "parents": [ "40bfcd14835009f45b18d5dff70c2f83c6a74a37" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Mon Sep 23 21:47:08 2024 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 30 14:17:30 2024 +0000" }, "message": "OWNERS: Remove myself\n\nI\u0027m leaving the chocolate factory.\n\nBUG\u003dnone\nTEST\u003dnone\n\nChange-Id: I6ff81f38dfda03c9dbca34a4d6bbf40e3c803804\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/5882471\nReviewed-by: Dossym Nurmukhanov \u003cdossym@chromium.org\u003e\nCommit-Queue: Dossym Nurmukhanov \u003cdossym@chromium.org\u003e\nTested-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "40bfcd14835009f45b18d5dff70c2f83c6a74a37", "tree": "3df0f3b0d55fe44e4ccb8dc2dfa2d1deab67547f", "parents": [ "79c658a1fda7280058c50c697f59029a6fa848b8" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Wed Nov 15 11:22:15 2023 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 16 22:58:22 2023 +0000" }, "message": "CPPLINT: Add lint configuration\n\nBorrowed in part from the kernel repository.\n\nBUG\u003dnone\nTEST\u003dcros lint is happier\n\nChange-Id: Icb41a04dfd4c289187975bc59505c78c26b56f22\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/5034762\nTested-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Brian Norris \u003cbriannorris@chromium.org\u003e\n" }, { "commit": "79c658a1fda7280058c50c697f59029a6fa848b8", "tree": "1c51e4accaf5791a248141178862d9fae9071ad1", "parents": [ "6f153044b6589c951c6d3374ee0f00bd4c5aeaa5" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Wed Nov 15 11:14:35 2023 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 16 22:58:20 2023 +0000" }, "message": "fmap: fmap_create() takes const name\n\nfmap_create() doesn\u0027t modify this param.\n\nBUG\u003db:288327526\nTEST\u003dbuild\n\nChange-Id: Icd2c4a2a57e13e27fe22a664ce40b4727afdf4ae\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/5034761\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Brian Norris \u003cbriannorris@chromium.org\u003e\nTested-by: Brian Norris \u003cbriannorris@chromium.org\u003e\n" }, { "commit": "6f153044b6589c951c6d3374ee0f00bd4c5aeaa5", "tree": "f7a9ffb7bc0675f85c29d6e8db59432024a2fe3c", "parents": [ "e70bb37bbaddf4796b5367a2765b51fe6fc7cd81" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Wed Nov 15 11:23:59 2023 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 16 22:58:19 2023 +0000" }, "message": "fmap.h: Lint multiline comment\n\ncpplint warns:\n\nlib/fmap.h:75: (cpplint) Complex multi-line /*...*/-style comment\nfound. Lint may give bogus warnings. Consider replacing these with\n//-style comments, with #if 0...#endif, or with more clearly structured\nmulti-line comments. [readability/multiline_comment] [5]\n\nIt\u0027s easy enough to fit this on one line, so do it to avoid arguing with\nthe linter.\n\nBUG\u003dnone\nTEST\u003dcros lint $(find -name \u0027*.c\u0027 -o -name \u0027*.h\u0027)\n\nChange-Id: I86c5e88c01d5e38a531854e6063875202e4458fa\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/5034760\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Brian Norris \u003cbriannorris@chromium.org\u003e\nTested-by: Brian Norris \u003cbriannorris@chromium.org\u003e\n" }, { "commit": "e70bb37bbaddf4796b5367a2765b51fe6fc7cd81", "tree": "7be3d8eb8bcf9b0834236dcf68701e11b721587a", "parents": [ "e3fc969bdf4e744e2478aeb4d0f5cd5a7fc80f70" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Wed Nov 15 11:04:54 2023 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 16 22:58:17 2023 +0000" }, "message": "fmap: Use FMAP_VER_{MAJOR,MINOR} in fmap header\n\nWe\u0027re accidentally using the program version (from the Makefile), and\nnot the FMAP structure version (from fmap.h). This causes problems when\ntools are doing strict checks on these fields. Particularly, they\u0027re\nlikely to care about a major version mismatch (0 vs 1).\n\nAppease the linter w.r.t. whitespace while I\u0027m at it.\n\nBUG\u003db:288327526\nTEST\u003duse with flashrom (e.g., in vpd tests), and pass VPD validity\n checks\n\nChange-Id: I3e5ae95bf506a1ef52dad16ad5a2ef64405b2922\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/5034759\nTested-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Brian Norris \u003cbriannorris@chromium.org\u003e\n" }, { "commit": "e3fc969bdf4e744e2478aeb4d0f5cd5a7fc80f70", "tree": "bc7aa5f7cd6ba338b028e2c2f3a695a887fe7164", "parents": [ "3d03867e05029989f277f0408f4080e20f88bb3f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Jun 08 09:47:59 2023 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 16 19:25:25 2023 +0000" }, "message": "PRESUBMIT: enable cros format on non-C files\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I39c199ec2269368bbb1ca2a1985273baec60ff60\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/4620768\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "3d03867e05029989f277f0408f4080e20f88bb3f", "tree": "e75a817c5bc0a445958942acdd99df6922c90eee", "parents": [ "4bebfe03dc8afa3c520fdf01c8995e1da66579f7" ], "author": { "name": "Dmitry Bilunov", "email": "kmeaw@google.com", "time": "Thu Jun 08 11:08:55 2023 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 16 15:53:48 2023 +0000" }, "message": "flashmap: Fix warnings with gcc 10\n\nBUG\u003db:229038573\nTEST\u003dran unittests\n\nChange-Id: I3a3c428c4c2a9eba6d1ff353e712f1220d5728cf\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/4601333\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nTested-by: Dmitry Bilunov \u003ckmeaw@google.com\u003e\nCommit-Queue: Dmitry Bilunov \u003ckmeaw@google.com\u003e\n" }, { "commit": "4bebfe03dc8afa3c520fdf01c8995e1da66579f7", "tree": "657f75900bcc1bb141869d61ea052c6f355d2576", "parents": [ "0cdea4526cc8bb80c4aeb9e26a04ac0daba333c3" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Jun 08 09:44:03 2023 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 08 17:17:25 2023 +0000" }, "message": "PRESUBMIT: lint commits, not files\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: Id843690cfc6f9a99c26999960fc2ea24ee3a7451\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/4600612\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "0cdea4526cc8bb80c4aeb9e26a04ac0daba333c3", "tree": "1380dcf7ffff59f9e7aa15c2ac721320a73a82cf", "parents": [ "3a04fe28408aca95e18862d1a158f4c1792dfa91" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Jun 08 09:47:30 2023 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 08 16:30:36 2023 +0000" }, "message": "python: reformat using black\n\nRan cros format across the files, and manually adjusted docstrings\nand long lines.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: Ie6c4809cde62196505b018b297563dcbbe7b7e36\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/4600613\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "3a04fe28408aca95e18862d1a158f4c1792dfa91", "tree": "65d78002fa644fda1b0f583d1aace00f56eaab24", "parents": [ "961c0e2451d1fa1eec20c5285c8a6d72d6794a35" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Jun 08 09:40:22 2023 -0400" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 08 16:25:14 2023 +0000" }, "message": "OWNERS: demote myself\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I41ff55986f467808b8746429c3d74437aa8357cc\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/4600611\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "961c0e2451d1fa1eec20c5285c8a6d72d6794a35", "tree": "eb13d5652a0cd341adece61e29d46eef0227712c", "parents": [ "9c71c8331ad52a11d29496ffb10cbdb1a51e2ccb" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Feb 10 21:52:28 2023 -0500" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Feb 11 05:41:27 2023 +0000" }, "message": "PRESUBMIT: drop python2 usage\n\nWe haven\u0027t used Python 2 in years.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I08924e67386a7a499c55a2ea90ebd6b2d7ac2caa\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/4240702\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "9c71c8331ad52a11d29496ffb10cbdb1a51e2ccb", "tree": "63eebcb098106693e29bbce840fedce94e297da6", "parents": [ "2f7b2e16f588dde75a0c9c28175f16b8cb9e11dc" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Fri Sep 03 17:14:58 2021 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 03 23:36:56 2021 +0000" }, "message": "flashmap: Update OWNERS\n\nDuncan no longer at Google.\n\nSee https://chat.google.com/room/AAAAYav-QOY/jaq2Fz5g_9I for context.\n\nBUG\u003dnone\nTEST\u003dnone\n\nChange-Id: I1dbeb82c73d1c62bf0d45cd2321cb29bfb1f7db9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/3140586\nTested-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Dossym Nurmukhanov \u003cdossym@chromium.org\u003e\nReviewed-by: Piotr Pawliczek \u003cpawliczek@chromium.org\u003e\nReviewed-by: Mike Nichols \u003cmikenichols@chromium.org\u003e\nOwners-Override: Piotr Pawliczek \u003cpawliczek@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "2f7b2e16f588dde75a0c9c28175f16b8cb9e11dc", "tree": "6fdc81bee0326e66662115d9bda50159bf41db9f", "parents": [ "01c852297739f592e0f17524a2ccc206140e0cb8" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 09 18:31:50 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sun Jul 28 09:44:43 2019 -0700" }, "message": "rework python scripts to support Python 2 \u0026 3\n\nWe run the unittests in both python versions to maintain coverage,\nand we run things through `cros lint` during upload to help prevent\nregressions.\n\nWe also switch the default to Python 3 to keep people on their toes.\n\nBUG\u003dchromium:982465\nTEST\u003drunning unittests against python2 \u0026 python3 pass\nTEST\u003d`./fmap.py bin/example.bin` through python2 \u0026 python3 works\n\nChange-Id: I79f0ce59664ea42dfa18e45ccde0dffc0c18227d\nReviewed-on: https://chromium-review.googlesource.com/1693888\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "01c852297739f592e0f17524a2ccc206140e0cb8", "tree": "6c5930f7fd5435841492a948bfb94705b6b5d1cc", "parents": [ "f35ccffdaf25bc9396aa96ccb2f72d33b6276ad9" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 09 18:15:42 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sat Jul 27 20:40:18 2019 -0700" }, "message": "fmap.py: sort the flags tuple\n\nThe output of this function is arbitrary because it\u0027s based on the\nordering of the dict keys of FMAP_FLAGS. This leads to the unittest\nsometimes passing \u0026 sometimes failing. Since this is meant for us\nhumans, sort the tuple so it\u0027s stable and unittests are reliable.\n\nBUG\u003dchromium:982465\nTEST\u003d`./fmap.py bin/example.bin` works\n\nChange-Id: Ida9e6768aa6662a400655c52bc2ba793197ab591\nReviewed-on: https://chromium-review.googlesource.com/1693887\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "f35ccffdaf25bc9396aa96ccb2f72d33b6276ad9", "tree": "bf22f3cc78a0cc51c02bddd7f2103e4b64c2a77f", "parents": [ "48fa0663a37625f6943d805624c506c56a523e40" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 09 18:13:18 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jul 26 22:54:32 2019 -0700" }, "message": "fmap_unittest.py: clean up lint warnings\n\nThe assertEquals helper is deprecated in favor of assertEqual, so\nrename all the users to that.\n\nThe testDecodeWithWrongName defines a decoded variable but doesn\u0027t\ndo anything other than assign to it. We don\u0027t need that for this\nparticular test (which is checking for assertions), so drop them.\n\nThe testDecodeWithOffset function was duplicated (exact same name \u0026\ntest code), so delete one of the duplicates.\n\nBUG\u003dchromium:982465\nTEST\u003d`cros lint` on this no longer complains\nTEST\u003d`./fmap_unittest.py` still passes\n\nChange-Id: I59c9b3a9b95283ecae9948c6b7e13dd86d54a4c2\nReviewed-on: https://chromium-review.googlesource.com/1693886\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "48fa0663a37625f6943d805624c506c56a523e40", "tree": "3afbe8a437ff5e9e14c5c9d2227ae4afeb20e66b", "parents": [ "700e83c9af7c1779fd483712881d40faeec627e9" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 09 18:09:20 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jul 26 22:54:32 2019 -0700" }, "message": "fmap.py: fix docstring style issues\n\n`cros lint` flags a bunch of issues with these docstrings.\nClean up the style to pass all the checks.\n\nBUG\u003dchromium:982465\nTEST\u003d`cros lint` on these no longer complains about docstrings\n\nChange-Id: I7caf0275ce1441bb4031f7d8e9e0ac96bfdf9b05\nReviewed-on: https://chromium-review.googlesource.com/1693885\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "700e83c9af7c1779fd483712881d40faeec627e9", "tree": "55f23cca4c6861db7f1d4412e8a6232e4f27ecd4", "parents": [ "7985eabefedd9644539be1193ca54903a1bfceec" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 09 14:03:12 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jul 26 22:54:32 2019 -0700" }, "message": "fmap.py: pretty print the object by default\n\nDumping the structure as a single line makes it hard to read. Format\nit for use humans by default and add a --raw option for people who are\nusing this tool in scripts.\n\nBUG\u003dchromium:982465\nTEST\u003d`./fmap.py bin/example.bin` shows human formatted output\nTEST\u003d`./fmap.py --raw bin/example.bin` shows one line\n\nChange-Id: I3232cdf104ae6edfbbc03e848166455710653f9d\nReviewed-on: https://chromium-review.googlesource.com/1693884\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "7985eabefedd9644539be1193ca54903a1bfceec", "tree": "e91a92988869412f82f9e9f165f75dc588e98a0a", "parents": [ "193121d636c6e776b221201628c9a30a45e6a673" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 09 13:58:10 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jul 26 22:54:31 2019 -0700" }, "message": "fmap.py: use argparse for parsing the command line\n\nThis makes the code easier to manage and provides automatic support\nfor things like -h/--help.\n\nBUG\u003dchromium:982465\nTEST\u003d`./fmap.py bin/example.bin` works\n\nChange-Id: I7a45d414cb2ed2d23bf65978b9dd06e05fc99cd7\nReviewed-on: https://chromium-review.googlesource.com/1693883\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "193121d636c6e776b221201628c9a30a45e6a673", "tree": "0ea291034f5606d13681ad0bdbcd521b25763137", "parents": [ "25a4f98e37f30bc9b9b67713b58e0b839a8bd2a2" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 09 13:54:09 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jul 26 01:08:17 2019 -0700" }, "message": "PRESUBMIT: run fmap unittests\n\nThese are fast so shouldn\u0027t be a problem to run.\n\nBUG\u003dchromium:982465\nTEST\u003d`repo upload` runs these unittests\n\nChange-Id: Ib32e56e28ed0b349370d46553a032e99ff92791c\nReviewed-on: https://chromium-review.googlesource.com/1693882\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: ChromeOS CL Exonerator Bot \u003cchromiumos-cl-exonerator@appspot.gserviceaccount.com\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "25a4f98e37f30bc9b9b67713b58e0b839a8bd2a2", "tree": "5a7ca7dd9d39f90154acdb3ac6d48cec6feefe8a", "parents": [ "5af26c3c6e0dfe78f9553bbf8f91508bd706643b" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 09 13:54:46 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jul 26 01:08:17 2019 -0700" }, "message": "make python scripts executable\n\nThese are expected to be run directly, so mark both of them executable\nso it\u0027s easier to run tests.\n\nBUG\u003dchromium:982465\nTEST\u003drunning both directly works\n\nChange-Id: Ib76c3d61a80c554ad03ed68065f9afa2c6ccb887\nReviewed-on: https://chromium-review.googlesource.com/1693881\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: ChromeOS CL Exonerator Bot \u003cchromiumos-cl-exonerator@appspot.gserviceaccount.com\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "5af26c3c6e0dfe78f9553bbf8f91508bd706643b", "tree": "828dfc6cd65ef743dca796d03319fb91c86b3a52", "parents": [ "274688eb2280dba7d1e0afe5a6a77c703624c43f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Jul 24 18:02:37 2019 -0400" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Jul 25 15:51:45 2019 +0000" }, "message": "OWNERS: add @google.com too\n\nBUG\u003dNone\nTEST\u003dNone\n\nExempt-From-Owner-Approval: updating OWNERS itself w/no existing approvers\nChange-Id: If529419e8004dc69dfd000b03d8ed830d61f48d9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashmap/+/1716019\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "274688eb2280dba7d1e0afe5a6a77c703624c43f", "tree": "697226ec06ab25b3cd47712e0773e8b5ee597594", "parents": [ "7b2f153a7a65bb8f958212c5c5aec0758256465a" ], "author": { "name": "Kirtika Ruchandani", "email": "kirtika@google.com", "time": "Sat May 25 12:52:31 2019 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue May 28 10:45:00 2019 -0700" }, "message": "flashmap: Update OWNERS\n\nRemove folks not on project/at Google.\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: I6f4c124724a113b542427548d373877d07f05544\nSigned-off-by: Kirtika Ruchandani \u003ckirtika@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/1630647\nCommit-Ready: Kirtika Ruchandani \u003ckirtika@chromium.org\u003e\nTested-by: Kirtika Ruchandani \u003ckirtika@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "7b2f153a7a65bb8f958212c5c5aec0758256465a", "tree": "7e5a11e4f5940850b1e421de0f2a43d418c5cdd7", "parents": [ "9108393752ffd93b133037add1f7b484de09bdbc" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Thu Feb 28 17:22:56 2019 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Mar 01 01:08:57 2019 -0800" }, "message": "flashmap: Add FMAP_AREA_PRESERVE in area flags\n\nMany projects started their initial builds without knowing that some\nsections must be preserved when being updated. This may be solved by\nadding section name to \u0027preserved\u0027 list in firmware updater (for\ninstance, CL:1239797), or include that section as sub area of\n{RO,RW}_PRESERVE.\n\nHowever, there are problems in both solution. For example, installing an\nolder image will run old updater, which will not preserve the new names.\nAlso, if there are multiple sections must be preserved (and not\ncontiguous - see CL:1493629) there will be problems.\nAdditionally, changing FMAP layout usually causes more problems.\n\nAs a result, adding the description in FMAP area would be the better\nidea. The new FMAP_AREA_PRESERVE is a suggestion for updater to preserve\nthis section if possible. Programs constructing FMAP must define its own\nway to add such attribute.\n\nBUG\u003db:126637087,chromium:936768\nTEST\u003dsudo emerge flashmap\n\nChange-Id: I61e80aa13efe36177b76b5a9d8d3a4b8bcbd9bac\nReviewed-on: https://chromium-review.googlesource.com/1493767\nCommit-Ready: ChromeOS CL Exonerator Bot \u003cchromiumos-cl-exonerator@appspot.gserviceaccount.com\u003e\nTested-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@google.com\u003e\n" }, { "commit": "9108393752ffd93b133037add1f7b484de09bdbc", "tree": "fc414fc88b4a4bc4d6357021ade8b631a2786779", "parents": [ "11bc385cb6d34ed9f53a240b8b6c0f01c6a0a776" ], "author": { "name": "Drew Davenport", "email": "ddavenport@chromium.org", "time": "Thu May 25 14:45:58 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri May 26 09:47:44 2017 -0700" }, "message": "flashmap: Bring over changes from factory repo\n\nfmap.py is identical to the one in factory/setup/fmap.py except:\n - no test functionality in main function\n - module docstring and license\n\nAdded some unit tests for the new functionality\n\nBUG\u003dchromium:726356\nTEST\u003dran unittests\n\nChange-Id: Ib67bd4260cf4e1cc08543b822521a4adcf0cbce6\nReviewed-on: https://chromium-review.googlesource.com/516382\nCommit-Ready: Drew Davenport \u003cddavenport@chromium.org\u003e\nTested-by: Drew Davenport \u003cddavenport@chromium.org\u003e\nReviewed-by: Drew Davenport \u003cddavenport@chromium.org\u003e\n" }, { "commit": "11bc385cb6d34ed9f53a240b8b6c0f01c6a0a776", "tree": "40cf5c614f56ba4a6b05591c5e2a33cb4c75cea7", "parents": [ "d9b74a2cfce7700f1846ffefc27befc0a4faa092" ], "author": { "name": "Drew Davenport", "email": "ddavenport@chromium.org", "time": "Thu May 25 14:13:55 2017 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri May 26 09:47:44 2017 -0700" }, "message": "flashmap: add fmap_unittest.py\n\n- Remove test functionality from fmap.py\u0027s main\n function and replace with appropriate unit tests\n in fmap_unittest.py\n- Bring over some formatting and lint fixes from\n factory/setup/fmap.py\n- Add *.pyc to .gitignore\n\nBUG\u003dchromium:726356\nTEST\u003dran unit tests\n\nChange-Id: I4cb99efa3d924483dfdff9be54f6c3fc10040f3f\nReviewed-on: https://chromium-review.googlesource.com/516242\nCommit-Ready: Drew Davenport \u003cddavenport@chromium.org\u003e\nTested-by: Drew Davenport \u003cddavenport@chromium.org\u003e\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "d9b74a2cfce7700f1846ffefc27befc0a4faa092", "tree": "99e9a2a8fa6b068dc2ad5f572d62b921acc7776d", "parents": [ "252eda88ac16a71a84da2c934b293c07a09a0df3" ], "author": { "name": "Chih-Yu Huang", "email": "akahuang@google.com", "time": "Tue May 16 18:57:08 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sat May 20 03:55:14 2017 -0700" }, "message": "fmap.h: Add `extern \"C\"` to make it compatible to C++.\n\nfmap.h is a C header file. We add `extern \"C\"` to let C++ code be able\nto include it.\n\nBUG\u003dnone\nTEST\u003demerge flashmap\n successfully build a c++ program which includes fmap.h\n\nChange-Id: I0317ddc9ce7182d69899d7756688ee7dcaded26a\nReviewed-on: https://chromium-review.googlesource.com/505677\nCommit-Ready: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nTested-by: Chih-Yu Huang \u003cakahuang@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "252eda88ac16a71a84da2c934b293c07a09a0df3", "tree": "5c162db745b376004b79b84755a8e93b33fc1ea5", "parents": [ "caf3f93f753df5ff089df615e465d46122bee123" ], "author": { "name": "Nicolas Boichat", "email": "drinkcat@google.com", "time": "Tue Apr 18 09:50:57 2017 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Apr 21 21:57:36 2017 -0700" }, "message": "fmap_find_area: Use const pointers for fmap and return value\n\nfmap_find_area does not modify the fmap, let\u0027s use const pointers.\n\nBUG\u003dnone\nTEST\u003demerge flashmap\n\nChange-Id: Ie5c64c3df3b2ef44a2e2ca0dbef4dd3403d91d75\nReviewed-on: https://chromium-review.googlesource.com/479037\nCommit-Ready: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nTested-by: Nicolas Boichat \u003cdrinkcat@chromium.org\u003e\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n" }, { "commit": "caf3f93f753df5ff089df615e465d46122bee123", "tree": "863d5b6a813bcbf40be0146415c2d9ee9bb6c68f", "parents": [ "4a4f568c8fca5b6e593f9d6b7a37fa7eaf52904c" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Mon Aug 08 15:00:13 2016 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Aug 17 19:16:10 2016 -0700" }, "message": "kv_pair: remove unused kv_pair array functions\n\nThese don\u0027t seem to be used anywhere, at least not in any published\ncode, and kv_pair_new_array() appears to misuse calloc() anyway.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dChromeOS compiles for ARM and x86 platforms\n\nChange-Id: Ife3e19dc4b3019251a119336d6c6b77a9de046cf\nSigned-off-by: David Hendricks \u003cdhendrix@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/366898\nReviewed-by: Duncan Laurie \u003cdlaurie@chromium.org\u003e\n" }, { "commit": "4a4f568c8fca5b6e593f9d6b7a37fa7eaf52904c", "tree": "7cecc6394a1e83d420bbe3ac0bc1786af1cc3f14", "parents": [ "aaaf66654dba797f152066df4d1dc4144b492c66" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Mon Aug 08 14:17:50 2016 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Aug 17 19:16:09 2016 -0700" }, "message": "kv_pair: Fix improper usage of calloc() in kv_pair_new()\n\nSeems we\u0027ve been lucky not to have had issues with this, until Stephen\nGilles (sgilles@math.umd.edu) encountered problems running fmap_decode\non an ARM-based system (Asus C201 / veyron_speedy) using musl libc.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dunit tests pass, fmap_decode no longer crashes for Stephen\n\nSigned-off-by: David Hendricks \u003cdhendrix@chromium.org\u003e\nChange-Id: I27b2c7ee8476cb66d482632ca509265310996835\nReviewed-on: https://chromium-review.googlesource.com/366897\nReviewed-by: Duncan Laurie \u003cdlaurie@chromium.org\u003e\n" }, { "commit": "aaaf66654dba797f152066df4d1dc4144b492c66", "tree": "cbdcd1a43fe37b335aa12ebd6a8075d2e89d5c22", "parents": [ "699e98cf6f69f1b516f07ed45c2b942074775ccc" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Fri Mar 14 11:46:49 2014 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Fri May 09 23:50:41 2014 +0000" }, "message": "Licensing fixups\n\nThis moves COPYING to LICENSE and adds OWNERS as per the\n\"Licensing for ChromeOS contributors\" doc.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dnone\n\nChange-Id: I880c220f3e177e32fa793ec0eabc273877eecca5\nReviewed-on: https://chromium-review.googlesource.com/190066\nCommit-Queue: David Hendricks \u003cdhendrix@chromium.org\u003e\nTested-by: David Hendricks \u003cdhendrix@chromium.org\u003e\nReviewed-by: Duncan Laurie \u003cdlaurie@chromium.org\u003e\n" }, { "commit": "699e98cf6f69f1b516f07ed45c2b942074775ccc", "tree": "38de2245b368eaa551b65386dcfd494993108df0", "parents": [ "e7865735aa22d55b2593cb02549a166fc2edd44b" ], "author": { "name": "Yunlian Jiang", "email": "yunlian@google.com", "time": "Thu Apr 04 15:20:43 2013 -0700" }, "committer": { "name": "ChromeBot", "email": "chrome-bot@google.com", "time": "Thu Apr 04 17:44:19 2013 -0700" }, "message": "Remove extra parentheses to pass clang checking.\n\nBUG\u003dchromium:219220\nTEST\u003demerge-lumpy flashmap, the error message is gone.\n\nChange-Id: I5fe8b5c9f1b6802d2487b57b96e93ba2e4e7c226\nReviewed-on: https://gerrit.chromium.org/gerrit/47368\nReviewed-by: David Hendricks \u003cdhendrix@chromium.org\u003e\nCommit-Queue: Yunlian Jiang \u003cyunlian@chromium.org\u003e\nTested-by: Yunlian Jiang \u003cyunlian@chromium.org\u003e\n" }, { "commit": "e7865735aa22d55b2593cb02549a166fc2edd44b", "tree": "07f05193d26add9b892068ad4a47ec3f253eab5b", "parents": [ "cc62ab05f132ecb78d6e7558f961c5faf2aa46c4" ], "author": { "name": "Han Shen", "email": "shenhan@google.com", "time": "Tue Apr 02 15:48:37 2013 -0700" }, "committer": { "name": "ChromeBot", "email": "chrome-bot@google.com", "time": "Wed Apr 03 16:34:50 2013 -0700" }, "message": "Fix improper use of memset.\n\nFor the following code snippet -\n char *str;\n str \u003d (char *)malloc(...);\n memset(str, \u0027\\0\u0027, sizeof(str));\n ^^^^^^^^^^^ always equals 4 or 8\n\nTEST\u003dBuilt.\nBUG\u003dNone\n\nChange-Id: I42fb6c27a2bd8cdbeb4941d8b01e242132132154\nReviewed-on: https://gerrit.chromium.org/gerrit/47191\nReviewed-by: David Hendricks \u003cdhendrix@chromium.org\u003e\nTested-by: Han Shen \u003cshenhan@google.com\u003e\nCommit-Queue: Han Shen \u003cshenhan@google.com\u003e\n" }, { "commit": "cc62ab05f132ecb78d6e7558f961c5faf2aa46c4", "tree": "db882383d0790e177d575e0c8e99e49a38dc85b2", "parents": [ "b34038febf50a1f2f309e13416580035784d0a8e" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Mon Mar 11 15:08:53 2013 -0700" }, "committer": { "name": "ChromeBot", "email": "chrome-bot@google.com", "time": "Wed Mar 13 12:41:10 2013 -0700" }, "message": "give strncpy() an appropriate limit\n\nThis tells strncpy() to copy max_len bytes instead of strlen(src)\nbytes, which will set bytes beyond strlen(src) with null bytes.\n\nWe really only need strlen(src) + 1, but for debugging it\u0027s\nnice not to have a bunch of garbage in the destination buffer.\n\nThis fixes a test which err\u0027d due to the lack of a terminating NULL\nat the end of dest (do_strcpy is only used by unit tests).\n\nBUG\u003dnone\nTEST\u003dmake test\n\nChange-Id: I73e19a15c91d874702b84877100cbf8d51bf8ac1\nReviewed-on: https://gerrit.chromium.org/gerrit/45143\nReviewed-by: Duncan Laurie \u003cdlaurie@chromium.org\u003e\nTested-by: David Hendricks \u003cdhendrix@chromium.org\u003e\nCommit-Queue: David Hendricks \u003cdhendrix@chromium.org\u003e\n" }, { "commit": "b34038febf50a1f2f309e13416580035784d0a8e", "tree": "2576eb1760115c653a94a4ccc3c3b7d458b0cefe", "parents": [ "73aa0babd88c3693423c368a079b1aba5c83f8bf" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Mon Mar 11 15:17:15 2013 -0700" }, "committer": { "name": "ChromeBot", "email": "chrome-bot@google.com", "time": "Wed Mar 13 12:41:10 2013 -0700" }, "message": "add gcov file extensions (.gcda and .gcno) to .gitignore\n\nBUG\u003dnone\nTEST\u003dgcov files no longer appear in git status\n\nChange-Id: I455e6445e32a6fdef2cb381b994908a17bde3e0f\nReviewed-on: https://gerrit.chromium.org/gerrit/45142\nReviewed-by: Duncan Laurie \u003cdlaurie@chromium.org\u003e\nCommit-Queue: David Hendricks \u003cdhendrix@chromium.org\u003e\nTested-by: David Hendricks \u003cdhendrix@chromium.org\u003e\n" }, { "commit": "73aa0babd88c3693423c368a079b1aba5c83f8bf", "tree": "8a6cdf31230339ba3f76936eb6d9bc08559a0aac", "parents": [ "fa5c49ea40c44f6322ee9860c0a06df73a8562e1" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Mon Mar 11 15:55:57 2013 -0700" }, "committer": { "name": "ChromeBot", "email": "chrome-bot@google.com", "time": "Wed Mar 13 12:41:09 2013 -0700" }, "message": "add PRESUBMIT.cfg\n\nThis adds a presubmit config file so we don\u0027t get annoying repo upload\nwarnings for tabs and software license.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dtried uploading a change, didn\u0027t get nagged for tabs and license\n\nChange-Id: Ia46ae58c6281fb6cc7ac0864d45c613908cb2df4\nReviewed-on: https://gerrit.chromium.org/gerrit/45141\nReviewed-by: Duncan Laurie \u003cdlaurie@chromium.org\u003e\nCommit-Queue: David Hendricks \u003cdhendrix@chromium.org\u003e\nTested-by: David Hendricks \u003cdhendrix@chromium.org\u003e\n" }, { "commit": "fa5c49ea40c44f6322ee9860c0a06df73a8562e1", "tree": "e581823802f8d3adafbbe03ff0f17cc1476697fa", "parents": [ "045b63af99f70a1c56a56e20e37f4d4b2a2f7eda" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Wed May 02 14:51:57 2012 -0700" }, "committer": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Wed May 02 14:55:29 2012 -0700" }, "message": "Add libfmap.a to install and uninstall rules\n\nBUG\u003dnone\nTEST\u003dlocally compiled\n\n\"sudo emerge flashmap\" (amd64) --\u003e /usr/lib64/libfmap.a\n\"emerge-daisy flashmap\" (32-bit) --\u003e /build/daisy/usr/lib/libfmap.a\n\nadding -C to those commands removes the .a files\n\nChange-Id: I679e040675db4eedd79b2bbc55b49f20d0fe79e4\n" }, { "commit": "045b63af99f70a1c56a56e20e37f4d4b2a2f7eda", "tree": "50373bbdb7a54c2e430772cbdb59c21db0cf6d4f", "parents": [ "6b97675909b2b7bac9822ac1285c5f817cdcc2d5" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Nov 02 12:33:05 2011 -0400" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Nov 02 12:33:05 2011 -0400" }, "message": "use libdir for .pc install\n\nThe .pc files should be under the same libdir as the libraries, so use\nthe existing $(libdir) variable rather than hardcoding /usr/lib/ when\ninstalling the pkg-config files.\n\nBUG\u003dchromium-os:20636\nTEST\u003d`emerge-amd64-generic flashmap` and see .pc files in /usr/lib64/\nTEST\u003d`emerge-x86-generic flashmap` and see .pc files in /usr/lib/\n\nChange-Id: I619f6d4c7d04eda0cbe0e3d0fed987a69d764021\n" }, { "commit": "6b97675909b2b7bac9822ac1285c5f817cdcc2d5", "tree": "07b8a8eeb94ebe72ac778aeabfb699f6aaf92102", "parents": [ "b3c8a92f1601c4298641fafef4bf23e3488f2678" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Tue Nov 01 16:09:53 2011 -0700" }, "committer": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Tue Nov 01 16:48:52 2011 -0700" }, "message": "set flashmap install prefix to /usr instead of /usr/local\n\n/usr/local/ does not exist on non-developer images in Chrome OS.\n\nBUG\u003dchromium-os:22304\nTEST\u003dBuilt locally and ensured files are placed in /usr instead of /usr/local.\n\nFor x86-generic:\n/build/x86-generic/usr/lib/libfmap.so\n/build/x86-generic/usr/lib/libfmap.so.0\n/build/x86-generic/usr/lib/pkgconfig/fmap.pc\n/build/x86-generic/usr/lib/libfmap.so.0.0.0\n/build/x86-generic/usr/include/fmap.h\n/build/x86-generic/usr/sbin/fmap_encode\n/build/x86-generic/usr/sbin/fmap_decode\n/build/x86-generic/usr/sbin/fmap_csum\n\nFor amd64-generic:\n/build/amd64-generic/usr/lib/pkgconfig/fmap.pc\n/build/amd64-generic/usr/lib64/libfmap.so\n/build/amd64-generic/usr/lib64/libfmap.so.0\n/build/amd64-generic/usr/lib64/libfmap.so.0.0.0\n/build/amd64-generic/usr/include/fmap.h\n/build/amd64-generic/usr/sbin/fmap_encode\n/build/amd64-generic/usr/sbin/fmap_decode\n/build/amd64-generic/usr/sbin/fmap_csum\n\nChange-Id: I64278c91c4b52f4d89d8d174a579ddb62da3a0c1\n" }, { "commit": "b3c8a92f1601c4298641fafef4bf23e3488f2678", "tree": "92b6a5b008f6eb1e58d5be8975aa33a9167390ab", "parents": [ "2b41f76b22509b9ea814b1d506a07791dd7192a9" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Tue Oct 25 20:39:44 2011 -0700" }, "committer": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Wed Oct 26 15:00:21 2011 -0700" }, "message": "Update libfmap naming and install rule\n\nThis updates the libfmap .so filename to better match GNU convention\nand also updates the soname (seen when running objdump -x). It also\nupdates the installation so that the package installs symbolic links.\n\n(Note: There was also some disambiguation between the lib directory\n belonging to the system and the lib directory belonging to the source)\n\nBUG\u003dchrome-os-partner:6600\nTEST\u003dlocally built for arm-generic and amd64-generic targets\n\nChange-Id: Ib1002f20a1a324bd9583f617f59cf3804e06659c\n" }, { "commit": "2b41f76b22509b9ea814b1d506a07791dd7192a9", "tree": "82b536baa5735fdfe958de8ee2f70c57b8545bd3", "parents": [ "e4b12265cf338b774f5bf338db7fb7c587387293" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Tue Oct 25 18:40:48 2011 -0700" }, "committer": { "name": "Gerrit Code Review", "email": "gerrit@gerrit.golo.chromium.org", "time": "Tue Oct 25 18:40:48 2011 -0700" }, "message": "Revert \"add version number to -lfmap provided by pkg-config\"\n\nThis turned out to be less useful than originally thought. Nothing broke, but nothing was gained either. Reverting.\n\nThis reverts commit e4b12265cf338b774f5bf338db7fb7c587387293" }, { "commit": "e4b12265cf338b774f5bf338db7fb7c587387293", "tree": "633090ce5bcecbf86328dd758f12751e81731bda", "parents": [ "bc1c8604d46ef044b9be187be034289ae84e777b" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Mon Oct 24 18:22:10 2011 -0700" }, "committer": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Mon Oct 24 18:55:46 2011 -0700" }, "message": "add version number to -lfmap provided by pkg-config\n\nThis is intended as a short-term fix to some linking issues caused by\nthe strange soname configuration currently used in this package, namely\nthat successfully linking other packages to libfmap depends on a symlink\nbeing created by ldconfig, which is currently created more or less on accident.\n\nFuture versions will likely revert this change and come with some other\nchanges to the Makefile.\n\nBUG\u003dnone\nTEST\u003dSee notes below.\nBefore:\npkg-config-x86-generic --libs-only-l fmap\n-lfmap\n\nAfter:\npkg-config-x86-generic --libs-only-l fmap\n-lfmap-0.3\n\nChange-Id: I103e7661d0a1b322e7b477e28f366da2cc499476\n" }, { "commit": "bc1c8604d46ef044b9be187be034289ae84e777b", "tree": "82b536baa5735fdfe958de8ee2f70c57b8545bd3", "parents": [ "5721cee05f808cda3276951c1f81ea1937f33227" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Tue Sep 27 17:04:48 2011 -0700" }, "committer": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Thu Sep 29 14:28:39 2011 -0700" }, "message": "Add pkg-config support to flashmap\n\nThis adds a rule to the Makefile to generate a pkg-config .pc file\nand install it if:\n1) /usr/lib/pkgconfig is a directory\n2) The user sets an environment variable.\n\nThe latter is useful for sandboxed environments since /usr/lib/pkgconfig\nmight exist in the target environment but not the sandbox where flashmap\nis being built.\n\nBUG\u003dnone\nTEST\u003dTest compiled on Goobuntu, cros_sdk (emerge), and x86-generic (emerge-x86-generic)\n\nChange-Id: Id45ef5300b693f8258671729b624b82ea1780965\n" }, { "commit": "5721cee05f808cda3276951c1f81ea1937f33227", "tree": "40138fa339e5060338475cf85387a0ea374b8fbf", "parents": [ "55d04f39429778250fc99a71113d3356a65fc084" ], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Tue Sep 06 15:20:12 2011 -0700" }, "committer": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Tue Sep 06 15:20:12 2011 -0700" }, "message": "Conditionally assign toolchain variables\n\ntc-export apparently does not set the CROSS_COMPILE prefix for tools like gcc,\nar, etc. Instead, it seems to set the variables directly.\n\nConditionally assigning them in the Makefile with \"?\u003d\" instead of \"\u003d\" or \":\u003d\"\nmakes cross compilation work for board overlays. With \"\u003d\" instead of \"?\u003d\",\ncompilation fails complaining that \"atom\" is not value for -mtune and -march.\n\nBUG\u003dnone\nTEST\u003dCompiled for host (amd64), x86-generic and tegra2_seaboard\n\nChange-Id: I9ddb2eb769d53be3ade5e325e9b83f343b9b19ba\n" }, { "commit": "55d04f39429778250fc99a71113d3356a65fc084", "tree": "a23312c013bf576c22e5fd832d87ab8a631bacf9", "parents": [], "author": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Wed Aug 31 12:29:48 2011 -0700" }, "committer": { "name": "David Hendricks", "email": "dhendrix@chromium.org", "time": "Wed Aug 31 12:29:48 2011 -0700" }, "message": "Initial import of flashmap\n" } ] }