| commit | a37ed135454d95e9e575797fad88e6ebb1039df1 | [log] [tgz] |
|---|---|---|
| author | Patryk Duda <pdk@semihalf.com> | Thu Oct 01 13:57:06 2020 +0200 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 02 04:39:47 2020 +0000 |
| tree | 93f7b74a7ecee59ff9e4f2f8f05ab628f4ac59a6 | |
| parent | ac5a8d04d4bd19eb2b21331915bdf8255fa589b2 [diff] |
firmware_ECCharging: Don't test when DUT performs discharge on AC
Some boards (eg. eve) performs discharge on AC when battery reports
that it is fully charged and doesn't want more charge. This can lead to
situation in which charge is below 100% and battery is still discharging,
for example:
> battery
Status: 0x00e0 FULL DCHG INIT
Param flags:00000002
Temp: 0x0baa = 298.6 K (25.5 C)
V: 0x218d = 8589 mV
V-desired: 0x0000 = 0 mV
I: 0xff22 = -222 mA(DISCHG)
I-desired: 0x0000 = 0 mA
Charging: Not Allowed
Charge: 98 %
> chgstate
state = discharge
ac = 1
batt_is_charging = 0
Test expects that battery is being charged when it is below 100%,
which is not true during discharge on AC.
This patch adds checking if discharge on AC takes place, if so just
exit from test with appropriate message.
BUG=b:162254118
TEST=Charge battery to 100%, this should trigger discharge on AC (check
it using 'battery' and 'chgstate' commands).
Run firmware_ECCharging test. It should report that DUT performs
discharge on AC and finish successfully.
Change-Id: Ic42a55cf98082984b95ea0d7d5daba83755d34bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2440896
Tested-by: Patryk Duda <pdk@semihalf.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Commit-Queue: Wai-Hong Tam <waihong@google.com>
Autotest is a framework for fully automated testing. It was originally designed to test the Linux kernel, and expanded by the Chrome OS team to validate complete system images of Chrome OS and Android.
Autotest is composed of a number of modules that will help you to do stand alone tests or setup a fully automated test grid, depending on what you are up to. A non extensive list of functionality is:
A body of code to run tests on the device under test. In this setup, test logic executes on the machine being tested, and results are written to files for later collection from a development machine or lab infrastructure.
A body of code to run tests against a remote device under test. In this setup, test logic executes on a development machine or piece of lab infrastructure, and the device under test is controlled remotely via SSH/adb/some combination of the above.
Developer tools to execute one or more tests. test_that for Chrome OS and test_droid for Android allow developers to run tests against a device connected to their development machine on their desk. These tools are written so that the same test logic that runs in the lab will run at their desk, reducing the number of configurations under which tests are run.
Lab infrastructure to automate the running of tests. This infrastructure is capable of managing and running tests against thousands of devices in various lab environments. This includes code for both synchronous and asynchronous scheduling of tests. Tests are run against this hardware daily to validate every build of Chrome OS.
Infrastructure to set up miniature replicas of a full lab. A full lab does entail a certain amount of administrative work which isn't appropriate for a work group interested in automated tests against a small set of devices. Since this scale is common during device bringup, a special setup, called Moblab, allows a natural progressing from desk -> mini lab -> full lab.
See the guides to test_that and test_droid:
See the best practices guide, existing tests, and comments in the code.
git clone https://chromium.googlesource.com/chromiumos/third_party/autotest
See the coding style guide for guidance on submitting patches.
You need to run utils/build_externals.py to set up the dependencies for pre-upload hook tests.