| commit | e3e87e52793394b570644d337f6f1d307fbecdea | [log] [tgz] |
|---|---|---|
| author | Patryk Duda <pdk@semihalf.com> | Wed Dec 09 16:01:46 2020 +0100 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 10 00:13:28 2020 +0000 |
| tree | bca0f2aaf953cc8ddacf6e7852cb86a4a4d5adee | |
| parent | 2043f6a075e02c1c3f3d97156eaba923618d82a0 [diff] |
firmware_ECWakeSource: Wait for G3 state when hibernating
Method run_shutdown_cmd() sends 'shutdown' command to DUT and
waits until DUT goes offline. Actually not responding for a ping
doesn't mean DUT is powered off.
This was found by running ECWakeSource test against EC ToT on casta.
Power button was pressed when DUT was in S0 state, so test was
unable to wake up DUT.
This was working before, because after sending shutdown command test was
issuing 'hibernate 1000' on EC console. Hibernating EC causes
chipset_force_shutdown() to be called if chipset is not in shutdown
state. Starting from CL:2442037 PSL hibernating with timeout is disabled
for NPCX.
Above situation was fixed by checking if 'shutdown' command sent to DUT
actually causes power state change to G3 (though EC hibernating needs to
be fixed too).
BUG=b:161775827
BRANCH=none
TEST=Flash EC ToT on Casta. Run ECWakeSource test. Make sure that power
button is pressed after DUT enters G3 state.
Change-Id: I5f578acf042bce28cb34a86e1de4921230943f4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2582039
Tested-by: Patryk Duda <pdk@semihalf.com>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Autotest is a framework for fully automated testing. It was originally designed to test the Linux kernel, and expanded by the Chrome OS team to validate complete system images of Chrome OS and Android.
Autotest is composed of a number of modules that will help you to do stand alone tests or setup a fully automated test grid, depending on what you are up to. A non extensive list of functionality is:
A body of code to run tests on the device under test. In this setup, test logic executes on the machine being tested, and results are written to files for later collection from a development machine or lab infrastructure.
A body of code to run tests against a remote device under test. In this setup, test logic executes on a development machine or piece of lab infrastructure, and the device under test is controlled remotely via SSH/adb/some combination of the above.
Developer tools to execute one or more tests. test_that for Chrome OS and test_droid for Android allow developers to run tests against a device connected to their development machine on their desk. These tools are written so that the same test logic that runs in the lab will run at their desk, reducing the number of configurations under which tests are run.
Lab infrastructure to automate the running of tests. This infrastructure is capable of managing and running tests against thousands of devices in various lab environments. This includes code for both synchronous and asynchronous scheduling of tests. Tests are run against this hardware daily to validate every build of Chrome OS.
Infrastructure to set up miniature replicas of a full lab. A full lab does entail a certain amount of administrative work which isn't appropriate for a work group interested in automated tests against a small set of devices. Since this scale is common during device bringup, a special setup, called Moblab, allows a natural progressing from desk -> mini lab -> full lab.
See the guides to test_that and test_droid:
See the best practices guide, existing tests, and comments in the code.
git clone https://chromium.googlesource.com/chromiumos/third_party/autotest
See the coding style guide for guidance on submitting patches.
You need to run utils/build_externals.py to set up the dependencies for pre-upload hook tests.