| commit | 093df1c3ac5acf88ba9bc55d8dd43052f5a319ab | [log] [tgz] |
|---|---|---|
| author | Abhishek Pandit-Subedi <abhishekpandit@chromium.org> | Mon Sep 14 16:37:43 2020 -0700 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Sep 17 19:28:41 2020 +0000 |
| tree | 45f149439e37b102250ea1e4976d4116bcf4ea72 | |
| parent | c929eecf076e131ccf9065ee7eb5b68bf21ebdd8 [diff] |
autotest: Add timeout to _ping_check_status
In Bluetooth MTBF tests, we encountered a scenario where a ping command
that should have completed in 1s (with a failure) completed almost
8 seconds later with success. Either ping failed to enforce the deadline
(set via -w1) or the subprocess call got stuck somewhere.
Here is an example log of the issue:
09/12 23:43:15.056 DEBUG| utils:0219| Running 'ping chromeos15-row5-rack5-host6 -w1 -c1'
09/12 23:43:23.067 DEBUG| utils:1993| [rc=0] 1 packets transmitted, 1 received, 0% packet loss, time 0ms; rtt min/avg/max/mdev = 2.923/2.923/2.923/0.000 ms
To enforce a more consistent ping check, also use the timeout parameter
when running the ping request. Either the ping will finish quickly (less
than deadline), finish at the deadline (which will likely be before the
timeout) or after the timeout (at which point the subprocess will be
killed).
BUG=b:168428728
TEST=Ran a bluetooth specific suspend/resume stress test that uses
cros_hosts.test_wait_for_sleep and passed 50 iterations without the
issue.
Change-Id: Ib1b0d6359b21c0dff792914f6904067d4abfc390
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2411453
Tested-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Reviewed-by: Yu Liu <yudiliu@google.com>
Commit-Queue: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Autotest is a framework for fully automated testing. It was originally designed to test the Linux kernel, and expanded by the Chrome OS team to validate complete system images of Chrome OS and Android.
Autotest is composed of a number of modules that will help you to do stand alone tests or setup a fully automated test grid, depending on what you are up to. A non extensive list of functionality is:
A body of code to run tests on the device under test. In this setup, test logic executes on the machine being tested, and results are written to files for later collection from a development machine or lab infrastructure.
A body of code to run tests against a remote device under test. In this setup, test logic executes on a development machine or piece of lab infrastructure, and the device under test is controlled remotely via SSH/adb/some combination of the above.
Developer tools to execute one or more tests. test_that for Chrome OS and test_droid for Android allow developers to run tests against a device connected to their development machine on their desk. These tools are written so that the same test logic that runs in the lab will run at their desk, reducing the number of configurations under which tests are run.
Lab infrastructure to automate the running of tests. This infrastructure is capable of managing and running tests against thousands of devices in various lab environments. This includes code for both synchronous and asynchronous scheduling of tests. Tests are run against this hardware daily to validate every build of Chrome OS.
Infrastructure to set up miniature replicas of a full lab. A full lab does entail a certain amount of administrative work which isn't appropriate for a work group interested in automated tests against a small set of devices. Since this scale is common during device bringup, a special setup, called Moblab, allows a natural progressing from desk -> mini lab -> full lab.
See the guides to test_that and test_droid:
See the best practices guide, existing tests, and comments in the code.
git clone https://chromium.googlesource.com/chromiumos/third_party/autotest
See the coding style guide for guidance on submitting patches.
You need to run utils/build_externals.py to set up the dependencies for pre-upload hook tests.