)]}' { "log": [ { "commit": "d1bb0eb3f9dbd6613a0b2434cb88b84821e03829", "tree": "896a7c4c65cec34f45eb3e4cd1b9824f397d0938", "parents": [ "6ee76b81ea8b9d1b902dfc79fad0a129f8580110" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Fri Nov 06 09:25:43 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 20 20:04:45 2020 +0000" }, "message": "README: Revise blocked_terms explanation to reflect change\n\nThis patch revises the explanation of blocked_terms.txt and unblocked_terms.txt\nto reflect the change that they\u0027re no longer indentical.\n\nBUG\u003db:165908442\nTEST\u003dNone\n\nChange-Id: I3857e56dec7c29c201b0cde3ac365f5af9a39521\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2522524\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "6ee76b81ea8b9d1b902dfc79fad0a129f8580110", "tree": "5370188f91c214bda7bd05bd74459360e710b291", "parents": [ "9ba001a0b2e492d67a2c2e8c1d04ad959e3f2b24" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Nov 20 01:16:06 2020 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 20 18:50:50 2020 +0000" }, "message": "pre-upload: reject -r0 ebuilds\n\nThese are redundant, confusing, and some tools don\u0027t like them.\n\nBUG\u003dchromium:1150672\nTEST\u003dunittests pass\nTEST\u003dran against example commits in chromiumos-overlay\n\nChange-Id: I0bee561cb00486f66a5064a611bbf53d4cbd15ac\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2551822\nReviewed-by: Manoj Gupta \u003cmanojgupta@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "9ba001a0b2e492d67a2c2e8c1d04ad959e3f2b24", "tree": "f4a06c0255fa871bf70f9d470cbffd503b74c92d", "parents": [ "13abd4c250de17bdfebe660174d2cec231852a85" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Nov 20 01:02:11 2020 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 20 08:01:27 2020 +0000" }, "message": "pre-upload: fix running in a worktree\n\nThe rev-parse --git-dir shows the worktree\u0027s internal .git/ dir which\nisn\u0027t what we really want here -- we\u0027re trying to find the root of\nthis git project checkout.\n\nBUG\u003dchromium:1104812\nTEST\u003dunittests pass in a git worktree\n\nChange-Id: I2ae7650235da124235c274ac45b4b29021357df3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2551820\nReviewed-by: Chirantan Ekbote \u003cchirantan@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "13abd4c250de17bdfebe660174d2cec231852a85", "tree": "5fab85b584a9f03c1bd47b5d0d37a1583e32ab86", "parents": [ "625fbeb1d9f458038077c603c8d6b4016a3b4e69" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Nov 20 00:56:27 2020 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 20 08:01:24 2020 +0000" }, "message": "unittest: remove redundant chdir\n\nWe use chromite\u0027s TestCase which handles restoring cwd at the\nend of tests, so no need to do that ourselves here.\n\nBUG\u003dNone\nTEST\u003dunittests pass\n\nChange-Id: I592df5a34cbbced1e398f29e2b43ad8c3a6524fa\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2551819\nReviewed-by: Chirantan Ekbote \u003cchirantan@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "625fbeb1d9f458038077c603c8d6b4016a3b4e69", "tree": "7f1bcf0cbe5889b1019adc7a07966c68a8d2dea0", "parents": [ "48b7ef38a95dd69bcf8405adf157f5a885d96f94" ], "author": { "name": "Laurent Chavey", "email": "chavey@google.com", "time": "Wed Nov 11 16:17:56 2020 +0900" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 13 06:27:43 2020 +0000" }, "message": "pre-submit: Fix comments from crrev/c/2526651.\n\nReplace mockers by mocks.\nRemove unused setup_initialized.\nIn @classmethod, use |cls| rather than |CheckFilesTest|.\nIn normal bound method, so use |self| rather than |CheckFilesTest|.\nRevert changes with call to cros_test_lib.main.\n\nBUG\u003dchromium:1135047\nTEST\u003drun pre-upload_unittest.py\n\nChange-Id: I1da5cf5e633d39aa2f6961f0ab5d769f58ebbe82\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2531257\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Laurent Chavey \u003cchavey@google.com\u003e\nCommit-Queue: Laurent Chavey \u003cchavey@google.com\u003e\n" }, { "commit": "48b7ef38a95dd69bcf8405adf157f5a885d96f94", "tree": "3635b28d43b5e54ab9e501d72f17390985ddfb03", "parents": [ "90b7bd472db4da564965e457c46b278dd550340d" ], "author": { "name": "Laurent Chavey", "email": "chavey@google.com", "time": "Tue Nov 10 20:01:10 2020 +0900" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Nov 11 04:08:35 2020 +0000" }, "message": "pre-submit: Add test for \u0027sanity\u0027 blocking regex.\n\nAdd a unit test for \u0027sanity\u0027 block and unblock.\n\nRefactor blocked_terms_unittest.py to speed up the tests.\nBring total test run time from 15s to 0.5s.\n\nBUG\u003dchromium:1135047\nTEST\u003drun pre-upload_unittest.py\n\nChange-Id: I14c4d1f37f1e2c463912ce6a526549d67229dd03\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2526651\nTested-by: Laurent Chavey \u003cchavey@google.com\u003e\nCommit-Queue: Laurent Chavey \u003cchavey@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "90b7bd472db4da564965e457c46b278dd550340d", "tree": "647305af922f4ca165317c2b6d3c1f6eec736b87", "parents": [ "b0fa56f893aa6399abbb2c7954a7f6a8ba11926a" ], "author": { "name": "Tom Hughes", "email": "tomhughes@chromium.org", "time": "Tue Nov 10 10:31:49 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 10 22:53:05 2020 +0000" }, "message": "pre-upload.py: Ignore license check for DIR_METADATA files\n\nSee http://go/chromium-metadata-files for details on the metadata files.\n\nBUG\u003db:172930457\nTEST\u003d./pre-upload_unittest.py\n\nChange-Id: I5137eefba84125926a48b9307907ea1fa31b298d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2529699\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Tom Hughes \u003ctomhughes@chromium.org\u003e\nTested-by: Tom Hughes \u003ctomhughes@chromium.org\u003e\n" }, { "commit": "b0fa56f893aa6399abbb2c7954a7f6a8ba11926a", "tree": "dbc2608bedda5cb90284ca717456b039c27f00b4", "parents": [ "2baad9ed78374718980709d6999aecc2781d3f1f" ], "author": { "name": "Bernie Thompson", "email": "bhthompson@google.com", "time": "Fri Nov 06 09:53:26 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 06 20:54:16 2020 +0000" }, "message": "Use dynamic length in blocked_terms_unittest\n\nFor the blocked test instances we should always see the same number of failures\nas the number of lines, so we can just count that instead of having an extra\nconstant.\n\nBUG\u003dNone\nTEST\u003d./blocked_terms_unittest.py\n\nChange-Id: Icef38ff53a5bc1dc761421a50826b47b9ca0fd6e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2522915\nReviewed-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nTested-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "2baad9ed78374718980709d6999aecc2781d3f1f", "tree": "e75ba26c4dd8bfc6a7e8c8043d5ffa6e5786daba", "parents": [ "495976afea9d9c5599d3010839bd21fda2352c7b" ], "author": { "name": "Bernie Thompson", "email": "bhthompson@google.com", "time": "Thu Nov 05 20:46:41 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 06 20:54:15 2020 +0000" }, "message": "Adjust sane blocked term regex\n\nThis should also allow for \u0027insane\u0027 so we can reduce double counting.\n\nBUG\u003dchromium:1135047\nTEST\u003d./blocked_terms_unittest.py\n\nChange-Id: I1ed27f42136f1d83ecbae9694f8891613d4fe120\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2522159\nReviewed-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nTested-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "495976afea9d9c5599d3010839bd21fda2352c7b", "tree": "9e655807fef339a1597228a4d0f8e7c269579eb0", "parents": [ "bb3debd8eb2f202665a36ff07b18b82698ef7faa" ], "author": { "name": "Bernie Thompson", "email": "bhthompson@google.com", "time": "Thu Nov 05 17:24:14 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 06 20:54:14 2020 +0000" }, "message": "Add check for whitelist regex term\n\nThis verifies the regex for whitelist functions as expected.\n\nBUG\u003db:172602552\nTEST\u003d./blocked_terms_unittest.py\n\nChange-Id: Ib2bc659c7e94d0ac0128daf7475a95cc012d5eb0\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2522152\nReviewed-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nTested-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "bb3debd8eb2f202665a36ff07b18b82698ef7faa", "tree": "826295a1243f089726c617d7621a5f7a6daa769c", "parents": [ "47eeccc8e71af88d93078d334099a94a8f059cc1" ], "author": { "name": "Laurent Chavey", "email": "chavey@google.com", "time": "Wed Nov 04 02:14:50 2020 +0900" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Nov 04 01:50:38 2020 +0000" }, "message": "pre-submit: Modify \u0027sane\u0027 blocking regex\n\nModify \u0027sane\u0027 regex to \u0027\\bsane\\b\\d\u0027 to only block \u0027sane\u0027 when used as a\nstand alone acronym or as an acronym with a number.\nThe regex as currently defined blocks any instances of words similar to\n\u0027asanEnabled\u0027 etc.\n\nModifying the regex to \u0027\\bsane(\\b|\\d)\u0027 limits pre-submit blocking to only\nthe acronym uses.\n\nAdd a unit test for \u0027sane\u0027 block and unblock.\n\nRefactor blocked_terms_unittest.py to remove dependencies on the format\nof the failure messages. Those are tested in pre-upload_unittest.py.\n\nBUG\u003dchromium:1135047\nTEST\u003drun pre-upload_unittest.py\n\nChange-Id: Ic0c4744475eab43a741d385387d14fa98347546a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2517161\nTested-by: Laurent Chavey \u003cchavey@google.com\u003e\nCommit-Queue: Laurent Chavey \u003cchavey@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "47eeccc8e71af88d93078d334099a94a8f059cc1", "tree": "610945dafd0f7085dceada7ac16f1a7098554dab", "parents": [ "6bf5ea88be9877d5f88938c07bf8263ef364162d" ], "author": { "name": "Laurent Chavey", "email": "chavey@google.com", "time": "Wed Oct 14 10:09:41 2020 +0900" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 22 07:25:12 2020 +0000" }, "message": "pre-submit: Modify \u0027mitm\u0027 blocking regex\n\nModify \u0027mitm\u0027 regex to \u0027\\bmitm(\\b|\\d)\u0027 to only block \u0027mitm\u0027 when used as a\nstand alone acronym or as an acronym with a number.\nThe regex as currently defined blocks any instances of words similar to\n\u0027commitments\u0027 etc.\n\nModifying the regex to \u0027\\bmitm(\\b|\\d)\u0027 limits presubmit blocking to only\nthe acronym uses.\n\nAdd block_terms_unittest.py to test block_terms.txt and unblock_terms.txt.\nAdd a unit test for \u0027mitm\u0027 block and unblock.\n\nBUG\u003dchromium:1129806\nTEST\u003drun pre-upload_unittest.py\nTEST\u003drun block_terms_unittest.py\n\nChange-Id: If311c7ba3d86bd95c25661f27fb4b1b26b77becb\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2469417\nTested-by: Laurent Chavey \u003cchavey@google.com\u003e\nCommit-Queue: Laurent Chavey \u003cchavey@google.com\u003e\nReviewed-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Stephane Belmon \u003csbelmon@google.com\u003e\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "6bf5ea88be9877d5f88938c07bf8263ef364162d", "tree": "c2a4f3a64d21fea3ea7a9e47fca401bcc00725fc", "parents": [ "c627874f1bba21f33406852c2425eeb4b577a599" ], "author": { "name": "Stephen Boyd", "email": "swboyd@chromium.org", "time": "Thu Oct 15 00:02:07 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 16 19:36:31 2020 +0000" }, "message": "pre-upload: Skip revbump check for profiles paths\n\nIf a CL combines a profile update (like make.defaults) for an overlay\nwith an ebuild change to the files/ directory a confusing error message\ncomes out from the repo upload step. For example, uploading CL:2446471\ncauses the check to complain that the ebuild needs a manual revbump when\nit really doesn\u0027t. This is because the hook is checking all paths in the\ncommit, including ones for the overlay\u0027s \u0027make.defaults\u0027. Skip out on\npaths that have \u0027/profiles/\u0027 in them so that the revbump logic doesn\u0027t\nget confused and lead developers astray.\n\nBUG\u003dNone\nTEST\u003dTry to upload CL:2446471 and see it doesn\u0027t complain anymore\n\nChange-Id: I1cffc6592e81a28d922481a704fa4e1e699919b0\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2473371\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Stephen Boyd \u003cswboyd@chromium.org\u003e\nTested-by: Stephen Boyd \u003cswboyd@chromium.org\u003e\n" }, { "commit": "c627874f1bba21f33406852c2425eeb4b577a599", "tree": "9c6fa361cfe44575f3511bba77f791e92f3d6de1", "parents": [ "434af9a93785aab809ad37f210d7cb4808830b88" ], "author": { "name": "Bob Haarman", "email": "inglorion@chromium.org", "time": "Tue Oct 06 21:43:29 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 08 18:11:40 2020 +0000" }, "message": "Restrict some blocked terms to word boundaries\n\nThis restricts /red.?line/ and /wtf/ to only match after a\nword boundary, to avoid unintended matches such as\n\"configured line\" and base64-encoded data that happens to have\nthe sequence \"wtf\" in it.\n\nBUG\u003dNone\nTEST\u003dRan search_blocked_words.sh with the new lists\n\nChange-Id: I123b022838992058c6331f2f796e685dc08dc7eb\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2454295\nTested-by: Bob Haarman \u003cinglorion@chromium.org\u003e\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: Bob Haarman \u003cinglorion@chromium.org\u003e\n" }, { "commit": "434af9a93785aab809ad37f210d7cb4808830b88", "tree": "44759c210659f1da0febcb51cd7c2a8a6b01483a", "parents": [ "0dc1f943cd7d43565bc2cb64327a47fef8b98cc8" ], "author": { "name": "Laurent Chavey", "email": "chavey@google.com", "time": "Mon Sep 28 22:25:16 2020 +0900" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 07 03:30:33 2020 +0000" }, "message": "pre-submit: Increase support for superseding unblocking regex\n\nAdd support to allow using regex to unblock a subset of a given blocked word\nregex. While working on some COIL cleanup, some of the blocked words are to\ngeneric to support incremental cleanup of the code base while enabling presubmit\nterm check for already cleaned up terms.\nThe patch allows the definition of regex in a local unblocked_terms.txt file to\nsupersede a more generic blocked word defined in the global blocked_terms.txt file.\n\nBUG\u003dchromium:1129806\nTEST\u003drun pre-upload_unittest.py\n\nChange-Id: I591616492adb57a54ecb9771512d29f6e22f6a69\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2434032\nTested-by: Laurent Chavey \u003cchavey@google.com\u003e\nCommit-Queue: Laurent Chavey \u003cchavey@google.com\u003e\nReviewed-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Stephane Belmon \u003csbelmon@google.com\u003e\n" }, { "commit": "0dc1f943cd7d43565bc2cb64327a47fef8b98cc8", "tree": "c9863d6e745dbb5e66c415373e1a55bb9130273f", "parents": [ "1ed799d0cad50a9483dcdb66e7ae50f6333baf04" ], "author": { "name": "Bob Haarman", "email": "inglorion@chromium.org", "time": "Sat Oct 03 00:06:59 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 05 22:48:15 2020 +0000" }, "message": "pre-upload: inclusive wording in pre-upload.py and its unittest\n\nThis changes a few instances of {black,while}list to more descriptive\nand inclusive terms.\n\nBUG\u003dNone\nTEST\u003drepo upload (runs the unittest)\n\nChange-Id: Iae9042684634dcc477bfb1ca4ee382af21d79644\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2446073\nCommit-Queue: Bob Haarman \u003cinglorion@chromium.org\u003e\nTested-by: Bob Haarman \u003cinglorion@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\n" }, { "commit": "1ed799d0cad50a9483dcdb66e7ae50f6333baf04", "tree": "100f39ff3048784aca440d6502f12fb75a1ec95b", "parents": [ "bd8faf662fcb25c4cbeeb147db384ce3b49c72b1" ], "author": { "name": "Tom Hughes", "email": "tomhughes@chromium.org", "time": "Fri Sep 25 14:37:28 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 29 19:17:51 2020 +0000" }, "message": "pre-upload_unittest: Add tests for clang_format checks\n\nBUG\u003db:166166797\nTEST\u003d./pre-upload_unittest.py\n\nChange-Id: I0911e525b8de33138715c3e445203ac1ec01aeab\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2432964\nTested-by: Tom Hughes \u003ctomhughes@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nCommit-Queue: Tom Hughes \u003ctomhughes@chromium.org\u003e\n" }, { "commit": "bd8faf662fcb25c4cbeeb147db384ce3b49c72b1", "tree": "cea6f67ce7e657ef56f4b2a754dc72cd1bacbea1", "parents": [ "e3e47364bf0cee57e44456f24e0dee9d7c42be00" ], "author": { "name": "Tomasz Figa", "email": "tfiga@chromium.org", "time": "Tue Sep 22 14:06:05 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Sep 23 18:34:45 2020 +0000" }, "message": "pre-upload: Bypass checkpatch for UPSTREAM and FROMGIT cherry picks\n\nBypass checkpatch for UPSTREAM and FROMGIT commits, since we do not\nintend to modify the upstream commits when landing them to our branches.\nAny fixes should sent as independent patches.\n\nKeep the checks for FROMLIST and BACKPORT commits, as by definition they\ncan be still fixed up.\n\nBUG\u003db:169141405\nTEST\u003drepo upload a long chain of CHROMIUM, BACKPORT, UPSTREAM and\n FROMLIST commits.\n\nChange-Id: I9ba6329432477963eb3488af85bd01aa770d39bb\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2424266\nReviewed-by: Douglas Anderson \u003cdianders@chromium.org\u003e\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nReviewed-by: Guenter Roeck \u003cgroeck@chromium.org\u003e\nCommit-Queue: Tomasz Figa \u003ctfiga@chromium.org\u003e\nTested-by: Tomasz Figa \u003ctfiga@chromium.org\u003e\n" }, { "commit": "e3e47364bf0cee57e44456f24e0dee9d7c42be00", "tree": "e9f858aa0ad5afca3ab84c17bc572e33c9a786e8", "parents": [ "375b962859e686d1d419fd888d834b669e79e9d7" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Tue Sep 22 15:54:40 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Sep 23 02:46:25 2020 +0000" }, "message": "pre-upload: Separate paths from revisions with \u0027--\u0027\n\nCurrent \u0027git diff\u0027 command fails with the following error:\n\n fatal: ambiguous argument\n \u0027/chromiumos/src/platform/bmpblk/images/build_images.py\u0027:\n unknown revision or path not in the working tree.\n Use \u0027--\u0027 to separate paths from revisions, like this:\n \u0027git \u003ccommand\u003e [\u003crevision\u003e...] -- [\u003cfile\u003e...]\u0027\n\nHence, separate paths from revisions with \u0027--\u0027.\n\nBUG\u003dnone\nTEST\u003drepo upload . --cbr\n\nChange-Id: I06216ad2e677aa3e0912a39a7d3f3f6eec77e9f2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2423604\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nTested-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nAuto-Submit: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\n" }, { "commit": "375b962859e686d1d419fd888d834b669e79e9d7", "tree": "bcf13804c40aabfde0258ea74a0935a4b4ddac7e", "parents": [ "e8681680b6085aaeb30decf7f42bae0bf46888f9" ], "author": { "name": "Tomasz Figa", "email": "tfiga@chromium.org", "time": "Tue Sep 22 14:25:07 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 22 18:45:20 2020 +0000" }, "message": "pre-upload: Add missing r prefixes for regular expression strings\n\nAs per the linter:\n\n[FAILED] chromiumos/repohooks: cros lint\n Hook script \"cros lint ${PRESUBMIT_FILES}\" failed with code 1:\n ************* Module pre-upload\n pre-upload.py:572:3: W1401: Anomalous backslash in string: \u0027\\.\u0027. String constant might be missing an r prefix. (anomalous-backslash-in-string)\n pre-upload.py:637:3: W1401: Anomalous backslash in string: \u0027\\.\u0027. String constant might be missing an r prefix. (anomalous-backslash-in-string)\n 14:23:51: ERROR: Found lint errors in 1 files.\n\nBUG\u003dnone\nTEST\u003drepo upload a long chain of kernel commits\n\nChange-Id: Ic64e9c82766589f6d5480c38e0824ba6e7765414\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2424265\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: Tomasz Figa \u003ctfiga@chromium.org\u003e\nTested-by: Tomasz Figa \u003ctfiga@chromium.org\u003e\n" }, { "commit": "e8681680b6085aaeb30decf7f42bae0bf46888f9", "tree": "a6176175fa59eec980ed072079284cde900cd23a", "parents": [ "c6dad5a63325a2b2b05ed6600a31cc9db5d7c855" ], "author": { "name": "Bob Haarman", "email": "inglorion@chromium.org", "time": "Mon Sep 21 18:38:29 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 22 01:03:06 2020 +0000" }, "message": "Change /\\bnative\\b/ to /\\bnative/ in {,un}blocked_terms.txt\n\nThis change makes the language checks also flag words that have\n\"native\" as a prefix, in addition to the full word. This flags\nthings like \"natively\" and \"nativewindow\".\n\nBUG\u003dNone\nTEST\u003dgit grep a few repos; saw this flags some additional things\n we want to catch, and no things we don\u0027t want to catch.\n\nChange-Id: I7aa448f789b053bb55abc34cc52fd25951af341c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2422368\nCommit-Queue: Bob Haarman \u003cinglorion@chromium.org\u003e\nTested-by: Bob Haarman \u003cinglorion@chromium.org\u003e\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nReviewed-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\n" }, { "commit": "c6dad5a63325a2b2b05ed6600a31cc9db5d7c855", "tree": "aa95ec4e042f825f410022346c519015dc7c0130", "parents": [ "5bf0de874fe61df5f1c5b2ed9c2995933460a3fa" ], "author": { "name": "Bob Haarman", "email": "inglorion@chromium.org", "time": "Fri Sep 18 22:22:55 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Sep 21 19:11:53 2020 +0000" }, "message": "Adjust {,un}blocked_terms.txt to avoid matching \"alternative\"\n\nThe regexp /native/ matches things like \"alternative\", which is not\nintended to be a blocked term. This change adds word boundaries to\nthe regexp so that it only matches \"native\".\n\nBUG\u003dNone\nTEST\u003dRan searched_blocked_words.sh on code that contains \"alternatively\".\n\nChange-Id: I9888ea68d25b16b922d3abc1ac7bba7c98ef38d7\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2419228\nTested-by: Bob Haarman \u003cinglorion@chromium.org\u003e\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nReviewed-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nCommit-Queue: Bob Haarman \u003cinglorion@chromium.org\u003e\n" }, { "commit": "5bf0de874fe61df5f1c5b2ed9c2995933460a3fa", "tree": "c90dbe740ee34699da38d76f32ec85654b3e5a67", "parents": [ "b9de46b97edaa5bdcb96f4b8e629b7ceb6ce3049" ], "author": { "name": "Bernie Thompson", "email": "bhthompson@google.com", "time": "Fri Sep 11 15:53:43 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 17 00:28:44 2020 +0000" }, "message": "Adjust blocked_terms and unblocked_terms lists\n\nThere are some terms that are already sufficiently rare in use today that we\nshould be able to block them globally, this patch does so and adjusts the text\nin the terms files to account for it.\n\nWe enable blocking for:\nblack.?hat # 3 instances across 2 repos remain\nfirst.?class.?citizen # 40 instances across 15 repos remain\ngrandfathered # 4 instances across 4 repos remain\ngr[ae]y.?hat # 0 instances!\nwhite.?glove # 0 instances!\nwhite.?hat # 0 instances!\n\nBUG\u003dNone\nTEST\u003dVerified a CL with these now blocked terms fails presubmit, but other\nunblocked terms do not.\n\nChange-Id: I21bafa181cf31516cc86d20f0c8a3e276599a747\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2406757\nReviewed-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nTested-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nAuto-Submit: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "b9de46b97edaa5bdcb96f4b8e629b7ceb6ce3049", "tree": "05c6c0618c310bbfb33313662ca0ae4fc4372da4", "parents": [ "71c9c781e2403a33054be5b19c51fcd57eb6b92f" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Fri Sep 11 18:20:05 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sun Sep 13 19:58:44 2020 +0000" }, "message": "pre-submit: Unlink unblocked_terms.txt\n\nAs we make the codebase more inclusive, words will be removed from the\nglobal unblocked_terms.txt. This patch unlinks unblocked_terms.txt from\nblocked_terms.txt so that the former can be updated separately.\n\nBUG\u003db:165908442\nTEST\u003dNone\n\nChange-Id: I04693c65e723f2196bfca0c706d46b5cbd8cadfe\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2407016\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nTested-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "71c9c781e2403a33054be5b19c51fcd57eb6b92f", "tree": "615045c8ed9ddf8fa071b2a908648b00641cb6a1", "parents": [ "6140f57908689b08b6935feabccd4660abc8746b" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Thu Aug 20 15:12:36 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Sep 12 20:08:27 2020 +0000" }, "message": "pre-submit: Add reference to search_blocked_words.sh\n\nThis patch adds a reference to search_blocked_words.sh, which prints\nthe number of occurrences of blocked words.\n\nIt also adds a comment to unblocked_terms.txt to avoid removal.\n\nBUG\u003db:165908442\nTEST\u003dNone\n\nChange-Id: Id5926e66e9da5f8ecdd20d8f67b7670cb6b5f795\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2404957\nCommit-Queue: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nTested-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "6140f57908689b08b6935feabccd4660abc8746b", "tree": "37a7d56fcb53da8f3b31c3a4f4eaa82b0a8674f2", "parents": [ "2089e01b8f2c8c5f8125d7eee57dce4ead69f345" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Sep 10 04:52:46 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 10 17:50:43 2020 +0000" }, "message": "keyword_check: scan markdown files too\n\nBUG\u003db:165908442\nTEST\u003d`repo upload` in docs/ scans markdown files too\n\nChange-Id: I3eb6e87b913a181546ac39cdc2f62612d24d75c0\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2401364\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nCommit-Queue: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "2089e01b8f2c8c5f8125d7eee57dce4ead69f345", "tree": "79cad5efed9099164777fa6d1a4e0344975e36a5", "parents": [ "4e362925a4d80d1e834ea4f9f9502d1ea4a2d328" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Thu Aug 20 15:12:36 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Sep 05 05:24:02 2020 +0000" }, "message": "pre-submit: Populate blocked_terms.txt\n\nThis patch populates the global list of blocked words. The list of\nunblocked words are symlinked from the block list. Thus, nothing\nwill be blocked globally.\n\nunblocked_terms.txt in this directry is referenced only if it\ndoesn\u0027t exist in the project directory. It\u0027s expected to be copied\nto each project when a project is starting COIL. It will also serve\nas a TODO list to locally track the progress.\n\nSee README.md for how to use unblocked_terms.txt for your project.\n\nBUG\u003db:165908442\nTEST\u003dRun repo upload --cbr --dry-run .\n [COMMIT 1/1 7a40d010022f] test: blocked_terms.txt\n [FAILED] path/to/X: _check_keywords\n Found a blocked keyword in:\n .../main.c, line 41: Matched \"dog-pile\" with regex of \"dog.?pile\"\n\nChange-Id: Iea03b536d24a1a1c9590aebed162c6624166a343\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2369239\nTested-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\n" }, { "commit": "4e362925a4d80d1e834ea4f9f9502d1ea4a2d328", "tree": "f6f271375801b9f43cd8d460ff3ddefc8d0a80f7", "parents": [ "40bdce5e9eaddc183884191cfb803ff23450a1aa" ], "author": { "name": "Bernie Thompson", "email": "bhthompson@google.com", "time": "Wed Sep 02 16:17:50 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 04 23:19:11 2020 +0000" }, "message": "Enable blocked terms test to unblock multiple terms\n\nThe original logic was a bit off, it would only really work for a single term.\nThis fixes the logic and adds a unittest with two terms.\n\nBUG\u003dNone\nTEST\u003d./pre-upload_unittest.py\n\nChange-Id: I0a95e833b6343c5f2c3f0831ae80fefd342676e6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2391394\nCommit-Queue: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nTested-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "40bdce5e9eaddc183884191cfb803ff23450a1aa", "tree": "691aef9de7e9073ff6623949ac9df28c1ff0bb92", "parents": [ "f6a2977da9bf95e75bb9368b6b4a8d642228808f" ], "author": { "name": "Tom Hughes", "email": "tomhughes@chromium.org", "time": "Tue Aug 25 08:57:03 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 25 17:37:15 2020 +0000" }, "message": "pre-upload: fix typo\n\nBUG\u003dnone\nTEST\u003dnone\n\nChange-Id: Ie57e2caf6ea51e4f140e54afd5e2718d37b81152\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2375313\nCommit-Queue: Tom Hughes \u003ctomhughes@chromium.org\u003e\nCommit-Queue: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nTested-by: Tom Hughes \u003ctomhughes@chromium.org\u003e\nAuto-Submit: Tom Hughes \u003ctomhughes@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\n" }, { "commit": "f6a2977da9bf95e75bb9368b6b4a8d642228808f", "tree": "59760ff7224ffc5f66d972feb6e48b56024a3933", "parents": [ "180ecd6558b76903da5769f53cd5fff14ab47b97" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Aug 22 03:57:08 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Aug 22 19:42:24 2020 +0000" }, "message": "unittests: switch to Python 3 stdlib mock\n\nWe don\u0027t want to use the old external 3rd party module anymore,\nso switch to the stdlib version in Python 3 itself.\n\nBUG\u003dchromium:1015720\nTEST\u003dunittests pass\n\nChange-Id: I3fcdded0cbd9a89f3793928d5295f75f9b804e9d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2370107\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "180ecd6558b76903da5769f53cd5fff14ab47b97", "tree": "372fdfcbc209c5ce3f4e4bfa30a35f6fdc8224c8", "parents": [ "0f4cd7b5dcf2e09af8a629e77e85070fc312b8f7" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Aug 19 00:41:51 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 21 22:42:16 2020 +0000" }, "message": "pre-upload: support options for default enabled flags [reland]\n\nWe pull out hook options when the hook is explicitly enabled, but not\nwhen it\u0027s implicitly enabled by default. We haven\u0027t had any hooks as\nthose take options before so no one noticed.\n\nThe previous version had a logic error and enabled all non-common\nhooks by default. This adds more unittests to verify that doesn\u0027t\nhappen, and then fixes the logic to only auto-enable common hooks.\n\nBUG\u003db:162982485\nTEST\u003dunittests pass\n\nChange-Id: Ic3aac6f8469579cdd9cb47aa058f97c3b0389e27\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2368044\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "0f4cd7b5dcf2e09af8a629e77e85070fc312b8f7", "tree": "af1665c4d4cd93607e958729e90bac980a35541d", "parents": [ "04e1fc535837213fbe7b96ad8d6e7dfe54112aa8" ], "author": { "name": "David Burger", "email": "dburger@chromium.org", "time": "Wed Aug 19 23:16:02 2020 +0000" }, "committer": { "name": "David Burger", "email": "dburger@chromium.org", "time": "Wed Aug 19 23:39:33 2020 +0000" }, "message": "Revert \"pre-upload: support options for default enabled flags\"\n\nThis reverts commit 04e1fc535837213fbe7b96ad8d6e7dfe54112aa8.\n\nReason for revert: Causing BRANCH field checks and others failing repo uploads in other projects.\n\nOriginal change\u0027s description:\n\u003e pre-upload: support options for default enabled flags\n\u003e \n\u003e We pull out hook options when the hook is explicitly enabled, but not\n\u003e when it\u0027s implicitly enabled by default. We haven\u0027t had any hooks as\n\u003e those take options before so no one noticed.\n\u003e \n\u003e BUG\u003db:162982485\n\u003e TEST\u003dunittests pass\n\u003e \n\u003e Change-Id: Ib94acf043b2b4053ae67e704610a9b0417c8cbf5\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2363878\n\u003e Reviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n\u003e Tested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n\u003e Commit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n\nBug: b:162982485\nChange-Id: I943a71b7a3bc1e804d0b13b142c2048f534245fd\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2365219\nReviewed-by: David Burger \u003cdburger@chromium.org\u003e\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nTested-by: David Burger \u003cdburger@chromium.org\u003e\nCommit-Queue: David Burger \u003cdburger@chromium.org\u003e\n" }, { "commit": "04e1fc535837213fbe7b96ad8d6e7dfe54112aa8", "tree": "44331478877060d9e3d33027f5d8489bd621ece6", "parents": [ "8e26f74c6df0f507b46ab4e704c2d1816848539b" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Aug 19 00:41:51 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 19 21:08:36 2020 +0000" }, "message": "pre-upload: support options for default enabled flags\n\nWe pull out hook options when the hook is explicitly enabled, but not\nwhen it\u0027s implicitly enabled by default. We haven\u0027t had any hooks as\nthose take options before so no one noticed.\n\nBUG\u003db:162982485\nTEST\u003dunittests pass\n\nChange-Id: Ib94acf043b2b4053ae67e704610a9b0417c8cbf5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2363878\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "8e26f74c6df0f507b46ab4e704c2d1816848539b", "tree": "af1665c4d4cd93607e958729e90bac980a35541d", "parents": [ "0299a2bb19e29e063f9907ad44be6f31ff190323" ], "author": { "name": "Bernie Thompson", "email": "bhthompson@google.com", "time": "Thu Jul 23 14:32:31 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 18 21:47:07 2020 +0000" }, "message": "Add blocked keywords pre-upload test\n\nBUG\u003db:162982485\nTEST\u003dUnittest passes and can still run pre-upload check on a CL.\n\nChange-Id: I6c16e9b3111b3063145a3a34f5985bbb54f69085\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2316468\nTested-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\nReviewed-by: Paul Fagerburg \u003cpfagerburg@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "0299a2bb19e29e063f9907ad44be6f31ff190323", "tree": "2a227cb71ddaee5249ef90b031a2506fa296801b", "parents": [ "291d860727938e5fccdb9ecae9bf9dcd91b5e63e" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Fri Jul 31 18:20:43 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Aug 15 01:52:51 2020 +0000" }, "message": "pre-upload: Add virtual package versions for private chip/baseboard\n\nThe pre-upload script currently requires public and private chipset or\nbaseboard virtual packages to have the same version numbers. This makes\nno sense (if they both exist they shouldn\u0027t have the same version\nnumber, private should override public). This patch introduces 1.8.5 and\n1.9.5 as the private equivalent for 1.8 and 1.9.\n\nAlso fix an existing bug with version numbers containing more than 2\ncomponents.\n\nBUG\u003db:119578707\nTEST\u003dUploaded a patch using these numbers.\n\nChange-Id: Iae06197aba2c7ae1816406c2ab01b861e67d6a71\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2333282\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nTested-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "291d860727938e5fccdb9ecae9bf9dcd91b5e63e", "tree": "cd1ece81fc9cd747a9938f58b68697fcfc96ef6e", "parents": [ "5dda600d09f90f17f5d1898bb704a2154e14e08e" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Fri Jul 31 17:34:02 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 14 22:38:35 2020 +0000" }, "message": "pre-upload: Allow exec_files check to be disabled\n\nThis patch allows PRESUBMIT.cfg files to disable the check for files\nincorrectly marked as executable. Of course, normally this check should\nnever be disabled and the sources should be fixed instead. However, in\ncertain repositories (e.g. firmware blob sources) we check in large\nunmodified drops of vendor code. Depending on how we get those drops\n(e.g. checkout from a different Git remote), they may already come with\nexecutable permissions set, and those permissions may be wrong. There is\nlittle point in tasking the Googler checking in this code with cleaning\nup all those permissions -- they\u0027d be incorrect with the next drop again\nanyway, and with some vendors there is little hope of getting them to\nclean up something like this on their end.\n\nBUG\u003db:119578707\nTEST\u003dNone\n\nChange-Id: I58c0811ce2d62b967c9773eeb82c7780c3c4f7cf\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2333280\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "5dda600d09f90f17f5d1898bb704a2154e14e08e", "tree": "9a6801d21a73bb55499fde02ade8fc345a454905", "parents": [ "5a905eaa134f93f449db0f0fcdc4767244d78076" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Aug 04 11:20:37 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 04 15:43:50 2020 +0000" }, "message": "fix OWNERS path\n\nThe find owners module will use the path in the current repo as the\nimplicit prefix even when crossing repo boundaries, so make sure we\nhave an explicit / anchor when loading from chromite. It doesn\u0027t\nmake a difference in this repo, but might as well avoid copy \u0026 paste\nconfusion.\n\nBUG\u003dNone\nTEST\u003dfind owners can find owners for this\n\nChange-Id: Ie94e555d39c7d4ef9f6f09e6a90c5875e4077419\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2332369\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Stephane Belmon \u003csbelmon@google.com\u003e\nCommit-Queue: Stephane Belmon \u003csbelmon@google.com\u003e\n" }, { "commit": "5a905eaa134f93f449db0f0fcdc4767244d78076", "tree": "3d3829c16768d15b33d2b0cee67adb92c91e7947", "parents": [ "6ab73fd03cb67789eebbba4dc3445a42d6d3630b" ], "author": { "name": "Sonny Sasaka", "email": "sonnysasaka@chromium.org", "time": "Fri Jul 24 15:30:12 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 31 23:17:25 2020 +0000" }, "message": "pre-upload: Add option for presubmit config file\n\nSome projects do not have its own PRESUBMIT.cfg (e.g. because it\u0027s a\nmirror of upstream). This patch adds an option to pre-upload.py to\nspecify a PRESUBMIT.cfg file to be used.\n\nBUG\u003db:159724354\nTEST\u003din src/third_party/bluez/upstream, do:\n/path/to/pre-upload.py --presubmit-config\u003d../current/PRESUBMIT.cfg\n\nChange-Id: Ife2c8df45a37883bf4149152730252e3fe968b19\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2318275\nTested-by: Sonny Sasaka \u003csonnysasaka@chromium.org\u003e\nCommit-Queue: Sonny Sasaka \u003csonnysasaka@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "6ab73fd03cb67789eebbba4dc3445a42d6d3630b", "tree": "ddbb8b52434a5200762cd8589bc95b1fd1f09daf", "parents": [ "1da56d501a24fbf357902c0f70bd9f301fbdb7f9" ], "author": { "name": "Keiichi Watanabe", "email": "keiichiw@chromium.org", "time": "Tue Jul 14 23:42:02 2020 +0900" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jul 28 16:29:04 2020 +0000" }, "message": "pre-upload.py: Add hook to run cargo clippy\n\nAdd a hook `check_cargo_clippy` to run cargo clippy in pre-upload.py.\nThis hook is opt-in and clippy runs only when files in specified Cargo\nprojects were modified.\n\nBUG\u003dchromium:1105466\nTEST\u003drepo upload a Rust CL\nTEST\u003dpre-upload_unittest.py\n\nChange-Id: I6cd642457125d1f76c87b0f6db19a2c36ab28c95\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2297362\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Keiichi Watanabe \u003ckeiichiw@chromium.org\u003e\nTested-by: Keiichi Watanabe \u003ckeiichiw@chromium.org\u003e\n" }, { "commit": "1da56d501a24fbf357902c0f70bd9f301fbdb7f9", "tree": "32786a688dd58acd76dba87d8f6786e06ba15fd5", "parents": [ "4cee050efc3512485b3f5ac6460388052fc266b6" ], "author": { "name": "Chirantan Ekbote", "email": "chirantan@chromium.org", "time": "Mon Jul 13 17:35:35 2020 +0900" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jul 13 15:26:07 2020 +0000" }, "message": "pre-upload.py: Use 2018 edition for rustfmt\n\nasync/await is only allowed with the 2018 edition for rust and this was\ncausing upload hook errors for files that contained those keywords.\n\nBUG\u003dnone\nTEST\u003drun hooks on a file with async/await and see that it doesn\u0027t fail\n\nChange-Id: I19b730a62cccb7f4f08b2ad6e022a661bf7c345b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2294657\nTested-by: Chirantan Ekbote \u003cchirantan@chromium.org\u003e\nAuto-Submit: Chirantan Ekbote \u003cchirantan@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "4cee050efc3512485b3f5ac6460388052fc266b6", "tree": "6547d45edfac04be6f5b5a3d0d5f6eb3fc714c94", "parents": [ "27b542899e1cc51c093114ca3d8dc0501043d53d" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Fri Jun 12 17:02:56 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jun 17 01:42:17 2020 +0000" }, "message": "pre-upload.py: support per-project checkpatch.pl\n\nProjects often carry their own checkpatch.pl, and the imprecise and\nalways-changing nature of the script means it\u0027s best (e.g., for false\nnegatives/positives) to match the local project with its script.\n\nAllow that in PRESUBMIT.cfg, e.g.:\n\n # kernel project\n [Hook Overrides Options]\n checkpatch_check: ./scripts/checkpatch.pl\n\n # coreboot\n [Hook Overrides Options]\n checkpatch_check: ./util/lint/checkpatch.pl --some\u003dother --options\n\nBUG\u003dnone\nTEST\u003dpre-upload.py on coreboot, kernel, etc., with and without .cfg\n changes\n\nChange-Id: I948188a98bd7c788d6a951dccd0928d76bdc4f0c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2243934\nTested-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Brian Norris \u003cbriannorris@chromium.org\u003e\n" }, { "commit": "27b542899e1cc51c093114ca3d8dc0501043d53d", "tree": "d515004e4188889653000c73d07229a3a0add011", "parents": [ "85848e522e7c6f8cd00c1c8c933d64594f4fdfcc" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Jun 15 14:44:37 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jun 16 01:38:41 2020 +0000" }, "message": "pre-upload: disallow gyp everywhere\n\nEveryone is migrated at this point.\n\nBUG\u003dchromium:960215\nTEST\u003dCQ passes\n\nChange-Id: I7605e94d05679e9669817675a692143c6a32a5f3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2246843\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nAuto-Submit: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Keigo Oka \u003coka@chromium.org\u003e\nCommit-Queue: Keigo Oka \u003coka@chromium.org\u003e\n" }, { "commit": "85848e522e7c6f8cd00c1c8c933d64594f4fdfcc", "tree": "90423d3950ba12f96169a88a444c583bd455c242", "parents": [ "c6114f44cc9590ef9681182a1215a3ee6022ae5d" ], "author": { "name": "Drew Davenport", "email": "ddavenport@chromium.org", "time": "Wed Jan 15 14:40:29 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jun 10 19:32:42 2020 +0000" }, "message": "pre-upload: Allow projects to ignore SoB altogether\n\nMake signoff_check tri-state - force on, force off, unspecified. If\nunspecified, signoff_check will be enabled, which is the current\nbehavior.\n\nSome projects, such as mesa-amd, track an upstream project where usage\nof Signed-Off-By is not enforced, nor is it rejected. Allow such\nprojects to ignore the SoB tag altogether during pre-upload checks.\n\nBUG\u003dnone\nTEST\u003dAttempt repo upload dryrun in kernel, platform2, and mesa-amd projects\n with and without SoB tags\n\nChange-Id: I4f0d553988f5e5b4248559bf0b9bb6e72c611e24\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2003452\nTested-by: Drew Davenport \u003cddavenport@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\nCommit-Queue: Drew Davenport \u003cddavenport@chromium.org\u003e\n" }, { "commit": "c6114f44cc9590ef9681182a1215a3ee6022ae5d", "tree": "6c68eba77ce641e3d1c6061c69d495a3503ea249", "parents": [ "f896194cab654d035a4fd99607f2a4687895b1cc" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri May 15 00:55:05 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 15 18:44:05 2020 +0000" }, "message": "pre-upload: eapi: recommend people move to EAPI\u003d7\n\nBUG\u003dNone\nTEST\u003dupload unittests pass\n\nChange-Id: Iaace669ed7f5f19827a1da4ea1e35cd9e2c2b20b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2203549\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "f896194cab654d035a4fd99607f2a4687895b1cc", "tree": "6b40c82442a1ffd7b73bf4db16bf141cbbb98e8d", "parents": [ "69d3e18502d1cb317938ab86cf94aba2ee8e608f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri May 15 00:36:31 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 15 16:44:53 2020 +0000" }, "message": "pre-upload: long lines: handle Python \u0026 Rust better\n\nSince Python is run through pylint which has much better checking\nlogic, don\u0027t bother enforcing long lines at all.\n\nWhile we\u0027re here, fix Rust\u0027s line length to 100 per rustfmt.\n\nBUG\u003dchromium:870016\nTEST\u003d`repo upload` no longer complains in chromite/\n\nChange-Id: I920d181f52513152af6e62dececb513b4a9fdb01\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2202752\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "69d3e18502d1cb317938ab86cf94aba2ee8e608f", "tree": "2232fc2f431525beb50bfaf3b488144f01d4e2f2", "parents": [ "fb5e8bf47e1ce3b827dca136c26bfe5256565d58" ], "author": { "name": "LaMont Jones", "email": "lamontjones@chromium.org", "time": "Wed Mar 11 15:00:53 2020 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 12 17:09:25 2020 +0000" }, "message": "pre-upload.py: --pre-submit has no description\n\n`pre-upload.py --pre-submit` failed printing commit description.\n\nBUG\u003dchromium:1060760\nTEST\u003dmanually verified\n\nChange-Id: I15eb3a9c41529c40a3ffa2ac28ff1b3bfc7d9ae3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2098999\nTested-by: LaMont Jones \u003clamontjones@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: LaMont Jones \u003clamontjones@chromium.org\u003e\nAuto-Submit: LaMont Jones \u003clamontjones@chromium.org\u003e\n" }, { "commit": "fb5e8bf47e1ce3b827dca136c26bfe5256565d58", "tree": "e228ddd9fa370c89ca7e725b193efedc63292862", "parents": [ "ff4768e4f73088145ec7e380dbb3cefd5872c658" ], "author": { "name": "LaMont Jones", "email": "lamontjones@chromium.org", "time": "Tue Mar 03 12:50:06 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 03 22:15:06 2020 +0000" }, "message": "pre-upload: Cq-Include-Trybots is valid in footer.\n\nAllow Cq-Include-Trybots: tag in footer to land alphabetically with\nChange-Id.\n\nBUG\u003dNone\nTEST\u003dunit tests pass\n\nChange-Id: I5bfbe0d3879ae5261022c01520b716bd43feae63\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2085658\nTested-by: LaMont Jones \u003clamontjones@chromium.org\u003e\nAuto-Submit: LaMont Jones \u003clamontjones@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\n" }, { "commit": "ff4768e4f73088145ec7e380dbb3cefd5872c658", "tree": "423e4aa6665450df815ba4e751ce2e491a3277f5", "parents": [ "775c2b373090f081e4c0cad9f9db62cc6845b002" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Feb 27 18:48:13 2020 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Feb 28 15:27:06 2020 +0000" }, "message": "require Python 3.6+\n\nWe switched the shebangs, but add an explicit version check too\nlike we\u0027ve started doing in chromite.\n\nBUG\u003dchromium:1003955\nTEST\u003d`repo upload` works with python3\n\nChange-Id: Ica9dede81305db8b74af8cfe622cda20aa4f52da\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2079672\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "775c2b373090f081e4c0cad9f9db62cc6845b002", "tree": "be5db8b3f88b0b3f2441436196a80cf9da0b6f38", "parents": [ "872fe761f66e6f7833ffa9693c37bde48cd06ac7" ], "author": { "name": "LaMont Jones", "email": "lamontjones@chromium.org", "time": "Wed Feb 19 17:32:54 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Feb 20 02:08:52 2020 +0000" }, "message": "pre-upload: Also exclude OWNERS.* from license check\n\nWe also have OWNERS.${stuff} files.\n\nBUG\u003dNone\nTEST\u003dcrrev.com/i/2592233 passes\n\nChange-Id: I8b0683d0badfbee2656a7ab808e9a9beb4da40e2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2065833\nTested-by: LaMont Jones \u003clamontjones@chromium.org\u003e\nAuto-Submit: LaMont Jones \u003clamontjones@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "872fe761f66e6f7833ffa9693c37bde48cd06ac7", "tree": "8e5cf930b44be85815ffdb14fc64bdaa059a7f66", "parents": [ "b707c52be93ed52d3e965e7c344adac291a2bdee" ], "author": { "name": "LaMont Jones", "email": "lamontjones@chromium.org", "time": "Mon Feb 10 15:36:14 2020 -0700" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Feb 10 23:06:07 2020 +0000" }, "message": "pre-upload: allow gofmt_check to be overridden\n\nProtoc generates files that do not pass gofmt linting (due to line\nlengths). Allow a repo to specify which golang files should be included\nand/or excluded in the gofmt check.\n\nBUG\u003dNone\nTEST\u003dinfra/proto repo can override\n\nChange-Id: I73f2012dabba03a981b52ea31d5be24d7a3774c5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2048136\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: David Burger \u003cdburger@chromium.org\u003e\nTested-by: LaMont Jones \u003clamontjones@chromium.org\u003e\n" }, { "commit": "b707c52be93ed52d3e965e7c344adac291a2bdee", "tree": "8617ed5d5bf9606afe02e290207855fcc96aa437", "parents": [ "380592f72e3057aea62c2448b966ac2de33b2318" ], "author": { "name": "Cheng Yueh", "email": "cyueh@google.com", "time": "Thu Jan 02 14:06:59 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Feb 04 12:53:56 2020 +0000" }, "message": "pre-upload: Check no BUG line after TEST line.\n\nIn the Chromium OS Contributing Guide, we state that BUG line must be\nbefore TEST line. This CL checks this in pre-upload.py.\n\nBUG\u003dNone\nTEST\u003dpre-upload_unittest.py\n\nChange-Id: I03a5669b3ff2749bc905fd113d1bc66555217251\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1985506\nCommit-Queue: Cheng Yueh \u003ccyueh@chromium.org\u003e\nTested-by: Cheng Yueh \u003ccyueh@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "380592f72e3057aea62c2448b966ac2de33b2318", "tree": "d0914e580d03a0760aac1dc582ebc69212cb1ebd", "parents": [ "237f3efeddd112777bb3ccaf91f3c7f32efa70e9" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Feb 03 15:27:16 2020 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Feb 04 03:11:47 2020 +0000" }, "message": "pre-upload: fix fallback hook loading with some configs\n\nWe set up some defaults at the end of _get_override_hooks, but these\nonly get added when the config has a [Hook Overrides] section. Rework\nthe code so we always add the defaults.\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: If589e9f1ca881f262f1feb9f32efbf37e339a224\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2036671\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "237f3efeddd112777bb3ccaf91f3c7f32efa70e9", "tree": "eb1f8d2fc3d532af5e1bb36c5e42704ccab71ca6", "parents": [ "5aae3f78992b7b2dd9b19a6899c9220bd8011a70" ], "author": { "name": "LaMont Jones", "email": "lamontjones@chromium.org", "time": "Wed Jan 22 10:40:52 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 22 19:11:39 2020 +0000" }, "message": "Allow Cq-Cl-Tag to follow Change-Id.\n\nPUpr CLs have this tag.\n\nBUG\u003dchromium:1039875\nTEST\u003dtryjob\n\nChange-Id: Ia95312296a5bf31de64834631a7351e37d1e6540\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2015129\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\nTested-by: LaMont Jones \u003clamontjones@chromium.org\u003e\nCommit-Queue: LaMont Jones \u003clamontjones@chromium.org\u003e\n" }, { "commit": "5aae3f78992b7b2dd9b19a6899c9220bd8011a70", "tree": "596d9fad1e2a782b7914820a1588818fb2ef86f5", "parents": [ "d0c5c8bba8d0708ed1350f3ba8aa0a0a5a4fe3ed" ], "author": { "name": "Ayato Tokubi", "email": "tokubi@google.com", "time": "Thu Jan 16 17:43:47 2020 +0900" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jan 17 00:47:35 2020 +0000" }, "message": "repohooks: allow java file to contain 100 chars\n\nJava files are allowed to contain 100 chars, not 80 chars.\n\nChromium Java style guide\nhttps://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md\nIt says \"Chromium follows the Android Open Source style guide unless an\nexception is listed below.\"\n\nAccording to AOSP Java Code Style for Contributors,\nhttps://source.android.com/setup/contribute/code-style#limit-line-length\n\"Each line of text in your code should be at most 100 characters long.\"\n\nThis CL allows Java files to contain over 80 chars under 100 chars.\n\nBUG\u003dNone\nTEST\u003dpre-upload_unittest.py\n\nChange-Id: I89143ea40316725a4c874be3ca545cb396a2bf61\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2004310\nTested-by: Ayato Tokubi \u003ctokubi@google.com\u003e\nCommit-Queue: Ayato Tokubi \u003ctokubi@google.com\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\nReviewed-by: Tatsuhisa Yamaguchi \u003cyamaguchi@chromium.org\u003e\nReviewed-by: Shuhei Takahashi \u003cnya@chromium.org\u003e\n" }, { "commit": "d0c5c8bba8d0708ed1350f3ba8aa0a0a5a4fe3ed", "tree": "258bf4f13acc987c53a072e96ee7fa9d1aaba4a4", "parents": [ "ed1b95a44b38f2a2a1fe82747524344c7710074c" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Dec 17 02:28:26 2019 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Dec 17 19:37:39 2019 +0000" }, "message": "pre-upload: migrate away from combine_stdout_stderr\n\nWe\u0027re dropping this in favor of a more standard naming.\n\nBUG\u003dchromium:1006587\nTEST\u003d`repo upload` still works\n\nChange-Id: Icc4e6d122f1f103078c61a83dc45f14dfdfda8ce\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1971370\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "ed1b95a44b38f2a2a1fe82747524344c7710074c", "tree": "a4e9a8ec74f47e212398b7113d0116cf1fadc79d", "parents": [ "ed9b2a07665e1531f9e81bd42ef94d789de2c004" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Dec 12 19:04:51 2019 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 13 05:25:37 2019 +0000" }, "message": "pre-upload: overhaul commit progress output\n\nOur existing output shows each commit \u0026 hook being run, and then\ndumps the full failure messages at the end. Lets switch to the\nstyle used in AOSP repohooks where output is more dynamic and\nimmediate when things go wrong. For single commits this isn\u0027t a\nbig deal, but for multiple commits, this can be huge.\n\nBUG\u003dNone\nTEST\u003d`repo upload` shows commit progress\n\nChange-Id: I5b14488b7fe22f9d2e29adf7201db7f00590872a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1965403\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "ed9b2a07665e1531f9e81bd42ef94d789de2c004", "tree": "e3bbd8b9954b3a77a31e4a5f3604c7ef7522c3ac", "parents": [ "550c05c67d27b1a2db03a13c298a64f67bd8f48c" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Dec 12 18:52:32 2019 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 13 03:15:30 2019 +0000" }, "message": "pre-upload: link to commit message documentation more\n\nBUG\u003dNone\nTEST\u003d`repo upload` w/bad CL includes link to docs\n\nChange-Id: Ieb30fe943106c3e2345f6da03c7f07e27e454447\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1965401\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "550c05c67d27b1a2db03a13c298a64f67bd8f48c", "tree": "f24f194bc277ce1387305538f823f581cbcb1c92", "parents": [ "f252cfcd7e1e896530c9876d0461bfcffdff3924" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Dec 09 18:16:36 2019 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Dec 11 00:13:36 2019 +0000" }, "message": "pre-upload: drop support for COMMIT-QUEUE.ini\n\nWe aren\u0027t checking this file anymore.\n\nBUG\u003dchromium:1025955\nTEST\u003dCQ passes\n\nChange-Id: I8d753b63647715ffd192d42f38f36b21f93ee3e9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1959697\nReviewed-by: Sean Abraham \u003cseanabraham@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "f252cfcd7e1e896530c9876d0461bfcffdff3924", "tree": "b3bde624685198383379892e92d4e6394a613607", "parents": [ "e39d0cd4025c21dfc1da385702f99fe0cea15aac" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Dec 09 17:34:28 2019 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Dec 10 22:18:50 2019 +0000" }, "message": "drop python 2 support\n\nLatest repo should make sure this always runs under Python 3.\nDrop support for Python 2 now.\n\nBUG\u003dchromium:1003955\nTEST\u003d`repo upload` works\n\nChange-Id: I119c76f196c113e61216412e36b1be478069a55f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1958809\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "e39d0cd4025c21dfc1da385702f99fe0cea15aac", "tree": "ddc3ff37cd644ffa6038fe5e4a65230a3a6fea4d", "parents": [ "6d28b59e84d0c198b4616a2a6e8860b2d1f9726e" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Nov 25 13:30:06 2019 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 25 19:41:26 2019 +0000" }, "message": "pre-upload: reject CQ-DEPEND lines\n\nThese were only for the old CQ system. We use Cq-Depend: tags now.\nReject the old style to help people migrate.\n\nBUG\u003dNone\nTEST\u003d`repo upload` works\n\nChange-Id: I442b093be67bbc237c5a49ff346b569214c44068\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1933029\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Brian Norris \u003cbriannorris@chromium.org\u003e\n" }, { "commit": "6d28b59e84d0c198b4616a2a6e8860b2d1f9726e", "tree": "a940d6efcda7a6f8b227f0035c5f5d3495a04df9", "parents": [ "054c15962c7d1f84720f0a3ca44286fc30c06258" ], "author": { "name": "Sean Abraham", "email": "seanabraham@chromium.org", "time": "Fri Nov 22 15:13:45 2019 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 22 23:31:47 2019 +0000" }, "message": "pre-upload: remove Legacy-Commit-Queue references\n\nThis label is never used by anything anymore.\n\nBUG\u003dchromium:1027747\nTEST\u003dnone\n\nChange-Id: Ie10785df706e27135259ea74bb32dcd848df31c4\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1930935\nTested-by: Sean Abraham \u003cseanabraham@chromium.org\u003e\nAuto-Submit: Sean Abraham \u003cseanabraham@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nCommit-Queue: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\n" }, { "commit": "054c15962c7d1f84720f0a3ca44286fc30c06258", "tree": "da2c01d91635470b14cea08e131b7194bb8b99e6", "parents": [ "9ab64b1112f9a2723124b6c5a0fa95bf4d7c4ba5" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Nov 18 03:51:54 2019 -0500" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Nov 18 18:34:54 2019 +0000" }, "message": "pre-upload: one more RunCommand-\u003erun change\n\nMissed this in the previous update.\n\nBUG\u003dchromium:1006587\nTEST\u003d`./run_tests` passes\n\nChange-Id: I4088c40ffd7e65042a3a4d84ca7b0f404312416a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1917973\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "9ab64b1112f9a2723124b6c5a0fa95bf4d7c4ba5", "tree": "f6f9072e852b1720784d005cf508f5e1d7aa34f5", "parents": [ "45334bd5da3d7320bbd5be78468d3ba0e9482062" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Nov 04 10:53:08 2019 -0500" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sun Nov 17 04:08:23 2019 +0000" }, "message": "pre-upload: reject Signed-off-by tags by default\n\nThese make sense in a few specific repos, but not the majority.\nStart rejecting them so people stop adding theme everywhere.\n\nBUG\u003dNone\nTEST\u003dupload still works\n\nChange-Id: Ie62b68d4804e5cc7540e1a2050d47be5a70d5537\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1917972\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "45334bd5da3d7320bbd5be78468d3ba0e9482062", "tree": "b3716fd1d008692aa1e5cad75a122a061720f4d0", "parents": [ "4efdee77d91054f8739f3bca6fa5c261a2237962" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Nov 04 10:42:33 2019 -0500" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Nov 13 07:37:37 2019 +0000" }, "message": "pre-upload: reject BRANCH tags by default\n\nThese make sense in a few specific repos, but not the majority.\nStart rejecting them so people stop adding them everywhere.\n\nBUG\u003dNone\nTEST\u003dupload still works\n\nChange-Id: Ic33c7861e3973b6902a2649579b18eb936da8db9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1894703\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "4efdee77d91054f8739f3bca6fa5c261a2237962", "tree": "9bc2533393b876c3b734d533875a8fa0ea06f0b2", "parents": [ "7bb709f03c23feff254ba84ca8589d62738e0163" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Nov 04 10:57:01 2019 -0500" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Nov 11 21:46:23 2019 +0000" }, "message": "pre-upload: get the raw commit message\n\n%s/%b sanitize the commit message, but we really want to see the\nexact original value so we can run our verification on it.\n\nAlso improve the commit message checker to link to our docs.\n\nBUG\u003dNone\nTEST\u003duploading a bad commit message is rejected\n\nChange-Id: Idfea8c4f9f138def1137c14a0e69e3487208ec1a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1894704\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "7bb709f03c23feff254ba84ca8589d62738e0163", "tree": "91fccfde39e5e8b89cbe2d3c7ad05db1fc6c6799", "parents": [ "3cbb8dd004364694774a941d6d3c7ee64fc9620e" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sun Sep 29 23:20:12 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Nov 04 13:30:22 2019 -0800" }, "message": "migrate cros_build_lib.run APIs\n\nThe RunCommand APIs have been renamed, so migrate to the new ones.\n\nBUG\u003dchromium:1006587\nTEST\u003dunittests passes\n\nChange-Id: Iaaada46aad600b7e58891388865f6ea96db34b18\nReviewed-on: https://chromium-review.googlesource.com/1897284\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\n" }, { "commit": "3cbb8dd004364694774a941d6d3c7ee64fc9620e", "tree": "21457a29a4b5e55ea36cc15f5f83c4cedbb9dbbd", "parents": [ "7e11517b28762175cf24adbfc53f330c1717b6db" ], "author": { "name": "Shuhei Takahashi", "email": "nya@chromium.org", "time": "Tue Oct 29 12:37:11 2019 +0900" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Oct 29 00:42:23 2019 -0700" }, "message": "pre-upload: Do not ignore errors in PRESUBMIT.cfg.\n\nWe used to fall back to an empty config if we fail to parse\nPRESUBMIT.cfg. But it\u0027s very error-prone because an accidental\nerror in PRESUBMIT.cfg leads to disabling all preupload hooks\nsilently.\n\nBUG\u003dchromium:1019067\nTEST\u003drepo upload # in third_party/autotest/files; fails\n\nChange-Id: I8c2f446eff4fceaba3a0f1373b5237b1afca67bc\nReviewed-on: https://chromium-review.googlesource.com/1885930\nTested-by: Shuhei Takahashi \u003cnya@chromium.org\u003e\nCommit-Ready: Shuhei Takahashi \u003cnya@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "7e11517b28762175cf24adbfc53f330c1717b6db", "tree": "a233aa1a9c8d4eb37d7e4d576a534b2514a12579", "parents": [ "4f99440f9ce88081fbbbbe9960e76479d67cda8a" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Oct 23 01:17:50 2019 -0400" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Oct 23 21:56:06 2019 +0000" }, "message": "run unittests through py2 \u0026 py3\n\nThis should help keep from regressing.\n\nBUG\u003dchromium:1003955\nTEST\u003d`repo upload` works\n\nChange-Id: I2af2b3c03f88163913c19e3e018f949ed7c76b86\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1875509\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "4f99440f9ce88081fbbbbe9960e76479d67cda8a", "tree": "8debefa431a5f40a83b60f0200782d861854eded", "parents": [ "960129a8839b1bf72ef0a5f3007d05b1be07d5b6" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 13 17:40:45 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Oct 23 14:25:18 2019 -0700" }, "message": "switch shebangs to python3\n\nThis will make `repo upload` execute us using python3 all the time.\nWe keep the Python 2 logic in place in case we need to rollback.\nWe can do this now that enough of chromite supports Python 3.\n\nBUG\u003dchromium:1003955\nTEST\u003d`repo upload` works with python3\n\nChange-Id: I7d25cf2b9cbbec8f0303ed68b02e1d9144b81b73\nReviewed-on: https://chromium-review.googlesource.com/1875508\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "960129a8839b1bf72ef0a5f3007d05b1be07d5b6", "tree": "31dcd09a13e50f743e4488cd5f8e412935b6cf0a", "parents": [ "aa7dc943f9ac356eb700331884ece7f0d4c6421c" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Sep 30 00:54:15 2019 -0400" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Sep 30 17:18:50 2019 +0000" }, "message": "cros_build_lib.run: rename stdout_to_pipe\u003dTrue to redirect_stdout\u003dTrue\n\nWe\u0027re dropping this in the run API, so switch to redirect_stdout.\n\nBUG\u003dchromium:1006587\nTEST\u003d`./run_tests` passes\n\nChange-Id: Id453898b8d036d2037fc698ecc3fbe8e2da19ba0\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/1831321\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "aa7dc943f9ac356eb700331884ece7f0d4c6421c", "tree": "3838cb152ce4469d2ab6a515b6374935c27378e5", "parents": [ "653cd268f7a9e6ae269fd8a92a6616817e7d5f2f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Sep 25 00:07:24 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Sep 24 23:34:37 2019 -0700" }, "message": "pre-upload: convert command inputs to bytes\n\nMake sure the input to commands are bytes rather than unicode\nstrings so the implicit ASCII conversion doesn\u0027t crash.\n\nBUG\u003dchromium:1007606\nTEST\u003d`reop upload` w/CL:1813597 passes\n\nChange-Id: Id3bc598f1a6fb7359d2bc409063f939e98499e17\nReviewed-on: https://chromium-review.googlesource.com/1823884\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Fergus Dall \u003csidereal@google.com\u003e\nReviewed-by: Shuhei Takahashi \u003cnya@chromium.org\u003e\n" }, { "commit": "653cd268f7a9e6ae269fd8a92a6616817e7d5f2f", "tree": "db72ee3b8b049c63086a617188e510f5cd327b79", "parents": [ "8cf8081300fe06e949aee4f044fcb879642fb036" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 20 14:05:02 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 20 16:36:39 2019 -0700" }, "message": "pre-upload: tweak sys.path patching style a bit\n\nThis should make the scope here a bit more clear.\n\nBUG\u003dchromium:1003955\nTEST\u003dunittests still pass\n\nChange-Id: Idbf76bdf77beb5760e6795c80dbef3ce949ccb8b\nReviewed-on: https://chromium-review.googlesource.com/1816124\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "8cf8081300fe06e949aee4f044fcb879642fb036", "tree": "9a76f720f5e02125ec50aaaf80e18e4a35e2f6ff", "parents": [ "f1ee2bf162cc95242dd11075d25786719f71a59c" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Sep 16 23:49:29 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 20 16:36:38 2019 -0700" }, "message": "clean up inconsistent-return-statements warnings\n\nBasically add \u0027return None\u0027 instead of relying on implicit returns.\n\nBUG\u003dchromium:980619\nTEST\u003d`cros lint` is clean w/pylint-1.7 again\n\nChange-Id: I27557730f54871c84d268624624270dd17cf804b\nReviewed-on: https://chromium-review.googlesource.com/1816123\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "f1ee2bf162cc95242dd11075d25786719f71a59c", "tree": "da87af70bd6631fe01a2af99184f0514a68ee04d", "parents": [ "e52b1bc12f1d8c03f701282bb2bbb719663749f6" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Sep 16 23:47:33 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 20 16:36:37 2019 -0700" }, "message": "move away from Exception.message\n\nPython 2.6 deprecated the Exception.message field and Python 3 has\ndropped it entirely. Using str() on the exception should get us\nall the same info, so switch to that (or implicitly so when using\n%s with formatting output).\n\nBUG\u003dchromium:980619\nTEST\u003d`cros lint` is clean w/pylint-1.7 again\n\nChange-Id: I5c4324ff0f2a81485e7a9091a50bf0c56a73c4f7\nReviewed-on: https://chromium-review.googlesource.com/1816122\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "e52b1bc12f1d8c03f701282bb2bbb719663749f6", "tree": "781d4ec028be1dc845c5c00f52254853249b8d1d", "parents": [ "8a4e8948980fa0085503345013c62db81970dd08" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Sep 16 23:45:41 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 20 16:36:37 2019 -0700" }, "message": "lint: clean up len-as-condition warnings\n\nRather than count iterables just to test equality to 0, use their\nimplicit truthiness instead. Shouldn\u0027t be any functional changes.\n\nBUG\u003dchromium:980619\nTEST\u003d`cros lint` is clean w/pylint-1.7 again\n\nChange-Id: I3ebf4f3dc51bed492caaa85d14b87239f61d3a6c\nReviewed-on: https://chromium-review.googlesource.com/1816121\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "8a4e8948980fa0085503345013c62db81970dd08", "tree": "9c49c506da5f2dd1e7bdfd08009a281746d9d4cd", "parents": [ "fd481cec30f6566594c391cb815bd8e1de3466e4" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Sep 16 23:43:49 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 20 16:36:36 2019 -0700" }, "message": "unittests: change self.assertEquals to self.assertEqual\n\nThe unittest module has deprecated the former name.\n\nBUG\u003dchromium:980619\nTEST\u003d`cros lint` is unchanged\n\nChange-Id: I75a563474cc2dbd45b7163698232dd8dec3ccfe3\nReviewed-on: https://chromium-review.googlesource.com/1816120\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "fd481cec30f6566594c391cb815bd8e1de3466e4", "tree": "6cb4f1b4214a63b7a9d0c4dadb81672f4b8a28ce", "parents": [ "919c7035f3811212c7575ccc601618441eb95847" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 13 18:14:48 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Sep 19 21:51:10 2019 -0700" }, "message": "disable wrong-import-position for chromite imports\n\nThe linter doesn\u0027t like the sys.path monkey patching before the\nimports and throws a warning. Suppress it since we can\u0027t avoid\nsys.path manipulation currently.\n\nBUG\u003dchromium:1003955\nTEST\u003d`cros lint` is clean\n\nChange-Id: I52b485e3903b26929176036ad0773c6facb490f5\nReviewed-on: https://chromium-review.googlesource.com/1803862\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "919c7035f3811212c7575ccc601618441eb95847", "tree": "286d3e064b70db503bb7785ac014d3d13d8e1d23", "parents": [ "71e643eb42a51c5bc6d54c5757cedd2b363ffaf9" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 13 17:48:08 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Sep 19 21:51:09 2019 -0700" }, "message": "pre-upload: check for builtins module too\n\nPython 3 has renamed this module, so tweak the check.\n\nBUG\u003dchromium:1003955\nTEST\u003d`repo upload` works with python3\n\nChange-Id: I18a6117101a114612fd28a1b0c9684cd29e2c15c\nReviewed-on: https://chromium-review.googlesource.com/1803861\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "71e643eb42a51c5bc6d54c5757cedd2b363ffaf9", "tree": "2390928fc7d5f5fc2b86a6349be27b565f4ed625", "parents": [ "526a5f8ffa6609e9ab9546c1b53acf6237394944" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 13 17:26:39 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Sep 19 21:51:08 2019 -0700" }, "message": "pre-upload: overhaul how we handle UTF-8 from commands\n\nWe\u0027ve been working on bytes in most places from command output. This\nlargely just works because people use UTF-8 or the binary content gets\nignored. Since we want to operate on strings everywhere, change the\nrun command helper to always return strings rather than bytes. We had\na single place that was dealing with possible UTF-8 errors, so move it\nto this common place for all to benefit.\n\nFor now we convert invalid UTF-8 content to U+FFFD characters. Seems\nunlikely anyone will notice as none of our tools operate on binary\ndata, and if they do, it\u0027s directly. If we get to the point where we\nhave a tool that wants bytes in/bytes out, we can expand the API.\n\nBUG\u003dchromium:1003955\nTEST\u003dunittests pass w/python2 \u0026 python3\n\nChange-Id: Iedd7c179e0b0be6d426aad0edb88117f2f472b95\nReviewed-on: https://chromium-review.googlesource.com/1803860\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "526a5f8ffa6609e9ab9546c1b53acf6237394944", "tree": "1f537e486112c79e5b0e9a2a5fd819bc4bb46585", "parents": [ "13302d4383ff382b9450b05787572491c9c25d3c" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 13 18:05:30 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Sep 19 15:46:53 2019 -0700" }, "message": "pre-upload: simplify _run_command\n\nWe have this wrapper around RunCommand so we can set a few fields to\nnon-default values. Otherwise we pass everything through. Rewrite\nthe code to use **kwargs so we only have to specify the fields that\nwe actually care about.\n\nBUG\u003dchromium:1003955\nTEST\u003dunittests pass\n\nChange-Id: I96d443b4b8bd049a97dc85542b78b0216024eeee\nReviewed-on: https://chromium-review.googlesource.com/1803859\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "13302d4383ff382b9450b05787572491c9c25d3c", "tree": "1a3af69df76664b428e5662a1dc07eadbda7de43", "parents": [ "7bfc89fe3e9f4bd83ab13088317aaebc3a06a1f2" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 13 17:21:24 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Sep 19 15:46:52 2019 -0700" }, "message": "pre-upload: switch to io.StringIO\n\nSince Python 3 dropped StringIO, switch over to io.StringIO.\n\nBUG\u003dchromium:1003955\nTEST\u003dunittests pass\n\nChange-Id: If7074d4dd89e31c7e48b79e8a6b34ed3adb65c98\nReviewed-on: https://chromium-review.googlesource.com/1803858\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "7bfc89fe3e9f4bd83ab13088317aaebc3a06a1f2", "tree": "9c35be1ad9db725884ae8e3db0fa4e1a73d35852", "parents": [ "eb806d82f4be3bb9e3a0f7fa46e90c823b18b1ae" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Fri Sep 13 15:45:51 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Sep 19 15:46:51 2019 -0700" }, "message": "pre-upload: import configparser from six.moves\n\nThis has been renamed in Python 3 from ConfigParser to configparser.\n\nBUG\u003dchromium:1003955\nTEST\u003dunittests pass\n\nChange-Id: I1af519d821872ea73dcadb9672ffa2b52c5e55e0\nReviewed-on: https://chromium-review.googlesource.com/1803857\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Will Bradley \u003cwbbradley@chromium.org\u003e\n" }, { "commit": "eb806d82f4be3bb9e3a0f7fa46e90c823b18b1ae", "tree": "7dc5625825a39d1f542d6b48feeda30a7a4bf74a", "parents": [ "b2496653980fde3ee5b7c0dcd8febec00f8bbf19" ], "author": { "name": "Ben Chan", "email": "benchan@chromium.org", "time": "Mon Sep 16 11:52:52 2019 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Sep 16 14:28:16 2019 -0700" }, "message": "pre-upload: fix output of hook indexes\n\nThis CL modifies the output of hook indexes to start at 1, instead of 0,\nin order to be consistent with the output of commit indexes.\n\nBUG\u003dNone\nTEST\u003d`repo upload` shows correct hook indexes.\n\nChange-Id: I76107b8d862fe23962fa7c4f5e588a5bada2b928\nReviewed-on: https://chromium-review.googlesource.com/1807442\nTested-by: Ben Chan \u003cbenchan@chromium.org\u003e\nCommit-Ready: Ben Chan \u003cbenchan@chromium.org\u003e\nCommit-Ready: Ben Chan \u003cbenchan@google.com\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "b2496653980fde3ee5b7c0dcd8febec00f8bbf19", "tree": "166ab904a53a836a1f01b8783a39406cd491ce4a", "parents": [ "e300c7d106a881eb25a4fc613637dfb2175e54a3" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Sep 12 23:35:46 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 13 12:54:19 2019 -0700" }, "message": "pre-upload: cache repeated git operations\n\nWe have a lot of places that run the same git command on the same git\ncommit to get the same data. Cache the results across runs to avoid\nthat overhead.\n\nRunning on my local chromite branch with 15 commits, this cuts the time\nfrom to process from ~37s to ~13s.\n\nBUG\u003dNone\nTEST\u003dunittests pass\n\nChange-Id: Ic920f734af8523fe31db29bd07e6661c03321250\nReviewed-on: https://chromium-review.googlesource.com/1802577\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\n" }, { "commit": "e300c7d106a881eb25a4fc613637dfb2175e54a3", "tree": "388926fbd1896adc899efa878f315ffe7afa7b5d", "parents": [ "e85b006f2b9b2abe1ae38d98d94ce43d75060a02" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Sep 12 23:33:52 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Sep 13 12:54:17 2019 -0700" }, "message": "pre-upload: skip merge commits\n\nWe don\u0027t have any checks that apply to merge commits, so skip them.\n\nBUG\u003dNone\nTEST\u003d`repo upload` with merge commits skips them\n\nChange-Id: I27441d1b052a6930c458b02fa754bc543b5f4c89\nReviewed-on: https://chromium-review.googlesource.com/1802576\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\n" }, { "commit": "e85b006f2b9b2abe1ae38d98d94ce43d75060a02", "tree": "2e8a24191e3cd9210ba815ff6c57476d6de69b84", "parents": [ "ce1cb1b5cae70e05b80c5058e742de91c1a0a7ef" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Aug 20 15:10:33 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Aug 20 14:27:13 2019 -0700" }, "message": "unittests: mock out rustfmt\n\nWe don\u0027t need to have rustfmt installed here.\n\nBUG\u003dNone\nTEST\u003d`./pre-upload_unittest.py` passes\n\nChange-Id: I00acb8d7e2fcde43e4e0d746d10335f876ed46b9\nReviewed-on: https://chromium-review.googlesource.com/1762358\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Fletcher Woodruff \u003cfletcherw@chromium.org\u003e\n" }, { "commit": "ce1cb1b5cae70e05b80c5058e742de91c1a0a7ef", "tree": "4db131682a324c0cf4200099427986d808d3198f", "parents": [ "b99b3771de40d048a7721f0a15006e12798a1708" ], "author": { "name": "Fletcher Woodruff", "email": "fletcherw@chromium.org", "time": "Fri Aug 16 15:59:32 2019 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sun Aug 18 20:54:14 2019 -0700" }, "message": "pre-upload: check rust formatting with rustfmt\n\nCheck all changed files with rustfmt, and block upload if any\nerrors are found.\n\nBUG\u003dNone\nTEST\u003dcheck that hook catches bad commit on \u0027repo upload\u0027\nTEST\u003dcheck that hook doesn\u0027t catch innocuous rust commits\n\nChange-Id: I656e8ea2f8af39d31537aadc510a000bff925ca7\nReviewed-on: https://chromium-review.googlesource.com/1759129\nTested-by: Fletcher Woodruff \u003cfletcherw@chromium.org\u003e\nCommit-Ready: Fletcher Woodruff \u003cfletcherw@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "b99b3771de40d048a7721f0a15006e12798a1708", "tree": "ba3cd8ecddbc200f9dd9b151d0185e0721ca3ac2", "parents": [ "24dd3c5c80663159c999b983ef99c16a95b66f91" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Aug 17 14:19:44 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sun Aug 18 00:01:48 2019 -0700" }, "message": "pre-upload: add hook count to status output\n\nWe run many hooks, so add a counter to the status bar for users.\n\nBUG\u003dNone\nTEST\u003d`repo upload` shows hook position\n\nChange-Id: I9854a837bdce46f83c99256e711b2000cb6ac557\nReviewed-on: https://chromium-review.googlesource.com/1757359\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\n" }, { "commit": "24dd3c5c80663159c999b983ef99c16a95b66f91", "tree": "fb4d49d75d8f6e433f2e98f367f224f15634d061", "parents": [ "abb8f91b0b4bc99abdf41aa5411191f385d789ac" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Aug 17 14:22:48 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Sun Aug 18 00:01:47 2019 -0700" }, "message": "clean up lint warnings\n\nNewer chromite adds more lint warnings.\n\nBUG\u003dNone\nTEST\u003d`cros lint` is clean in here\n\nChange-Id: I96416f2d4e51956a2991e8b91124b3300693ffdf\nReviewed-on: https://chromium-review.googlesource.com/1757360\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Michael Mortensen \u003cmmortensen@google.com\u003e\n" }, { "commit": "abb8f91b0b4bc99abdf41aa5411191f385d789ac", "tree": "af4b9ed7d9f46825c5c1157a3a26196a7d418e3a", "parents": [ "bb34a22ba346707b5395dfb1379556fdbc98389f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Mon Aug 05 18:30:27 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Aug 05 20:45:24 2019 -0700" }, "message": "README.md: convert to markdown \u0026 migrate from dev.chromium.org\n\nBUG\u003dNone\nTEST\u003dlooked at file in gitiles\n\nChange-Id: Ie251562f4187807427e0405b584042c81b3d74d4\nReviewed-on: https://chromium-review.googlesource.com/1737201\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: LaMont Jones \u003clamontjones@chromium.org\u003e\n" }, { "commit": "bb34a22ba346707b5395dfb1379556fdbc98389f", "tree": "ef41d0ff09ce708c9e67884173d2734528cc79c1", "parents": [ "56e8de008f25ec12fbb1215bdbb2726057ac419f" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Jul 31 14:40:46 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Jul 31 15:00:43 2019 -0700" }, "message": "pre-upload: rewrite tag logic to avoid filter()\n\nWe\u0027ve banned the filter() builtin, so rewrite the logic to avoid it.\nThis makes the check slightly more strict in that we only allow tags\nwith the correct case, but that should be fine.\n\nBUG\u003dchromium:982868\nTEST\u003dunittests pass\n\nChange-Id: Ia10dff1ac2027b77e435c1d1155cefdf74031b94\nReviewed-on: https://chromium-review.googlesource.com/1729850\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Jack Neus \u003cjackneus@google.com\u003e\n" }, { "commit": "56e8de008f25ec12fbb1215bdbb2726057ac419f", "tree": "19a23122a2196cef9be576635ee1ef33701f2314", "parents": [ "1365040ca97f9862787893a17d8a1a150170b8f0" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Jul 31 14:40:14 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Jul 31 14:30:11 2019 -0700" }, "message": "fix some Python 3 linting issues\n\nBUG\u003dNone\nTEST\u003dCQ passes\n\nChange-Id: I3b298f795e01318420dc2bfc5051e3163fac4414\nReviewed-on: https://chromium-review.googlesource.com/1729849\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Alex Klein \u003csaklein@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "1365040ca97f9862787893a17d8a1a150170b8f0", "tree": "3eb93f0c14d47674c6f3322b3cfa559c2d6794e1", "parents": [ "8edbf64a7c2cae8b78aa9e3e89281ebb4bf18b66" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Jul 31 14:31:46 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Jul 31 14:22:05 2019 -0700" }, "message": "pre-upload: ignore generated Go protobuf bindings\n\nBUG\u003dchromium:989573\nTEST\u003dunittests pass\n\nChange-Id: I3b0e43b71641c369390238d365fb88e1adb192d2\nReviewed-on: https://chromium-review.googlesource.com/1729627\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Alex Klein \u003csaklein@chromium.org\u003e\n" }, { "commit": "8edbf64a7c2cae8b78aa9e3e89281ebb4bf18b66", "tree": "49710f7a954b2a9510c874ec11c7e7c93b1a0447", "parents": [ "f9f79eb141f2ccc072b1be4c543c11c75726ee21" ], "author": { "name": "Jack Neus", "email": "jackneus@google.com", "time": "Wed Jul 10 16:08:31 2019 -0600" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Fri Jul 12 10:23:03 2019 -0700" }, "message": "Presubmit OEM check\n\nAdd presubmit check to `repo upload` that checks to see\nif any OEM names are present in the CL description.\n\nBUG\u003dchromium:982868\nTEST\u003dpresubmit unit tests\n\nChange-Id: I9e83164b2e1e5a0e303f6b8cbc8fa410f540cf58\nReviewed-on: https://chromium-review.googlesource.com/1692080\nTested-by: Jack Neus \u003cjackneus@google.com\u003e\nCommit-Ready: Jack Neus \u003cjackneus@google.com\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Paul Fagerburg \u003cpfagerburg@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nReviewed-by: Nick Crews \u003cncrews@chromium.org\u003e\n" }, { "commit": "f9f79eb141f2ccc072b1be4c543c11c75726ee21", "tree": "b9b46a9bd3eedc982edc53bca9f18ecd73c74fe1", "parents": [ "7e880acf00dc99cd2e46d042465c4654863e02b8" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Tue Jul 09 20:12:55 2019 -0700" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Jul 10 13:28:16 2019 -0700" }, "message": "pre-upload: silence some OWNERS line length complaints\n\nlines with file names can get to be pretty long, and there\u0027s nothing\nobvious that can be done to fix that.\n\nBUG\u003dchromium:982802\nTEST\u003dTried to `repo upload` I25abfcf66bb0ba4abf6f581ad506d7e56e1a75bc\n again; no lint complaints\n\nChange-Id: I0c555bb4de6392f3c0f7278b57e6ba6eabb7f3b9\nReviewed-on: https://chromium-review.googlesource.com/1695700\nTested-by: George Burgess \u003cgbiv@chromium.org\u003e\nCommit-Ready: George Burgess \u003cgbiv@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "7e880acf00dc99cd2e46d042465c4654863e02b8", "tree": "6efbf6c107218b935799aa015c5954790a0b2241", "parents": [ "9732e38a5551e4bbcd222d2bbb89ee0fc5c95dee" ], "author": { "name": "Keigo Oka", "email": "oka@chromium.org", "time": "Wed Jul 03 15:03:43 2019 +0900" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Wed Jul 03 02:10:40 2019 -0700" }, "message": "Check added files have current year in license header\n\nChanged the hook to return a list of errors in the course of the change.\nIt will be helpful for users to find as many errors in a single run of\nlinter.\n\nTEST\u003d./pre-upload_unittest.py\nTEST\u003dtried to add new file with wrong year and checked linter complains.\nBUG\u003dchromium:980061\n\nChange-Id: I2cd0ee95493f47114d62fcb81d72fccc627b8ca1\nReviewed-on: https://chromium-review.googlesource.com/1687034\nTested-by: Keigo Oka \u003coka@chromium.org\u003e\nCommit-Ready: Keigo Oka \u003coka@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "9732e38a5551e4bbcd222d2bbb89ee0fc5c95dee", "tree": "ae985e2ba5cf512d188826cdc56e2700920563ac", "parents": [ "acfb18af36cf972b11974bb0cc103d38be0538c8" ], "author": { "name": "Keigo Oka", "email": "oka@chromium.org", "time": "Fri Jun 28 17:44:59 2019 +0900" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Jul 01 20:29:32 2019 -0700" }, "message": "Check license header for .go files.\n\nTEST\u003dunittest\nTEST\u003dmanually checked repo upload fails if license header is missing in\na go file, and success otherwise.\nBUG\u003dchromium:979452\n\nChange-Id: Ic1f81fce7bbba88f799677d72e2ce2f241134f1d\nReviewed-on: https://chromium-review.googlesource.com/1679931\nTested-by: Keigo Oka \u003coka@chromium.org\u003e\nCommit-Ready: Keigo Oka \u003coka@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "acfb18af36cf972b11974bb0cc103d38be0538c8", "tree": "7c5829c43437b434bb1630d8a4dcd91253a9c127", "parents": [ "150a6fd1b9dcd6ad8c07d2f8aedf68513647a662" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jun 11 14:40:48 2019 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Jun 11 22:05:29 2019 -0700" }, "message": "set OWNERS to build team\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: I737053b099d0046071229f8ac6a5588c6afa1f80\nReviewed-on: https://chromium-review.googlesource.com/1653470\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Chris McDonald \u003ccjmcdonald@chromium.org\u003e\nReviewed-by: LaMont Jones \u003clamontjones@chromium.org\u003e\n" }, { "commit": "150a6fd1b9dcd6ad8c07d2f8aedf68513647a662", "tree": "5d41b61b804d2d341840cb79ccee994c5b3b5a06", "parents": [ "dd90882dd32c906cf2b48bbd767f66d381a5e499" ], "author": { "name": "Keigo Oka", "email": "oka@chromium.org", "time": "Tue Jun 04 11:30:25 2019 +0900" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Jun 06 23:03:02 2019 -0700" }, "message": "Update repohook check about gyp\n\nThere are some packages already migrated and some packages I missed.\n\nTEST\u003dCode search to check no directories expect the listed ones have gyp: http://cs/search/?q\u003dfile:%5C.gypi?+-file:platform/ap/+-file:platform/ap-daemons/+-file:/drivefs-google3/+-file:/drivefs/+-file:/platform2/+-file:platform/actions/+-file:/weave/libweave/+-file:/platform/thermald/+-file:/platform/experimental-touch-fw/\u0026m\u003d100\u0026sq\u003dpackage:%5Echromeos_public$%7C%5Echromeos_internal$\u0026type\u003dcs\nTEST\u003dAdd x.gyp here and repo upload fails.\nTEST\u003drepo upload works in ap/wireless and ap/security repos.\nBUG\u003dNone\n\nChange-Id: I741ed21537e227932bbbe65d5a5da71a090dbff6\nReviewed-on: https://chromium-review.googlesource.com/1644773\nCommit-Ready: Keigo Oka \u003coka@chromium.org\u003e\nTested-by: Keigo Oka \u003coka@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Tatsuhisa Yamaguchi \u003cyamaguchi@chromium.org\u003e\n" }, { "commit": "dd90882dd32c906cf2b48bbd767f66d381a5e499", "tree": "f9d2b24da263dbbc8e09b1ff84fe70537524ecee", "parents": [ "b8c7d7d336e1996b9f7643be4248f1d8d86981b9" ], "author": { "name": "Keigo Oka", "email": "oka@chromium.org", "time": "Tue Jun 04 11:30:25 2019 +0900" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Mon Jun 03 22:25:37 2019 -0700" }, "message": "Remove unnecessary pylint disable\n\nRemoving stale local .pyc files in chromite/, the linter no longer complains.\n\nTEST\u003drepo upload doesn\u0027t fail.\nBUG\u003dchromium:960636\n\nChange-Id: Idfe64978cf62ba7be922f0c0fe3c4f13f67e8bb1\nReviewed-on: https://chromium-review.googlesource.com/1642470\nCommit-Ready: Keigo Oka \u003coka@chromium.org\u003e\nTested-by: Keigo Oka \u003coka@chromium.org\u003e\nLegacy-Commit-Queue: Commit Bot \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" } ], "next": "b8c7d7d336e1996b9f7643be4248f1d8d86981b9" }