)]}' { "commit": "0c62a1450e098b3a14305a3937c39c386e8a7254", "tree": "ecff9afc7275d0027cb83425c097645d36fed06a", "parents": [ "23c62e9f8087539c08cbee2c477853849aa69f3b" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Tue Dec 11 13:24:29 2018 -0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Dec 11 15:56:35 2018 -0800" }, "message": "pre-upload: fix a few style/compatibility issues\n\nA few review notes came after CL:1336039 landed.\n\n * os.path.join: might as well use this everywhere we\u0027re constructing\n paths out of _get_hooks_dir()\n * it\u0027s a little clearer to name the non-msg HookFailure() args\n\nBUG\u003dnone\nTEST\u003dunit tests; run a few good/bad commits through .../pre-upload.py\n\nChange-Id: I401fe6c8bf02a3020122fa0875b2beb23345be27\nReviewed-on: https://chromium-review.googlesource.com/1372334\nCommit-Ready: Brian Norris \u003cbriannorris@chromium.org\u003e\nTested-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "ef17c32680cf1b8e90fafd38063534dbf249191c", "old_mode": 33261, "old_path": "pre-upload.py", "new_id": "14c5e992982d937a042427567f81c4019b8603e6", "new_mode": 33261, "new_path": "pre-upload.py" } ] }