Reinstate BRANCH= checks for coreboot and depthcharge
There are many branches in flight now, and many changes need to be
ported to certain branches. Let's enforce the BRANCH= clause in
firmware patch descriptions.
BUG=none
TEST=tried uploading a depthcharege patch without a BRACNH= clause,
got a presubmit error.
Change-Id: If4403c8f705e5a855ab1aee5e0d8db9a1ca2f751
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/221786
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
diff --git a/pre-upload.py b/pre-upload.py
index 9247d93..064bb8f 100755
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -1049,13 +1049,15 @@
"chromiumos/overlays/chromiumos-overlay": [_check_manifests],
"chromiumos/overlays/portage-stable": [_check_manifests],
"chromiumos/platform2": [_check_project_prefix],
- "chromiumos/platform/depthcharge": [_check_change_has_signoff_field,
+ "chromiumos/platform/depthcharge": [_check_change_has_branch_field,
+ _check_change_has_signoff_field,
_run_checkpatch_depthcharge],
"chromiumos/platform/ec": [_run_checkpatch_ec,
_check_change_has_branch_field],
"chromiumos/platform/mosys": [_check_change_has_branch_field],
"chromiumos/platform/vboot_reference": [_check_change_has_branch_field],
- "chromiumos/third_party/coreboot": [_check_change_has_signoff_field,
+ "chromiumos/third_party/coreboot": [_check_change_has_branch_field,
+ _check_change_has_signoff_field,
_run_checkpatch_coreboot],
"chromiumos/third_party/flashrom": [_check_change_has_branch_field],
"chromiumos/third_party/kernel": [_run_checkpatch, _kernel_configcheck],
