commit fd481cec30f6566594c391cb815bd8e1de3466e4
author Mike Frysinger <vapier@chromium.org> Fri Sep 13 18:14:48 2019 -0400
committer chrome-bot <chrome-bot@chromium.org> Thu Sep 19 21:51:10 2019 -0700
tree 6cb4f1b4214a63b7a9d0c4dadb81672f4b8a28ce
parent 919c7035f3811212c7575ccc601618441eb95847

disable wrong-import-position for chromite imports

The linter doesn't like the sys.path monkey patching before the
imports and throws a warning.  Suppress it since we can't avoid
sys.path manipulation currently.

BUG=chromium:1003955
TEST=`cros lint` is clean

Change-Id: I52b485e3903b26929176036ad0773c6facb490f5
Reviewed-on: https://chromium-review.googlesource.com/1803862
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Will Bradley <wbbradley@chromium.org>

clang-format.py

diff --git a/clang-format.py b/clang-format.py
index 84f9429..1d78584 100755
--- a/clang-format.py
+++ b/clang-format.py
@@ -18,6 +18,8 @@
   sys.path.insert(0, _path)
 del _path
 
+# The sys.path monkey patching confuses the linter.
+# pylint: disable=wrong-import-position
 from chromite.lib import commandline
 from chromite.lib import constants
 from chromite.lib import cros_build_lib

pre-upload.py

diff --git a/pre-upload.py b/pre-upload.py
index bbbac61..77c4d99 100755
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -42,6 +42,8 @@
 if __name__ == '__main__':
   sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), '..', '..'))
 
+# The sys.path monkey patching confuses the linter.
+# pylint: disable=wrong-import-position
 from chromite.lib import commandline
 from chromite.lib import constants
 from chromite.lib import cros_build_lib

pre-upload_unittest.py

diff --git a/pre-upload_unittest.py b/pre-upload_unittest.py
index 87932b4..8641418 100755
--- a/pre-upload_unittest.py
+++ b/pre-upload_unittest.py
@@ -12,6 +12,8 @@
 import os
 import sys
 
+import mock
+
 import errors
 
 # pylint: disable=W0212
@@ -21,15 +23,14 @@
 sys.path.insert(0, os.path.join(os.path.dirname(os.path.realpath(__file__)),
                                 '..', '..'))
 
+# The sys.path monkey patching confuses the linter.
+# pylint: disable=wrong-import-position
 from chromite.lib import constants
 from chromite.lib import cros_build_lib
 from chromite.lib import cros_test_lib
 from chromite.lib import git
 from chromite.lib import osutils
 
-# Needs to be after chromite imports so we use the bundled copy.
-import mock
-
 
 pre_upload = __import__('pre-upload')