commit 667db5dcce1a682115947e5f7a157034060a0313
author Tom Wai-Hong Tam <waihong@chromium.org> Thu Feb 27 06:28:14 2014 +0800
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Thu Feb 27 02:28:37 2014 +0000
tree 0967546437791ec5c64c8a05e612ce545fde2c48
parent ed7a3fab1122bc3b299dc55346399065e422622c

Don't check symlinks for license headers

Because it tried to open the symlink and caused an error. So ignore symlinks.

BUG=None
TEST=tried uploading a CL with a symlink
TEST=`./pre-upload_unittest.py` passes

Change-Id: I07f2394a832d82e692fbe5ec4d3ec270a671dcaa
Reviewed-on: https://chromium-review.googlesource.com/188072
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>

pre-upload.py

diff --git a/pre-upload.py b/pre-upload.py
index 59836ad..235b037 100755
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -168,8 +168,8 @@
                         COMMON_EXCLUDED_PATHS)
 
   for f in files:
-    # Ignore non-existant files
-    if os.path.exists(f):
+    # Ignore non-existant files and symlinks
+    if os.path.exists(f) and not os.path.islink(f):
       contents = open(f).read()
       if not contents:
         # Ignore empty files