tree 372fdfcbc209c5ce3f4e4bfa30a35f6fdc8224c8
parent 0f4cd7b5dcf2e09af8a629e77e85070fc312b8f7
author Mike Frysinger <vapier@chromium.org> 1597812111 -0400
committer Commit Bot <commit-bot@chromium.org> 1598049736 +0000

pre-upload: support options for default enabled flags [reland]

We pull out hook options when the hook is explicitly enabled, but not
when it's implicitly enabled by default.  We haven't had any hooks as
those take options before so no one noticed.

The previous version had a logic error and enabled all non-common
hooks by default.  This adds more unittests to verify that doesn't
happen, and then fixes the logic to only auto-enable common hooks.

BUG=b:162982485
TEST=unittests pass

Change-Id: Ic3aac6f8469579cdd9cb47aa058f97c3b0389e27
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2368044
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>