tree 695a2292dcc4bb889010b802c71d5fcce8cd0129
parent 3dc42417674d019e75fa471c86c1286797392637
author Hugo Benichi <hugobenichi@google.com> 1637502743 +0900
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> 1666120133 +0000

[CfM-96]shill: portal: Services with web proxy skips portal detection

This patch partially reverts crrev/c/2493374 and adds back a check in
Device::StartPortalDetection() which automatically upgrades connected
Services with a web proxy configuration to Service::kStateOnline.

In general shill's portal detector is not compatible with all web
proxy configurations in on-prem scenarios where the proxy is often
combined with a HTTP/HTTPS filter that may block shill's portal
detection probes. When this happens the connected Service never upgrades
to Service::kStateOnline which can cascade into additional issues like
b/200477591.

BUG=b:169939319
BUG=b:200477591
BUG=b:249613320
TEST=unit tests

Change-Id: I02cc510fe67bd9e276678106c8a7b1ac4f9bc285
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3292656
Tested-by: Hugo Benichi <hugobenichi@google.com>
Commit-Queue: Hugo Benichi <hugobenichi@google.com>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Matthew Wang <matthewmwang@chromium.org>
(cherry picked from commit fb8c07f47cfd5a296b6cd698f2fb6782ad88eafb)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3964748
Owners-Override: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Kyle Williams <kdgwill@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Pablo Ceballos <pceballos@chromium.org>
Auto-Submit: Kyle Williams <kdgwill@chromium.org>