tree 083ea88e9f191f81d507c58e36a63fe6c88ffad9
parent 5f95856451d40eb6db73f6c23a98971943a760d6
author Alex Khouderchah <akhouderchah@chromium.org> 1565981116 -0700
committer chrome-bot <chrome-bot@chromium.org> 1570250479 -0700

shill: routing_table: Set Device table id based on interface id

Previously, Connection would allocate a table ID for its Device and
inform RoutingTable that the table is a per-Device table (causing
device-specific routes to be moved from the main routing table to the
per-Device table). This CL modifies this behavior such that each
Device has a reserved table based on its interface index. Additional
routing tables can still be requested and freed, but these are for
use-cases like blackhole tables, rather than being used for per-Device
tables. Note that Connection will still clear all of its table's
routes on destruction.

In addition to removing the per-device map in RoutingTable and the
somewhat confusing SetPerDeviceTable interface, this allows for routes
to always be sent to the correct per-Device table. The following CL
furthers this by informing the kernel of the table ID, which causes it
to create RA-triggered default routes directly in the per-Device table
rather than requiring shill to manually move those routes.

BUG=chromium:941597, b:138795581
TEST=-All unit tests are passing.
     -Manually verified routing tables/rules, including connecting to
      VPNs.
     -Manually tested connecting to many different WiFi ESSs (as the
      same Device will be used with different networks that will have
      different routes and gateways).

Change-Id: I32595b445b3c4807d74915547362c42fffb2eef6
Reviewed-on: https://chromium-review.googlesource.com/1765666
Tested-by: Alex Khouderchah <akhouderchah@chromium.org>
Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Hugo Benichi <hugobenichi@google.com>