tree 69807ea5f9062b1879c456914146bfab2d990341
parent cf7514437e8cd7fec8e731e14419f744e6cd733c
author Denny Huang <dennyh@google.com> 1665691931 +0000
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> 1666088263 +0000

diagnostics: Fallback to VPD when missing OEM name in cros-config for SystemFetcher

Currently the OEM name in OS Info in SystemFetcher is fetched only from
cros-config. However, the OEM name is usually filled after (or right
before) launch. Fallback to VPD (vpd.ro.oem-name) when it’s missing in
cros-config. This is part of the OEM name customization process, see
go/cros-healthd-customize-impl-oem.

In addition, comments are added to FetchOsInfo inside SystemFetcher to
make the fetcher logic easier to follow.

BUG=b:239674405
TEST=FEATURES=test emerge-$BOARD diagnostics
TEST=Make sure the OEM name in cros-config is empty, set fake content in
VPD, and verify via CLI.
  1. (dut) `cros_config /branding oem-name` and verify empty output
  2. (dut) `vpd -s oem_name=FAKE_OEM; dump_vpd_log --force; reboot`
  3. (dut) `cros-health-tool telem --category=system` and verify the
     content of "os_info.oem_name" is "FAKE_OEM".

Cq-Depend: chromium:3957794
Change-Id: Ief88d0ac0d8687aefb912534ccae2f8edaf48053
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3956334
Tested-by: Denny Huang <dennyh@google.com>
Reviewed-by: Byron Lee <byronlee@chromium.org>
Reviewed-by: Paddykp Yao <paddykp_yao1@asus.corp-partner.google.com>
Reviewed-by: Chung-sheng Wu <chungsheng@google.com>
Commit-Queue: Denny Huang <dennyh@google.com>