tree 2d078da418ebcbb186f6e0b264f670e0569035fa
parent 3335cd5e412e2748a477e49c7f649ff4ac42231c
author Nicholas Bishop <nbishop@neverware.com> 1593794818 -0400
committer Commit Bot <commit-bot@chromium.org> 1596055835 +0000

login: fix check for file descriptor validity

LoginScreenStorage was incorrectly checking a file descriptor against
zero, but it should check against -1. Fixed by using
ScopedFD::is_valid instead of ScopedFD::get.

Added a new RetrieveInvalidData test that verifies that Retrieve
properly returns false if the file associated with the key is
empty. This required modifying
FakeSharedMemoryUtil::WriteDataToSharedMemory to return an invalid
file descriptor if the input vector is empty, which matches the
behavior of base::SharedMemory::Create.

BUG=b:159942676
TEST=cros_workon_make --test chromeos-login

Change-Id: I4b33b54426880f47b297c2e4d431ed7a608fdce0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2281102
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Alexander Hendrich <hendrich@chromium.org>
Tested-by: Nicholas Bishop <nbishop@neverware.com>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>