commit 92f1171bc48041e3603922c049d34a287719f819
author Ian Barkley-Yeung <iby@google.com> Fri Jul 31 18:39:07 2020 -0700
committer Commit Bot <commit-bot@chromium.org> Thu Aug 06 09:44:16 2020 +0000
tree 295f641c13fcf0e44f9b2184a7f73ba7d52957c5
parent f408b12b563d3c78814774cecafa67ad6ea7da20

login: Launch crashpad to 100% on most boards

There are currently three classes of boards:
1. Most boards, which are running an experiment where Chrome is run 10%
   of the time with Crashpad and 90% of the time with Breakpad.
2. kukui, which runs Crashpad 100% of time
3. scarlet, bob, kevin, rainier, oak, elm, and hana, where Crashpad
   doesn't work so we run Breakpad 100% of the time

We have finished the experiment and are ready to launch Crashpad to 100%
on most boards.

These changes switch the boards in category 1 (the Crashpad/Breakpad
experiment group) to running Crashpad 100% of the time.

Before, since there were 3 categories, we represented the categories
using two USE flags: force_crashpad and force_breakpad. If
force_crashpad was set, the board was in category 2. If force_breakpad
was set, the board was in category 3. If neither was set, the board was
in category 1.

Now, there are only two categories: boards running Crashpad and boards
running Breakpad. Therefore, there is now only 1 USE flag:
force_breakpad. If force_breakpad is set, then the boards (scarlet, bob,
kevin, rainier, oak, elm, and hana) will continue to run only Breakpad;
otherwise, they will be at 100% Crashpad.

Update the browser Crashpad/Breakpad logic accordingly. The logic
becomes much simpler as we no longer need to wait until browser startup
to decide which of the two crash handlers we will be using -- we no
longer allow tests to override the selection and we no longer want to
reroll the experiment on each restart.

BUG=chromium:1038427
FIXED=chromium:1038427
TEST=Ran on cyan, hana, kukui, and hana-kernelnext.
* Restarted Chrome multiple times. hana always used
  --no-enable-crashpad. All others used --enable-crashpad and had
  --crashpad-handler-pid
* Killed Chrome with SEGV. All board produced crash dumps
* Ran ChromeCrash* tast tests. hana skipped all Crashpad tests. All
  others skipped all Breakpad tests. All tests except
  ui.ChromeCrashLoggedIn.gpu_process_breakpad passed.

Cq-Depend: chromium:2334665, chromium:2334514, chromium:2335783, chromium:2335750, chrome-internal:3197841, chrome-internal:3198092
Change-Id: Id380d97b8b52c304b9b3b77485e83e4f86a11ed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2335749
Tested-by: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>