tree 54d14f9003bc8f769f5fa166051f2e3275ad7d8c
parent 173dc8c1c19dfafd28ff885ea34f66fc783ae1f8
author Alex Khouderchah <akhouderchah@chromium.org> 1591030289 -0700
committer Commit Bot <commit-bot@chromium.org> 1596134534 +0000

shill: Deprecate crypto implementation

This change migrates "crypted" strings from ROT47 to plaintext. Since
the decryption code expects to find "rot47:" at the beginning of an
"encrypted" string, we would have problems if the plaintext also began
with that prefix. This change instead migrates keys, deprecating the
old storage strings used for "encrypted" fields.

Note that this migration cannot be done transparently by KeyFileStore
because clients have different logic that doesn't always invoke the
cryted KeyFileStore methods. Instead this change simply explicitly
migrates all crypted keys, hopefully simplifying the future removal of
this code.

BUG=chromium:1084279
TEST=All unit tests are passing.
TEST=Manually verified with device whose profiles contain WiFi and VPN
     credentials that connections still work and that the persisted
     profile updates to storing in plaintext.

Change-Id: I804e0d83f14e15a91694d4740e58b991b69411ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2210007
Tested-by: Alex Khouderchah <akhouderchah@chromium.org>
Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>