tree 4035b7269e813a58150bc0763c5beb49f91f7356
parent 410b3f1fb29ce54a2cc9407377a7d0e3451c2785
author Brian Norris <briannorris@chromium.org> 1595980694 -0700
committer Commit Bot <commit-bot@chromium.org> 1596217028 +0000

shill: log early messages

shill_main's OnStartup() sets up logging (stderr for --foreground;
syslog for background (default)).

DaemonTask::Init() constructs most of our singletons (ProcessManager,
Manager, etc.).

There's no reason for ordering one or the other, except to determine
where the logging for Init() goes. Let's let logging for Init() go to
the right place (i.e., background = syslog) by setting up logging before
we go through most other initialization.

While at it, we can simplify the callback hierarchy by inlining
OnStartup() into main(). Note that we still need to construct
ShillDaemon first, because we rely on its embedded AtExitManager for
things like Minjail::GetInstance() / lazy pointer initialization.

This makes things like the following a little more useful, as there are
potentially some manager- or property-related logs that come in the
constructors:

  stop shill; start shill SHILL_LOG_LEVEL=-3 SHILL_LOG_SCOPES="+manager+property+profile"

BUG=none
TEST=see above

Change-Id: I676b3e06f1bfea2d878bf36765fa77e4b5d61c36
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2325076
Tested-by: Brian Norris <briannorris@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>
Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org>