)]}' { "log": [ { "commit": "506d9df62d10ad0fde2d8d96b25b194d749262ff", "tree": "bcc837446605fe65c0ce4e860777461ae23702b9", "parents": [ "681305cd1caefeef9a62e210267d63a1e3f133e0" ], "author": { "name": "Sergey Frolov", "email": "sfrolov@google.com", "time": "Tue Dec 29 17:42:30 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jan 01 00:19:31 2021 +0000" }, "message": "Add ensure_not_tainted_license.sh\n\nThis is a part of the work to ensure that tainted images are never\nsigned with MP keys. A special tainted tag was added to the license file by\nhttps://chromium-review.googlesource.com/c/chromiumos/chromite/+/2560225\nand in ensure_not_tainted.sh we detect the presence of this tag.\n\nThis script has been manually tested on tainted and non-tainted images.\n\nBUG\u003dchromium:1059363\nTEST\u003dmanual\nBRANCH\u003dnone\n\nChange-Id: I17ca27bb7895f268a79cca3ad948808f0f96b8c7\nSigned-off-by: Sergey Frolov \u003csfrolov@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2607414\nCommit-Queue: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\n" }, { "commit": "681305cd1caefeef9a62e210267d63a1e3f133e0", "tree": "012e67db92ee97a61df1d6b285f309e862df5446", "parents": [ "bc2317695965bb92b8809d9c06327adedcb0653c" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@google.com", "time": "Mon Dec 28 15:33:23 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Dec 29 18:37:12 2020 +0000" }, "message": "Revert \"sign_gsc_firmware: update generated file name\"\n\nThis reverts commit bc2317695965bb92b8809d9c06327adedcb0653c.\n\nThe reason for revert is that the signer needs to know the generated\nfile name, and in case vboot reference alters the name the signer\nremains unaware of the change and is still looking for the file named\n@CHIP@...\n\nSome other means of figuring out the file name will be required, let\u0027s\nstick with the @CHIP@ prefix for now.\n\nBRANCH\u003dnone\nBUG\u003db:173049030\nTEST\u003dnone\n\nChange-Id: I23ea65314d49e86fc4edb015e89b6076f87a54dd\nSigned-off-by: Vadim Bendebury \u003cvbendeb@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2605238\nTested-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nTested-by: George Engelbrecht \u003cengeg@google.com\u003e\nAuto-Submit: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nCommit-Queue: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n" }, { "commit": "bc2317695965bb92b8809d9c06327adedcb0653c", "tree": "b06a9d15be28fc8ddd4439d7dc7b3c65b2a0ebf9", "parents": [ "af02768dace900e7e62d6788b4ff81b57b3e0a79" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@google.com", "time": "Wed Dec 16 19:49:29 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 18 18:08:14 2020 +0000" }, "message": "sign_gsc_firmware: update generated file name\n\nWhen processing Gsc image singing request the signing server is not\naware of which chip the image is being signed for, the output file\nname includes the string @CHIP@ and it is the responsibility of the\nactual signing scripts to figure out if the image is for Cr50 or Ti50.\n\nThe destination image type is determined based no the signing manifest\ncontents, this patch add code to replace @CHIP@ with the actual image\ntype.\n\nBRANCH\u003dnone\nBUG\u003db:173049030\nTEST\u003dinvoked the script to sign a Ti50 image locally, verified that\n the produced signed image file had the expected name.\n\nChange-Id: Ib1534ce50e0a44d0ec014e8dbee4e4d85c2082c9\nSigned-off-by: Vadim Bendebury \u003cvbendeb@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2596695\nTested-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nAuto-Submit: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nCommit-Queue: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n" }, { "commit": "af02768dace900e7e62d6788b4ff81b57b3e0a79", "tree": "012e67db92ee97a61df1d6b285f309e862df5446", "parents": [ "fb25edf13402ef3be8935c7d3dc1416efff49c5b" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Tue Dec 08 16:59:27 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Dec 16 00:39:29 2020 +0000" }, "message": "cgptlib: Always zero-initialize GPT entries buffers\n\nClusterFuzz still managed to find cases where we try to CRC a GPT\nentries buffer that wasn\u0027t initialized. Not that that\u0027s really an issue\nor anything... but this patch should shut it up.\n\nBRANCH\u003dnone\nBUG\u003dchromium:1155876\nTEST\u003dnone\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: I3d0b4f34693d87b66513f398dd13441aba543c3a\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2580110\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "fb25edf13402ef3be8935c7d3dc1416efff49c5b", "tree": "c825a3116e75b3c782917c853f24721c645284f3", "parents": [ "e1db52ef9282486117247d178af184e2641904c8" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@google.com", "time": "Thu Dec 03 11:19:09 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 11 21:06:50 2020 +0000" }, "message": "sign_gsc_firmware: refactor and extend to support D2\n\nThe major difference between Cr50 and Ti50 signing is that the RW\nsections are represented differently: elf files in Cr50 case and ihex\nfiles in Ti50 case.\n\nOther differences include the produced signed final image size and the\noffsets of the components in the final image.\n\nThe signing script is being updated to figure out all these\ndifferences at run time. A new optional field is introduced in the\nsigning manifest, the \u0027generation\u0027. If this field is absent or set to\n\u0027h\u0027 (for H1), the script proceeds with the Cr50 signing process. If\n\u0027generation\u0027 is set to \u0027d\u0027 (for D2), the script proceeds with the Ti50\nsigning process.\n\nInstead of using fixed offsets into the final image, the base\naddresses of the components in ihex format are used, the only fixed\nvalue is the base address of the flash image in the chip address space\n(0x40000 for H1 vs 0x80000 for D2).\n\nTo make this work for H1 the output format of the signed blob produced\nby gsc-codesigner is changed from binary to ihex.\n\nBRANCH\u003dnone\nBUG\u003db:173049030\nTEST\u003dusing this script and the signing_istructions.sh module produced\n by the real Cr50 signer was able to produce functional images for\n both Cr50 and Ti50.\n\nChange-Id: I845be1101b09c9476fa27fbddb72607dc6cea901\nSigned-off-by: Vadim Bendebury \u003cvbendeb@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2570009\nTested-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nAuto-Submit: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nCommit-Queue: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n" }, { "commit": "e1db52ef9282486117247d178af184e2641904c8", "tree": "2ce70e15258daf353338343bd2b34d4976bcaa2b", "parents": [ "7e9472ab7a1729a69365a9a21516d70d11f893c4" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@google.com", "time": "Wed Dec 02 15:14:21 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 11 21:06:49 2020 +0000" }, "message": "sign_gsc_firmware: add functions to determine ihex module base address\n\nWith the advent of D2 memory layout scheme it became impossible to\nhardcode the base address of various components of the D2 firmware\nimage. Luckily, the components are represented as binary blobs in\nIntel ihex format, which allows to retrieve the base address of the\ncomponent from the ihex records.\n\nThe address is composed of two elements: the segment base supplied in\nthe record type 02 or 04, and the record offset into the segment,\nsupplied in the data record of type 0.\n\nThe segment address is expressed as a 16 bit value, the actual value\nshifted right either 4 bits (in case of record type 02) or 16 bits (in\ncase of record type 04). The data record offset is also a 16 bit\nvalue.\n\nThe base address of the blob is calculated as\n\n\u003csegment address\u003e + \u003cfirst data record offset\u003e\n\nand is available from the first two records in the ihex module.\n\nDetailed information of ihex file format can be found in\nhttps://en.wikipedia.org/wiki/Intel_HEX .\n\nBRANCH\u003dnone\nBUG\u003db:173049030\nTEST\u003dwith the next patch in the stack applied was able to successfully\n build a multicomponent ti50 image.\n\nChange-Id: I135c2f9960f1f218532c82bafd7acbe362414fc9\nSigned-off-by: Vadim Bendebury \u003cvbendeb@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2570008\nTested-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nCommit-Queue: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n" }, { "commit": "7e9472ab7a1729a69365a9a21516d70d11f893c4", "tree": "de5161cc4eb871a2dec9277b091623cb9039400f", "parents": [ "21b7225caf55686fd27007c878758cacac7ff55f" ], "author": { "name": "Vadim Bendebury", "email": "vbendeb@google.com", "time": "Thu Nov 12 20:06:09 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 11 21:06:47 2020 +0000" }, "message": "image_signing: use GSC nomenclature instead of Cr50\n\nThis patch does not yet provide the ability to sign Ti50 images, but\nprepares the signing scripts for further modifications to support a\nvariety of security chip signing flows.\n\nBRANCH\u003dnone\nBUG\u003db:173049030\nTEST\u003dverified successful signing of a Cr50 image in a test signer\n setup\n also created a functional Cr50 image invoking\n sign_official_build.sh by hand.\n\nChange-Id: Ic103c9fdf7d1c4ea160c7f6849d5ae5a8303c343\nSigned-off-by: Vadim Bendebury \u003cvbendeb@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2537078\nTested-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nCommit-Queue: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\nAuto-Submit: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n" }, { "commit": "21b7225caf55686fd27007c878758cacac7ff55f", "tree": "b8e72d70705466a6b1491b89a0d7e2d80a05d7e0", "parents": [ "ebd1261eb5df292ecaf4995c4d80954b6ffb1161" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Dec 04 16:15:00 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Dec 09 17:37:53 2020 +0000" }, "message": "futility: update: add new quirk \u0027no_check_platform\u0027\n\nSome devices may have flashed firmware with different platform name in\ntheir early stage (especially in the first build of leading devices),\nso we do want to provide an explicit way (not just --force) to skip\nchecking platform name.\n\nThe change CL:2059621 does not help because the loaded system\nfirmware looks good.\n\nThis is implemented as a quirk so we can enable it using a CBFS quirk\nfile, making it easier to be deployed by auto update.\n\nBRANCH\u003dNone\nBUG\u003dNone\nTEST\u003dmake runtests\n\nChange-Id: I888d5848921d31c9b7cba1b96c42d38fda71927e\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2573999\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "ebd1261eb5df292ecaf4995c4d80954b6ffb1161", "tree": "d98360a4d754c2cecba0cfcfef82513ee1e2a790", "parents": [ "3425315e87738b80c9efc15801d491545b38146b" ], "author": { "name": "Kangheui Won", "email": "khwon@chromium.org", "time": "Tue Dec 01 17:15:07 2020 +1100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Dec 09 12:01:45 2020 +0000" }, "message": "vboot2: Use TPM for hash acceleration allowance\n\nPreviously we used a flag in preamble to prevent HW acceleration for SHA\nhashing. However we started to use kernel TPM flag for RSA part since we\ncan use the flag in preamble only after we verified preamble.\n\nNo need to keep both for same objective, so deprecate old flag and\nchange code to use TPM flag.\n\nBUG\u003db:166038345\nBRANCH\u003dzork\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang make runtests\nTEST\u003dboot Ezkinil, check HW acceleration is used for SHA\n\nSigned-off-by: Kangheui Won \u003ckhwon@chromium.org\u003e\nChange-Id: I81b174dbe285fa3f68a22667b6af14a52b06b112\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2566866\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "3425315e87738b80c9efc15801d491545b38146b", "tree": "e2ac91f886f53c5d6ee80533aeba4bda143dc54a", "parents": [ "1009be350708b0782fa875c0f4b165dcd8f9ba0b" ], "author": { "name": "Kangheui Won", "email": "khwon@chromium.org", "time": "Fri Nov 27 16:00:06 2020 +1100" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Dec 09 12:01:41 2020 +0000" }, "message": "vboot2: remove rsa from vb2_hwcrypto_rsa_allowed\n\nInitially vb2_hwcrypto_rsa_allowed were meant to only determine if we\ncan use rsa hardware acceleration. However we\u0027re planning to also use\nthis method for hashing, hence drop rsa from the name.\n\nBUG\u003db:166038345\nBRANCH\u003dzork\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang make runtests\n\nSigned-off-by: Kangheui Won \u003ckhwon@chromium.org\u003e\nChange-Id: I9efb05b3d035dcd584a47d006415ea87bf931ad6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2566865\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "1009be350708b0782fa875c0f4b165dcd8f9ba0b", "tree": "a3c7b92e169aa8d599dc05b8b11ee2e0af3b485b", "parents": [ "3b4b439b6450ceacd36d91036e4509b8b6f7880c" ], "author": { "name": "Yury Khmel", "email": "khmel@google.com", "time": "Thu Dec 03 19:09:00 2020 +0000" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Sat Dec 05 05:14:02 2020 +0000" }, "message": "signer: Verify many Android signer operations that content is unchanged.\n\nThis adds extra verifications to many Android signer operation in order\nto narrow down the problem when empty folders are removed from the disk.\n\nBUG\u003dchromium:1154734\nTEST\u003dLocally image signing passed. Emulated problem and it was detected.\n\nBRANCH\u003dnone\nSigned-off-by: Yury Khmel \u003ckhmel@google.com\u003e\nChange-Id: If8bb9fced290117766bfa9ff76a25fc86ed263dc\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2572240\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "3b4b439b6450ceacd36d91036e4509b8b6f7880c", "tree": "8325eb39e2f4c2c817ddcf0170966818432021f9", "parents": [ "03d6cc6106bd72503a669c8640335fe858ebeaf2" ], "author": { "name": "Joel Kitching", "email": "kitching@google.com", "time": "Mon Nov 02 15:34:21 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Dec 04 13:13:26 2020 +0000" }, "message": "vboot: deprecate and remove legacy UI code\n\nBUG\u003db:146399181, b:167643628\nTEST\u003dmake clean \u0026\u0026 make runtests\nTEST\u003dBuild and flash to device\nBRANCH\u003dnone\n\nCq-Depend: chromium:2512739\nSigned-off-by: Joel Kitching \u003ckitching@google.com\u003e\nChange-Id: Ia8d95451d55142fbe9acaa6e49de9b5abe134083\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2512740\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\nTested-by: Joel Kitching \u003ckitching@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "03d6cc6106bd72503a669c8640335fe858ebeaf2", "tree": "8cb1f865814e951494de722595a1555459ce2fac", "parents": [ "8f083896bd3df75dec79a099bb0fc2c57fea16ba" ], "author": { "name": "Tom Hughes", "email": "tomhughes@chromium.org", "time": "Tue Dec 01 11:41:57 2020 -0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Dec 03 00:11:17 2020 +0000" }, "message": "Makefile: use -fPIC instead of -fPIE\n\nAccording to the gcc docs:\n -fPIE\n These options are similar to -fpic and -fPIC, but generated position\n independent code can be only linked into executables\n\nExample failure when linking against shared library:\n\nFAILED: lib/libbrillo-core.so\nx86_64-cros-linux-gnu-clang++ -shared -Wl,-O2 -Wl,--as-needed\n-Wl,--gc-sections -Wl,--icf\u003dall -Wl,-z,relro -Wl,-z,noexecstack\n-Wl,-z,now -Wl,--as-needed --sysroot\u003d/build/hatch -o\n./lib/libbrillo-core.so -Wl,-soname\u003dlibbrillo-core.so\n@lib/libbrillo-core.so.rsp\nld.lld: error: relocation R_X86_64_PC32 cannot be used against symbol\nsubprocess_stdin; recompile with -fPIC\n\u003e\u003e\u003e defined in\n/build/hatch/usr/lib/../lib64/libvboot_host.a(subprocess.o)\n\u003e\u003e\u003e referenced by subprocess.c:278 (host/lib/subprocess.c:278)\n\u003e\u003e\u003e subprocess.o:(subprocess_run) in archive\n/build/hatch/usr/lib/../lib64/libvboot_host.a\n\nBRANCH\u003dnone\nBUG\u003db:174578361\nTEST\u003dFEATURES\u003d\"test\" emerge-hatch vboot_reference\n\nChange-Id: I5cda8dbe87d20d1b4b659459d861bc04f492e3e5\nSigned-off-by: Tom Hughes \u003ctomhughes@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2568259\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "8f083896bd3df75dec79a099bb0fc2c57fea16ba", "tree": "75e7f3485cd4530ce3d28a9238d32e2666b12087", "parents": [ "48195e5878006ac2cf74cb7f02953ab06c68202d" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Fri Nov 20 19:53:33 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 26 13:18:13 2020 +0000" }, "message": "minidiag: Fix button initialization errors in memory tests\n\nCall log_page_init(ui) to initialize button states in memory tests.\nAdd TODO comments for splitting out log_page_update().\n\nBUG\u003db:173772273\nBRANCH\u003dzork\nTEST\u003dBuild locally\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: Icc5504bfcbfefc264a01289cc7988e97064bc8fd\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2552308\nReviewed-by: Meng-Huan Yu \u003cmenghuan@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "48195e5878006ac2cf74cb7f02953ab06c68202d", "tree": "ddda0f1d52d04ddbee29b82261214718bbfd9b88", "parents": [ "edd222428715125b9ef2a9a8a064fc32a0d0bd24" ], "author": { "name": "Patrick Georgi", "email": "pgeorgi@google.com", "time": "Fri Nov 20 21:20:15 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 24 10:23:45 2020 +0000" }, "message": "Makefile: Test for warning flags before using them\n\nTest for warning flags that older gcc versions don\u0027t support\nand only use them if supported.\n\nBUG\u003dnone\nTEST\u003dvboot builds with gcc 4.9, ensured with manual tests that the\ntest_ccflag operator works correctly.\n\nChange-Id: I14c8cbe9a687981f195d481f744db12d8877a3e0\nSigned-off-by: Patrick Georgi \u003cpgeorgi@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2550799\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nTested-by: Patrick Georgi \u003cpgeorgi@chromium.org\u003e\nCommit-Queue: Patrick Georgi \u003cpgeorgi@chromium.org\u003e\n" }, { "commit": "edd222428715125b9ef2a9a8a064fc32a0d0bd24", "tree": "402cb9a2088e7f7715f6c31464e30366c03386b8", "parents": [ "58534c3376f1caa8198d920f05cdac40cf2180d7" ], "author": { "name": "Patrick Georgi", "email": "pgeorgi@google.com", "time": "Sat Nov 21 10:53:08 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 23 16:13:23 2020 +0000" }, "message": "Split UI parts out of fwlib for host builds\n\nThey\u0027re not needed on the host (except for tests) and they trigger\na bug in GCC 4.9 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id\u003d49132).\nThis way futility remains buildable with such an old host compiler,\neven if firmware builds and serious work (with tests) needs a newer\ncompiler.\n\nError message averted (sample):\nfirmware/2lib/2ui_screens.c:17:32: error: initializer element is not constant\n #define MENU_ITEMS(a) ((struct vb2_menu){ \\\n ^\nfirmware/2lib/2ui_screens.c:1231:10: note: in expansion of macro \u0027MENU_ITEMS\u0027\n .menu \u003d MENU_ITEMS(diagnostics_memory_items),\n ^\n\nChange-Id: Ic5bd16e4d252df4297d57c5d41436f4322a1445c\nSigned-off-by: Patrick Georgi \u003cpgeorgi@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2553422\nTested-by: Patrick Georgi \u003cpgeorgi@chromium.org\u003e\nCommit-Queue: Patrick Georgi \u003cpgeorgi@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "58534c3376f1caa8198d920f05cdac40cf2180d7", "tree": "4e4744a1559d372eecc0db22b5192f784a0040cf", "parents": [ "9d4053df76c127f625a8571d3ef16e6a063c8de5" ], "author": { "name": "Patrick Georgi", "email": "pgeorgi@google.com", "time": "Sat Nov 21 10:26:01 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 23 16:13:21 2020 +0000" }, "message": "Hide __has_attribute from non-clang compilers\n\ngcc 4.9 doesn\u0027t know __has_attribute so don\u0027t expose it\nfor non-clang compilers\n\nChange-Id: I991af712adbd56d64938a35b75b7de468154e3a6\nSigned-off-by: Patrick Georgi \u003cpgeorgi@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2553421\nTested-by: Patrick Georgi \u003cpgeorgi@chromium.org\u003e\nCommit-Queue: Patrick Georgi \u003cpgeorgi@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "9d4053df76c127f625a8571d3ef16e6a063c8de5", "tree": "c266dd5dd83a6b64fee9f31012b396539b1f6a6b", "parents": [ "abcd6d24548480c1b3aeb5998c15b8548cea3b76" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Wed Nov 18 16:31:27 2020 -0800" }, "committer": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Fri Nov 20 01:51:08 2020 +0000" }, "message": "Revert \"Reland: Clean up implicit fall through.\"\n\nThis reverts commit 6208b9aa9c4e8b7c9ff8063965c9f9aa519c1740.\n\nUpstream coreboot has raised concerns that relying on GCC 7+ features\nfor host utilities is too restrictive, so revert this and go back to\ncustomizing fallthrough annotations by compiler. Cleaned out some of the\nC++-specific stuff because vboot isn\u0027t built with C++.\n\nBRANCH\u003dNone\nBUG\u003dNone\nTEST\u003dBuilt with clang and GCC.\n\nChange-Id: I75d796d289b0a6c249fc8ac2dadb1453be468642\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2547821\nReviewed-by: Manoj Gupta \u003cmanojgupta@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "abcd6d24548480c1b3aeb5998c15b8548cea3b76", "tree": "2b639efb536f166de64fc5ac4385362c5e3bab0a", "parents": [ "9a820d73511379877b077fde452c31fede89da23" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Fri Nov 06 11:24:22 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 19 05:06:30 2020 +0000" }, "message": "vboot/ui: Pass screen and locale_id to vb2ex_prepare_log_screen()\n\nTo support multi-line title for log screens, we need to support\ndifferent size of log box in each screen. Therefore, pass the screen and\nlocale information to vb2ex_prepare_log_screen() so that the number of\nlines per page can be determined.\n\nBUG\u003db:165187866\nTEST\u003demerge-asurada depthcharge\nBRANCH\u003dnone\n\nCq-Depend: chromium:2522156\nChange-Id: I652d6261ed559a948e7bd578da3ec81d54374039\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2522416\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "9a820d73511379877b077fde452c31fede89da23", "tree": "c9df9eff93ad9519e4e2c3a51739a01df3a2f0c5", "parents": [ "34e90fe57efa32774f5a5d6073cbc74a126e676c" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Wed Sep 23 12:37:45 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 12 12:40:05 2020 +0000" }, "message": "minidiag/ui: Prevent calling update action if there were no updates\n\nAdd a return code `VB2_ERROR_EX_DIAG_TEST_UPDATED` to determine if\nupdating needed.\n\nBUG\u003db:168776970\nBRANCH\u003dnone\nTEST\u003dBuild locally, boot recovery, select \u0027run diagnostics\u0027,\n enter memory test (quick) screen,\n and observe that the delay reduces while pressing keyboard\n\nCq-Depend: chromium:2423699\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I7606911bee7257e8eed4ec35d197efaa57b72e13\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2424370\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "34e90fe57efa32774f5a5d6073cbc74a126e676c", "tree": "e1cbbcac04e4ee7a4ab8efed8630b7d0204d4b9b", "parents": [ "58894ec1de7fa63948a04f72434931081f0458e4" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Tue Sep 22 15:49:29 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 12 12:40:04 2020 +0000" }, "message": "minidiag/ui: Prevent calling update action if memory test is finished\n\nSkip calling diagnostics_memory_update_screen() action if memory test is\nfinished to reduce delays in memory diagnostics screens.\n\nBUG\u003db:168776970, b:171852478\nBRANCH\u003dnone\nTEST\u003dBuild locally, boot recovery, select \u0027run diagnostics\u0027,\n enter memory test (quick) screen, wait until test is finished,\n and observe that the delay reduces while pressing keyboard\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I4f8dbadc68989112bce418119ff7405ec150a7df\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2423089\n" }, { "commit": "58894ec1de7fa63948a04f72434931081f0458e4", "tree": "279443064ae7c06da339f14c656721e1be97a98e", "parents": [ "7991ecdb219a5290e2e5a9663b19fce8e5b15145" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Wed Sep 23 14:55:24 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 12 12:40:03 2020 +0000" }, "message": "vboot/ui: Remove extra delay for long iteration time\n\nIf an iteration takes longer than KEY_DELAY_MS, no extra delay.\nOtherwise, delay until the iteration time reaches KEY_DELAY_MS.\n\nBUG\u003db:168776970\nBRANCH\u003dnone\nTEST\u003dBuild locally\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: Ia78dbe1cc87d08c02f99f4fc9269929c12c18b77\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2424373\n" }, { "commit": "7991ecdb219a5290e2e5a9663b19fce8e5b15145", "tree": "c29e14c60f3eab41e6da8b0464262eb053cc54fc", "parents": [ "10343b821fbc1e1ff9db19af45c9c0827389df7f" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Fri Oct 30 16:28:01 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 12 12:40:01 2020 +0000" }, "message": "vboot/ui/tests: Remove unnecessary aborting delay check\n\n- Do not check if delay is aborted every time since we already have\nan individual test item.\n- Do not save the last return value of vb2ex_mtime() to allow us to use\nvb2ex_mtime() elsewhere.\n- Use fuzzy match for `delay finished` test items.\n\nBUG\u003db:156448738\nBRANCH\u003dnone\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: Ic211955637c67dc35ffd4c12194a8ccb77e1bf9c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2508104\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "10343b821fbc1e1ff9db19af45c9c0827389df7f", "tree": "ba54243231658b1c97fabfd5fecfd2a323bb54ae", "parents": [ "935e2b9d3fc0dbe67cb93acaa16bac9d49bff894" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Mon Nov 02 19:32:29 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Nov 04 11:49:58 2020 +0000" }, "message": "vboot/ui/tests: Add time-related constants in 2ui_private.h\n\nAdd several constants in 2ui_private.h for testing:\n- KEY_DELAY_MS\n- DEV_DELAY_SHORT_MS\n- DEV_DELAY_NORMAL_MS\n- DEV_DELAY_BEEP1_MS\n- DEV_DELAY_BEEP2_MS\n\nBUG\u003db:156448738\nBRANCH\u003dnone\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I7349d5214a90699fda67135329d7a6b93022bb27\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2513418\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "935e2b9d3fc0dbe67cb93acaa16bac9d49bff894", "tree": "53e339de23b545dec48c12acf03d2f63727c2869", "parents": [ "f1062d8ad6e596b7e8850e60c8b7f87d8fd84041" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Mon Nov 02 18:50:51 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Nov 04 11:49:55 2020 +0000" }, "message": "vboot/ui: Suffix \"_ms\" to time-related variables\n\nFor test/vb2_ui_tests.c:\n- Rename mock_get_timer_last to mock_get_timer_last_ms.\n- Rename mock_time to mock_time_ms.\n- Rename mock_time_start to mock_time_start_ms.\n\nFor 2lib/2ui.c and 2lib/2ui_screen.c:\n- Rename start_time to start_time_ms in struct vb2_ui_context.\n- Rename elapsed to elapsed_ms in developer_mode_action().\n\nBUG\u003db:156448738\nBRANCH\u003dnone\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: Icabe04003f0dc95f41c9ed8b8e2292f1f64e86bc\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2513417\n" }, { "commit": "f1062d8ad6e596b7e8850e60c8b7f87d8fd84041", "tree": "a4fa4f90fd14080f7431e598fdb6e21465aa84e5", "parents": [ "fd5cd5aa9883d346b102210004b8fafecc1ba457" ], "author": { "name": "George Engelbrecht", "email": "engeg@google.com", "time": "Mon Nov 02 14:58:36 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 03 07:15:12 2020 +0000" }, "message": "common: log loopback detaches\n\nWe want to find the culprit loopback device which isn\u0027t detatching on\ncrbug.com/1141907. We might as well log our cleanup actions anyway, and\nthis will allow us to see the last loopback processed in production.\n\nBUG\u003dchromium:1141907\nTEST\u003djust a log message\nBRANCH\u003dNone\nSigned-off-by: George Engelbrecht \u003cengeg@google.com\u003e\nChange-Id: I126efceae4f67993069675c23f6c4af61c7e5667\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2514561\nReviewed-by: LaMont Jones \u003clamontjones@chromium.org\u003e\n" }, { "commit": "fd5cd5aa9883d346b102210004b8fafecc1ba457", "tree": "fda74bda3f575222f95d45e99e26a05f04e0b98b", "parents": [ "204dfbdf7b70d798cb01e8785e8de58615ef8d16" ], "author": { "name": "George Engelbrecht", "email": "engeg@google.com", "time": "Mon Nov 02 14:24:23 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 03 07:15:11 2020 +0000" }, "message": "common: save the existing return value on cleanup\n\nCurrently this trap initiated function will not save the orginal return\nvalue of the script. Save it and return it on exit.\n\nBUG\u003dchromium:1141907\nTEST\u003dunittest and manually on a signer\nBRANCH\u003dNone\nSigned-off-by: George Engelbrecht \u003cengeg@google.com\u003e\nChange-Id: Icd807f4d153e4bcc1d309fbcea43c2b3344771ca\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2514560\nReviewed-by: Sean McAllister \u003csmcallis@google.com\u003e\nReviewed-by: LaMont Jones \u003clamontjones@chromium.org\u003e\n" }, { "commit": "204dfbdf7b70d798cb01e8785e8de58615ef8d16", "tree": "f667f2f643c8b02e08447b849d2df71e2adf6f13", "parents": [ "0d46f9d37e24473569f36d8250979290d09edfde" ], "author": { "name": "George Engelbrecht", "email": "engeg@google.com", "time": "Mon Nov 02 14:16:03 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 03 07:15:10 2020 +0000" }, "message": "cleanup_minimal: remove duplicate trap for temps and mounts\n\nBUG\u003dchromium:1141907\nTEST\u003dunit tests and manual signing run\nSigned-off-by: George Engelbrecht \u003cengeg@google.com\u003e\nBRANCH\u003dnone\n\nChange-Id: I0316f464e138dea9e77b2554a3b31250e8b92c07\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2514559\nReviewed-by: Sean McAllister \u003csmcallis@google.com\u003e\nReviewed-by: LaMont Jones \u003clamontjones@chromium.org\u003e\nCommit-Queue: George Engelbrecht \u003cengeg@google.com\u003e\nTested-by: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "0d46f9d37e24473569f36d8250979290d09edfde", "tree": "38528fe29510dbe625b48f5975106e495d206c05", "parents": [ "45d821b531a9469d4e884c82c1e091631f7e069c" ], "author": { "name": "George Engelbrecht", "email": "engeg@google.com", "time": "Mon Nov 02 13:30:01 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 03 07:15:08 2020 +0000" }, "message": "common.sh: adapt to get clean shellcheck\n\nBUG\u003dchromium:1141907\nTEST\u003dunit tests and manual signing run\nSigned-off-by: George Engelbrecht \u003cengeg@google.com\u003e\nBRANCH\u003dnone\n\nChange-Id: I39b133ca69e717576140b418fc59dd167f068d59\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2514558\nReviewed-by: Sean McAllister \u003csmcallis@google.com\u003e\nReviewed-by: LaMont Jones \u003clamontjones@chromium.org\u003e\nCommit-Queue: George Engelbrecht \u003cengeg@google.com\u003e\nTested-by: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "45d821b531a9469d4e884c82c1e091631f7e069c", "tree": "2f07f3017139209a01856b83897373f6dcad0212", "parents": [ "d621e58a53c72b64aea88df19fd29560d635e956" ], "author": { "name": "George Engelbrecht", "email": "engeg@google.com", "time": "Sat Oct 31 16:07:15 2020 -0600" }, "committer": { "name": "George Engelbrecht", "email": "engeg@google.com", "time": "Sat Oct 31 22:11:34 2020 +0000" }, "message": "common.sh: don\u0027t let eval terminate cleanup\n\nEval will terminate the shell on non-zero error code.\n\n\"POSIX says that an error in a special built-in utility\n(such as eval) should cause the non-interactive shell to terminate\"\n\nThis is the case and is causing cleanup to terminate android signing\nwith a non-zero error when it is clear the intent (given the set +e) is\nthat we should be best effort here.\n\nBUG\u003dchromium:1141907\nTEST\u003dunittest and manually on a signer\n\nChange-Id: Ie6374b292c7982371d549b919b44328ea71a09dd\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2513228\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nTested-by: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "d621e58a53c72b64aea88df19fd29560d635e956", "tree": "e82c9570fdb4565010ba9eedf0a0201ede56690c", "parents": [ "3c644e07368c8827c1de1c8d919c48dac1153c6a" ], "author": { "name": "George Engelbrecht", "email": "engeg@google.com", "time": "Fri Oct 30 16:18:04 2020 -0600" }, "committer": { "name": "George Engelbrecht", "email": "engeg@google.com", "time": "Fri Oct 30 22:36:02 2020 +0000" }, "message": "sign_android: don\u0027t use xattrs from unsquashfs\n\nWe\u0027ve moved to applying a file based set of selinux policies instead of\ntaking the ones that were snagged from the image. Remove the policy\nattributes and let unsquash do whatever it would do by default.\n\nSee https://chat.google.com/room/AAAA45hbdCQ/jkXYe7jMEDk.\n\nBUG\u003dchromium:1141907\nTEST\u003dunittests\n\nChange-Id: I0a976fb216e0a07c00c4bb2fb68df6fa1ea00d79\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2511121\nReviewed-by: Yury Khmel \u003ckhmel@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Yury Khmel \u003ckhmel@google.com\u003e\nCommit-Queue: George Engelbrecht \u003cengeg@google.com\u003e\nCommit-Queue: Yury Khmel \u003ckhmel@google.com\u003e\nTested-by: George Engelbrecht \u003cengeg@google.com\u003e\nAuto-Submit: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "3c644e07368c8827c1de1c8d919c48dac1153c6a", "tree": "fd29b87dcf3c28811055d29c73c5f44a36f4f9cf", "parents": [ "191d52fb9f64b749ca0577d454da679e58ad5a36" ], "author": { "name": "Brian Norris", "email": "briannorris@chromium.org", "time": "Tue Oct 27 15:57:29 2020 -0700" }, "committer": { "name": "LaMont Jones", "email": "lamontjones@chromium.org", "time": "Wed Oct 28 20:06:14 2020 +0000" }, "message": "sign_official_build: dump more info in resign_android_image_if_exists\n\nWe\u0027re getting silent errors in here somewhere.\n\nBRANCH\u003dnone\nBUG\u003dchromium:1141907\nTEST\u003dnone\n\nChange-Id: I9af0a3ea1696920fe67c915660f82a68c1bddf34\nSigned-off-by: Brian Norris \u003cbriannorris@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2504358\nReviewed-by: LaMont Jones \u003clamontjones@chromium.org\u003e\nCommit-Queue: LaMont Jones \u003clamontjones@chromium.org\u003e\nTested-by: LaMont Jones \u003clamontjones@chromium.org\u003e\n" }, { "commit": "191d52fb9f64b749ca0577d454da679e58ad5a36", "tree": "6fb3c261c50f42f5b43bd9297d0a0b2171f36ea7", "parents": [ "772d739ac180e1601d24c47e6f21bb5dcc81c11f" ], "author": { "name": "Yi Chou", "email": "yich@google.com", "time": "Wed Oct 14 15:46:47 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 28 15:20:03 2020 +0000" }, "message": "crossystem: support clear_tpm_owner_request on TPM2.0 simulator\n\nThis CL would give VM boards the ability to hard reset TPM.\n\nWhen clearing TPM ownership on real devices, there are two things\nwould happen:\n1. TPM reset all of its NVRAM data.\n2. mount-encrypted can\u0027t decrypt old encrypted partition.\n\nThe TPM2.0 simulator put its NV space at \"/var/lib/trunks/NVChip\".\nAnd \"/var/lib\" is under encrypted partition.\nRemove the mount-encrypted key would cause mount-encrypted lost the\nencrypted partition on next boot, and it would simply achieve those\ntwo targets.\n\nBUG\u003db:170785530\nBRANCH\u003dnone\nTEST\u003dcrossystem clear_tpm_owner_request\u003d1\n\nCq-Depend: chromium:2501904\nSigned-off-by: Yi Chou \u003cyich@google.com\u003e\nChange-Id: Ifeff0cf03bf76706849905816d22024f3d1b952f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2470577\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "772d739ac180e1601d24c47e6f21bb5dcc81c11f", "tree": "9c5061d36d45e8b7e6b91a165617242a57b37ba4", "parents": [ "920a1202ad7afdda4f0110eb1c18f1a40ab36b9a" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Thu Sep 24 16:10:12 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 16 11:12:50 2020 +0000" }, "message": "futility: update: load quirks from firmware image CBFS file\n\nThe firmware updater now looks at CBFS \u0027FW_MAIN_A\u0027 (RW A) and if a text\nfile \u0027updater_quirks\u0027 is found, the contents will be fetched to setup\ndefault quirks.\n\nThis helps sharing same customization across multiple firmware images\n(for different models) shared by same unibuild OS image. Without that,\nwe have to maintain a large list of hard-coded model names in firmware\nupdater source.\n\nBRANCH\u003dnone\nBUG\u003db:169284414\nTEST\u003dmake runtests\n\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nChange-Id: I938bffe9f16bc3adee0dc3efb6976efe581c6d8c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2426093\nReviewed-by: Karthikeyan Ramasubramanian \u003ckramasub@chromium.org\u003e\n" }, { "commit": "920a1202ad7afdda4f0110eb1c18f1a40ab36b9a", "tree": "e793ea094e84b99a0508ab7b1a4b80b38ca30bfc", "parents": [ "662bb489d5061348d6eb61490185d0944d1ba817" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Tue Oct 13 16:58:01 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 16 01:34:10 2020 +0000" }, "message": "lib: gpt_misc: Avoid leaving GPT entries data uninitialized\n\nIf we fail reading a GPT header, we memset() the respective buffer to 0\nto avoid operating on uninitialized bytes. We should do the same for the\nGPT entries array.\n\nBRANCH\u003dNone\nBUG\u003dchromium:1137521\nTEST\u003dmake runtests\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: I1019eaf5e9ab05cd9953a15874f4931766952d88\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2469601\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "662bb489d5061348d6eb61490185d0944d1ba817", "tree": "926d3a202b68e2b6f99eed27cb4970e7e45f687c", "parents": [ "ee0b21b31c48c2d9bb65a020643271d435edb0d9" ], "author": { "name": "Karthikeyan Ramasubramanian", "email": "kramasub@google.com", "time": "Sun Oct 11 23:21:09 2020 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 15 22:01:13 2020 +0000" }, "message": "futility/updater: Add quirk to preserve management engine\n\nIn recent Intel platforms, updating Management Engine (ME) while SoC is in\nS0 state is an unsupported use-case. To work-around this issue for the\ndevices that are in development, specifically during firmware update,\nthis quirk is added to preserve the ME region. In the subsequent boot,\nME region is updated as part of boot firmware update upstart script.\n\nBUG\u003db:165590952\nBRANCH\u003dNone\nTEST\u003dWith the quirk enabled, ensured that the ME is preserved under the\nfollowing scenario:\nchromeos-firmwareupdate --mode\u003dautoupdate\nchromeos-firmwareupdate --mode\u003drecovery\nfutility update --mode\u003dautoupdate -a /usr/sbin/chromeos-firmwareupdate\nfutility update --mode\u003drecovery -a /usr/sbin/chromeos-firmwareupdate\nIn other scenarios, ME region is not preserved.\n\nChange-Id: I81a52d11d1fb363b7e07ef3439b927449456b28a\nSigned-off-by: Karthikeyan Ramasubramanian \u003ckramasub@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2465286\nTested-by: Karthikeyan Ramasubramanian \u003ckramasub@chromium.org\u003e\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nCommit-Queue: Karthikeyan Ramasubramanian \u003ckramasub@chromium.org\u003e\n" }, { "commit": "ee0b21b31c48c2d9bb65a020643271d435edb0d9", "tree": "1a017d8f38028e8a8365e43eb3eed5e545706804", "parents": [ "86f6ce865157a35c3c4e1aab3f75b45aac2c9720" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Tue Oct 13 15:03:20 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 15 02:17:29 2020 +0000" }, "message": "futility: update: support multi-line quirks\n\nTo support loading quirks from external files, we want to skip tab (\\t)\nand new line characters (\\n, \\r).\n\nBRANCH\u003dnone\nBUG\u003db:169284414\nTEST\u003dmake runtests\n\nChange-Id: If314d6cf36907837ce9c36b73337976ee0c6fad1\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2467305\nReviewed-by: Karthikeyan Ramasubramanian \u003ckramasub@chromium.org\u003e\nCommit-Queue: Karthikeyan Ramasubramanian \u003ckramasub@chromium.org\u003e\n" }, { "commit": "86f6ce865157a35c3c4e1aab3f75b45aac2c9720", "tree": "3b3f8bd0d49253692bb02c23a7673d867cbe59bd", "parents": [ "4dacbf92be28c937e07b397ade29e5b8a84cdb7f" ], "author": { "name": "Yury Khmel", "email": "khmel@google.com", "time": "Thu Oct 08 21:26:35 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 14 19:53:30 2020 +0000" }, "message": "signer: syncronize image packing to what we have in build image phase.\n\nThis follows steps we have in build image phase to have parity in image\npacking.\n * Discard reapply selinex context. This looks not needed once\n re-signing should not change selinux context. Instead we could do\n similar to build image, pass file context to mksquashfs\n * Apply mksquashfs params based on image type, container/vm. This\n fixes proper block size and image compression algorithm\n * Remove old image before packing to prevent mksquashfs merge attempt\n\nBUG\u003db:170400225\nBUG\u003db:170220295\nBUG\u003db:170219920\nBRANCH\u003dnone\nTEST\u003dlocally signed vm (kohaku) and container (hana): arc.Optin*,\n arc.Preopt*. Also checked final image size. With this CL it is\n reduced to 150Mb(vm) and very close to original image size\n (delta is less than 0.1%)\n\nSigned-off-by: Yury Khmel \u003ckhmel@chromium.org\u003e\nChange-Id: I7037bea68fc2969345a8fabc3c6a9b9b690f02d1\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2462005\nReviewed-by: Yusuke Sato \u003cyusukes@chromium.org\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nTested-by: Yury Khmel \u003ckhmel@google.com\u003e\nAuto-Submit: Yury Khmel \u003ckhmel@google.com\u003e\nCommit-Queue: Yury Khmel \u003ckhmel@google.com\u003e\n" }, { "commit": "4dacbf92be28c937e07b397ade29e5b8a84cdb7f", "tree": "81bdd763aa1f62e494880e56b47a4af9cdb5f2ed", "parents": [ "519c608d2464b5b45b7bfe432a27eae119777971" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Tue Oct 13 19:04:52 2020 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 14 15:44:56 2020 +0000" }, "message": "crossystem: remove mosys nvstorage implementation\n\nAs promised, it\u0027s October 2020, nyan_kitty went AUE with M85, and M86\njust got pushed stable. That means we can now delete this code :)\n\nBUG\u003dchromium:1090803\nBRANCH\u003dnone\nTEST\u003dcompiles\n\nSigned-off-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nChange-Id: I5a15ef1e1ad02885af135d8e42d02d492bdd6c05\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2469604\nReviewed-by: Paul Fagerburg \u003cpfagerburg@chromium.org\u003e\n" }, { "commit": "519c608d2464b5b45b7bfe432a27eae119777971", "tree": "9f6053cb0e9b7457c564e7a197cf451958e599ea", "parents": [ "4e93a487ff99c80777ee80f183193e07bc58c41d" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Thu Sep 24 12:06:06 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 14 05:58:49 2020 +0000" }, "message": "vboot/ui: Split disabled_item_mask into two masks for log screen\n\nAdd three macros in 2api.h for bitmask operations:\n- VB2_SET_BIT(mask, index)\n- VB2_CLR_BIT(mask, index)\n- VB2_GET_BIT(mask, index)\nThese macros will be used in corresponding depthcharge CLs.\n\nSplit disabled_item_mask into:\n- disabled_item_mask: Disabled style, but still visible and selectable.\n- hidden_item_mask: Not visible.\n\nIgnore selecting on disabled menu items.\n\nSet appropriate disabled_item_mask for page up/down buttons in log\nscreen.\n\nRevise tests of hidden_item_mask and add unit tests of disabled_item_mask.\n\nBUG\u003db:163301076, b:146399181\nBRANCH\u003dnone\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang; DETACHABLE\u003d1;\n make clean \u0026\u0026 make runtests\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang; PHYSICAL_PRESENCE_KEYBOARD\u003d1;\n make clean \u0026\u0026 make runtests\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang; DIAGNOSTIC_UI\u003d1;\n make clean \u0026\u0026 make runtests\nTEST\u003dBuild locally, navigate to debug info screen with \u003cTAB\u003e,\n select page up or page down, and observe that nothing happens.\n\nCq-Depend: chromium:2432168\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I1607af53f6e2b5c1cde568cb24606314051d2380\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2426154\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "4e93a487ff99c80777ee80f183193e07bc58c41d", "tree": "987fe31e34cde02ee8947d247d1fdb0607f21674", "parents": [ "68e42911998b23d244f281990b7040fefd12995e" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Mon Oct 05 15:44:25 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 12 13:38:30 2020 +0000" }, "message": "vboot/ui/tests: Fix ignoring vb2ex_display_ui calls in unit tests\n\nSave parameters `timer_disabled` and `error_code` in mocked\nvb2ex_displayed_ui calls to check whether the consecutive calls are\nduplicate or not.\n\nThe unit tests of these parameters will be added in following CLs.\n\nBRANCH\u003dnone\nBUG\u003db:146399181, b:156448738\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang; DETACHABLE\u003d1;\n make clean \u0026\u0026 make runtests\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang; PHYSICAL_PRESENCE_KEYBOARD\u003d1;\n make clean \u0026\u0026 make runtests\nTEST\u003dFEATURES\u003dtest PKGDIR\u003d/build/puff/test-packages\n /mnt/host/source/chromite/bin/parallel_emerge\n --sysroot\u003d/build/puff --jobs\u003d32 vboot_reference\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I2b7c9b6b05d2427e938394ff9d0769fbde81f773\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2449310\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "68e42911998b23d244f281990b7040fefd12995e", "tree": "93b17bc1c793bda732e100c1d45595a71210f6e5", "parents": [ "9b010ef3f07ba0539f78696bde2a0842b766cfea" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Wed Oct 07 11:36:58 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 12 13:38:29 2020 +0000" }, "message": "vboot/ui/tests: Fix struct compare error in unit tests\n\nUse packed structures to avoid unexpected error about padding.\n\nBUG\u003db:156448738, b:170186754\nBRANCH\u003dnone\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\nTEST\u003dFEATURES\u003dtest PKGDIR\u003d/build/puff/test-packages\n /mnt/host/source/chromite/bin/parallel_emerge\n --sysroot\u003d/build/puff --jobs\u003d32 vboot_reference\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: Ibdcffe81d92db2880c53282a313ffa678af7d43d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2454911\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "9b010ef3f07ba0539f78696bde2a0842b766cfea", "tree": "e2cbbc38cd29443fbcfcd0487b123727d9242011", "parents": [ "6f5af922dfcc7b7c196537900b9229004ad1d025" ], "author": { "name": "Victor Hsieh", "email": "victorhsieh@chromium.org", "time": "Wed Oct 07 17:12:02 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 09 03:22:05 2020 +0000" }, "message": "signer: resign networkstack APKs with correct key\n\nBUG\u003db:170156734\nBRANCH\u003dnone\nTEST\u003dsign rvc-arc image\n\nSigned-off-by: Victor HSieh \u003cvictorhsieh@chromium.org\u003e\nChange-Id: I99fc4eb19be6cc785297e223a6603c1d777c5c77\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2458789\nReviewed-by: Yury Khmel \u003ckhmel@chromium.org\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "6f5af922dfcc7b7c196537900b9229004ad1d025", "tree": "76833b44fc84cabff981cf940c10020277d65584", "parents": [ "d8367f0d08a1af4655bfd4c5cef54dc5c79cca07" ], "author": { "name": "Victor Hsieh", "email": "victorhsieh@chromium.org", "time": "Mon Oct 05 15:40:32 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 08 00:00:31 2020 +0000" }, "message": "Deal with Android\u0027s new networkstack key\n\nBUG\u003db:170156734\nTEST\u003drun signing script locally\nBRANCH\u003dNone\n\nSigned-off-by: Victor HSieh \u003cvictorhsieh@chromium.org\u003e\nChange-Id: I4f045729241b479b56fef5687b721b5b59c2eed8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2450551\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "d8367f0d08a1af4655bfd4c5cef54dc5c79cca07", "tree": "47506a93ce420fc18ccd93dcfd6af6d01b93e5d5", "parents": [ "7c6bf3080a20077f1da49bc383297ac33bce35f8" ], "author": { "name": "Yury Khmel", "email": "khmel@google.com", "time": "Sat Oct 03 08:49:18 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 06 18:57:30 2020 +0000" }, "message": "arc: Fix RVC signed image does not boot.\n\nThis supports new set of certificates plat_mac_permissions.xml and adds\nhandling media and network_stack certificates.\n\nBRANCH\u003dnone\nBUG\u003db:169458218\nTEST\u003dSign test image from goldeneye per instructions in bug, deploy\nit to device (kohaku) pass tast.arc.Optin.vm test\n\nSigned-off-by: Yury Khmel \u003ckhmel@chromium.org\u003e\nChange-Id: I61c4e327eaa605ed60c0c80b3598c0f4fb6e5f5f\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2447430\nTested-by: Yury Khmel \u003ckhmel@google.com\u003e\nAuto-Submit: Yury Khmel \u003ckhmel@google.com\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nCommit-Queue: Yury Khmel \u003ckhmel@google.com\u003e\n" }, { "commit": "7c6bf3080a20077f1da49bc383297ac33bce35f8", "tree": "089b5f738bba8822d09e9d9d819e080c67e89416", "parents": [ "a5c13bc047d656545d8f9ff345d49e636f678311" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Thu Sep 24 15:54:39 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 05 12:26:04 2020 +0000" }, "message": "lib21: always append \u0027\\0\u0027 in vb2_readfile\n\nFor utilities reading text file, it is easier to process as ASCIIZ input\nif vb2_readfile can always return a buffer ends with \u0027\\0\u0027 so we don\u0027t\nneed to pass and check the size.\n\nBUG\u003dNone\nTEST\u003dmake clean \u0026\u0026 make runtests\nBRANCH\u003dNone\n\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nChange-Id: Ib6294969fb325b9b7899e6295fb1817ad91a9952\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2426092\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "a5c13bc047d656545d8f9ff345d49e636f678311", "tree": "025ff3ad3ef99789229fc2e181f3a562f9a1724b", "parents": [ "a8dd21bf2f94be2463338d66b97105aeb7a6cdc6" ], "author": { "name": "Joel Kitching", "email": "kitching@google.com", "time": "Thu Sep 24 17:13:31 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 05 10:42:12 2020 +0000" }, "message": "vboot/ui: fix some rogue spacing\n\nBUG\u003db:146399181\nTEST\u003dmake clean \u0026\u0026 make runtests\nBRANCH\u003dnone\n\nSigned-off-by: Joel Kitching \u003ckitching@google.com\u003e\nChange-Id: I884ec94adc762549ad565fe0796d3db625039f64\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2428563\nTested-by: Joel Kitching \u003ckitching@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "a8dd21bf2f94be2463338d66b97105aeb7a6cdc6", "tree": "3aa973fb1cee82553491346fa66556995659f57b", "parents": [ "9c9f616ec70672590477fcd2f23fb050dfa8eb48" ], "author": { "name": "Joel Kitching", "email": "kitching@google.com", "time": "Thu Sep 24 17:11:49 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 05 10:42:11 2020 +0000" }, "message": "vboot/ui: introduce casts around vb2_menu_item helpers\n\nFollow same style as MENU_ITEMS macro for clarity and safety.\n\nBUG\u003db:146399181\nTEST\u003dmake clean \u0026\u0026 make runtests\nBRANCH\u003dnone\n\nSigned-off-by: Joel Kitching \u003ckitching@google.com\u003e\nChange-Id: I9aac27dca763c98fd5ca7e35219163d990c73ab0\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2428202\nTested-by: Joel Kitching \u003ckitching@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nCommit-Queue: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "9c9f616ec70672590477fcd2f23fb050dfa8eb48", "tree": "20fbd730a292c3eb0d09a9dec613b114094a73a9", "parents": [ "4c523ed10f25de872ac0513ebd6ca53d3970b9de" ], "author": { "name": "Joel Kitching", "email": "kitching@google.com", "time": "Thu Sep 24 17:07:59 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 05 10:42:10 2020 +0000" }, "message": "vboot/ui: stop including 2secdata.h in 2ui.c\n\nHeader not needed.\n\nBUG\u003db:146399181\nTEST\u003dmake clean \u0026\u0026 make runtests\nBRANCH\u003dnone\n\nSigned-off-by: Joel Kitching \u003ckitching@google.com\u003e\nChange-Id: I84585909db16ce71cf4ba1beba1f6924c9e71457\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2428201\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nTested-by: Joel Kitching \u003ckitching@chromium.org\u003e\nCommit-Queue: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "4c523ed10f25de872ac0513ebd6ca53d3970b9de", "tree": "e8bcb22da0a7713b55413f424096ae5d97e70b99", "parents": [ "524012c64c07f8673998428cca7f80e01a387f48" ], "author": { "name": "Kangheui Won", "email": "khwon@chromium.org", "time": "Fri Oct 02 11:09:06 2020 +1000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Oct 03 02:02:13 2020 +0000" }, "message": "vboot2: Add support for modexp acceleration\n\nAdd vb2ex_hwcrypto_modexp support to accelerate only calculation part of\nRSA and we can handle the rest. Instead of relying on opaque hardware\naccleration for all RSA verification process, this will enable us to\nmaintain our security level while enhancing overall speed of\nverification.\n\nBRANCH\u003dzork\nBUG\u003db:169157796\nTEST\u003dmake runtests\n\nSigned-off-by: Kangheui Won \u003ckhwon@chromium.org\u003e\nChange-Id: I6f9fc919c4215964158815a58a9f1b338c2a76a4\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2444809\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "524012c64c07f8673998428cca7f80e01a387f48", "tree": "d011d454951af2d6dbcf7d4dc7af53a31cc883db", "parents": [ "98ab5ea45d8eaa194e52f0347fc19f767663f8c1" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Sep 25 11:11:22 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Sep 26 09:18:33 2020 +0000" }, "message": "futility: updater: print flashrom execution logs on read failure\n\nTo prevent flooding AU logs, we don\u0027t want flashrom to print verbose\nlogs especially when reading system SPI flash. However, if anything goes\nwrong it will be very helpful to have all the messages logged.\n\nWith this patch, we will try reading system flash again with max verbosity.\n\nBUG\u003dchromium:943262,b:169026171\nTEST\u003dmake futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility\nBRANCH\u003dNone\n\nChange-Id: I5469182f2628855e65546bef3abf8791261aabca\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1545598\nCommit-Queue: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\n" }, { "commit": "98ab5ea45d8eaa194e52f0347fc19f767663f8c1", "tree": "9dd29340bb63e7a2221b4b667b691d668a81eb36", "parents": [ "a2291a962395440966a9aac2c241d46e07f23e2d" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Tue Sep 08 10:40:37 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 24 04:19:37 2020 +0000" }, "message": "vboot/ui: Always beep when error dialog is shown\n\nSetting error_code always implies we need to beep.\n\nBUG\u003db:146399181\nTEST\u003dBuild locally\nBRANCH\u003dzork\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I65d790a63739f36dc1db8e22321adbff26d70893\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2397017\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "a2291a962395440966a9aac2c241d46e07f23e2d", "tree": "e57aceaeeda1a2978652c56abce4e05086134faa", "parents": [ "6c15b6cfb29082147e93b3c9e510a796a8d85a75" ], "author": { "name": "Shelley Chen", "email": "shchen@google.com", "time": "Mon Aug 17 00:52:47 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 24 02:20:42 2020 +0000" }, "message": "firmware/2lib: Add error message for ctrl-U when usb boot is not enabled\n\nCurrently, we only have a beep when the user presses ctrl-u. Adding\nan error message to clarify what the error is.\n\nBUG\u003db:164944674\nBRANCH\u003dpuff, zork\nTEST\u003dboot into developer mode\n make sure \"boot from external disk\" doesn\u0027t appear\n press ctrl+U and make sure dialog box with error appears\n\nCq-Depend: chromium:2359765\nSigned-off-by: Shelley Chen \u003cshchen@google.com\u003e\nChange-Id: Id8fad79802cb61883758e8c7561163cc17fb0f87\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2359768\nTested-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\nCommit-Queue: Shelley Chen \u003cshchen@chromium.org\u003e\n" }, { "commit": "6c15b6cfb29082147e93b3c9e510a796a8d85a75", "tree": "03c429b88a0a3e6558b32d785e5425c772b845c6", "parents": [ "07cd40854b31ad018657a173d4ff422d575a1f8f" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Aug 14 15:31:25 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Sep 23 01:19:25 2020 +0000" }, "message": "make_dev_ssd.sh: Correct root partition regular expression\n\nDiscovered by CL:2353632, the regular expression for extracting rootfs\npartition should include non-digit character first otherwise we won\u0027t\nget correct number when the partition number is longer than one digit\n(e.g., \u003e\u003d10).\n\nBUG\u003dNone\nTEST\u003d./make_dev_ssd.sh\nBRANCH\u003dnone\n\nChange-Id: I155e04beec47c55df4d09cb78168ab0a7407c697\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2353776\nReviewed-by: Kuang-che Wu \u003ckcwu@chromium.org\u003e\n" }, { "commit": "07cd40854b31ad018657a173d4ff422d575a1f8f", "tree": "0d25824de1d34ab7fce126b05409aa234a5e1d5a", "parents": [ "4e5ce4293a724bce9e1fa36c5e305bdbc85946bd" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Mon Aug 31 14:04:57 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Sep 21 04:08:18 2020 +0000" }, "message": "firmware/2lib: Handle errors in alternate boot\n\nHandle three different errors in alternate boot:\n- VB2_UI_ERROR_ALTERNATE_BOOT_DISABLED\n- VB2_UI_ERROR_NO_BOOTLOADER\n- VB2_UI_ERROR_ALTERNATE_BOOT_FAILED\n\nBUG\u003db:146399181, b:161092974\nTEST\u003dmake clean \u0026\u0026 make runtests\nBRANCH\u003dpuff, zork\n\nCq-Depend: chromium:2384995\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I1e6572ed4a1c756d6d3727818439de25cad03158\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2382998\nTested-by: Shelley Chen \u003cshchen@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Shelley Chen \u003cshchen@chromium.org\u003e\n" }, { "commit": "4e5ce4293a724bce9e1fa36c5e305bdbc85946bd", "tree": "38b606e00753d0c1d6e63ce1cfabb405579fb2da", "parents": [ "3fbb2d16c42b70a1fdf57dc693e10ca11c998d10" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Tue Sep 15 15:30:00 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 17 05:09:39 2020 +0000" }, "message": "vboot/ui: Force to reacquire log on initialization\n\nForce to reacquire a newer firmware log snapshot every time when the\nuser enters the firmware log screen.\n\nRe-entering (e.g. back from language selection or debug info tab) will\nstill show the cached firmware log string.\n\nBUG\u003db:146399181, b:168442372\nTEST\u003dmake clean \u0026\u0026 make runtests\nTEST\u003dBuild locally, navigate to the firmware log screen,\n go back, and enter the firmware log screen again.\nBRANCH\u003dnone\n\nCq-Depend: chromium:2409742\nChange-Id: I8c3eea23446c58603ce698a86f1aca4b264ebb0e\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2411761\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "3fbb2d16c42b70a1fdf57dc693e10ca11c998d10", "tree": "fbf3bc7079036d435fee47cf390f35e56551ccb0", "parents": [ "3f96c587e972e926badb50a15d4040e3ace8da62" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Wed Sep 09 18:45:38 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 15 17:57:37 2020 +0000" }, "message": "fuzzers: Initialize secdata\n\nCL:2353775 made the functions tested by vb2_keyblock_fuzzer and\nvb2_preamble_fuzzer look at secdata, which broke the fuzzer because they\ndon\u0027t initialize secdata the way a normal boot would. This patch makes\nthe fuzzers initialize both firmware and kernel secdata explicitly (and\nnvdata as well for good measure, although I think it\u0027s technically not\nneeded).\n\nBRANCH\u003dNone\nBUG\u003dchromium:1125143,chromium:1124172\nTEST\u003dNone\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: Id9aaa4d44a20455133adc4c2bc524895629edfb9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2402423\nCommit-Queue: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "3f96c587e972e926badb50a15d4040e3ace8da62", "tree": "aee337c7fbcf281e7e20c284da226af855700ff7", "parents": [ "750da40fb8a9b6692d2ce6df39e527f5120c128c" ], "author": { "name": "Jacob Garber", "email": "jgarber1@ualberta.ca", "time": "Thu Sep 03 15:46:47 2020 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 15 04:35:42 2020 +0000" }, "message": "host: Make gpiochip path buffer larger\n\nThe name of a gpiochip can in theory be up to NAME_MAX characters long\n(usually 255), which exceeds the length of the 30 byte buffer allocated\nfor it. In practice we won\u0027t need more than the 30 bytes, but the\nsmaller buffer trips a -Wformat-truncation warning from GCC that makes\nthe build fail. Make the buffer bigger to keep GCC happy.\n\nBUG\u003dnone\nBRANCH\u003dnone\nTEST\u003dmake utillib compiles on BeagleBone Black\n\nChange-Id: I528f395033f58057846e717ff126e7a5dca504e3\nSigned-off-by: Jacob Garber \u003cjgarber1@ualberta.ca\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2393193\nTested-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nCommit-Queue: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "750da40fb8a9b6692d2ce6df39e527f5120c128c", "tree": "668323f67927964c7a25769a66afd62ae51b982b", "parents": [ "4bb06cc1b73c738acf056d7fc0a96c4690e8ef8a" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Fri Sep 04 19:28:47 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Sep 12 09:29:08 2020 +0000" }, "message": "vboot/ui: Disallow Ctrl-S when GBB forces dev mode\n\nWhen GBB forces developer mode (VB2_GBB_FLAG_FORCE_DEV_SWITCH_ON),\ndisallow Ctrl-S shortcut in developer screens. Beep and show an error\nmessage when Ctrl-S is pressed.\n\nBRANCH\u003dzork\nBUG\u003db:146399181, b:164975737\nTEST\u003dexport CC\u003dx86_64-pc-linux-gnu-clang; make runtests\nTEST\u003demerge-nami depthcharge\n\nCq-Depend: chromium:2397556\nChange-Id: I62d18575290498b7ae829c2b3a2ff8dda6679636\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2390593\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "4bb06cc1b73c738acf056d7fc0a96c4690e8ef8a", "tree": "4206b2f4324c1b4dc4720ef186046a807ad72f84", "parents": [ "1166a2fa507be97896e41ed048693e9232e26f62" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Wed Sep 09 14:51:10 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 11 16:57:37 2020 +0000" }, "message": "COIL: Change denylist to blocklist\n\nThe signer uses BLOCKLIST instead of DENYLIST. This patches make the\nlanguage match.\n\nBUG\u003db:163883397\nBRANCH\u003dNone\nTEST\u003degrep -i -I -r \"deny.*list\"\nTEST\u003dmake runtests\n\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nChange-Id: I47c913eb2ca89cd3eea4ca3ff5f1accb223ba418\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2401968\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "1166a2fa507be97896e41ed048693e9232e26f62", "tree": "98d64bb08ef4fb252e34396eb60708f6ce732e9a", "parents": [ "f573cf6669b5f2972f29f511efead068b8c3b38e" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Fri Aug 21 10:22:41 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 11 16:57:36 2020 +0000" }, "message": "COIL: Change sane to inclusive words\n\nBUG\u003db:163883397\nBRANCH\u003dNone\nTEST\u003dmake runtests\nTEST\u003degrep -r -i -I \u0027(sane|insane)\u0027\n\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nChange-Id: I109207575e2c00d6aa3b0ed17de7f699087a9658\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2369464\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "f573cf6669b5f2972f29f511efead068b8c3b38e", "tree": "a294e9fafe4ddf4692ac79820abaa6c4a67d0509", "parents": [ "ade6151a678c59e270c89bcca37f61cfdd41700d" ], "author": { "name": "Joel Kitching", "email": "kitching@google.com", "time": "Mon Aug 03 23:52:27 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 11 10:47:08 2020 +0000" }, "message": "vboot: Introduce alternate boot functionality\n\nIntroduce alternate boot functionality both via keyboard shortcut\n(\"Ctrl+L\") to directly boot into the default alternate bootloader,\nand via menu (\"Alternate bootloader\" on dev screen) to show a screen\nlisting available bootloaders.\n\nBUG\u003db:146399181, b:161092974\nTEST\u003dmake clean \u0026\u0026 make runtests\nBRANCH\u003dpuff, zork\n\nCq-Depend: chromium:2339040\nSigned-off-by: Joel Kitching \u003ckitching@google.com\u003e\nChange-Id: I28f157936017719dc95656db147967f5e61a1407\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2335017\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nTested-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "ade6151a678c59e270c89bcca37f61cfdd41700d", "tree": "446f2f41581df2f1939abaa544b4ead71a36417a", "parents": [ "176e01ded3bcefb6cb8baa984a158d42562bb1e9" ], "author": { "name": "Idwer Vollering", "email": "vidwer@gmail.com", "time": "Fri Aug 28 23:16:28 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 11 01:29:19 2020 +0000" }, "message": "portability fixes: support building vboot on FreeBSD\n\nBuilt on FreeBSD 12.1-RELEASE, 13-CURRENT, using gcc9 installed from\npackages.\n\nChange-Id: Ifa8bb343c7e916c1b545cf6c1e4bd0a18ea391cd\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2382790\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nTested-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "176e01ded3bcefb6cb8baa984a158d42562bb1e9", "tree": "fe038ca26e3111a1d65554f6b8a5417440aa9f36", "parents": [ "3dd8fe4c4e927fdb14a7a943911f6f118c56bc0a" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Wed Sep 09 17:47:21 2020 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 10 20:03:26 2020 +0000" }, "message": "crossystem: allow last nvdata entry to be filled\n\nMosys used to have code (below), which led me to believe that we\nalways try and leave the last entry unfilled:\n\n memset(blank, 0xff, VBNV_BLOCK_SIZE);\n for (index \u003d 0; index \u003c len / VBNV_BLOCK_SIZE; index++) {\n unsigned int offset \u003d index * VBNV_BLOCK_SIZE;\n if (!memcmp(blank, \u0026data[offset], VBNV_BLOCK_SIZE))\n break;\n }\n\n if (index \u003d\u003d 0) {\n lprintf(LOG_ERR, \"VBNV is uninitialized\\n\");\n return -1;\n } else if (index \u003e\u003d len) { \u003c---- SEE NOTE\n lprintf(LOG_ERR, \"VBNV is full\\n\"); \u003c--- unreachable\n return -1;\n } else {\n return index - 1;\n }\n\nThe statement at \"SEE NOTE\" will always be false, so this code fooled\nme to believe that we consider VBNV without a row of 0xFF*16 to be\nempty.\n\nAnd so I implemented and wrote unit tests for what I believed the\ncorrect behavior to be :/\n\nAnyway, this is causing us issues since AP firmware does not implement\nit that way. So allow the last row to be filled.\n\nBUG\u003dchromium:1112578\nBRANCH\u003dnone\nTEST\u003dunit tests\n\nSigned-off-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nChange-Id: Ib3da78eddef69a688d081cdb5391a25000dac9d3\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2402385\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "3dd8fe4c4e927fdb14a7a943911f6f118c56bc0a", "tree": "077195265d6bd377611543d7002a587d130c72ec", "parents": [ "2fb7683bf82362adb699e2a0df6cdb1bf4047df0" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Fri Aug 21 10:22:41 2020 -0700" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Sep 10 10:19:57 2020 +0000" }, "message": "COIL: Add unblocked_terms.txt to block keywords\n\nThis CL kicks off COIL for vboot_reference.\n\nCurrently the global unblocked_terms.txt are in effect. Since\nit\u0027s identical to the global blocked_terms.txt, nothing is being\nblocked.\n\nThis patch adds unblocked_terms.txt, which overrides the global one.\nThus, all changes with a word listed in the global blocked_terms.txt\nbut not in the local unblocked_terms.txt will be blocked.\n\nBUG\u003db:165908442, b:163883397\nBRANCH\u003dNone\nTEST\u003dRun repohook.\n\nCq-Depend: chromium:2369239\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nChange-Id: I1618db8e46f2b77397e016c1dfb02f20f66bb3aa\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2369360\nReviewed-by: Bernie Thompson \u003cbhthompson@chromium.org\u003e\n" }, { "commit": "2fb7683bf82362adb699e2a0df6cdb1bf4047df0", "tree": "e8270a1c847de09d0a7c57db9a54be6128aa77b1", "parents": [ "94d8aa60b8045f96a759871a81a3b69986430ba1" ], "author": { "name": "Meng-Huan Yu", "email": "menghuan@chromium.org", "time": "Mon Aug 24 16:17:56 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 10 00:30:33 2020 +0000" }, "message": "minidiag: Add storage and memory diagnostic screens\n\nBRANCH\u003dnone\nBUG\u003db:156692539, b:156693348\nTEST\u003demerge-hatch vboot_reference\nTEST\u003dunittest passed:\n( export CC\u003dx86_64-pc-linux-gnu-clang DEBUG\u003d1 MENU_UI\u003d1 DIAGNOSTIC_UI\u003d1\n MINIMAL\u003d1 TPM2_MODE\u003d MOCK_TPM\u003d; make clean \u0026\u0026\n make -j32 test_setup \u0026\u0026 make runtests; echo $? )\n\nCq-Depend: chromium:2322286, chromium:2328704, chromium:2336239\nCq-Depend: chromium:2361823, chromium:2361582\nSigned-off-by: Meng-Huan Yu \u003cmenghuan@chromium.org\u003e\nChange-Id: I8b875b09bd5bcdb65f08c11945b046d2b3c3a113\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2372022\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "94d8aa60b8045f96a759871a81a3b69986430ba1", "tree": "99507bbae4d3ff5bd7db95017117fd275dc57f72", "parents": [ "68f0eaaea967334f9fa05251bb13ac843a7d5b26" ], "author": { "name": "Martin Roth", "email": "martinroth@chromium.org", "time": "Wed Sep 02 10:56:08 2020 -0600" }, "committer": { "name": "Martin Roth", "email": "martinroth@google.com", "time": "Wed Sep 09 20:29:56 2020 +0000" }, "message": "Add script for signing PSP Verstage\n\nThis script will sign the psp_veratage.bin file and modify the fields as required.\n\nBUG\u003db:166095736\nTEST\u003dcreate verstage signed with test key.\n\nChange-Id: I234d7902f950a60a816dd5f4d46d3d5afd105489\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2390825\nTested-by: Martin Roth \u003cmartinroth@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nCommit-Queue: Martin Roth \u003cmartinroth@google.com\u003e\n" }, { "commit": "68f0eaaea967334f9fa05251bb13ac843a7d5b26", "tree": "75f575e4aed6e04f0969476b8b2c67d70af72c8b", "parents": [ "8f43ad977003ac4ed502c285dc08feca5e4d9bdf" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Sep 03 16:56:06 2020 -0400" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Sep 09 06:41:54 2020 +0000" }, "message": "keygeneration: psp verstagebl: refactor key gen \u0026 csr generation\n\nWe want to separate the stages of creating the key \u0026 using the key as\nour HSM tools use different commands for these.\n\nThis also means we no longer need a passphrase at all.\n\nBUG\u003db:166095736\nTEST\u003dran script before \u0026 after and made sure output (largely) looked the same\nBRANCH\u003dNone\n\nChange-Id: Id488789f83c21ffb6263489e3c22531878ceb1f2\nSigned-off-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2391219\nReviewed-by: Furquan Shaikh \u003cfurquan@chromium.org\u003e\n" }, { "commit": "8f43ad977003ac4ed502c285dc08feca5e4d9bdf", "tree": "93b282f4cba1874f5f13e1d01ebe39a748f0afd1", "parents": [ "94801a71980ddf3295a7849bbe575327d295595d" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Tue Aug 18 14:43:16 2020 +0800" }, "committer": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Wed Sep 09 06:17:10 2020 +0000" }, "message": "vboot/ui: Always show page up/down buttons in log screen\n\nAlways show page up/down buttons in log screen.\nBeep if users select the page up button on the first page or the page\ndown button on the last page.\n\nBRANCH\u003dpuff, zork\nBUG\u003db:146399181, b:163301076\nTEST\u003demerge-puff depthcharge\nTEST\u003demerge-zork depthcharge\nTEST\u003dnavigate to the debug info screen by \u003cTAB\u003e\n\nCq-Depend: chromium:2361582\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I29a567554f9283ea3fca0f58fb31c7056523c2a9\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2361823\nCommit-Queue: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "94801a71980ddf3295a7849bbe575327d295595d", "tree": "9e339f87c42a6956eee896c85e4a8ea970dd918b", "parents": [ "7f37cd1886b82522b4bac0c3e422341d68b7bd08" ], "author": { "name": "Meng-Huan Yu", "email": "menghuan@chromium.org", "time": "Tue Aug 18 18:05:19 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Sep 05 13:20:46 2020 +0000" }, "message": "minidiag: Add diagnostic menu screen\n\nBRANCH\u003dnone\nBUG\u003db:156692539, b:156693348\nTEST\u003demerge-hatch vboot_reference\nTEST\u003dunittest passed:\n( export CC\u003dx86_64-pc-linux-gnu-clang DEBUG\u003d1 MENU_UI\u003d0 DIAGNOSTIC_UI\u003d0\n MINIMAL\u003d1 TPM2_MODE\u003d MOCK_TPM\u003d; make clean \u0026\u0026\n make -j32 test_setup \u0026\u0026 make runtests; echo $? )\n( export CC\u003dx86_64-pc-linux-gnu-clang DEBUG\u003d1 MENU_UI\u003d1 DIAGNOSTIC_UI\u003d0\n MINIMAL\u003d1 TPM2_MODE\u003d MOCK_TPM\u003d; make clean \u0026\u0026\n make -j32 test_setup \u0026\u0026 make runtests; echo $? )\n( export CC\u003dx86_64-pc-linux-gnu-clang DEBUG\u003d1 MENU_UI\u003d0 DIAGNOSTIC_UI\u003d1\n MINIMAL\u003d1 TPM2_MODE\u003d MOCK_TPM\u003d; make clean \u0026\u0026\n make -j32 test_setup \u0026\u0026 make runtests; echo $? )\n( export CC\u003dx86_64-pc-linux-gnu-clang DEBUG\u003d1 MENU_UI\u003d1 DIAGNOSTIC_UI\u003d1\n MINIMAL\u003d1 TPM2_MODE\u003d MOCK_TPM\u003d; make clean \u0026\u0026\n make -j32 test_setup \u0026\u0026 make runtests; echo $? )\n\nCq-Depend: chromium:2193314, chromium:2328704\nSigned-off-by: Meng-Huan Yu \u003cmenghuan@chromium.org\u003e\nChange-Id: I4f3c64ce53b14437cb14d3c1109e14608d082141\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2318590\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "7f37cd1886b82522b4bac0c3e422341d68b7bd08", "tree": "a42f7af482196fccdfa512a763df9c7e370e5f5f", "parents": [ "c6641cfd113383f363ebae41256a8447fdc81918" ], "author": { "name": "Meng-Huan Yu", "email": "menghuan@chromium.org", "time": "Tue Aug 04 17:07:49 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 03 23:54:52 2020 +0000" }, "message": "vboot/ui: Add refresh flag to support force refresh the screen in action\n\nCL:2163088 is working on depthcharge side to support refreshing\neverything in vboot side, but it is still work in progress.\nIn the meanwhile, we can have a flag to control the refreshing for\nalready support refreshing everytime screen.\n\nThis flag can be removed after all screens are supported refreshing\neverytime in vboot.\n\nBRANCH\u003dnone\nBUG\u003db:156692539, b:156693348\nTEST\u003demerge-hatch vboot_reference\nTEST\u003dverfied in later CL that the screen is refreshed when the action\ncallback set this flag.\n\nSigned-off-by: Meng-Huan Yu \u003cmenghuan@chromium.org\u003e\nChange-Id: Ie76e8dce5186d0acfbc176a4cc8079c3df37fd38\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2336239\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "c6641cfd113383f363ebae41256a8447fdc81918", "tree": "ec687be00a63602c0656ce3015bd120e10941411", "parents": [ "8196d4e598a86c31ac07c60de151d9e9c2f9502c" ], "author": { "name": "Martin Roth", "email": "martinroth@chromium.org", "time": "Thu Aug 27 15:21:38 2020 -0600" }, "committer": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Thu Sep 03 19:31:06 2020 +0000" }, "message": "Add CSR generation script for signing PSP Verstage\n\nThis script is based on previous key generation scripts and on the\nAMD document describing their recommendations.\n\nBUG\u003db:166095736\nTEST\u003dGenerate keys of different sizes with different passphrases in\nvarious directories.\n\nChange-Id: I76a31f5d592d233282c145a9a4ce5220a2d597d8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2380612\nTested-by: Martin Roth \u003cmartinroth@google.com\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "8196d4e598a86c31ac07c60de151d9e9c2f9502c", "tree": "d4c0cf6406fadc642509c5ac19064a7e399228fc", "parents": [ "ac15a1562c185f3c48a5f988ca7beef974d22f44" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Thu Jul 30 13:52:34 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 03 09:58:22 2020 +0000" }, "message": "vboot/ui: Implement firmware log screen\n\nImplement firmware log screen which can be accessed from advanced\noptions menu.\n\nThe screen displays a snapshot for the firmware log using the same\nlayout of debug info screen.\n\nBRANCH\u003dpuff, zork\nBUG\u003db:146399181, b:146105976\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\nTEST\u003dUSE\u003d\"menu_ui\" emerge-puff depthcharge\nTEST\u003dUSE\u003d\"menu_ui\" emerge-zork depthcharge\nTEST\u003dselect \"advanced options\",\n and navigate to firmware log screen\n\nCq-Depend: chromium:2334490\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I3cb5800d71925aa20ca4d5636172885e23fd0099\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2328241\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "ac15a1562c185f3c48a5f988ca7beef974d22f44", "tree": "be07ab6005dc74c7c92ea61c91d812bb03d5a375", "parents": [ "4417f398d9eaee16e9c08e5b231244b01ea745b1" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Tue Sep 01 15:31:14 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Sep 03 02:04:36 2020 +0000" }, "message": "2stub: vb2ex_abort()s on host should abort(), not just exit()\n\nOur keyblock and preamble fuzzers have been broken since CL:2353775,\nbecause they don\u0027t set up secdata in the context which the tested\nfunctions now depend upon. Unfortunately, we got no alerting about\nthis... I only just happened to look at ClusterFuzz randomly today and\nsaw an odd break in execution statistics around that date.\n\nWith the new code as it is right now, all fuzzing attempts of the\nfunction end up running vb2ex_abort() from the uninitialized secdata. It\nwould be great if the fuzzer could report every time it ends up in that\nfunction, but it doesn\u0027t seem to do that right now. Supposedly it\nreports \"crashes\", but I guess exit(1) is not a crash, so let\u0027s switch\nthe line to abort() and see if that gets me the reporting behavior I\nwant (before actually fixing the fuzzer).\n\nBRANCH\u003dNone\nBUG\u003dNone\nTEST\u003dNone\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: Ie65838f30fa33a7602db253860afc8eeadcac4c6\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2389002\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "4417f398d9eaee16e9c08e5b231244b01ea745b1", "tree": "3a6d280711c0e9a93b9afc72b2efb69380d1c6e4", "parents": [ "34c589e5c189a635b63917ee63997b103e20dbf4" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Thu Jul 30 13:52:34 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sun Aug 30 17:18:40 2020 +0000" }, "message": "vboot/ui: Add reinit screen hook\n\nRe-initialize the log screen when going back from another screen.\n\nBRANCH\u003dpuff\nBUG\u003db:146399181, b:146105976\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\nTEST\u003dUSE\u003d\"menu_ui\" emerge-puff depthcharge\n when the firmware log screen is implemented,\n select \"advanced options\",\n navigate to firmware log screen,\n press \u003cTAB\u003e to debug info,\n and select back to firmware log screen\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: Ie44805e3bfb14a4a8b660a18a123a184a4c5ea45\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2329224\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n(cherry picked from commit 2cb872fa3056158c35f82a9412e667b69ccf5a49)\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2332200\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "34c589e5c189a635b63917ee63997b103e20dbf4", "tree": "d26a203762e61f09d123a440d0d0cca9f671fc54", "parents": [ "9ab10a883cb485ab643375b502ff1609622e9f48" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Sat Aug 29 06:47:20 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Aug 29 17:49:21 2020 +0000" }, "message": "futility: update: Add \u0027--gbb_flags FLAGS\u0027 to override GBB flags\n\nDevelopers may want to use the new GBB flags when flashing a firmware\nimage. That can be done by --factory, but it\u0027s also more convenient to\nhave a new parameter for overriding the flags with a new value.\n\nBRANCH\u003dnone\nBUG\u003db:166569397\nTEST\u003dmake runtests\n\nChange-Id: If9dce9b1f2fbb27655ad2a111ba75ab83375fb7a\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2382991\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "9ab10a883cb485ab643375b502ff1609622e9f48", "tree": "3fa79dcdc9a0fdf1df94b19c17dec85649d8af3b", "parents": [ "e24a6f60c11ce3d616cb1932da6395a72c5b8bfd" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Fri Aug 28 17:17:53 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Aug 29 13:51:33 2020 +0000" }, "message": "vboot/ui: Fix handling error beep request without screen state change\n\nCheck the variable error_beep to handle the error beep request without\nscreen state change.\n\nBRANCH\u003dzork\nBUG\u003db:146399181\nTEST\u003dUSE\u003d\"menu_ui\" emerge-zork depthcharge chromeos-bootimage\nTEST\u003dEnter the debug info screen by \u003cTAB\u003e,\n select \u003cPage up\u003e, and notice a beep\n\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: Id31fb06c37e2fee9b2eec1030cec06f22e7de854\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2379585\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "e24a6f60c11ce3d616cb1932da6395a72c5b8bfd", "tree": "7b5ec1f60bc3932643727eb52b9e6753e0e0d0fa", "parents": [ "927a95261259382ef0e167babcd997d3bfb6f1fd" ], "author": { "name": "Kangheui Won", "email": "khwon@chromium.org", "time": "Thu Aug 13 15:48:41 2020 +1000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 26 05:02:06 2020 +0000" }, "message": "vboot2: use hwcrypto for RSA when allowed\n\nAdd vb2ex_hwcrypto_rsa_verify support for RSA verification.\nIf firmware implements the function it will used instead of SW\nimplementation in vboot.\n\nAlso separate hwcrypto stubs to 2stub_hwcrypto.c for depthcharge and coreboot.\nDepthcharge needs stubs but fails to compile 2stub.c\n\nBRANCH\u003dnone\nBUG\u003db:163710320, b:161205813\nTEST\u003dmake runtests\nTEST\u003dcheck hwcrypto is allowed/disallowed depending on nvmem flag\n\nChange-Id: I85573e7cff31f32043db4b0a6b24b642856024e3\nSigned-off-by: Kangheui Won \u003ckhwon@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2353775\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "927a95261259382ef0e167babcd997d3bfb6f1fd", "tree": "ffef54eb4d54c9efb0fa351fd5266c56794c9039", "parents": [ "fefcaa653f2c7a79aa0270d8b2ef7cb290a6f225" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Wed Aug 19 18:14:43 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 25 08:07:34 2020 +0000" }, "message": "futility: Work around clang/GCC problem with libzip headers\n\nI don\u0027t even want to get into why this is needed. I\u0027m so tired of\nhaving to deal with new clang-specific toolchain bullshit 2-3 times a\nyear. libzip did this\n\nhttps://github.com/nih-at/libzip/commit/1d949dd77339fb59605dc8f3a30f76604d693795\n\nand then we upreved to it in CL:2245845 and now building upstream\ncoreboot in a Chrome OS chroot is broken.\n\nI have to get back to wasting time on the other three random things\nthat broke when I ran repo sync, so someone please just approve...\n\nBRANCH\u003dNone\nBUG\u003dNone\nTEST\u003dNone\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: Ic578e8f8e47f7fafd98d8c3148cbe24d9156886b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2366053\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "fefcaa653f2c7a79aa0270d8b2ef7cb290a6f225", "tree": "0ad60ecc2d1966c5d1fd6eaa5fc1915a0725f9f2", "parents": [ "d641f8d74688290f4c7185c042b6973032ce2f37" ], "author": { "name": "Chun-Ta Lin", "email": "itspeter@google.com", "time": "Tue Aug 18 16:09:49 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Aug 24 04:32:03 2020 +0000" }, "message": "vboot: adjust VB2_SECDATA_KERNEL_FLAGS in non-recovery path\n\nCurrently, VB2_SECDATA_KERNEL_FLAGS controls experimental features\nlike phone recovery (and its UI), diagnostics entry. All of those\nare under recovery screen. In order to allow later update pushes to\nenable specific features in write-protected RO, we should not set\nthose flags in recovery path. Otherwise, it will always toggle back\nand forth when booting RO recovery path vs. normal boot path.\n\nBRANCH\u003dpuff\nBUG\u003db:165181118\nTEST\u003dMENU_UI\u003d0 DIAGNOSTIC_UI\u003d0 make runtests\nTEST\u003dMENU_UI\u003d0 DIAGNOSTIC_UI\u003d1 make runtests\nTEST\u003dMENU_UI\u003d1 DIAGNOSTIC_UI\u003d0 make runtests\nTEST\u003dMENU_UI\u003d1 DIAGNOSTIC_UI\u003d1 make runtests\nTEST\u003dCherry-pick locally to ToT of firmware-puff-13324.B with\n chromium:2360066 to manually check flags on Kaisa device.\n\nChange-Id: I7ec45b4ecfa6d50781cec2690dbc88894c734073\nSigned-off-by: Chun-Ta Lin \u003citspeter@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2361983\nTested-by: Chun-ta Lin \u003citspeter@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\nCommit-Queue: Chun-ta Lin \u003citspeter@chromium.org\u003e\n" }, { "commit": "d641f8d74688290f4c7185c042b6973032ce2f37", "tree": "8dd90ba4003ba8ece554fe2c43b26d0168d737d2", "parents": [ "3932b1c8729e9bfac918da50224d06adae73fde0" ], "author": { "name": "Kangheui Won", "email": "khwon@chromium.org", "time": "Wed Aug 19 19:29:20 2020 +1000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Aug 20 23:39:44 2020 +0000" }, "message": "vboot2: Add prototype for hwcrypto RSA\n\nIntroduce new prototype for HW RSA accleration. This is not used\non anywhere yet but will unblock coreboot work to support HW RSA.\n\nBRANCH\u003dnone\nBUG\u003db:163710320, b:161205813\nTEST\u003dmake runtests; emerge-zork coreboot depthcharge\n\nChange-Id: Ic4b93f32410efdd06bd012efe58749b6ef0692c6\nSigned-off-by: Kangheui Won \u003ckhwon@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2364338\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "3932b1c8729e9bfac918da50224d06adae73fde0", "tree": "c9e59a0c279fb352a36d3f3528149bc54ad51d1e", "parents": [ "053592bd3d5fcb79b8fa3a6f6193ffedfc041dba" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Wed Aug 12 15:46:30 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 19 02:09:04 2020 +0000" }, "message": "inclusive: change usage of blacklist/whitelist\n\nGoogle is working to change its source code to use more inclusive\nlanguage. To that end, replace the term \"blacklist\" \u0026 \"whitelist\"\nwith inclusive alternatives.\n\nchrome-internal:3214766, chrome-internal:3214767, chrome-internal:3214831\nwill be checked in separately. They refer to a pinned vboot_reference.\nSo, this patch won\u0027t affect the signer until the pin is moved.\n\nBUG\u003db:163883397\nBRANCH\u003dNone\nTEST\u003dgrep -ir \"white*list\"\nTEST\u003dgrep -ir \"black*list\"\nTEST\u003dmake runtests\n\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nChange-Id: Iff98b55713b3c7381ba092ff14b50141b8422cf2\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2353421\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "053592bd3d5fcb79b8fa3a6f6193ffedfc041dba", "tree": "6088a6910490013226292fdb570f0dcd992d8739", "parents": [ "faf9cd3bbbc133487c272d81771b8bbf4d439915" ], "author": { "name": "Daisuke Nojiri", "email": "dnojiri@chromium.org", "time": "Wed Aug 12 15:46:30 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 19 02:09:02 2020 +0000" }, "message": "inclusive: change usage of sanity\n\nGoogle is working to change its source code to use more inclusive\nlanguage. To that end, replace the term \"sanity\" with inclusive\nalternatives.\n\nBUG\u003db:163883397\nBRANCH\u003dNone\nTEST\u003dgrep -ir sanity\nTEST\u003dmake runtests\n\nSigned-off-by: Daisuke Nojiri \u003cdnojiri@chromium.org\u003e\nChange-Id: I708a044d89050c442f14fb11a8ae5e98490d56af\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2353420\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "faf9cd3bbbc133487c272d81771b8bbf4d439915", "tree": "820653cb6c64cb2519206baae9d7eba4fbe2224f", "parents": [ "075ce5e15eca906b937d5a2b4a8245bbbadcc272" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Tue Aug 11 15:49:20 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 18 11:12:09 2020 +0000" }, "message": "vboot/ui: Display error for untrusted confirmation\n\nDisplay a error dialog box while user confirms with untrusted keyboard.\n\nBUG\u003db:144969091, b:161866932\nBRANCH\u003dpuff\nTEST\u003dPHYSICAL_PRESENCE_KEYBOARD\u003d1; emerge-puff depthcharge\n\nCq-Depend: chromium:2345837\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I2b0fdc217bbaa23ac71a41bf400c412be634ec0c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2346455\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "075ce5e15eca906b937d5a2b4a8245bbbadcc272", "tree": "ac32427f988f66840bdc5cb1a86ce90d50206176", "parents": [ "4f2fc7ae50e01b45a5e88982084e3974a232b028" ], "author": { "name": "Bob Moragues", "email": "moragues@google.com", "time": "Mon Aug 17 21:51:36 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 18 09:42:23 2020 +0000" }, "message": "futility: Allow --force to override min_platform_version quirk\n\nBUG\u003db:162747154\nBRANCH\u003dnone\nTEST\u003dverify that update runs for rev1, but not rev0 without --force\nTEST\u003dverify that update runs for both rev1 and rev0 with --force\n\nSigned-off-by: Bob Moragues \u003cmoragues@chromium.org\u003e\nChange-Id: I1594d6a4c83d8a0c13494f8f108225618612db8e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2360590\nReviewed-by: Douglas Anderson \u003cdianders@chromium.org\u003e\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nCommit-Queue: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "4f2fc7ae50e01b45a5e88982084e3974a232b028", "tree": "b7359eee11564d1ebd2ba10a62fb85dcc9ca36fe", "parents": [ "a8f3a03198d1e813508e56174cb5eeed4f9b41a1" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Tue Aug 04 14:31:01 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Aug 12 13:36:56 2020 +0000" }, "message": "vboot/tests: Fix unit tests with MENU_UI\u003d1\n\nFix vboot_api_kernel4_tests with MENU_UI\u003d1 by mocking UI functions for\nmenu UI.\n\nBRANCH\u003dnone\nBUG\u003db:146399181, b:156448738\nTEST\u003dMENU_UI\u003d0 DIAGNOSTIC_UI\u003d0 make runtests\nTEST\u003dMENU_UI\u003d0 DIAGNOSTIC_UI\u003d1 make runtests\nTEST\u003dMENU_UI\u003d1 DIAGNOSTIC_UI\u003d0 make runtests\nTEST\u003dMENU_UI\u003d1 DIAGNOSTIC_UI\u003d1 make runtests\n\nChange-Id: Ie1bf4296a757bd1a65c7d0e17f954db4a0dafc3f\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2336206\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "a8f3a03198d1e813508e56174cb5eeed4f9b41a1", "tree": "8cb57488f0876353c343e2ba37949a21cb5cafb5", "parents": [ "329564b254c0a5f4a62528f0b3c49a50b9e4911f" ], "author": { "name": "Chun-Ta Lin", "email": "itspeter@google.com", "time": "Sat Jul 04 10:14:26 2020 +0800" }, "committer": { "name": "Chun-ta Lin", "email": "itspeter@chromium.org", "time": "Sun Aug 09 03:50:09 2020 +0000" }, "message": "minidiag: add entry\n\nThe entry `Launch diagnostics` in recovery screen will set\nVB2_NV_DIAG_REQUEST and reboot.\n\nBRANCH\u003dnone\nBUG\u003db:155848434\nTEST\u003d( export CC\u003dx86_64-pc-linux-gnu-clang DEBUG\u003d1 DIAGNOSTIC_UI\u003d0\n MINIMAL\u003d1 TPM2_MODE\u003d MOCK_TPM\u003d; make clean \u0026\u0026\n make -j32 test_setup \u0026\u0026 make runtests; echo $? )\nTEST\u003d( export CC\u003dx86_64-pc-linux-gnu-clang DEBUG\u003d1 DIAGNOSTIC_UI\u003d1\n MINIMAL\u003d1 TPM2_MODE\u003d MOCK_TPM\u003d; make clean \u0026\u0026\n make -j32 test_setup \u0026\u0026 make runtests; echo $? )\nTEST\u003dLOCALES\u003d\"en\" USE\u003d\"menu_ui minidiag\" emerge-nami chromeos-bmpblk\n vboot_reference depthcharge chromeos-bootimage\nTEST\u003dUnset by\n \u0026\u003d ~VB2_SECDATA_KERNEL_FLAG_DIAGNOSTIC_UI_DISABLED manually;\n trigger recovery mode on device;\n visually confirmed `Launch diagnostics` is shown;\n select, reboot and confirm behavior from serial output:\n \"Unset diagnostic request (undo display init)\".\n\nCq-Depend: chromium:2282643, chromium:2282664, chromium:2289814\nChange-Id: I34af282edee66c5b9943e2d11fb514bac9ccddd8\nSigned-off-by: Chun-Ta Lin \u003citspeter@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2282867\nTested-by: Chun-ta Lin \u003citspeter@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "329564b254c0a5f4a62528f0b3c49a50b9e4911f", "tree": "bba04a60a8967a5682583054e5223c57f76ad6aa", "parents": [ "ba87dbf12e3b5e9c918d36670e13eb0c3284ad09" ], "author": { "name": "Joel Kitching", "email": "kitching@google.com", "time": "Thu Jul 30 17:13:06 2020 +0800" }, "committer": { "name": "Chun-ta Lin", "email": "itspeter@chromium.org", "time": "Sun Aug 09 03:48:55 2020 +0000" }, "message": "vboot: create secdata_kernel flag to disable diagnostic UI\n\nDiagnostic UI is currently not ready to ship. Disable\nthe UI (including both entry point and the UI itself)\nuntil it is ready.\n\nAlso remove unused mock_presence from vboot_api_kernel4_tests.\n\nBUG\u003db:155848434, b:162486211\nTEST\u003dmake clean \u0026\u0026 make runtests\nBRANCH\u003dnone\n\nSigned-off-by: Joel Kitching \u003ckitching@google.com\u003e\nChange-Id: I5cad7d40b2f52015f17f930a4d061c9cdf976a49\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2328985\nTested-by: Chun-ta Lin \u003citspeter@chromium.org\u003e\nCommit-Queue: Chun-ta Lin \u003citspeter@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "ba87dbf12e3b5e9c918d36670e13eb0c3284ad09", "tree": "0ac6ccc2bcfdfaab03e86e6d74a57131690db75f", "parents": [ "b99b5f454c1cc51c30e95558aee598ebb6e60dd5" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Thu Aug 06 09:28:38 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Aug 08 05:59:15 2020 +0000" }, "message": "futility: updater: always set new boot/try cookies\n\nIf the update target is same as the active image, the firmware updater\nwill do nothing on vboot2. However, if the system already have\nfw_try_next set to other slot (for example after multiple updates\napplied without rebooting) then the next boot will not pick the right\nfirmware. So we have to ensure fw_try_next is set to right value.\nIn the meantime, if fw_try_count and fw_result are not configured at the\nsame time, the system may start \"trying\" again and increase the chance\nto fail.\n\nTo fix that, we should clear trial cookies when there is no update, just\nlike chromeos-setgoodfirmware.\n\nBUG\u003db:162866548\nTEST\u003dmake runtests\nBRANCH\u003dNone\n\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nChange-Id: I41ecac445000a850d050d77f0f694ee431926424\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2340172\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "b99b5f454c1cc51c30e95558aee598ebb6e60dd5", "tree": "df81ac3ad19f05ba4bf155f54f3d349d64f4ee81", "parents": [ "bf426948e45d6ba13d299f4877f20ff579a62422" ], "author": { "name": "Bob Moragues", "email": "moragues@google.com", "time": "Mon Aug 03 20:46:42 2020 +0000" }, "committer": { "name": "Bob Moragues", "email": "moragues@chromium.org", "time": "Thu Aug 06 00:57:58 2020 +0000" }, "message": "futility: Add version quirk for trogdor\n\nBUG\u003db:162747154\nBRANCH\u003dnone\nTEST\u003dverify that update runs for rev1, but not rev0\n\nSigned-off-by: Bob Moragues \u003cmoragues@chromium.org\u003e\nChange-Id: I19e88a3046c6e98968650b6d7b1296a1a47c1470\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2334360\nReviewed-by: Philip Chen \u003cphilipchen@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nTested-by: Douglas Anderson \u003cdianders@chromium.org\u003e\n" }, { "commit": "bf426948e45d6ba13d299f4877f20ff579a62422", "tree": "623ef5b5524811e0c6a45d7f612e67b8da282405", "parents": [ "b92543cf86dfa5d342cc0b0f86a38df41d7b7cb1" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Thu Jul 16 15:28:32 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 31 01:51:12 2020 +0000" }, "message": "vboot/ui: Implement debug info screen navigation\n\nThe debug info screen can be accessed from advanced option screen.\n\nBRANCH\u003dnone\nBUG\u003db:146399181, b:144969088\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\nTEST\u003dUSE\u003d\"menu_ui\" emerge-nami depthcharge\n select \"advanced options\",\n observe its layout,\n and navigate to debug info screen\n\nCq-Depend: chromium:2301571\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I1fed968770a2681c28d49869676fb9b4f1d46494\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2301629\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "b92543cf86dfa5d342cc0b0f86a38df41d7b7cb1", "tree": "2095ffd5dd7b275679a98eb6f73998685de269c0", "parents": [ "bc9f971e406619cf0e4f489866d0e38b2bb1264f" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Fri Jun 19 13:28:06 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 31 01:51:09 2020 +0000" }, "message": "vboot/ui: Implement debug info screen\n\nImplement debug info screen with multiple pages.\n\nThe debug info screen can be accessed using TAB as keyboard shortcut.\nThe menu navigation will be added in a separate CL.\n\nThe screen has one textbox for displaying one page of debug info,\nand three buttons: page up, page down, and back.\n\nBRANCH\u003dpuff\nBUG\u003db:146399181, b:144969088\nTEST\u003dCC\u003dx86_64-pc-linux-gnu-clang;\n make clean \u0026\u0026 make runtests\nTEST\u003dUSE\u003d\"menu_ui\" emerge-nami depthcharge\n press tab, observe the debug info on the screen\n\nCq-Depend: chromium:2251685\nSigned-off-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\nChange-Id: I6bc0a49c4d69817825f35435b643b006823b5c03\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2251868\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "bc9f971e406619cf0e4f489866d0e38b2bb1264f", "tree": "036e2930274b69f198caed3fa8ec00f9a1b35212", "parents": [ "699189d29bd5385ee36621940c9256f8921e31f4" ], "author": { "name": "Joel Kitching", "email": "kitching@google.com", "time": "Sun Jul 26 14:26:18 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jul 29 22:17:56 2020 +0000" }, "message": "vboot: disallow DIAGNOSTIC_UI with MENU_UI\n\nDIAGNOSTIC_UI is incompatible with the new menu_ui (\"Groot\").\nDisallow diagnostic UI under the condition of using MENU_UI.\n\nBUG\u003db:146399181, b:160748354\nTEST\u003dmake clean \u0026\u0026 make runtests\nBRANCH\u003dnone\n\nSigned-off-by: Joel Kitching \u003ckitching@google.com\u003e\nChange-Id: Idc09e37a72d355baf7fa42ade7cdfecb3d41eabb\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2319415\nTested-by: Joel Kitching \u003ckitching@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "699189d29bd5385ee36621940c9256f8921e31f4", "tree": "f1ac1a89fe4eaa53e1fff49611c7d4548d8e596f", "parents": [ "640d0cb5b1e0a95b0a723c27f6b73638df5feddb" ], "author": { "name": "Victor Hsieh", "email": "victorhsieh@chromium.org", "time": "Tue Jul 28 10:31:22 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jul 29 22:13:07 2020 +0000" }, "message": "sign_android_image: use ARCVM file context if needed\n\nApparently the file android_file_contexts has a different name for ARCVM\nwith _vm suffix. Choose _vm if the container one is not found.\n\nBUG\u003db:161828692\nTEST\u003dsign_official_build.sh base recovery_image.bin mykey signed.bin\nBRANCH\u003dnone\n\nSigned-off-by: Victor Hsieh \u003cvictorhsieh@chromium.org\u003e\nChange-Id: I8a93d8e1dd5b824f319d7de804f8f74825166a97\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2323647\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "640d0cb5b1e0a95b0a723c27f6b73638df5feddb", "tree": "54ff469c40632ecbe790107723b3e465f456d458", "parents": [ "588839c060d0e977594720bc9fc1ab054d1f5178" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Thu Jul 16 10:22:05 2020 +0800" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jul 28 17:00:17 2020 +0000" }, "message": "vboot/ui: decouple error beep from error message\n\nSome error such as VB2_UI_ERROR_DEV_EXTERNAL_BOOT_FAILED only requires a\nbeep sound to notify the user. No dialog box will be shown for these\nerrors.\n\nInstead of defining them in the vb2_ui_error enum and ignore them in\nvb2ex_display_ui() in depthcharge, add a new field \u0027error_beep\u0027 to\nvb2_ui_context and use it for playing error beep sound in the UI loop.\nThen these beep-only errors can be removed from the enum.\n\nAlso remove VB2_UI_ERROR_DEV_INTERNAL_NOT_ALLOWED because it is not used\neverywhere.\n\nBRANCH\u003dpuff\nBUG\u003db:146399181, b:161375587\nTEST\u003demerge-puff depthcharge\nTEST\u003db/161375587 is not reproducible\n\nCq-Depend: chromium:2299925\nChange-Id: Ia90d1c8a164334d4cfec84281722eb6f2623b111\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2299968\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "588839c060d0e977594720bc9fc1ab054d1f5178", "tree": "962217b835031ae8f87d681fcbcdd3fd4d22ddd3", "parents": [ "c9c14da9bbc256618d11cfccac0bf72d0b524a21" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Sun Jul 26 21:12:07 2020 +0200" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jul 28 04:36:13 2020 +0000" }, "message": "host/lib/include/subprocess.h: Add `extern` to globals\n\nThis prevents linker errors regarding multiple definitions.\n\nChange-Id: I62d6132c20ca2b9620a9f3b1539a1a0109c5aa26\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2318026\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nTested-by: Joel Kitching \u003ckitching@chromium.org\u003e\nCommit-Queue: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\n" }, { "commit": "c9c14da9bbc256618d11cfccac0bf72d0b524a21", "tree": "42f6b1543ebf2a7b7badc966612a52678addae03", "parents": [ "9d4986f4dbefa423ed64728db94c772f45391a62" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Tue Jul 21 05:15:50 2020 -0400" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 24 04:11:45 2020 +0000" }, "message": "image_signing: drop support for signing nvidia lp0_firmware\n\nThis was only used by smaug which went EOL a while ago and we\u0027ve\nalready deleted supporting logic.\n\nBUG\u003dNone\nTEST\u003dCQ passes\nBRANCH\u003dNone\n\nChange-Id: Ia639c7da3c70c62ee102f11d510ffaa928ab244a\nSigned-off-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2309221\nReviewed-by: Furquan Shaikh \u003cfurquan@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" }, { "commit": "9d4986f4dbefa423ed64728db94c772f45391a62", "tree": "cdb79faa9fc30a422782cb480208cb5542c06fd7", "parents": [ "4f1094911adb8a44d60de49135978ce04b8917cb" ], "author": { "name": "Wu-Cheng Li", "email": "wuchengli@chromium.org", "time": "Thu Jul 23 08:57:51 2020 +0000" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 24 02:20:29 2020 +0000" }, "message": "Revert \"Makefile: Add dumpRSAPublicKey to SDK utilities\"\n\nThis reverts commit cd78ae54a2f7ccec9ef0216b633d1b4626d14af0.\n\nReason for revert: broke snapshot builders\n\nBUG\u003dchromium:1108724\nTEST\u003dNone\n\nOriginal change\u0027s description:\n\u003e Makefile: Add dumpRSAPublicKey to SDK utilities\n\u003e \n\u003e This utility is used in key generation, so it really belongs in the SDK.\n\u003e However, some autotests currently also want to generate keys on the DUT.\n\u003e So let\u0027s just install it to both.\n\u003e \n\u003e BRANCH\u003dnone\n\u003e BUG\u003dnone\n\u003e TEST\u003dsudo emerge\n\u003e \n\u003e Signed-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\n\u003e Change-Id: I8b69b284d2a1c15f1fb17e1bb7be43a6215cd42d\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2298661\n\u003e Reviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n\nBug: none\nChange-Id: Ia868c8c5f4a7269e25ef38a51157bbd90ac24064\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2315562\nReviewed-by: Wu-Cheng Li \u003cwuchengli@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nTested-by: Wu-Cheng Li \u003cwuchengli@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "4f1094911adb8a44d60de49135978ce04b8917cb", "tree": "c2ad660ae7d8104af1a82ac3030bf77d232f0f16", "parents": [ "cd78ae54a2f7ccec9ef0216b633d1b4626d14af0" ], "author": { "name": "Victor Hsieh", "email": "victorhsieh@chromium.org", "time": "Tue Jul 21 13:44:46 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jul 23 05:40:01 2020 +0000" }, "message": "sign_official_build: accept arcvm/bertha image\n\nBUG\u003db:161828692\nTEST\u003dsign_official_build.sh base recovery_image.bin mykey signed.bin\nTEST\u003dsign_android_unittests.sh\nBRANCH\u003dnone\n\nSigned-off-by: Victor Hsieh \u003cvictorhsieh@chromium.org\u003e\nChange-Id: I158cd0c23198ffe8773b5882ba214b3ca4d26cae\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2310758\nReviewed-by: Mike Frysinger \u003cvapier@chromium.org\u003e\n" }, { "commit": "cd78ae54a2f7ccec9ef0216b633d1b4626d14af0", "tree": "028145b0ed45d41055fed90f6a898286d360fd41", "parents": [ "cc210abb146b96513d8acc185a64a7d3fee14aec" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Tue Jul 14 17:35:39 2020 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jul 23 02:56:10 2020 +0000" }, "message": "Makefile: Add dumpRSAPublicKey to SDK utilities\n\nThis utility is used in key generation, so it really belongs in the SDK.\nHowever, some autotests currently also want to generate keys on the DUT.\nSo let\u0027s just install it to both.\n\nBRANCH\u003dnone\nBUG\u003dnone\nTEST\u003dsudo emerge\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: I8b69b284d2a1c15f1fb17e1bb7be43a6215cd42d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2298661\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n" } ], "next": "cc210abb146b96513d8acc185a64a7d3fee14aec" }