)]}' { "commit": "9d4053df76c127f625a8571d3ef16e6a063c8de5", "tree": "c266dd5dd83a6b64fee9f31012b396539b1f6a6b", "parents": [ "abcd6d24548480c1b3aeb5998c15b8548cea3b76" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Wed Nov 18 16:31:27 2020 -0800" }, "committer": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Fri Nov 20 01:51:08 2020 +0000" }, "message": "Revert \"Reland: Clean up implicit fall through.\"\n\nThis reverts commit 6208b9aa9c4e8b7c9ff8063965c9f9aa519c1740.\n\nUpstream coreboot has raised concerns that relying on GCC 7+ features\nfor host utilities is too restrictive, so revert this and go back to\ncustomizing fallthrough annotations by compiler. Cleaned out some of the\nC++-specific stuff because vboot isn\u0027t built with C++.\n\nBRANCH\u003dNone\nBUG\u003dNone\nTEST\u003dBuilt with clang and GCC.\n\nChange-Id: I75d796d289b0a6c249fc8ac2dadb1453be468642\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2547821\nReviewed-by: Manoj Gupta \u003cmanojgupta@chromium.org\u003e\nReviewed-by: Joel Kitching \u003ckitching@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "dbc62643c7a5986297e257bcc062f034372696a4", "old_mode": 33188, "old_path": "firmware/2lib/include/2common.h", "new_id": "0d66458f360fa505ae85a5b00a988c1f3695cab5", "new_mode": 33188, "new_path": "firmware/2lib/include/2common.h" }, { "type": "modify", "old_id": "3fbb2fdceff8da30839f35449168b93301ca2c55", "old_mode": 33188, "old_path": "firmware/lib/cgptlib/cgptlib.c", "new_id": "4c091d04b371d2a63d25f0aeb68aeeefdf07fdf6", "new_mode": 33188, "new_path": "firmware/lib/cgptlib/cgptlib.c" }, { "type": "modify", "old_id": "a1ffe5b0dfd7c02174bd7b7d52dac932c8dc9e14", "old_mode": 33188, "old_path": "firmware/lib/vboot_ui_legacy_clamshell.c", "new_id": "027b49ea4c093ae03e8d42d261de698b20209262", "new_mode": 33188, "new_path": "firmware/lib/vboot_ui_legacy_clamshell.c" }, { "type": "modify", "old_id": "59a49684e6ec421cd0515cc69f658b2ee23fb4c3", "old_mode": 33188, "old_path": "firmware/lib/vboot_ui_legacy_wilco.c", "new_id": "7838bcfeeacbc5f814552a0a69a5a8d5093e2eb5", "new_mode": 33188, "new_path": "firmware/lib/vboot_ui_legacy_wilco.c" }, { "type": "modify", "old_id": "ff7252c6edde9b1777790f63f6fd0955ecf5cad6", "old_mode": 33188, "old_path": "futility/cmd_dump_fmap.c", "new_id": "3a0e14edbd14a4ce2bfd660e5eebfd2e4d2a05a8", "new_mode": 33188, "new_path": "futility/cmd_dump_fmap.c" }, { "type": "modify", "old_id": "c95b8c975fcf54681eed98dbb385647646bf5eb4", "old_mode": 33188, "old_path": "futility/cmd_sign.c", "new_id": "6243e3a845f05da4c3e99a0cb93a5a4f890b462f", "new_mode": 33188, "new_path": "futility/cmd_sign.c" }, { "type": "modify", "old_id": "25a55d82591c8fd3ac924814989cae18b9cab2d4", "old_mode": 33188, "old_path": "host/lib/crossystem.c", "new_id": "bb10c399864d68776f91d2f773dfe3390e55f615", "new_mode": 33188, "new_path": "host/lib/crossystem.c" } ] }