)]}' { "commit": "6c18af501798c9b597839a3628c8374a2f8d7483", "tree": "e846d7253980759aed453ba8649653cc7a4b60b9", "parents": [ "6764405c93664efcf9742bf4973225099f65b6ec" ], "author": { "name": "Mike Frysinger", "email": "vapier@chromium.org", "time": "Wed Sep 07 16:45:48 2016 -0400" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Thu Sep 08 15:36:23 2016 -0700" }, "message": "cgpt: add support for managing the legacy boot gpt bit\n\nBit 2 in the GPT partition attributes has been allocated as the legacy\nbios boot (equivalent to the \"active\" or \"boot\" flag in MBR). If we\ntry to boot images on newer x86 systems, syslinux dies because it can\u0027t\nfind any GPT partition marked bootable.\n\nUpdate the various parts of cgpt add \u0026 show to manage this bit. Now we\ncan run:\n\tcgpt add -i 12 -B 1 chromiumos_image.bin\nAnd the EFI partition will be marked bootable.\n\nBUG\u003dchromium:644845\nTEST\u003dvboot_reference unittests pass\nTEST\u003dbooted an amd64-generic disk image via USB on a generic laptop\nBRANCH\u003dNone\n\nChange-Id: I78e17b8df5b0c61e9e2d8a3c703e6d5ad230fe92\nReviewed-on: https://chromium-review.googlesource.com/382411\nCommit-Ready: Mike Frysinger \u003cvapier@chromium.org\u003e\nTested-by: Mike Frysinger \u003cvapier@chromium.org\u003e\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "c4edd9541ba32461af095bee04437212cda17616", "old_mode": 33188, "old_path": "cgpt/cgpt.h", "new_id": "1216a72c70d95364b1eaedceeac9aa13337f8d52", "new_mode": 33188, "new_path": "cgpt/cgpt.h" }, { "type": "modify", "old_id": "d6b3cabddb4a0244fce69c0eb2ed14bfe8110ade", "old_mode": 33188, "old_path": "cgpt/cgpt_add.c", "new_id": "3808255a6a4f76b85b925ea38dee3046ddec6cad", "new_mode": 33188, "new_path": "cgpt/cgpt_add.c" }, { "type": "modify", "old_id": "29906d40aa2a243b05f3eba29fc46673b0f7f8b8", "old_mode": 33188, "old_path": "cgpt/cgpt_common.c", "new_id": "1a6bd3cb6cf868f3d6c431ff3c89ec0899d513aa", "new_mode": 33188, "new_path": "cgpt/cgpt_common.c" }, { "type": "modify", "old_id": "638655bd0a269d58b785f8b45c6b20cd726a7b3b", "old_mode": 33188, "old_path": "cgpt/cgpt_show.c", "new_id": "81b499c7362c61a5a38248f1935f77a91bb738db", "new_mode": 33188, "new_path": "cgpt/cgpt_show.c" }, { "type": "modify", "old_id": "ca379a2220729e90e5ca06493820c6dcb20ed85b", "old_mode": 33188, "old_path": "cgpt/cmd_add.c", "new_id": "3c7741b87f919fd260d9352ad8140abbef99e816", "new_mode": 33188, "new_path": "cgpt/cmd_add.c" }, { "type": "modify", "old_id": "860d80e75fb670c5150eec8994d3c10411af7cdf", "old_mode": 33188, "old_path": "cgpt/cmd_show.c", "new_id": "b9e648188c13a79415933b18b37201a446226d04", "new_mode": 33188, "new_path": "cgpt/cmd_show.c" }, { "type": "modify", "old_id": "275b3ae86b13b97e36b417f72305e94ea31c80c4", "old_mode": 33188, "old_path": "firmware/include/gpt.h", "new_id": "ae957cf70a481ae2d49618607475a92fead3d9f0", "new_mode": 33188, "new_path": "firmware/include/gpt.h" }, { "type": "modify", "old_id": "0ecbba4b95d4f7116d9a2969ffb926b1f80b730f", "old_mode": 33188, "old_path": "firmware/include/gpt_misc.h", "new_id": "58ce83fa40716329eda3c7ff2ed451fa507dacf9", "new_mode": 33188, "new_path": "firmware/include/gpt_misc.h" }, { "type": "modify", "old_id": "7d402dfbe36ef78279eb1746464b90f058649011", "old_mode": 33188, "old_path": "firmware/lib/cgptlib/cgptlib_internal.c", "new_id": "24b7ba15bfaa144e470b83bd13835b5934233d46", "new_mode": 33188, "new_path": "firmware/lib/cgptlib/cgptlib_internal.c" }, { "type": "modify", "old_id": "b13c49166539c365be1103b64db0b03822674d6d", "old_mode": 33188, "old_path": "firmware/lib/cgptlib/include/cgptlib_internal.h", "new_id": "cd616e5c5127098b8e757fdd752a0362d1442d57", "new_mode": 33188, "new_path": "firmware/lib/cgptlib/include/cgptlib_internal.h" }, { "type": "modify", "old_id": "3f0a71bd371d59d93f618ecb36d484e75ceb2b97", "old_mode": 33188, "old_path": "host/include/cgpt_params.h", "new_id": "92f0d3a48a1a548000451507b5ac59a0362d932c", "new_mode": 33188, "new_path": "host/include/cgpt_params.h" }, { "type": "modify", "old_id": "1e8df252848c19b1372c3f93870ff4d1dcd42438", "old_mode": 33188, "old_path": "tests/cgptlib_test.c", "new_id": "f736fd9a2c2db89526e59aec8b6700da3ea498f4", "new_mode": 33188, "new_path": "tests/cgptlib_test.c" } ] }