)]}' { "commit": "1eb83efdba367db2a590eb94a0cc45cd538aa696", "tree": "72efa521b7d5357346c7054c65243454e6234c1e", "parents": [ "637ff03502f3511d90e8d79cc1c52b3be01d6cd3" ], "author": { "name": "Andrey Ulanov", "email": "andreyu@google.com", "time": "Wed Jun 10 20:02:06 2015 -0700" }, "committer": { "name": "ChromeOS Commit Bot", "email": "chromeos-commit-bot@chromium.org", "time": "Sat Jun 13 02:53:36 2015 +0000" }, "message": "cgpt repair: fix segfault which occurs when one of the headers is bad\n\nWhen one of GPT headers is invalid the corresponding partition table\nis not loaded and corresponding pointers in GptData are NULL.\nGptRepair will try to memcpy one entries table to another which\nresults in SIGSEGV.\n\nThis change fixes it by freeing and then reallocating bad copy of\npartition table. This potentially fixes problems which would occur\nif two tables have different size.\n\nChange that initially introduced this problem by not always allocating\nsecondary_entries:\nhttps://chromium-review.googlesource.com/223800\n\nTEST\u003d\"cgpt repair\" works where it previously didn\u0027t\nTEST\u003dmake runtests\nBUG\u003dbrillo:1203\nBRANCH\u003dnone\n\nChange-Id: Ibb2fcf33faa5ba157b0865d04c90ee3f26eee113\nReviewed-on: https://chromium-review.googlesource.com/276766\nReviewed-by: Randall Spangler \u003crspangler@chromium.org\u003e\nCommit-Queue: Andrey Ulanov \u003candreyu@google.com\u003e\nTested-by: Andrey Ulanov \u003candreyu@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "1880ea5b2598b77b8bee8356af1a0e088b340c49", "old_mode": 33188, "old_path": "cgpt/cgpt_repair.c", "new_id": "ebe034b1425f60f38d0b78b43e8e12063f5bfca7", "new_mode": 33188, "new_path": "cgpt/cgpt_repair.c" }, { "type": "modify", "old_id": "a94224f3200b15462b77ced05b2f1046375d7c23", "old_mode": 33188, "old_path": "firmware/include/gpt_misc.h", "new_id": "e5a366bb9305901bab3e2d6b4f020a884dd526d9", "new_mode": 33188, "new_path": "firmware/include/gpt_misc.h" }, { "type": "modify", "old_id": "0be2bc5ac9c22b819dc903d1c918106ae7b6a170", "old_mode": 33188, "old_path": "firmware/lib/cgptlib/include/cgptlib_internal.h", "new_id": "50477c4fed60e15b712162eabcb695c35aa037e5", "new_mode": 33188, "new_path": "firmware/lib/cgptlib/include/cgptlib_internal.h" }, { "type": "modify", "old_id": "5176017a221ff9673a2b352cbdd7ba7e44818142", "old_mode": 33261, "old_path": "tests/run_cgpt_tests.sh", "new_id": "8a46d03ab8d3389fc16a4f91edca01425167a38b", "new_mode": 33261, "new_path": "tests/run_cgpt_tests.sh" } ] }