)]}' { "commit": "3d8d93b1e2688b703b55cf471a737e44baf3f144", "tree": "3704740e83ce068af05c6a90c2e80153662624f4", "parents": [ "e1761d644a336f98a73d65317eea90fb7c81d24f" ], "author": { "name": "Joel Kitching", "email": "kitching@google.com", "time": "Sun Mar 17 18:14:18 2019 +0800" }, "committer": { "name": "chrome-bot", "email": "chrome-bot@chromium.org", "time": "Tue Mar 26 13:20:09 2019 -0700" }, "message": "vboot: do not check for VB2_CONTEXT_FORCE_DEVELOPER_MODE\n\nAs part of chromium:942901, physical dev switch functionality\nis being deprecated.\n\nVB2_CONTEXT_FORCE_DEVELOPER_MODE is for the express purpose\nof enabling developer mode when the physical dev switch is\non. (See: coreboot\u0027s src/security/vboot/vboot_logic.c)\n\nRemove the check of this context flag for deciding whether\ndeveloper mode is enabled.\n\nIn order to retain a path to developer mode on devices\nwith physical dev switch, this CL depends on\nVBSD_HONOR_VIRT_DEV_SWITCH check being removed first\n(see CL:1526070). (Alternately, we can wait for CB:31943\nto be merged and pulled downstream.)\n\nThis constant will be marked as deprecated in a subsequent\nCL, once the coreboot CL has been pulled downstream.\n\nBUG\u003db:124141368, b:124192753, chromium:942901\nTEST\u003dBuild locally\nTEST\u003d/work/vboot/src/repohooks/pre-upload.py\nTEST\u003dmake clean \u0026\u0026 make runtests\nTEST\u003dmake clean \u0026\u0026 COV\u003d1 make coverage \u0026\u0026 make coverage_html\nCQ-DEPEND\u003dCL:1526070\nBRANCH\u003dnone\n\nChange-Id: I81b54b9e2b8d3c6f9c00b40dd0771cda0585037c\nSigned-off-by: Joel Kitching \u003ckitching@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/1524757\nCommit-Ready: ChromeOS CL Exonerator Bot \u003cchromiumos-cl-exonerator@appspot.gserviceaccount.com\u003e\nTested-by: Joel Kitching \u003ckitching@chromium.org\u003e\nReviewed-by: Simon Glass \u003csjg@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "2f68639efbc37cfbda7b7ae1f5afebaa84b3e98a", "old_mode": 33188, "old_path": "firmware/2lib/2misc.c", "new_id": "5d82fc03e5fd08b25bba81f1059d8a83a386a08c", "new_mode": 33188, "new_path": "firmware/2lib/2misc.c" }, { "type": "modify", "old_id": "9bf67727662af7c10d69034d6d0c1f5166a5e604", "old_mode": 33188, "old_path": "firmware/2lib/include/2api.h", "new_id": "ac4b05874ea515075109f281e5a41a663e5e777f", "new_mode": 33188, "new_path": "firmware/2lib/include/2api.h" }, { "type": "modify", "old_id": "1bb9686f94ae16d7fa50faab3a5174c8f022741a", "old_mode": 33188, "old_path": "tests/vb2_misc_tests.c", "new_id": "f17ac1b1c3a9d70003b9e21a0379f211cd209f33", "new_mode": 33188, "new_path": "tests/vb2_misc_tests.c" } ] }