vboot: do not check for VB2_CONTEXT_FORCE_DEVELOPER_MODE

As part of chromium:942901, physical dev switch functionality
is being deprecated.

VB2_CONTEXT_FORCE_DEVELOPER_MODE is for the express purpose
of enabling developer mode when the physical dev switch is
on.  (See: coreboot's src/security/vboot/vboot_logic.c)

Remove the check of this context flag for deciding whether
developer mode is enabled.

In order to retain a path to developer mode on devices
with physical dev switch, this CL depends on
VBSD_HONOR_VIRT_DEV_SWITCH check being removed first
(see CL:1526070).  (Alternately, we can wait for CB:31943
to be merged and pulled downstream.)

This constant will be marked as deprecated in a subsequent
CL, once the coreboot CL has been pulled downstream.

BUG=b:124141368, b:124192753, chromium:942901
TEST=Build locally
TEST=make clean && make runtests
TEST=make clean && COV=1 make coverage && make coverage_html

Change-Id: I81b54b9e2b8d3c6f9c00b40dd0771cda0585037c
Signed-off-by: Joel Kitching <kitching@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1524757
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Kitching <kitching@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
3 files changed