)]}' { "commit": "bbc76063294f4b9fcca6b581d9831595d840a1a3", "tree": "15118ac0ea82290254defad9d5a4947e2537034e", "parents": [ "435be9873179338d0c4e7b2d823989181a089771" ], "author": { "name": "Randall Spangler", "email": "rspangler@chromium.org", "time": "Fri Sep 20 11:18:08 2013 -0700" }, "committer": { "name": "chrome-internal-fetch", "email": "chrome-internal-fetch@google.com", "time": "Tue Feb 11 05:30:34 2014 +0000" }, "message": "Fix jumping EC from RO to RW if disable-jump was called on previous boot\n\nIt\u0027s possible for the AP to get updated and remove the RO-normal flag\nwithout needing to update EC-RW firmware - for example, if it only\nneeds to update the BIOS. In this case, the EC doesn\u0027t need update,\nbut does need to jump to its RW firmware. But if the EC is already\nbooted RO-normal with jump disabled, it will refuse that request and\ngo to recovery mode.\n\nThe fix is simply to check if the request to jump to RW requires the\nEC to cold-boot first, and pass through that error code to the caller.\n\nBUG\u003dchrome-os-partner:22617\nBRANCH\u003dnone (affects all platforms, but only in this odd case, and this\n is a change to the RW portion of the code)\nTEST\u003dpass new unit test which triggers this condition\n\nChange-Id: Ia8d64dff784a9135ef23f6eb26bbca4ad9df57c3\nSigned-off-by: Randall Spangler \u003crspangler@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/170168\nReviewed-by: Vadim Bendebury \u003cvbendeb@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "7f85dc75fe1b7381655d3e10960b2dc6dff48eb3", "old_mode": 33188, "old_path": "firmware/lib/vboot_api_kernel.c", "new_id": "e137e6d4dac2fa3632396ab2bbd60851e39434e7", "new_mode": 33188, "new_path": "firmware/lib/vboot_api_kernel.c" }, { "type": "modify", "old_id": "cefbf416d170d74dcfb4b48493de853d80c12b5c", "old_mode": 33188, "old_path": "tests/vboot_api_kernel3_tests.c", "new_id": "49bc7aad8bb2bc1a10c8138ee1252ad67c5654ac", "new_mode": 33188, "new_path": "tests/vboot_api_kernel3_tests.c" } ] }