| commit | 86ed3884efe1bee509f2e94e2f718955f923e1bd | [log] [tgz] |
|---|---|---|
| author | Manoj Gupta <manojgupta@google.com> | Fri Oct 25 13:48:50 2019 -0700 |
| committer | Manoj Gupta <manojgupta@chromium.org> | Mon Oct 28 22:16:59 2019 +0000 |
| tree | 8f658dc10c578328af4e747a0b3b2d40b6fde40b | |
| parent | 9c35c41b6c2f515714d609eb1458c50e89f2be48 [diff] |
firmware: Fix more UBSAN left shift errors. Follow up commit to CL:1867970. Shifting a uint8_t left by 24 promotes to an int, not an unsigned int (and shifts into the sign bit are undefined). Probably doesn't make a difference in assembly but still doesn't hurt to fix. Courtesy of UBSAN. BRANCH=None BUG=chromium:1015908 TEST=No more shift errors in unit test Change-Id: I10060df6b23da81388db34973b831c09c8d61bff Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1881475 Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org>