fromupstream.py: Move return out of loop
Move the return statement out of the loop that processes positional
arguments. Having the return inside the loop meant that the script
would only process one patch even if you gave it more than one patch.
This probably happened because the loop is so long that it's not
possible to keep the whole thing in one screen so no one noticed that
the return was indented too far in. Isn't semantic whitespace such a
wonderful thing?
I'm not sure how people didn't run into this before but I guess no one
really tries to apply multiple patches at a time.
BUG=none
TEST=applied multiple patches with one call to fromupstream.py
Change-Id: I137593f588d4f306abaf509f5d1665cf7d6a1d57
Reviewed-on: https://chromium-review.googlesource.com/1655051
Commit-Ready: Chirantan Ekbote <chirantan@chromium.org>
Tested-by: Chirantan Ekbote <chirantan@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
diff --git a/contrib/fromupstream.py b/contrib/fromupstream.py
index 8000918..0aee900 100755
--- a/contrib/fromupstream.py
+++ b/contrib/fromupstream.py
@@ -385,7 +385,7 @@
['git', 'commit', '--amend', '-F', '-'], stdin=subprocess.PIPE
).communicate(commit_message)
- return 0
+ return 0
if __name__ == '__main__':
sys.exit(main(sys.argv[1:]))
