tree 97e62acfe66b9b4d26eb00ff4f8ae3ce8910253b
parent 223af57cfcbf75e2e9ed0553da32fe21c6d1f91a
author Vadim Bendebury <vbendeb@chromium.org> 1367096368 -0700
committer ChromeBot <chrome-bot@google.com> 1367232472 -0700

Make sure that cros_write_firmware returns errors when appropriate

The cros_write_firmware utility does not always return error status,
it should return success is and only if the image was successfully
written to a removable device.

With this change the nonzero error is returned both when the utility
is interrupted while waiting for a device to be plugged in and when
there is more than one removable device found without clearly
indicating which one to use..

BUG=none
TEST=manual
  . plug in two removable devices and run the utility, get the
    following:

    vvvvvvvvvvvvvvvvvvvvvvv
    Please specify destination as '-w sd:<disk_description>'
     - <disk_description> can be either . for the only disk,
       or the full device name, one of listed below:
    /dev/sde - Realtek USB3.0 Card Reader 2.0 GB
    /dev/sdg - Realtek USB3.0 Card Reader 3.9 GB
    ^^^^^^^^^^^^^^^^^^^^^^^^

  . hit ^C while the utility is waiting for the card to be plugged in,
    get the following:

    vvvvvvvvvvvvvvvvvvvvvvv
    No removable device found, interrupted
    ^^^^^^^^^^^^^^^^^^^^^^^^

   In both cases exit status is set to 1

Change-Id: Icc385274b04557d058d0cbe01c9a640f3d794fc8
Reviewed-on: https://gerrit.chromium.org/gerrit/49438
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>