| commit | 24014581add2c6ad069237c45ee3ddc8ac657394 | [log] [tgz] |
|---|---|---|
| author | Jaques Clapauch <jaquesc@google.com> | Thu Jul 07 01:06:33 2022 +0000 |
| committer | Jaques Clapauch <jaquesc@google.com> | Thu Jul 07 18:07:13 2022 +0000 |
| tree | 75486607e99f7e8c33ca228ad66e0de7924638c2 | |
| parent | 8582bc03fe99d096ea74f33860e4224890ab0e86 [diff] |
Fixing init crash not being captured Init error wasn't passed and execution was continuing BUG=None TEST=None Change-Id: Ib4538c63d92721b04b364e12fb2cd80145067592 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/3750099 Auto-Submit: Jaques Clapauch <jaquesc@google.com> Reviewed-by: Azizur Rahman <azrahman@google.com> Tested-by: Jaques Clapauch <jaquesc@google.com> Reviewed-by: Derek Beckett <dbeckett@chromium.org> Commit-Queue: Jaques Clapauch <jaquesc@google.com>
diff --git a/src/chromiumos/test/provision/v2/cros-provision/cli/AbstractCommand.go b/src/chromiumos/test/provision/v2/cros-provision/cli/AbstractCommand.go index 8975147..5691feb 100644 --- a/src/chromiumos/test/provision/v2/cros-provision/cli/AbstractCommand.go +++ b/src/chromiumos/test/provision/v2/cros-provision/cli/AbstractCommand.go
@@ -60,7 +60,9 @@ for _, cmd := range cmds { options = append(options, cmd.Name()) if cmd.Is(subcommand) { - cmd.Init(os.Args[2:]) + if err := cmd.Init(os.Args[2:]); err != nil { + return nil, fmt.Errorf("failed to initialize cli command, %s", err) + } return cmd, nil } }