Test the following cases:
The test yaml files include the CLs for the creation of the Kindred variant. The coreboot CL for Kindred is coreboot:32936, and was upstreamed as chromium:1641906. These CLs have long since merged, and so nothing will be uploaded to any gerrit instances or merged into ToT.
need_to_push.yaml has the change_id for the coreboot CL modified so that the CL cannot be found, which makes it look like the CL has not been pushed. The program will ask the user to push it to coreboot.
need_to_upstream.yaml also has the change_id for the coreboot CL modified, but the gerrit instance (coreboot) and CL number (32936) are already there, so the CL has already been found. However, searching chromium for that change_id as an original-change-id will fail, indicating that the CL has not been upstreamed from coreboot yet.
upstreamed.yaml has the correct change_id for the coreboot CL. The program will find the CL in coreboot, then find the upstreamed CL in chromium, and proceed to the cq_depend step (which is not yet implemented).
(cr) $ cp testdata/need_to_push.yaml ~/.new_variant.yaml (cr) $ ./new_variant.py --continue INFO:root:Running step push_coreboot INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): review.coreboot.org ERROR:root:The following commit needs to be pushed to coreboot.org: ERROR:root: Branch "kindred" ERROR:root: in directory "/mnt/host/source/src/third_party/coreboot" ERROR:root: with change-id "Ithischangeidwillnotbefoundbecauseitdoesntexist" ERROR:root:Please push the branch to review.coreboot.org, and then re-start this program with --continue (cr) $ cp testdata/need_to_upstream.yaml ~/.new_variant.yaml (cr) $ ./new_variant.py --continue INFO:root:Running step push_coreboot INFO:root:Running step upload_CLs INFO:root:Running step find_coreboot_upstream ERROR:root:Program cannot continue until coreboot CL is upstreamed. ERROR:root:(coreboot:32936, change-id Ichangeiddoesntmatterbecausewealreadyknowtheclnumber) ERROR:root:Please wait for the CL to be upstreamed, then run this program again with --continue (cr) $ cp testdata/upstreamed.yaml ~/.new_variant.yaml (cr) $ ./new_variant.py --continue INFO:root:Running step push_coreboot INFO:root:Running step upload_CLs INFO:root:Running step find_coreboot_upstream INFO:root:Running step clean_up
The test data for Cq-Depend uses old commits for Kindred, and has a step_list that prevents the CLs from being modified or uploaded. The intent here is to show that the Cq-Depend line is determined correctly for each CL that has dependencies.
(cr) $ cp testdata/cqdepend.yaml ~/.new_variant.yaml (cr) $ ./new_variant.py --continue --verbose INFO:root:Running step calc_cq_depend DEBUG:root:Processing add_priv_yaml to add dependencies DEBUG:root:Add to commit add_priv_yaml Cq-Depend: chromium:1629121, chromium:1638243, chrome-internal:1364967, chromium:1648602 DEBUG:root:Processing add_pub_yaml to add dependencies DEBUG:root:Add to commit add_pub_yaml Cq-Depend: chrome-internal:1331261, chromium:1638243, chrome-internal:1364967, chromium:1648602 DEBUG:root:Processing cb_config to add dependencies DEBUG:root:Add to commit cb_config Cq-Depend: chromium:1641906 (cr) $ rm ~/.new_variant.yaml