)]}' { "commit": "4376fe5c17537bab177bbe18d0cf6da0ec384f4b", "tree": "64bd161d18c933f91e1bc92197d504ff8748302f", "parents": [ "fc1e983e4463221f62727e1d44c7ec864389dacc" ], "author": { "name": "Paul Fagerburg", "email": "pfagerburg@google.com", "time": "Tue Jun 16 10:22:35 2020 -0600" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jun 16 19:33:32 2020 +0000" }, "message": "new_variant: handle empty lists for cros_workon\n\nMake sure that the list of packages to cros_workon start or stop\nis not empty. If it is empty, then don\u0027t try to cros_workon start\nor stop it, because the library will raise an exception.\n\nBUG\u003db:159092931\nTEST\u003dcros_workon all of the packages that are listed for Hatch,\nso that when the build gets to the workon-and-emerge point, there\nwon\u0027t be any packages to stop working on:\n\n(cr) $ cros_workon --board\u003dhatch start coreboot libpayload \\\nvboot_reference depthcharge intel-cmlfsp coreboot-private-files-hatch \\\nchromeos-ec chromeos-config-bsp-hatch-private\n(cr) $ ./new_variant.py --board\u003dhatch --variant\u003dtiamat\n\nGenerate the fitimage as directed, outside the chroot.\n\n(cr) $ ./new_variant.py --continue\n\nObserve that the emerge is successful, and you get a prompt to push\nto coreboot. At that point, abort and clean up.\n\n(cr) $ cros_workon --board\u003dhatch stop coreboot libpayload \\\nvboot_reference depthcharge intel-cmlfsp coreboot-private-files-hatch \\\nchromeos-ec chromeos-config-bsp-hatch-private\n(cr) $ ./new_variant.py --abort\n\nNow make sure that the program doesn\u0027t try to cros_workon start an\nempty list:\n\nChange config_workon_pkgs in hatch.py to [].\n\n(cr) $ ./new_variant.py --board\u003dhatch --variant\u003dtiamat\n\nGenerate the fitimage as directed, outside the chroot.\n\n(cr) $ ./new_variant.py --continue\n\nObserve that the build_config step succeeds. Once the build pauses\nfor coreboot upload, `./new_variant.py --abort` and then restore\nhatch.py.\n\nChange-Id: I481ab7c386e1fbc6f8dfca4006677bf01c09aacc\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/2247049\nTested-by: Paul Fagerburg \u003cpfagerburg@chromium.org\u003e\nReviewed-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nCommit-Queue: Paul Fagerburg \u003cpfagerburg@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "6330129c2754fcf1849933aac1b067e9129c6e74", "old_mode": 33261, "old_path": "contrib/variant/new_variant.py", "new_id": "3cc42207df000232f437deeadab00665e68af2c5", "new_mode": 33261, "new_path": "contrib/variant/new_variant.py" } ] }