tree 11e24de98e21a6cbe026ae7a20bbc829e9dd7259
parent fe9a3893b905ede866392344021a1d345fbc1b90
author Congbin Guo <guocb@google.com> 1596572572 -0700
committer Congbin Guo <guocb@chromium.org> 1596653525 +0000

gs_cache: bugfix when list members of a broken tar file

In some special cases, the tar file from upstream may be broken. If we
don't close the input of tar command in this case, the tar command, as
well as the connection, will hang for ever. This can cause cascade
issues to gs_cache due to connection leaking.

BUG=None
TEST=Deployed to chromeos2-devserver6 and:
 1. Construct a fake broken tar file for /download RPC
 2. Verify that the /list_member will hang w/o this CL.
 3. Apply this CL.
 4. Verify that the /list_member will terminate (though the output is
     not complete)

Change-Id: I89c4eeb1b77376983653a72567a9ea3fa2a14299
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/2337399
Commit-Queue: Congbin Guo <guocb@chromium.org>
Commit-Queue: Sanika Kulkarni <sanikak@chromium.org>
Tested-by: Congbin Guo <guocb@chromium.org>
Auto-Submit: Congbin Guo <guocb@chromium.org>
Reviewed-by: Sanika Kulkarni <sanikak@chromium.org>